Page MenuHomeFreeBSD
Feed Advanced Search

Apr 4 2024

stevek requested review of D44631: Add function to OSD to get values without taking the lock..
Apr 4 2024, 12:18 AM

Apr 3 2024

stevek requested review of D44630: arm64: Separate serror handler to EL1H and EL0 versions..
Apr 3 2024, 11:45 PM
stevek updated the diff for D44629: Optimize the handling of big/little endian determination..

Update summary

Apr 3 2024, 11:29 PM
stevek requested review of D44629: Optimize the handling of big/little endian determination..
Apr 3 2024, 11:27 PM
stevek committed rG112783ebbc31: userboot: allow for overriding the version file location (authored by stevek).
userboot: allow for overriding the version file location
Apr 3 2024, 11:11 PM
stevek closed D44624: userboot: allow for overriding the version file location.
Apr 3 2024, 11:10 PM
stevek added a comment to D10469: The c11 appendix K string functions.

There seems to be no change here or in https://github.com/trixirt/libc11ext in the last five years. @trix_juniper.net are you still planning to pursue this?

Apr 3 2024, 11:04 PM
stevek updated the diff for D39768: sockets: avoid layering violation in handling SO_SETFIB.

Made changes according to review comments.
Also fixed an issue when compiling gve_adminq.c due to the addition of
prototypes that use "bool", but the .c file was not including sys/types.h

Apr 3 2024, 10:57 PM
stevek added inline comments to D44622: efi: Add macros for building an EFI GUID.
Apr 3 2024, 9:44 PM
stevek requested review of D44625: userboot: support environment and symlinks in test application.
Apr 3 2024, 9:32 PM
stevek requested review of D44624: userboot: allow for overriding the version file location.
Apr 3 2024, 9:24 PM
stevek requested review of D44623: vm: add macro to mark arguments used when NUMA is defined.
Apr 3 2024, 9:11 PM
stevek requested review of D44622: efi: Add macros for building an EFI GUID.
Apr 3 2024, 8:29 PM
stevek requested review of D44620: iflib: Fix compiler warnings.
Apr 3 2024, 8:23 PM
stevek committed rG13ab9fa09be7: kernel: Add options for MAC_DEBUG and MAC_VERIEXEC_DEBUG (authored by stevek).
kernel: Add options for MAC_DEBUG and MAC_VERIEXEC_DEBUG
Apr 3 2024, 8:07 PM

Apr 1 2024

stevek updated the diff for D44464: x86: Add NMI callback function..

Updated based on review comments

Apr 1 2024, 8:03 PM
stevek added inline comments to D44464: x86: Add NMI callback function..
Apr 1 2024, 6:51 PM

Mar 28 2024

stevek updated the diff for D44535: arm64: Add a CPU reset hook instead of expecting PSCI.

Updated based on review comments

Mar 28 2024, 7:05 PM
stevek added a comment to D44535: arm64: Add a CPU reset hook instead of expecting PSCI.

Is there a reason to not have cpu_reset_hook = psci_reset by default so we can remove the NULL check?

Mar 28 2024, 6:23 PM
stevek committed rG2aee804c9ef0: kerneldump: Add flag to indicate kernel core was successfully dumped (authored by stevek).
kerneldump: Add flag to indicate kernel core was successfully dumped
Mar 28 2024, 6:13 PM
stevek closed D44542: kerneldump: Add flag to indicate kernel core was successfully dumped.
Mar 28 2024, 6:13 PM
stevek committed rGfe429e6794d3: stand/efi: Changes to efichar to allow it to be used in the kernel (authored by stevek).
stand/efi: Changes to efichar to allow it to be used in the kernel
Mar 28 2024, 6:10 PM
stevek closed D44541: stand/efi: Changes to efichar to allow it to be used in the kernel.
Mar 28 2024, 6:10 PM

Mar 27 2024

stevek committed rGf6e77cb8c146: include: Allow SDESTDIR to be overridden (authored by stevek).
include: Allow SDESTDIR to be overridden
Mar 27 2024, 11:19 PM
stevek committed rG39f6f6f1c6f8: libmagic: Use HOST_CC when compiling hostprog used by build (authored by stevek).
libmagic: Use HOST_CC when compiling hostprog used by build
Mar 27 2024, 11:19 PM
stevek closed D44540: include: Allow SDESTDIR to be overridden.
Mar 27 2024, 11:19 PM
stevek closed D44539: libmagic: Use HOST_CC when compiling hostprog used by build.
Mar 27 2024, 11:19 PM
stevek requested review of D44542: kerneldump: Add flag to indicate kernel core was successfully dumped.
Mar 27 2024, 11:12 PM
stevek requested review of D44541: stand/efi: Changes to efichar to allow it to be used in the kernel.
Mar 27 2024, 10:40 PM
stevek committed rGa6d8dcb0d981: csh: Use HOST_CC when compiling hostprog used by csh build (authored by stevek).
csh: Use HOST_CC when compiling hostprog used by csh build
Mar 27 2024, 10:24 PM
stevek closed D44537: csh: Use HOST_CC when compiling hostprog used by csh build.
Mar 27 2024, 10:23 PM
stevek closed D44536: sys.mk: Define HOST_CC as CC by default..
Mar 27 2024, 10:23 PM
stevek committed rG3abd36c68fe4: sys.mk: Define HOST_CC as CC by default. (authored by stevek).
sys.mk: Define HOST_CC as CC by default.
Mar 27 2024, 10:23 PM
stevek requested review of D44540: include: Allow SDESTDIR to be overridden.
Mar 27 2024, 10:13 PM
stevek added reviewers for D44539: libmagic: Use HOST_CC when compiling hostprog used by build: sjg, bdrewery.
Mar 27 2024, 10:06 PM
stevek requested review of D44539: libmagic: Use HOST_CC when compiling hostprog used by build.
Mar 27 2024, 10:05 PM
stevek requested review of D44538: config: Search include paths for files to be read (options, files).
Mar 27 2024, 9:53 PM
stevek requested review of D44537: csh: Use HOST_CC when compiling hostprog used by csh build.
Mar 27 2024, 9:33 PM
stevek requested review of D44536: sys.mk: Define HOST_CC as CC by default..
Mar 27 2024, 9:27 PM
stevek requested review of D44535: arm64: Add a CPU reset hook instead of expecting PSCI.
Mar 27 2024, 9:18 PM
stevek abandoned D39624: veriexec: Add support in rc.d script processing..
Mar 27 2024, 9:09 PM ยท rc
stevek requested review of D44530: arm64: Add SError handler registration.
Mar 27 2024, 5:56 PM
stevek requested review of D44529: geom: Register classes in SI_SUB_DRIVERS as order SI_ORDER_THIRD.
Mar 27 2024, 3:34 PM
stevek updated the diff for D44528: guestrpc module to handle VMware backdoor port GuestRPC functionality.

Fixed typo in comment.

Mar 27 2024, 3:20 PM
stevek requested review of D44528: guestrpc module to handle VMware backdoor port GuestRPC functionality.
Mar 27 2024, 3:18 PM

Mar 21 2024

stevek requested review of D44464: x86: Add NMI callback function..
Mar 21 2024, 10:26 PM
stevek accepted D44415: libsysdecode use MKTABLES_INCLUDEDIR.
Mar 21 2024, 4:42 PM

Mar 1 2024

stevek requested review of D44163: top: allow changing PCPU stats and/or showing args defaults at compile time.
Mar 1 2024, 2:22 AM

Feb 15 2024

stevek closed D43920: psci: Add FDT node status check.
Feb 15 2024, 7:24 PM
stevek committed rG53670ee165f4: psci: Add FDT node status check (authored by stevek).
psci: Add FDT node status check
Feb 15 2024, 7:24 PM
stevek requested review of D43920: psci: Add FDT node status check.
Feb 15 2024, 5:00 PM

Dec 30 2023

stevek accepted D43238: bsd.man.mk allow staging compressed pages.
Dec 30 2023, 4:07 PM

Dec 1 2023

stevek closed D42836: iicbus: add compat32 support for I2C ioctls.
Dec 1 2023, 1:34 AM
stevek committed rG682b069c5c56: iicbus: add compat32 support for I2C ioctls (authored by stevek).
iicbus: add compat32 support for I2C ioctls
Dec 1 2023, 1:34 AM

Nov 30 2023

stevek updated the diff for D42836: iicbus: add compat32 support for I2C ioctls.

Changed iiccopyinmsgs32 to iic_copyinmsgs32, per suggested comments

Nov 30 2023, 11:36 PM
stevek added inline comments to D42836: iicbus: add compat32 support for I2C ioctls.
Nov 30 2023, 5:21 AM
stevek updated the diff for D42836: iicbus: add compat32 support for I2C ioctls.

Addressed comments from jhb

Nov 30 2023, 5:19 AM

Nov 29 2023

stevek added inline comments to D42836: iicbus: add compat32 support for I2C ioctls.
Nov 29 2023, 11:28 PM
stevek committed rG376330aca184: smbus: add compat32 support for SMB ioctls (authored by stevek).
smbus: add compat32 support for SMB ioctls
Nov 29 2023, 11:16 PM
stevek closed D42837: smbus: add compat32 support for SMB ioctls.
Nov 29 2023, 11:16 PM
stevek added reviewers for D42837: smbus: add compat32 support for SMB ioctls: kib, jhb.
Nov 29 2023, 7:37 PM
stevek added a reviewer for D42836: iicbus: add compat32 support for I2C ioctls: jhb.
Nov 29 2023, 7:37 PM
stevek added a reviewer for D42836: iicbus: add compat32 support for I2C ioctls: manu.
Nov 29 2023, 7:35 PM
stevek requested review of D42837: smbus: add compat32 support for SMB ioctls.
Nov 29 2023, 7:35 PM
stevek requested review of D42836: iicbus: add compat32 support for I2C ioctls.
Nov 29 2023, 7:35 PM

Nov 20 2023

stevek added inline comments to D42624: Fix share/zoneinfo for DIRDEPS_BUILD.
Nov 20 2023, 7:45 PM
stevek accepted D42624: Fix share/zoneinfo for DIRDEPS_BUILD.
Nov 20 2023, 7:41 PM

Nov 15 2023

stevek committed rGfa08011a521c: zoneinfo: fix makefile rules script (authored by stevek).
zoneinfo: fix makefile rules script
Nov 15 2023, 12:54 AM
stevek closed D42608: zoneinfo: fix makefile rules script.
Nov 15 2023, 12:53 AM
stevek updated the summary of D42608: zoneinfo: fix makefile rules script.
Nov 15 2023, 12:51 AM
stevek added reviewers for D42608: zoneinfo: fix makefile rules script: sjg, des.
Nov 15 2023, 12:48 AM
stevek requested review of D42608: zoneinfo: fix makefile rules script.
Nov 15 2023, 12:46 AM

Nov 3 2023

stevek accepted D42404: arm64: Check if PSCI before calling SMCCC.

Looks good, verified with the board where we had seen the issue.

Nov 3 2023, 2:16 PM

Nov 2 2023

stevek committed rG2008043f3867: loader: add target for dirdeps build (authored by stevek).
loader: add target for dirdeps build
Nov 2 2023, 11:39 PM
stevek closed D39741: loader: add target for dirdeps build.
Nov 2 2023, 11:39 PM
stevek updated the diff for D39741: loader: add target for dirdeps build.

Updated to current "main" branch and removed $FreeBSD$ lines

Nov 2 2023, 11:36 PM
stevek abandoned D6814: Add libfdt user space library.
Nov 2 2023, 10:11 PM
stevek accepted D42132: veriexec: Simplify the initialization of loader tunable.
Nov 2 2023, 10:07 PM

Oct 30 2023

stevek committed rG95335dd3c19e: rtld: introduce STATIC_TLS_EXTRA (authored by stevek).
rtld: introduce STATIC_TLS_EXTRA
Oct 30 2023, 5:43 PM
stevek closed D42025: rtld: introduce STATIC_TLS_EXTRA.
Oct 30 2023, 5:42 PM
stevek added a comment to D42025: rtld: introduce STATIC_TLS_EXTRA.
In D42025#967445, @kib wrote:

You also need to rename the vars in the summary.

Oct 30 2023, 3:40 AM
stevek added a comment to D42025: rtld: introduce STATIC_TLS_EXTRA.

Updated the review summary from the commit log

Oct 30 2023, 3:39 AM
stevek retitled D42025: rtld: introduce STATIC_TLS_EXTRA from rtld: introduce OPTIONAL_STATIC_TLS to rtld: introduce STATIC_TLS_EXTRA.
Oct 30 2023, 3:39 AM
stevek updated the diff for D42025: rtld: introduce STATIC_TLS_EXTRA.

Updated environment variable to match the variables used internally.
Instead of OPTIONAL_STATIC_TLS, the name is now STATIC_TLS_EXTRA.
Updated the man page also.

Oct 30 2023, 1:18 AM

Oct 29 2023

stevek updated the diff for D42025: rtld: introduce STATIC_TLS_EXTRA.

Made changes per review comments.

Oct 29 2023, 9:15 PM
stevek committed rGe5b786625f7f: dirdeps: Add missing dependency files (authored by stevek).
dirdeps: Add missing dependency files
Oct 29 2023, 9:10 PM
stevek committed rG5e3190f70063: dirdeps: Update Makefile.depend* files with empty contents (authored by stevek).
dirdeps: Update Makefile.depend* files with empty contents
Oct 29 2023, 9:03 PM

Oct 13 2023

stevek accepted D42133: veriexec: Correctly export symbols.
Oct 13 2023, 7:04 PM

Sep 29 2023

stevek requested review of D42025: rtld: introduce STATIC_TLS_EXTRA.
Sep 29 2023, 11:44 PM
stevek closed D42019: Allow for CSTD to be set kernel module Makefiles before inclusion.
Sep 29 2023, 11:20 PM
stevek committed rGe47381c9fc72: Allow for CSTD to be set kernel module Makefiles before inclusion (authored by stevek).
Allow for CSTD to be set kernel module Makefiles before inclusion
Sep 29 2023, 11:20 PM
stevek added a comment to D42019: Allow for CSTD to be set kernel module Makefiles before inclusion.

I should also note that we currently have at least one case of this in our source tree currently, which is what prompted the change. It compiles fine with "c99", but does not with "gnu99".
It's going to take some time for the code to be able to be changed to address the issues.

Sep 29 2023, 7:14 PM
stevek added a comment to D42019: Allow for CSTD to be set kernel module Makefiles before inclusion.
In D42019#958439, @sjg wrote:

Given conf generates one big Makefile for the entire kernel, and thus CSTD is global for everything compiled into the kernel, I'm unsure how sensible this really is

As already noted, this makefile is used by kernel modules too.
The makefile generated by config(8) is not relevant.

Yes, but typically modules can also be compiled into the kernel, where you need to use -std= explicitly. I don't object to it going in, I just don't see it being all that useful.

Sep 29 2023, 7:10 PM
stevek added a comment to D42019: Allow for CSTD to be set kernel module Makefiles before inclusion.
In D42019#958400, @imp wrote:

I've been running with this set to c11....

What do you want to set higher? And what do people think about just inching this up across the board.

Sep 29 2023, 4:34 PM
stevek requested review of D42019: Allow for CSTD to be set kernel module Makefiles before inclusion.
Sep 29 2023, 3:08 PM

Sep 22 2023

stevek accepted D41946: Add support for host32 for DIRDEPS_BUILD.

Looks good

Sep 22 2023, 9:32 PM

Sep 20 2023

stevek committed rG8789e3b0214e: rpcbind: Add flag for foreground mode (authored by stevek).
rpcbind: Add flag for foreground mode
Sep 20 2023, 3:42 PM
stevek closed D41674: rpcbind: Add flag for foreground mode.
Sep 20 2023, 3:41 PM

Sep 19 2023

stevek added a comment to D41674: rpcbind: Add flag for foreground mode.
In D41674#954474, @imp wrote:

This seems fine.

Sep 19 2023, 2:39 PM

Aug 31 2023

stevek added a reviewer for D41674: rpcbind: Add flag for foreground mode: imp.
Aug 31 2023, 5:05 PM