Update summary
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Apr 4 2024
Apr 3 2024
In D10469#794487, @emaste wrote:There seems to be no change here or in https://github.com/trixirt/libc11ext in the last five years. @trix_juniper.net are you still planning to pursue this?
Made changes according to review comments.
Also fixed an issue when compiling gve_adminq.c due to the addition of
prototypes that use "bool", but the .c file was not including sys/types.h
Apr 1 2024
Updated based on review comments
Mar 28 2024
Updated based on review comments
In D44535#1015791, @andrew wrote:Is there a reason to not have cpu_reset_hook = psci_reset by default so we can remove the NULL check?
Mar 27 2024
Fixed typo in comment.
Mar 21 2024
Mar 1 2024
Feb 15 2024
Dec 30 2023
Dec 1 2023
Nov 30 2023
Changed iiccopyinmsgs32 to iic_copyinmsgs32, per suggested comments
Addressed comments from jhb
Nov 29 2023
Nov 20 2023
Nov 15 2023
Nov 3 2023
Looks good, verified with the board where we had seen the issue.
Nov 2 2023
Updated to current "main" branch and removed $FreeBSD$ lines
Oct 30 2023
In D42025#967445, @kib wrote:You also need to rename the vars in the summary.
Updated the review summary from the commit log
Updated environment variable to match the variables used internally.
Instead of OPTIONAL_STATIC_TLS, the name is now STATIC_TLS_EXTRA.
Updated the man page also.
Oct 29 2023
Made changes per review comments.
Oct 13 2023
Sep 29 2023
I should also note that we currently have at least one case of this in our source tree currently, which is what prompted the change. It compiles fine with "c99", but does not with "gnu99".
It's going to take some time for the code to be able to be changed to address the issues.
In D42019#958440, @jrtc27 wrote:In D42019#958439, @sjg wrote:In D42019#958437, @jrtc27 wrote:Given conf generates one big Makefile for the entire kernel, and thus CSTD is global for everything compiled into the kernel, I'm unsure how sensible this really is
As already noted, this makefile is used by kernel modules too.
The makefile generated by config(8) is not relevant.Yes, but typically modules can also be compiled into the kernel, where you need to use -std= explicitly. I don't object to it going in, I just don't see it being all that useful.
In D42019#958400, @imp wrote:I've been running with this set to c11....
What do you want to set higher? And what do people think about just inching this up across the board.
Sep 22 2023
Sep 20 2023
Sep 19 2023
In D41674#954474, @imp wrote:This seems fine.