One common typo: "CPU featire flags" should be "CPU feature flags".

Edited comment for load_tmpfs

Looks good.

Looks reasonable to me.

There's also the problem that this will still have issues when dealing with re-root and/or chroot environments.

Remove KLD_ON_SECURELEVEL, as it is not necessary.

Remove unnecessary copyright in the mac_veriexec module Makefile.

In D8494#176547, @imp wrote:

I'm afraid I wasn't clear because it wasn't either of those things.

I'm thinking you should separate this change into two changes. One that's the file_loadraw() change. And a second one that's the rest of this diff. The code itself is fine. Sorry for the confusion.

In D8494#176527, @imp wrote:

Looks good to me, but maybe you'd do the file_loadraw() one first...

In D8234#171524, @jtl wrote:

Yay for this change!

And, yes, @jhb probably has a more robust solution, for reasons he states (e.g. modules that a user kldloads from a custom place).

In D8234#171288, @jhb wrote:

I think this isn't really the right way to fix this. The kernel linker knows the full path to the module and that is what kgdb uses to figure out where modules live (and they might not be in the module path at all if you have done 'make load' from a module build directory, or they could be in a "later" path in the module path if the user uses an absolute path with kldlad). pmcstat should be using the full path (though that might require fixing the pmcstat messages if pmcstat is relying on those rather than this.

It might (or might not) be relevant to Juniper that chroots might mess up reliance on the "full path" from the kernel's perspective.

Fix man page argument name for -K flag to be consistent.

Just remove freeing memory in pmcstat_cleanup, since we only clean up
when we are exiting anyway.

In D6814#155318, @andrew wrote:

This should be attached to the build, and used by the GNU dtc.

I'm looking into handling the registration differently to avoid the finalization step in order to get closer to what is necessary to support loading/unloading modules. Therefore, marking this review with Plan Changes for now.

In D7453#155148, @jhb wrote:

I would just say that these are kernel environment variables rather than sysctls in the commit message.

It looks like recent changes to uart would require a re-work of this change, abandoning this review for now.