Page MenuHomeFreeBSD
Feed Advanced Search

May 7 2019

tuexen added inline comments to D20147: Remove non-functional SCTP checksum offload support for virtio.
May 7 2019, 8:29 PM
tuexen closed D20147: Remove non-functional SCTP checksum offload support for virtio.
May 7 2019, 8:28 PM
tuexen committed rS347233: Remove non-functional SCTP checksum offload support for virtio..
Remove non-functional SCTP checksum offload support for virtio.
May 7 2019, 8:28 PM

May 5 2019

tuexen committed rS347166: MFC r337737:.
MFC r337737:
May 5 2019, 8:14 PM
tuexen committed rS347165: MFC r337708:.
MFC r337708:
May 5 2019, 8:08 PM
tuexen committed rS347163: MFC r337706:.
MFC r337706:
May 5 2019, 7:39 PM
tuexen committed rS347162: MFC r337688:.
MFC r337688:
May 5 2019, 7:31 PM
tuexen committed rS347161: MFC r336937:.
MFC r336937:
May 5 2019, 7:20 PM
tuexen committed rS347157: MFC r336932:.
MFC r336932:
May 5 2019, 2:14 PM
tuexen committed rS347156: MFC r336574:.
MFC r336574:
May 5 2019, 12:34 PM
tuexen committed rS347155: MFC r336551:.
MFC r336551:
May 5 2019, 12:33 PM
tuexen committed rS347154: MFC r336511:.
MFC r336511:
May 5 2019, 12:28 PM
tuexen committed rS347153: MFC r335194:.
MFC r335194:
May 5 2019, 12:12 PM
tuexen committed rS347152: MFC r333981:.
MFC r333981:
May 5 2019, 11:35 AM
tuexen committed rS347149: MFC r333980:.
MFC r333980:
May 5 2019, 11:05 AM
tuexen committed rS347147: MFC r333979:.
MFC r333979:
May 5 2019, 10:57 AM
tuexen committed rS347146: MFC r333604:.
MFC r333604:
May 5 2019, 10:42 AM
tuexen committed rS347144: MFC r335179:.
MFC r335179:
May 5 2019, 8:08 AM
tuexen committed rS347143: MFC r335176:.
MFC r335176:
May 5 2019, 8:06 AM

May 4 2019

tuexen committed rS347126: MFC r346854:.
MFC r346854:
May 4 2019, 1:58 PM
tuexen committed rS347125: MFC r346400:.
MFC r346400:
May 4 2019, 1:56 PM
tuexen committed rS347123: MFC r346197:.
MFC r346197:
May 4 2019, 1:05 PM
tuexen committed rS347122: MFC r346182:.
MFC r346182:
May 4 2019, 1:02 PM
tuexen committed rS347121: MFC r346134:.
MFC r346134:
May 4 2019, 1:00 PM
tuexen committed rS347120: MFC r345525:.
MFC r345525:
May 4 2019, 12:58 PM
tuexen committed rS347119: MFC r345505:.
MFC r345505:
May 4 2019, 12:56 PM
tuexen committed rS347118: MFC r345504:.
MFC r345504:
May 4 2019, 12:54 PM
tuexen committed rS347117: MFC r345494:.
MFC r345494:
May 4 2019, 12:52 PM
tuexen committed rS347116: MFC r345465:.
MFC r345465:
May 4 2019, 12:50 PM
tuexen committed rS347112: MFC r345461:.
MFC r345461:
May 4 2019, 12:07 PM
tuexen committed rS347111: MFC r345460:.
MFC r345460:
May 4 2019, 12:02 PM
tuexen committed rS347110: MFC r345458:.
MFC r345458:
May 4 2019, 11:24 AM
tuexen committed rS347109: MFC r345441:.
MFC r345441:
May 4 2019, 11:21 AM
tuexen committed rS347108: MFC r344925:.
MFC r344925:
May 4 2019, 11:18 AM
tuexen committed rS347107: MFC r344924:.
MFC r344924:
May 4 2019, 11:17 AM
tuexen committed rS347106: MFC r344872:.
MFC r344872:
May 4 2019, 11:15 AM
tuexen committed rS347105: MFC r344742:.
MFC r344742:
May 4 2019, 11:13 AM
tuexen committed rS347104: MFC r344726:.
MFC r344726:
May 4 2019, 11:11 AM
tuexen committed rS347103: MFC r344724:.
MFC r344724:
May 4 2019, 11:07 AM
tuexen committed rS347102: MFC r344723:.
MFC r344723:
May 4 2019, 11:06 AM
tuexen committed rS347101: MFC r344722:.
MFC r344722:
May 4 2019, 11:03 AM
tuexen committed rS347100: MFC r344721:.
MFC r344721:
May 4 2019, 11:01 AM
tuexen committed rS347099: MFC r344708:.
MFC r344708:
May 4 2019, 10:59 AM
tuexen committed rS347098: MFC r344704:.
MFC r344704:
May 4 2019, 10:57 AM
tuexen committed rS347096: MFC r344368:.
MFC r344368:
May 4 2019, 10:39 AM
tuexen committed rS347095: MFC r344367:.
MFC r344367:
May 4 2019, 10:36 AM
tuexen committed rS347094: MFC r344148:.
MFC r344148:
May 4 2019, 10:33 AM
tuexen committed rS347093: MFC r344048:.
MFC r344048:
May 4 2019, 10:13 AM
tuexen committed rS347092: MFC r343961:.
MFC r343961:
May 4 2019, 10:09 AM
tuexen committed rS347091: MFC r343960:.
MFC r343960:
May 4 2019, 10:06 AM
tuexen committed rS347090: MFC r340179:.
MFC r340179:
May 4 2019, 10:04 AM
tuexen committed rS347087: MFC r343954:.
MFC r343954:
May 4 2019, 9:28 AM
tuexen committed rS347086: MFC r343951:.
MFC r343951:
May 4 2019, 9:25 AM
tuexen committed rS347085: MFC r343770:.
MFC r343770:
May 4 2019, 9:18 AM
tuexen committed rS347084: MFC r343769:.
MFC r343769:
May 4 2019, 9:16 AM
tuexen committed rS347083: MFC r343742:.
MFC r343742:
May 4 2019, 9:14 AM
tuexen committed rS347082: MFC r343661:.
MFC r343661:
May 4 2019, 9:11 AM
tuexen committed rS347081: MFC r343525:.
MFC r343525:
May 4 2019, 9:07 AM
tuexen committed rS347080: MFC r343401:.
MFC r343401:
May 4 2019, 9:02 AM

May 3 2019

tuexen created D20147: Remove non-functional SCTP checksum offload support for virtio.
May 3 2019, 1:45 PM

Apr 29 2019

tuexen added a comment to D20086: Replace ncat by a perl script for running an SCTP discard server.

Yes, you are right. Not sure what I was looking at. Should I add the trailing empty line to get things consistent?

Oh I just committed rS346873, let see if it helps.

Apr 29 2019, 5:56 AM
tuexen added a comment to D20044: tun/tap: merge.

I can't seem to reproduce this issue (though some things aren't functional in my current test system (until tomorrow), as I'm bridging with encrypted wifi):

# sysctl net.link.tap.up_on_open=1
# ifconfig tap0 create
# ifconfig bridge0 create
# ifconfig bridge0 addm wlan0 addm tap0 up
# cc tap-test.c
# ./a.out
Received packet of length 86
Received packet of length 130
Received packet of length 130
Received packet of length 74

I'll run more tests in the morning on another system on ethernet, but the only way I was able to reproduce is by not setting the up_on_open sysctl (since the interface isn't up'd in the test).

Apr 29 2019, 5:32 AM

Apr 28 2019

tuexen added a comment to D20044: tun/tap: merge.

I tested this patch and the tun interface worked as expected. However, the tap interface didn't. Running the program

on an unpatched system results in output like:

tuexen@bsd14:~ % sudo ./tap-test
Received packet of length 42
Received packet of length 86
Received packet of length 130
Received packet of length 150
Received packet of length 86
Received packet of length 90
Received packet of length 74
tuexen@bsd14:~ %

On a patched system I only get:

tuexen@head:~ % sudo ./tap-test
tuexen@head:~ %

When capturing traffic on the tap0 interface on the unpatched system, I see (after some other packets) the injected UDP packet and the resulting ICMP packet.
When running tcpdump -i tap0 -n on a patched system, no packets are shown at all.

Apr 28 2019, 9:21 PM
tuexen added a comment to D20044: tun/tap: merge.

Would it make sense to use if_tuntap.c instead of if_tun.c, the same for the name of the module to load, the device to compile in?

I was pretty torn on naming- tuntap would definitely make sense and has the advantage of being a lot more obvious if one is looking for the tap driver source. Tun also makes sense to an extent (since tap is just a layer-2 tunnel) and only forces tap users to change things, rather than tap and the subset of tun users that load it as a module rather than letting it remain in their kernel config. That's probably really not that big of a deal, given the nature of this.

Apr 28 2019, 9:15 PM
tuexen added a comment to D20086: Replace ncat by a perl script for running an SCTP discard server.

Just to double check: tst.ipv4localsctp.ksh.out and tst.localsctpstate.ksh.out both contain a single empty line at the end. Do you want me to add another one to tst.localsctpstate.ksh.out. This would make them inconsistent...

https://svnweb.freebsd.org/base/head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/ip/tst.localsctpstate.ksh.out?revision=338213&view=markup
tst.localsctpstate.ksh.out doesn't seem to have an empty line in the end.

Yes, you are right. Not sure what I was looking at. Should I add the trailing empty line to get things consistent?

Apr 28 2019, 8:39 PM
tuexen committed rS346854: Some test scripts use ncat --sctp --listen port to run an SCTP discard.
Some test scripts use ncat --sctp --listen port to run an SCTP discard
Apr 28 2019, 7:07 PM
tuexen closed D20086: Replace ncat by a perl script for running an SCTP discard server.
Apr 28 2019, 7:07 PM
tuexen added a comment to D20086: Replace ncat by a perl script for running an SCTP discard server.

I've tested test in my development environment and testvm images from artifact.ci.freebsd.org, for making these two tests passing, we also need to modify tst.localsctpstate.ksh.out to added an extra blank line at the end of the file. I think it's acceptable for now, and other .out files also have this line. I would like to check that extra blank line is generated by the test driver or these ksh test scripts later, and fix them all together.

Apr 28 2019, 6:51 PM
tuexen added inline comments to D20086: Replace ncat by a perl script for running an SCTP discard server.
Apr 28 2019, 6:47 PM
tuexen updated the diff for D20086: Replace ncat by a perl script for running an SCTP discard server.

Remove debug output.

Apr 28 2019, 6:46 PM
tuexen added a comment to D20044: tun/tap: merge.

Would it make sense to use if_tuntap.c instead of if_tun.c, the same for the name of the module to load, the device to compile in?

Apr 28 2019, 12:29 PM
tuexen added a comment to D20017: Expect *localsctp* to fail.
In D20017#430777, @ngie wrote:

Abandoning review based on in-depth analysis from @tuexen.

Apr 28 2019, 10:58 AM
tuexen created D20086: Replace ncat by a perl script for running an SCTP discard server.
Apr 28 2019, 10:57 AM

Apr 25 2019

tuexen accepted D20028: Track TCP connection's NUMA domain in the inpcb.
Apr 25 2019, 2:43 PM

Apr 24 2019

tuexen added a comment to D20017: Expect *localsctp* to fail.

OK, I have figured out why the tests are failing. The problem is the discard server:

ncat --sctp --listen $local $sctpport &

Once an association is established, it figures out via select that stdin is readable, it reads 0 bytes from stdin and terminates.
For TCP one can get rid of that behaviour (using --no-shutdown / --recv-only), but none of this works for SCTP.

Apr 24 2019, 10:06 AM

Apr 23 2019

tuexen added a comment to D20017: Expect *localsctp* to fail.
In D20017#430588, @ngie wrote:

OK, I just check we have nmap in the test vm image and it does the work: https://github.com/freebsd/freebsd-ci/commit/689e19c8c71e1892f476c9ef9392f6b443d0ed15
The other failures are due to some perl stuff which I haven't had time on it: https://ci.freebsd.org/job/FreeBSD-head-amd64-dtrace_test/lastCompletedBuild/testReport/common.ip/t_dtrace_contrib/tst_ipv4localsctp_ksh/

I'm debugging this now. Seems to be a kernel issue. Will let you know once I have understood and fixed the issue.
Is using ncat and issue?

ncat isn't available on FreeBSD. The fact that there isn't a listening ncat service will mean that the test will not properly setup the necessary preconditions in order to test out the functionality.

Apr 23 2019, 10:57 PM
tuexen added a comment to D20017: Expect *localsctp* to fail.

OK, I just check we have nmap in the test vm image and it does the work: https://github.com/freebsd/freebsd-ci/commit/689e19c8c71e1892f476c9ef9392f6b443d0ed15
The other failures are due to some perl stuff which I haven't had time on it: https://ci.freebsd.org/job/FreeBSD-head-amd64-dtrace_test/lastCompletedBuild/testReport/common.ip/t_dtrace_contrib/tst_ipv4localsctp_ksh/

Apr 23 2019, 10:30 PM

Apr 22 2019

tuexen accepted D19594: Fix udp_output() locking strategy in one case.
Apr 22 2019, 8:31 PM
tuexen accepted D19594: Fix udp_output() locking strategy in one case.

I tested that this patch fixes the issue reported by syzkaller.

Apr 22 2019, 10:32 AM

Apr 19 2019

tuexen abandoned D19965: Fix various IPV6_CHECKSUM issues.
Apr 19 2019, 6:11 PM
tuexen added a comment to D19965: Fix various IPV6_CHECKSUM issues.

All for reviews have been committed. Thanks a lot for the very quick reviews!

Apr 19 2019, 6:10 PM
tuexen closed D19969: Don't send ICMPv6 packets when the checksum is wrong.
Apr 19 2019, 6:09 PM
tuexen committed rS346406: When an IPv6 packet is received for a raw socket which has the.
When an IPv6 packet is received for a raw socket which has the
Apr 19 2019, 6:09 PM
tuexen added inline comments to D19969: Don't send ICMPv6 packets when the checksum is wrong.
Apr 19 2019, 5:40 PM
tuexen updated the diff for D19969: Don't send ICMPv6 packets when the checksum is wrong.

Integrate change suggested by bz@.

Apr 19 2019, 5:40 PM
tuexen committed rS346402: When a checksum has to be computed for a received IPv6 packet because it.
When a checksum has to be computed for a received IPv6 packet because it
Apr 19 2019, 5:28 PM
tuexen closed D19968: Improve checksum computation via IPV6_CHECKSUM for received packets.
Apr 19 2019, 5:28 PM
tuexen added a comment to D19967: Don't overwrite buffer when computing checksum via IPV6_CHECKSUM.
In D19967#429234, @bz wrote:

Can you please improve the description before committing stating that it's related to rip6_output().

Apr 19 2019, 5:22 PM
tuexen committed rS346401: Avoid a buffer overwrite in rip6_output() when computing the checksum.
Avoid a buffer overwrite in rip6_output() when computing the checksum
Apr 19 2019, 5:21 PM
tuexen closed D19967: Don't overwrite buffer when computing checksum via IPV6_CHECKSUM.
Apr 19 2019, 5:21 PM
tuexen closed D19966: Improve input validation for IPPROTO_IPV6 level socket option IPV6_CHECKSUM.
Apr 19 2019, 5:18 PM
tuexen committed rS346400: Improve input validation for the socket option IPV6_CHECKSUM..
Improve input validation for the socket option IPV6_CHECKSUM.
Apr 19 2019, 5:18 PM
tuexen added a comment to D19965: Fix various IPV6_CHECKSUM issues.
In D19965#429179, @bz wrote:

Split up in four reviews or committing them separately once approved?

For review already if possible. Means I need less brain cycles now to divide the four apart as well.

Apr 19 2019, 4:49 PM
tuexen created D19969: Don't send ICMPv6 packets when the checksum is wrong.
Apr 19 2019, 4:46 PM
tuexen created D19968: Improve checksum computation via IPV6_CHECKSUM for received packets.
Apr 19 2019, 4:42 PM
tuexen created D19967: Don't overwrite buffer when computing checksum via IPV6_CHECKSUM.
Apr 19 2019, 4:36 PM
tuexen created D19966: Improve input validation for IPPROTO_IPV6 level socket option IPV6_CHECKSUM.
Apr 19 2019, 4:31 PM
tuexen added inline comments to D19965: Fix various IPV6_CHECKSUM issues.
Apr 19 2019, 4:11 PM
tuexen updated the diff for D19965: Fix various IPV6_CHECKSUM issues.

Address Ed's comment

Apr 19 2019, 4:11 PM
tuexen added a comment to D19965: Fix various IPV6_CHECKSUM issues.
In D19965#429164, @bz wrote:

This seems like four different issues and it's kind of hard to keep them apart in a single change. For the sake of having a readable history and easily seeing/understanding each problem, can you please split them up?

Apr 19 2019, 4:05 PM