Page MenuHomeFreeBSD
Feed Advanced Search

May 7 2024

imp accepted D45010: bnxt_en: Driver version update to 230.0.133.0.
May 7 2024, 3:36 PM
imp accepted D45009: bnxt_en: Firmware header version update to 1.10.3.42.

ah, mechanically generated code.

May 7 2024, 3:36 PM
imp added a comment to D45008: bnxt_en: Firmware error recovery support.

Seems reasonable, but it's a bit large to know for sure.

May 7 2024, 3:35 PM
imp accepted D45007: bnxt_en: Added support for priority queues extended stats.

This looks straight forward enough that I'm happy ...

May 7 2024, 3:22 PM
imp added inline comments to D45006: bnxt_en: L2-RoCE driver communication interface.
May 7 2024, 3:13 PM
imp added a comment to D45005: bnxt_en: Add PFC, ETS & App TLVs protocols support.

The build stuff looks good.
I can't speak to the hardware.
The extraneous (white space) changes are relatively low for vendor updates and don't get too much .

May 7 2024, 3:10 PM
imp committed rG75e5f5916e0e: boot1.efi: Don't redundantly include devpath.c (authored by imp).
boot1.efi: Don't redundantly include devpath.c
May 7 2024, 2:55 PM
imp added a comment to D44872: Use LTO/symbol versioning to optimize (de-clutter) boot bits and pieces.

boot1.efi isn't worth optimizing, especially if we have to add all the attribute((weak))
For me, it only goes from 157184 down to 132608 (with the changes I described here). I forgot to check without the adjustments with these changes unvarnished... It's still 15% savings...
And for boot1.efi, we don't want the full libsa... there's several subparts to libsa that kinda live together in this library: low level, libc stuff, filesystem support. We don't want all of that in boot1.efi, so adding whole-archive is counter productive and unnecessary. We don't use the filesystem support at all in boot1.efi.

May 7 2024, 3:18 AM
imp added inline comments to D44872: Use LTO/symbol versioning to optimize (de-clutter) boot bits and pieces.
May 7 2024, 2:19 AM
imp added inline comments to D44872: Use LTO/symbol versioning to optimize (de-clutter) boot bits and pieces.
May 7 2024, 12:01 AM

May 6 2024

imp added a comment to D44872: Use LTO/symbol versioning to optimize (de-clutter) boot bits and pieces.

@imp I think at one point you would be pulling just the devpath.c from the libsa, but then you gave up and started to pull the whole circus. But it continued to pull that one still. Fixed in the new rev.

May 6 2024, 11:53 PM
imp added a comment to D42116: remove OMAP4 support.

If it doesn't work, it's been broken long enough for us to retire.
IIRC, though, Oskar was working on making at least some TI SoCs working.
FreeBSD 11 or maybe early 12 was the last time my Pandaboard booted.

May 6 2024, 10:55 PM · ARM
imp committed rG08b452033834: sg: Add sg(4) man page (authored by imp).
sg: Add sg(4) man page
May 6 2024, 10:31 PM
imp accepted D45106: clock_gettime.2: fix markup.

I may have been responsible for some of this damage

May 6 2024, 8:10 PM
imp abandoned D36037: clock_gettime: Minor clarification.

ah, can't just close it :(

May 6 2024, 7:56 PM
imp accepted D36037: clock_gettime: Minor clarification.

This is my detritis... 314542de6d0a0 actually resolved this.

May 6 2024, 7:56 PM
imp added a comment to D36037: clock_gettime: Minor clarification.

hmmm, maybe I should find and commit this.

May 6 2024, 7:50 PM
imp accepted D45104: git-arc: Use a helper function to fetch boolean config variables.
May 6 2024, 6:02 PM
imp committed rG1314d14c3271: endian.h: Define uint{16,32,64}_t (authored by imp).
endian.h: Define uint{16,32,64}_t
May 6 2024, 4:44 PM
imp accepted D45099: pw: Test home directory ownership and mode..

This looks good.

May 6 2024, 3:53 PM

May 4 2024

imp committed rG1023317ac491: ota: Merge one true awk 20240422 (a3b68e649d2d) (authored by imp).
ota: Merge one true awk 20240422 (a3b68e649d2d)
May 4 2024, 9:51 PM
imp committed rG4fc5f321bac9: rc.conf.5: Fix translation from netmask to cdir (authored by imp).
rc.conf.5: Fix translation from netmask to cdir
May 4 2024, 9:48 PM
imp committed rG1c25f3fdf3e6: ota: Import One True Awk 20240422 (a3b68e649d2d) (authored by imp).
ota: Import One True Awk 20240422 (a3b68e649d2d)
May 4 2024, 5:16 PM
imp committed rGcb808de400c7: rc.conf.5: modernise network_interfaces (authored by lexi_le-fay.org).
rc.conf.5: modernise network_interfaces
May 4 2024, 4:46 PM
imp committed rG0ad9b235e1ea: arp(8): fix a typo in error message for -s/-S (authored by lexi_le-fay.org).
arp(8): fix a typo in error message for -s/-S
May 4 2024, 3:04 PM
imp committed rG9a62cdc01327: intro.2 as errno.2: Use the name macro for errno (authored by concussious.bugzilla_runbox.com).
intro.2 as errno.2: Use the name macro for errno
May 4 2024, 2:59 PM
imp committed rG69ff2d754c1c: intro.2: Add sys/syscall.h to SYNOPSIS (authored by concussious.bugzilla_runbox.com).
intro.2: Add sys/syscall.h to SYNOPSIS
May 4 2024, 2:59 PM
imp committed rG6dfbe695c322: intro.2 as errno.2: Update maximum hard link limit (authored by concussious.bugzilla_runbox.com).
intro.2 as errno.2: Update maximum hard link limit
May 4 2024, 2:59 PM
imp committed rG6279646f47d3: aic7xxx: make target mode enable a device hint (authored by hp_tmm.cx).
aic7xxx: make target mode enable a device hint
May 4 2024, 2:45 PM
imp committed rG34db47a9dbc7: aic7xxx: aicasm correct include file (authored by hp_tmm.cx).
aic7xxx: aicasm correct include file
May 4 2024, 2:45 PM
imp committed rG758d02fb3074: checkstyle9: Relax sob line requirement (authored by imp).
checkstyle9: Relax sob line requirement
May 4 2024, 1:58 PM
imp committed rG2f9966ff63d6: packages: add package for NTP (authored by lexi_le-fay.org).
packages: add package for NTP
May 4 2024, 1:44 PM

May 3 2024

imp committed rG04ea5e9f84e2: MINIMAL: Grow minimal to support ata, scsi and nvme (authored by imp).
MINIMAL: Grow minimal to support ata, scsi and nvme
May 3 2024, 3:09 PM
imp closed D45012: MINIMAL: Grow minimal to support ata, scsi and nvme.
May 3 2024, 3:09 PM
imp committed rGea2d874cca7c: geom_stripe: Cascade cantrim just like we do for gmirror (authored by mgrooms_shrew.net).
geom_stripe: Cascade cantrim just like we do for gmirror
May 3 2024, 3:04 PM
imp committed rG12117d0e9314: da: Update trim stats for WRITE SAME and ATA TRIM (authored by mgrooms_shrew.net).
da: Update trim stats for WRITE SAME and ATA TRIM
May 3 2024, 2:48 PM

May 2 2024

imp committed rGd21c19d4127b: cam/iosched: Document latency buckets correctly. (authored by imp).
cam/iosched: Document latency buckets correctly.
May 2 2024, 10:02 PM
imp committed rGb12cae88cfb6: nvmecontrol: Allow optional /dev/ for device names (authored by imp).
nvmecontrol: Allow optional /dev/ for device names
May 2 2024, 9:53 PM
imp added a comment to D45042: arm64: Make jemalloc safe for 16k / 4k interoperability.

I've been thinking about adding PAGE_SIZE_MAX/PAGE_SHIFT_MAX or similar to arm64 to define the largest page size the kernel could support. We could then use that here if it's defined.

May 2 2024, 2:56 PM

May 1 2024

imp accepted D44715: nvmecontrol: New commands to support Fabrics hosts.

Thanks for the rework!
I'm just finishing a nvme-cli port :)

May 1 2024, 10:15 PM
imp added a comment to D40676: ktrace: Record detailed ECAPMODE violations.

After this change, ktrace output is littered with 'CAP system call not allowed: $SYSCALL' on systems w/o capsicum enabled

Are systems without Capsicum still supported? I thought that option was removed in 14.

May 1 2024, 4:17 PM · capsicum
imp added a comment to D45042: arm64: Make jemalloc safe for 16k / 4k interoperability.

I've run this patch from you and noticed no world build time regressions with a 4k kernel

May 1 2024, 2:41 PM
imp added a comment to D45032: Boot option to mute console messages after the banner is displayed..

https://cgit.freebsd.org/src/commit/?id=2cb49090114108d594195b9b32c762391340484c

May 1 2024, 4:08 AM

Apr 30 2024

imp added inline comments to D44986: Fix new users of MAXPHYS and hide it from the kernel namespace.
Apr 30 2024, 1:50 AM

Apr 29 2024

imp requested review of D45012: MINIMAL: Grow minimal to support ata, scsi and nvme.
Apr 29 2024, 3:16 PM
imp committed rG86fbb05da1ae: ctl: Fix CTL GET EVENT STATUS NOTIFICATION valid bits (authored by hp_tmm.cx).
ctl: Fix CTL GET EVENT STATUS NOTIFICATION valid bits
Apr 29 2024, 2:38 PM
imp committed rGe05b6502f9ca: package: fix dependency generation (authored by lexi_le-fay.org).
package: fix dependency generation
Apr 29 2024, 2:33 PM
imp committed rG2ef5a8624a15: package: FreeBSD-periodic should depend on FreeBSD-cron (authored by lexi_le-fay.org).
package: FreeBSD-periodic should depend on FreeBSD-cron
Apr 29 2024, 2:31 PM
imp committed rG702766d09a37: services.5: describe better (authored by concussious.bugzilla_runbox.com).
services.5: describe better
Apr 29 2024, 2:23 PM
imp committed rGb2b8fa1a64af: Add libxo support to du (authored by Nathan Huff <nhuff@acm.org>).
Add libxo support to du
Apr 29 2024, 2:23 PM
imp committed rGd289382897e7: rights.4: various corrections on capability rights (authored by CismonX <admin@cismon.net>).
rights.4: various corrections on capability rights
Apr 29 2024, 4:49 AM
imp committed rG78444b5ade65: glabel: Add support for Linux swap (authored by rbranco_suse.com).
glabel: Add support for Linux swap
Apr 29 2024, 4:41 AM
imp committed rG0c0a2110f196: package: move authpf into the FreeBSD-pf package (authored by lexi_le-fay.org).
package: move authpf into the FreeBSD-pf package
Apr 29 2024, 4:35 AM
imp committed rG1b3c07bed63c: package: move OpenBSM auditing into its own package (authored by lexi_le-fay.org).
package: move OpenBSM auditing into its own package
Apr 29 2024, 4:35 AM
imp committed rG6b1d152d892d: UPDATING: add entry for recent pkgbase changes (authored by lexi_le-fay.org).
UPDATING: add entry for recent pkgbase changes
Apr 29 2024, 4:35 AM
imp committed rGd94c991f3bcd: setkey: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0]) (authored by ehaouas_noos.fr).
setkey: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0])
Apr 29 2024, 4:28 AM
imp committed rG70fad8acae73: ipf: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0]) (authored by ehaouas_noos.fr).
ipf: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0])
Apr 29 2024, 4:28 AM
imp committed rG7028e630d611: camcontrol: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0]) (authored by ehaouas_noos.fr).
camcontrol: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0])
Apr 29 2024, 4:28 AM
imp committed rGc3c816173d25: ipfw: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0]) (authored by ehaouas_noos.fr).
ipfw: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0])
Apr 29 2024, 4:28 AM
imp committed rGb561d8f59c7d: zonectl: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0]) (authored by ehaouas_noos.fr).
zonectl: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0])
Apr 29 2024, 4:28 AM
imp committed rGabab59f662b3: usbconfig: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0]) (authored by ehaouas_noos.fr).
usbconfig: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0])
Apr 29 2024, 4:28 AM
imp committed rGcbfd42cc07cc: wlandebug: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0]) (authored by ehaouas_noos.fr).
wlandebug: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0])
Apr 29 2024, 4:28 AM
imp committed rG4c6e656e2e5a: rwhod: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0]) (authored by ehaouas_noos.fr).
rwhod: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0])
Apr 29 2024, 4:28 AM
imp committed rGf93475cf0fd8: pstat: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0]) (authored by ehaouas_noos.fr).
pstat: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0])
Apr 29 2024, 4:28 AM
imp committed rG67db7b43d07e: ppp: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0]) (authored by ehaouas_noos.fr).
ppp: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0])
Apr 29 2024, 4:28 AM
imp committed rGbccbb2fc4bce: ndp: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0]) (authored by ehaouas_noos.fr).
ndp: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0])
Apr 29 2024, 4:28 AM
imp committed rG83409a9357a4: moused: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0]) (authored by ehaouas_noos.fr).
moused: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0])
Apr 29 2024, 4:28 AM
imp committed rG338d9c35d55d: kbdcontrol: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0]) (authored by ehaouas_noos.fr).
kbdcontrol: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0])
Apr 29 2024, 4:28 AM
imp committed rG8f65dcd6276b: ctld: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0]) (authored by ehaouas_noos.fr).
ctld: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0])
Apr 29 2024, 4:28 AM
imp committed rG2f8ea2f605ac: ctladm: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0]) (authored by ehaouas_noos.fr).
ctladm: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0])
Apr 29 2024, 4:28 AM
imp committed rG8918cc95e869: btxld: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0]) (authored by ehaouas_noos.fr).
btxld: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0])
Apr 29 2024, 4:28 AM
imp committed rGd1d652c06015: rtadvctl: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0]) (authored by ehaouas_noos.fr).
rtadvctl: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0])
Apr 29 2024, 4:28 AM
imp committed rG93e96d6c87dc: rtadvd: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0]) (authored by ehaouas_noos.fr).
rtadvd: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0])
Apr 29 2024, 4:27 AM
imp committed rGfdbf7cab91ae: bluetooth: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0]) (authored by ehaouas_noos.fr).
bluetooth: Use nitems(foo) instead of sizeof(foo)/sizeof(foo[0])
Apr 29 2024, 4:27 AM
imp committed rG2b8df536a681: axgbe: Various stability improvements (authored by stephan.dewt_yahoo.co.uk).
axgbe: Various stability improvements
Apr 29 2024, 2:42 AM
imp committed rG6063683eb83a: ada: Another NCQ Trim instability drive (authored by imp).
ada: Another NCQ Trim instability drive
Apr 29 2024, 2:38 AM

Apr 28 2024

imp accepted D44754: fattime: make the test code check beyond 32-bit time_t limits.
Apr 28 2024, 11:14 PM
imp accepted D44753: fattime: make the test code build again.
Apr 28 2024, 8:48 PM
imp added a comment to D33233: sync.8: Document that the "sync dance" is not a thing.
In D33233#1025445, @imp wrote:

There's almost no difference between sync; shutdown and just shutdow other than more typing. The latter does a sync first thing anyway (in the system call) so you may start the io a smidgen earlier with the former... but sync doesn't guarantee the io will be done before shutdown starts... so even doing them on sepatate lines might only gain you the time it takes you to type shutdown at the expense of typing 5 extra characters.

The main difference is that you control the time you leave to the system to actually write to disk. Typing sync and then shutdown almost immediately indeed doesn't make much sense. Waiting for some seconds or much more does, if you know statistically that all writes will have finished by that chosen time.

Apr 28 2024, 6:26 PM
imp accepted D44986: Fix new users of MAXPHYS and hide it from the kernel namespace.
Apr 28 2024, 6:04 PM

Apr 27 2024

imp added a comment to D44979: in6.h: expose s6_addr* definitions to user level.

Yes. I agree. It will be defined for both kernel and loader builds.

Apr 27 2024, 7:20 PM
imp committed rG8c81694af438: linux: ignore setsockopt(IPV6_RECVERR) (authored by lexi_le-fay.org).
linux: ignore setsockopt(IPV6_RECVERR)
Apr 27 2024, 1:04 PM
imp added a comment to D33233: sync.8: Document that the "sync dance" is not a thing.

There's almost no difference between sync; shutdown and just shutdow other than more typing. The latter does a sync first thing anyway (in the system call) so you may start the io a smidgen earlier with the former... but sync doesn't guarantee the io will be done before shutdown starts... so even doing them on sepatate lines might only gain you the time it takes you to type shutdown at the expense of typing 5 extra characters.

Apr 27 2024, 3:12 AM
imp added a comment to D33233: sync.8: Document that the "sync dance" is not a thing.

Since reboot and shutdown system calls were added just after v7, the sync 3 times dance is a placebo. It was marginally useful on v7 before powering off. It's existed in lore as being necessary when it hasn't been. And since all it does is schedule IO you can't use it to know data is on the disk.

Apr 27 2024, 2:17 AM

Apr 26 2024

imp added inline comments to D44979: in6.h: expose s6_addr* definitions to user level.
Apr 26 2024, 11:04 PM
imp committed rGf0e59ecff85d: CTL: READ(6) should be allowed on CD devices (authored by hp_tmm.cx).
CTL: READ(6) should be allowed on CD devices
Apr 26 2024, 3:14 AM

Apr 25 2024

imp committed rGce3b53ffcc3e: nvmecontrol: Flesh out nvmecontrol format information (authored by imp).
nvmecontrol: Flesh out nvmecontrol format information
Apr 25 2024, 11:48 PM
imp closed D44958: nvmecontrol: Flesh out nvmecontrol format information.
Apr 25 2024, 11:48 PM
imp updated the diff for D44958: nvmecontrol: Flesh out nvmecontrol format information.

update per Chuck's idea of making it clear it's an index. Hopefully this makes
it clearer. Thanks Chuck!

Apr 25 2024, 11:16 PM
imp added reviewers for D44958: nvmecontrol: Flesh out nvmecontrol format information: chuck, chs, mav, manpages.
Apr 25 2024, 5:25 PM
imp requested review of D44958: nvmecontrol: Flesh out nvmecontrol format information.
Apr 25 2024, 5:24 PM
imp added a comment to D44918: fwget: update wireless IDs for rtw88/89, ath1xk, mt76 and add iwlwifi.

So I'm not saying we need it now, but we likely need to know if we can... get some sleep

Apr 25 2024, 4:05 AM
imp added a comment to D44918: fwget: update wireless IDs for rtw88/89, ath1xk, mt76 and add iwlwifi.

I don't suppose that yhese could be generated automatically? It's a huge table to maintain by hand...

Apr 25 2024, 3:15 AM
imp added a comment to D44935: Unmuting console boot messages for some scenarios.

Any reason to not always set cn_mute = 0 unconditionally?

Apr 25 2024, 3:12 AM

Apr 24 2024

imp committed rG9857f824ec77: arm_kernel_bothdr.awk: Update to latest ota (authored by imp).
arm_kernel_bothdr.awk: Update to latest ota
Apr 24 2024, 11:59 PM
imp committed rGc7a5881d7a6a: Add support for Intel Atom S1200 UART (authored by henrichhartzer_tuta.io).
Add support for Intel Atom S1200 UART
Apr 24 2024, 11:59 PM
imp accepted D44931: vfs_lookup.c: only call ktrcapfail() if KTRACE is enabled.
Apr 24 2024, 7:18 PM
imp accepted D44930: syscalls.master: correct return type of {read,write}v.
Apr 24 2024, 7:12 PM
imp added a comment to D43463: grdc: add countdown timer mode.

Can we merge this?

Apr 24 2024, 4:23 AM
imp added a reverting change for rGcf04a7775a4e: swapon: Do not overwrite Linux swap header: rGfeabaf8d5389: Revert "swapon: Do not overwrite Linux swap header".
Apr 24 2024, 3:19 AM