Page MenuHomeFreeBSD
Feed Advanced Search

Sep 11 2019

imp committed rS352212: Assume all the short args have optional args so allocate space for the.
Assume all the short args have optional args so allocate space for the
Sep 11 2019, 1:34 PM
imp accepted D21487: mips: ubldr: use truncated load address for mips32.

I fear this is the last bad choice we have.

Sep 11 2019, 1:18 AM

Sep 10 2019

imp committed rS352171: Remove dirs (and their now-empty parents) empty since r344779.
Remove dirs (and their now-empty parents) empty since r344779
Sep 10 2019, 5:51 PM
imp committed rS352170: Remove dir empty since r327952.
Remove dir empty since r327952
Sep 10 2019, 5:50 PM
imp committed rS352169: Remove dir empty since r314564.
Remove dir empty since r314564
Sep 10 2019, 5:49 PM
imp committed rS352168: Remove dirs empty since r280031.
Remove dirs empty since r280031
Sep 10 2019, 5:47 PM
imp committed rS352167: Remove dir empty since r276851.
Remove dir empty since r276851
Sep 10 2019, 5:46 PM
imp committed rS352162: Remove empty directory after r297894.
Remove empty directory after r297894
Sep 10 2019, 5:31 PM
imp committed rS352161: Remove empty dir after r342815 (pt 2, oops).
Remove empty dir after r342815 (pt 2, oops)
Sep 10 2019, 5:30 PM
imp committed rS352160: Remove empty dir after r288683.
Remove empty dir after r288683
Sep 10 2019, 5:27 PM
imp committed rS352159: Remove empty dir after r342815.
Remove empty dir after r342815
Sep 10 2019, 5:26 PM
imp committed rS352158: Remove dir empty since r214734.
Remove dir empty since r214734
Sep 10 2019, 5:20 PM
imp committed rS352157: Remove dirs empty since r336203.
Remove dirs empty since r336203
Sep 10 2019, 5:19 PM
imp committed rS352156: Remove directory empty after r266735.
Remove directory empty after r266735
Sep 10 2019, 4:58 PM
imp committed rS352155: Remove empty directory after r215937.
Remove empty directory after r215937
Sep 10 2019, 4:57 PM
imp committed rS352154: Remove empty directory after r342871.
Remove empty directory after r342871
Sep 10 2019, 4:56 PM
imp committed rS352153: Remove empty directory imported with r342935.
Remove empty directory imported with r342935
Sep 10 2019, 4:53 PM
imp committed rS352152: Remove empty directory imported with r238438.
Remove empty directory imported with r238438
Sep 10 2019, 4:52 PM
imp committed rS352151: Remove now-empty directory after r288337.
Remove now-empty directory after r288337
Sep 10 2019, 4:50 PM
imp committed rS352150: Remove now-empty directories after r272458.
Remove now-empty directories after r272458
Sep 10 2019, 4:49 PM
imp committed rS352149: Remove gateworks directories left over from r336136.
Remove gateworks directories left over from r336136
Sep 10 2019, 4:43 PM
imp committed rS352148: Remove empty tap/tun modules directories after r347241.
Remove empty tap/tun modules directories after r347241
Sep 10 2019, 4:41 PM
imp committed rS352147: Remove leftover usr.bin/send-pr after r338042.
Remove leftover usr.bin/send-pr after r338042
Sep 10 2019, 4:40 PM
imp committed rS352146: Remove empty directory after r342256.
Remove empty directory after r342256
Sep 10 2019, 4:39 PM
imp committed rS352145: Remove empty directory aftre r336532.
Remove empty directory aftre r336532
Sep 10 2019, 4:37 PM
imp committed rS352144: Remove more directories left over from nand removal.
Remove more directories left over from nand removal
Sep 10 2019, 4:36 PM
imp committed rS352143: Remove empty directories after drm removal.
Remove empty directories after drm removal
Sep 10 2019, 4:35 PM
imp committed rS352141: Remove empty directories left over from nand removal.
Remove empty directories left over from nand removal
Sep 10 2019, 4:30 PM

Sep 9 2019

imp committed rS352100: Remove obsolete WITHOUT names that are no longer in the system..
Remove obsolete WITHOUT names that are no longer in the system.
Sep 9 2019, 6:46 PM
imp committed rS352099: These should have been removed when we removed atmel port before 12..
These should have been removed when we removed atmel port before 12.
Sep 9 2019, 6:46 PM
imp committed rS352094: MFC: r351429,351430,351485,351497,351498.
MFC: r351429,351430,351485,351497,351498
Sep 9 2019, 6:28 PM

Sep 7 2019

imp committed rS352023: MFC: r351429, r351430, r351485, r351497, r351498.
MFC: r351429, r351430, r351485, r351497, r351498
Sep 7 2019, 8:01 PM
imp committed rS351967: Some newer HID devices have descriptors that are larger than 1k. Bump.
Some newer HID devices have descriptors that are larger than 1k. Bump
Sep 7 2019, 3:52 AM

Sep 6 2019

imp committed rS351950: Initialize if_hw_tsomaxsegsize to 0 to appease gcc's flow analysis as a.
Initialize if_hw_tsomaxsegsize to 0 to appease gcc's flow analysis as a
Sep 6 2019, 6:25 PM
imp closed D21530: Fix ggate.h typo..
Sep 6 2019, 3:02 PM
imp committed rS351936: Fix typo not -> nor and add 'the' because we are talking about specific flags.
Fix typo not -> nor and add 'the' because we are talking about specific flags
Sep 6 2019, 3:02 PM
imp accepted D21552: rc.8: Update documentation regarding old-style rc scripts.
Sep 6 2019, 2:54 PM
imp added inline comments to D21530: Fix ggate.h typo..
Sep 6 2019, 2:19 PM
imp added inline comments to D21530: Fix ggate.h typo..
Sep 6 2019, 4:15 AM
imp committed rS351917: MFC r349845:.
MFC r349845:
Sep 6 2019, 12:07 AM

Sep 5 2019

imp committed rS351915: MFC r349845:.
MFC r349845:
Sep 5 2019, 11:55 PM
imp committed rS351914: MFC r351747:.
MFC r351747:
Sep 5 2019, 11:40 PM
imp committed rS351913: MFC r343755:.
MFC r343755:
Sep 5 2019, 11:28 PM
imp committed rS351912: Revert r351902 ... it didn't properly exclude rack.c changes.
Revert r351902 ... it didn't properly exclude rack.c changes
Sep 5 2019, 11:25 PM
imp committed rS351911: MFC r351706:.
MFC r351706:
Sep 5 2019, 11:13 PM
imp committed rS351910: MFC r351705:.
MFC r351705:
Sep 5 2019, 11:13 PM
imp committed rS351909: MFC r351704:.
MFC r351704:
Sep 5 2019, 11:12 PM
imp committed rS351908: MFC r351406,r351447:.
MFC r351406,r351447:
Sep 5 2019, 11:10 PM
imp committed rS351907: MFC r351411:.
MFC r351411:
Sep 5 2019, 11:08 PM
imp committed rS351906: MFC r351403:.
MFC r351403:
Sep 5 2019, 11:04 PM
imp committed rS351905: MFC r351376:.
MFC r351376:
Sep 5 2019, 11:03 PM
imp committed rS351904: MFC r351356:.
MFC r351356:
Sep 5 2019, 11:02 PM
imp committed rS351903: MFC r351355:.
MFC r351355:
Sep 5 2019, 11:01 PM
imp committed rS351902: MFC r343755:.
MFC r343755:
Sep 5 2019, 10:39 PM
imp accepted D21286: Loader: Add load offset to powerpc kernel entry point.
Sep 5 2019, 9:46 PM

Sep 4 2019

imp committed rS351828: Support doorbell strides != 0..
Support doorbell strides != 0.
Sep 4 2019, 8:08 PM
imp closed D21514: Support doorbell strides != 0..
Sep 4 2019, 8:08 PM
imp committed rS351824: Report the Host Buffer Memory minimum and preferred sizes..
Report the Host Buffer Memory minimum and preferred sizes.
Sep 4 2019, 7:19 PM
imp added inline comments to D21514: Support doorbell strides != 0..
Sep 4 2019, 4:01 PM

Sep 3 2019

imp updated the diff for D21514: Support doorbell strides != 0..

Fix some comment wrapping.

Sep 3 2019, 10:22 PM
imp added inline comments to D21514: Support doorbell strides != 0..
Sep 3 2019, 10:21 PM
imp updated the diff for D21514: Support doorbell strides != 0..

mixed up min / max

Sep 3 2019, 10:20 PM
imp added a reviewer for D21514: Support doorbell strides != 0.: mav.
Sep 3 2019, 9:46 PM
imp updated the test plan for D21514: Support doorbell strides != 0..
Sep 3 2019, 9:42 PM
imp created D21514: Support doorbell strides != 0..
Sep 3 2019, 9:39 PM
imp committed rS351747: Implement nvme suspend / resume for pci attachment.
Implement nvme suspend / resume for pci attachment
Sep 3 2019, 3:26 PM
imp closed D21493: Implement nvme suspend / resume for pci attachment.
Sep 3 2019, 3:26 PM
imp updated the diff for D21493: Implement nvme suspend / resume for pci attachment.

Improve comments. Wait for reset to finish. stay in the 'resetting'
state until resume completes (though this seems to only affect
queueing of new commands on I/O completions which shouldn't be
possible w/o the hardware queues present....)

Sep 3 2019, 2:44 PM
imp added inline comments to D21493: Implement nvme suspend / resume for pci attachment.
Sep 3 2019, 5:34 AM
imp added a comment to D21493: Implement nvme suspend / resume for pci attachment.

Redid with the code move into nvme_ctrlr... tests fine.. like that better (will make ahci easier to do too)...

Sep 3 2019, 5:29 AM
imp updated the diff for D21493: Implement nvme suspend / resume for pci attachment.

Move things to export less from nvme_ctrlr

Sep 3 2019, 5:27 AM
imp added inline comments to D21493: Implement nvme suspend / resume for pci attachment.
Sep 3 2019, 5:16 AM
imp added inline comments to D21493: Implement nvme suspend / resume for pci attachment.
Sep 3 2019, 3:45 AM
imp updated the test plan for D21493: Implement nvme suspend / resume for pci attachment.
Sep 3 2019, 3:41 AM
imp created D21493: Implement nvme suspend / resume for pci attachment.
Sep 3 2019, 3:39 AM

Sep 2 2019

imp committed rS351705: In all the places that we use the polled for completion interface, except crash.
In all the places that we use the polled for completion interface, except crash
Sep 2 2019, 5:11 PM
imp committed rS351706: In nvme_completion_poll, add a sanity check to make sure that we complete the.
In nvme_completion_poll, add a sanity check to make sure that we complete the
Sep 2 2019, 5:11 PM
imp committed rS351704: Add a brief comment explaining why we can return ETIMEDOUT from the call to the.
Add a brief comment explaining why we can return ETIMEDOUT from the call to the
Sep 2 2019, 5:10 PM
imp added inline comments to D21487: mips: ubldr: use truncated load address for mips32.
Sep 2 2019, 1:48 PM
imp added a comment to D21487: mips: ubldr: use truncated load address for mips32.

Seems not at all right to me...

Sep 2 2019, 2:21 AM

Aug 30 2019

imp added a comment to D21446: New port: security/ktls_isa-l_crypto..

It looks good to my eye, modulo my suggestion.

Aug 30 2019, 10:02 PM

Aug 29 2019

D21467: Use relative paths in ObsoleteFiles.inc is now accepted and ready to land.
Aug 29 2019, 5:24 PM
D21198: Fix ObsoleteFiles after pwm.9 mlink to pwmbus.9 is now accepted and ready to land.
Aug 29 2019, 4:57 PM
D21435: mips: fix _mcount is now accepted and ready to land.

LGTM, but I didn't test it.

Aug 29 2019, 4:52 PM
imp added a comment to D21465: Create new wrapper function: bus_delayed_attach_children().

From IRC this morning:
[09:40:36] <DamnHippi> bsdimp: I like the idea. I sure wish there was a way to get the relationship to interrupts or intr config hooks into the name (but the name is already pretty long).
[09:41:17] <bsdimp> I struggled with the name as well...
[09:41:34] <bsdimp> bus_delayed_attach(dev, BUS_INTR);
[09:41:43] <bsdimp> was the second choice I had to have a mask of things that you delay it for.
[09:41:46] <DamnHippi> hmmm, interesting.
[09:42:03] <bsdimp> but then that isn't just the children, etc
[09:42:12] <DamnHippi> there was another change pending having to do with delaying attachment.
[09:42:17] <bsdimp> so I went with the simple, but I'm open to something more generic
[09:42:23] <DamnHippi> hang on a sec
[09:42:25] <bsdimp> BUS_NEWDEV
[09:42:39] <bsdimp> or whatever so that nathanw's ideas could be done this way too.
[09:42:54] <bsdimp> The device is partially attach, and finishes attaching when the right device(s) appear.
[09:43:15] <DamnHippi> https://reviews.freebsd.org/D15229
[09:43:41] <bsdimp> yea, that's the one. I love the idea, and hate how he did it.
[09:43:48] <DamnHippi> I haven't even looked at it, just saw it mentioned the other day.
[09:43:51] <bsdimp> and was looking for a better way.
[09:43:56] <bsdimp> and this may be it.
[09:44:42] <DamnHippi> but I can't sidetrack into this in depth right now, I'm kinda slammed at $work.
[09:44:43] <bsdimp> It's more similar to config_intrhook() than this though. config_dependend_device_now_here() but you can't have a device_t to pass to it because that device doesn't exist :)
[09:45:16] <bsdimp> DamnHippi works for me. lemme think about your feedback and we'll chat tomorrow. I have a couple of weekend tests I want to run and I gotta get them setup.

Aug 29 2019, 3:46 PM
imp added reviewers for D21465: Create new wrapper function: bus_delayed_attach_children(): ian, jhb.
Aug 29 2019, 3:30 PM
imp created D21465: Create new wrapper function: bus_delayed_attach_children().
Aug 29 2019, 3:29 PM
imp added a comment to D21452: ichsmb: defer smbus attach until interrupts are available.

Looks great to me too... Forgot to click Accept yesterday when I looked at it.

Aug 29 2019, 2:20 PM

Aug 28 2019

imp accepted D21370: Add conv=fsync flag to dd.
Aug 28 2019, 7:35 PM

Aug 26 2019

D21418: Centralize __pcpu definitions. is now accepted and ready to land.

Seems a bit wasteful to have multiple files with the same bits, but since some are arrays and others are pointers, I'm unsure of what to suggest instead.

Aug 26 2019, 4:41 PM
imp added a comment to D17282: new syscall: __sysctlbyname.

Thanks for doing the compat shim. I think this would have been one area where it would have been hard to recover from a make installworld before a new kernel was in place...

Aug 26 2019, 4:23 PM

Aug 25 2019

imp committed rS351498: Replace -Werror with ${WERROR} in pmcstudy.
Replace -Werror with ${WERROR} in pmcstudy
Aug 25 2019, 10:06 PM
imp committed rS351497: Replace -Werror with ${WERROR} in module builds.
Replace -Werror with ${WERROR} in module builds
Aug 25 2019, 10:06 PM
imp added inline comments to D20562: The efifat files are no longer used: remove the code to build them..
Aug 25 2019, 9:27 PM
imp committed rS351485: Fix bogusly declared WERRORs in kernel build.
Fix bogusly declared WERRORs in kernel build
Aug 25 2019, 7:39 PM
imp added a comment to D16698: First draft HID over I2C support (Mouse only).

I built this on -current and got an insta-panic when trying to lock a null spin lock in attach...

Aug 25 2019, 5:56 AM · Contributor Reviews (base)
imp added inline comments to D16698: First draft HID over I2C support (Mouse only).
Aug 25 2019, 5:52 AM · Contributor Reviews (base)

Aug 24 2019

D21389: Stop using des_cblock * for arguments to DES functions. is now accepted and ready to land.

Looks sane to me. Thanks for digging to the bottom of this rathole...

Aug 24 2019, 12:23 AM

Aug 23 2019

imp committed rS351447: It turns out the duplication is only mostly harmless..
It turns out the duplication is only mostly harmless.
Aug 23 2019, 10:53 PM
imp closed D21382: It turns out the duplication is only mostly harmless..
Aug 23 2019, 10:53 PM