Page MenuHomeFreeBSD
Feed Advanced Search

Advanced Search
Use Results
Hide Query

Nov 27 2018

imp committed rS341005: NVME trim clocking.
NVME trim clocking
Nov 27 2018, 12:37 AM

Nov 26 2018

imp committed rS341003: Minor tweaks to the formatting.
Minor tweaks to the formatting
Nov 26 2018, 10:52 PM

Nov 22 2018

imp added inline comments to D18036: Fix style nits in strings.
Nov 22 2018, 1:12 AM

Nov 20 2018

imp committed rS340664: Ensure that all values of ns, us and ms work for {n,u,m}stosbt.
Ensure that all values of ns, us and ms work for {n,u,m}stosbt
Nov 20 2018, 7:11 AM
imp closed D18051: Ensure that all values of ns, us and ms work for {n,u,m}stosbt.
Nov 20 2018, 7:11 AM
imp added a comment to D18051: Ensure that all values of ns, us and ms work for {n,u,m}stosbt.

updated with kasserts enabled as much as I can...

Nov 20 2018, 2:42 AM
imp updated the diff for D18051: Ensure that all values of ns, us and ms work for {n,u,m}stosbt.

KASSERT where possible...

Nov 20 2018, 2:40 AM

Nov 19 2018

imp updated the diff for D18051: Ensure that all values of ns, us and ms work for {n,u,m}stosbt.

cem's changes

Nov 19 2018, 11:01 PM
imp added a comment to D18051: Ensure that all values of ns, us and ms work for {n,u,m}stosbt.

OK. I think that some of the other ways to spell stuff may be more obscure.

Nov 19 2018, 11:00 PM
imp updated the summary of D18051: Ensure that all values of ns, us and ms work for {n,u,m}stosbt.
Nov 19 2018, 9:42 PM
imp updated the test plan for D18051: Ensure that all values of ns, us and ms work for {n,u,m}stosbt.
Nov 19 2018, 8:58 PM
imp created D18051: Ensure that all values of ns, us and ms work for {n,u,m}stosbt.
Nov 19 2018, 8:55 PM

Nov 16 2018

imp closed D3461: Base of autoloading stuff.

This was committed a long time ago...

Nov 16 2018, 10:03 PM
imp added a comment to D17705: Suggest upload of dmesg in login fortune file.

I don't think we need email= anymore.

Nov 16 2018, 5:43 PM
imp committed rS340481: Remove do-nothing nvme_modevent..
Remove do-nothing nvme_modevent.
Nov 16 2018, 4:51 PM

Nov 15 2018

imp committed rS340452: Introduce scsi_ata_setfeatures() as a convenient way to make.
Introduce scsi_ata_setfeatures() as a convenient way to make
Nov 15 2018, 4:02 PM
imp committed rS340453: Add cam_iosched_set_latfcn to set a latency callback for high latency..
Add cam_iosched_set_latfcn to set a latency callback for high latency.
Nov 15 2018, 4:02 PM
imp committed rS340450: When converting ns,us,ms to sbt, return the ceil() of the result.
When converting ns,us,ms to sbt, return the ceil() of the result
Nov 15 2018, 4:02 PM
imp committed rS340451: Do proper conversion to/from sbt..
Do proper conversion to/from sbt.
Nov 15 2018, 4:02 PM

Nov 14 2018

imp committed rS340448: Remove trailing white space in advance of other changes..
Remove trailing white space in advance of other changes.
Nov 14 2018, 11:16 PM
imp added a comment to D17860: <<Two NVMe Bootup hang>.

Seems reasonable to me.

Nov 14 2018, 3:59 PM
imp added a comment to D17973: Fix /etc/ntp mode.
In D17973#384258, @garga wrote:

Since I don't have a src bit, may I add "Approved by: imp"?

Nov 14 2018, 3:39 PM

Nov 13 2018

imp committed rS340418: Remove support for versions prior to FreeBSD 7.0 from twa(4).
Remove support for versions prior to FreeBSD 7.0 from twa(4)
Nov 13 2018, 11:53 PM
imp committed rS340412: Use atomic_load_acq_int() here too to poll done, ala r328521.
Use atomic_load_acq_int() here too to poll done, ala r328521
Nov 13 2018, 10:41 PM
imp accepted D17969: Prepare for removal of CTM from FreeBSD-13.

Looks good. I have a couple of suggested tweaks that make things better imho, but if you don't like one or the other, you can ignore.
I trust whatever you decide, so I'm clicking 'accept' to not hold things up.

Nov 13 2018, 2:51 PM · manpages
imp accepted D17973: Fix /etc/ntp mode.
Nov 13 2018, 2:46 PM
imp added a comment to D17865: Increase SDMA default boundary for SDHCI.

FWIW, we run MAXPHYS of 8MB at Netflix. There's been talk of bumping MAXPHYS to 1MB from 128k since it helps a lot on more modern devices.

Nov 13 2018, 2:42 PM

Nov 12 2018

imp accepted D17935: Remove CTM from 13-CURRENT.

Looks good to me. I'd do a separate commit that just says 'CTM will move to ports in FreeBSD 13' in the ctm man page and get that merged before 12.0R (so ASAP).
I agree with Rob we should have an updating entry, and a line in the release notes (relnotes: yes should do that).
I don't think we need to do anything more other than commit this review after a few month (there's no rush, and safely after the turbulence 12.0R is mildly better), but I'll give that feedback and leave the timing to your discretion.

Nov 12 2018, 6:12 PM · Src Committers
imp added inline comments to D17958: Print an error message in efi_main.c if we can't allocate memory for the heap..
Nov 12 2018, 5:34 PM
imp accepted D17912: Enable evdev driver and support in generic.
Nov 12 2018, 5:19 PM

Nov 10 2018

imp accepted D17934: Don't stat nsswitch.conf all the time..
Nov 10 2018, 2:18 AM

Nov 8 2018

imp added a comment to D17912: Enable evdev driver and support in generic.

Please also add to MINIMAL

Nov 8 2018, 7:40 PM
imp committed rS340250: MFC r340155: Assert locks held for async events..
MFC r340155: Assert locks held for async events.
Nov 8 2018, 2:21 PM

Nov 7 2018

imp accepted D17892: newvers.sh: avoid regenerating vers.c if content unchanged.
Nov 7 2018, 6:48 PM

Nov 5 2018

imp committed rS340155: Only assert locked for many async events..
Only assert locked for many async events.
Nov 5 2018, 6:47 PM
imp closed D17837: Only assert locked for many async events..
Nov 5 2018, 6:47 PM
imp accepted D17848: Update review requests for bhyve..

Seems to achieve the desired policy goals.

Nov 5 2018, 6:07 PM

Nov 4 2018

imp added a comment to D17822: loader: always set media size from partition..

Seems legit to me. I like the abstraction even if we don't determine the size in multiple places.

Nov 4 2018, 6:23 PM
imp added reviewers for D17837: Only assert locked for many async events.: ken, scottl.
Nov 4 2018, 6:18 PM
imp created D17837: Only assert locked for many async events..
Nov 4 2018, 6:17 PM

Nov 3 2018

imp committed rS340094: Add missing .El.
Add missing .El
Nov 3 2018, 1:44 AM
imp committed rS340093: Document disbale_phy in ahcich sysctls..
Document disbale_phy in ahcich sysctls.
Nov 3 2018, 12:47 AM
imp committed rS340092: Implement ability to turn on/off PHYs for AHCI devices..
Implement ability to turn on/off PHYs for AHCI devices.
Nov 3 2018, 12:38 AM
imp closed D16043: add a sysctl to the AHCI driver to allow disabling the PHY.
Nov 3 2018, 12:38 AM

Nov 2 2018

imp committed rS340088: Further research shows usbdump(8) is what we should point people at.
Further research shows usbdump(8) is what we should point people at
Nov 2 2018, 10:18 PM
imp committed rS340087: Catch up with the SCSI device removal. We should likely review why we.
Catch up with the SCSI device removal. We should likely review why we
Nov 2 2018, 10:16 PM
imp committed rS340086: Document r226775: tell why we omit usbus[0-9]+.
Document r226775: tell why we omit usbus[0-9]+
Nov 2 2018, 10:15 PM
imp added a comment to D16043: add a sysctl to the AHCI driver to allow disabling the PHY.

This looks good to my eye. I'll rebase and commit after a quick test unless I hear otherwise....

Nov 2 2018, 6:43 PM
imp created D17819: Simple int13 refactor.
Nov 2 2018, 6:01 PM
imp committed rS340074: Add sysctl_usec_to_sbintime and sysctl_msec_to_sbintime..
Add sysctl_usec_to_sbintime and sysctl_msec_to_sbintime.
Nov 2 2018, 5:51 PM

Nov 1 2018

imp committed rS340024: Add comments explaining what hold/unhold do.
Add comments explaining what hold/unhold do
Nov 1 2018, 9:51 PM
imp committed rS340019: MFC: r339800 and r339802:.
MFC: r339800 and r339802:
Nov 1 2018, 9:28 PM

Oct 31 2018

imp added a comment to D17779: Build kernel-toolchain before kernel during make universe.

I'm uneasy about doing this automatically... What if I already have a good compiler? Last thing I want is to rebuild clang a bazillion times while I'm iterating through kernel build issues on N platforms.

Oct 31 2018, 4:55 PM
imp added a comment to D17667: loader: issue edd probe before legacy ah=08 and detect no media.

OK. Since there's not a simple place to point people, let's get this in.

Oct 31 2018, 4:26 PM
imp accepted D17667: loader: issue edd probe before legacy ah=08 and detect no media.
Oct 31 2018, 2:55 PM
imp accepted D17775: Commit candidate for D16719.

these look good to me. Just a question over putting intel_ in a name for a facility that looks like it might be more generic than that...

Oct 31 2018, 2:35 PM

Oct 30 2018

imp accepted D17706: Reformat syscalls.master for better readability..
Oct 30 2018, 8:36 PM
imp added a comment to D17706: Reformat syscalls.master for better readability..

This looks sane to me. At least the few places I spot-checked did. And it passes the 'not too terrible to look at' test too, which is nice.

Oct 30 2018, 8:36 PM

Oct 29 2018

imp accepted D16966: Permit local kernel modules to be built as part of a kernel..

I dislike the ls, but have no better suggestion,

Oct 29 2018, 10:51 PM
imp accepted D17739: Update awk(1) manual to accurately describe regex syntax..

Looks good to me...

Oct 29 2018, 10:15 PM
imp added a comment to D17739: Update awk(1) manual to accurately describe regex syntax..
In D17739#379433, @dteske wrote:
In D17739#379046, @jmg wrote:

oh, don't forget to bump date!

There's no date to bump?

Oct 29 2018, 10:13 PM

Oct 28 2018

imp committed rS339834: Bump .Dd forgotten in last commit..
Bump .Dd forgotten in last commit.
Oct 28 2018, 3:02 AM
imp committed rS339833: Note that the kenrel doesn't keep track daylight savings time, nor.
Note that the kenrel doesn't keep track daylight savings time, nor
Oct 28 2018, 2:58 AM
imp committed rS339832: ftime appeared in 7th Edition Unix to replace gtime..
ftime appeared in 7th Edition Unix to replace gtime.
Oct 28 2018, 2:58 AM
imp committed rS339831: Move LUA_ROOT to /boot/lua.
Move LUA_ROOT to /boot/lua
Oct 28 2018, 2:58 AM

Oct 27 2018

imp abandoned D16805: Turn back the clock just a little: make userboot.so always be 4th.

We've fixed this via other means.
I have no plans to commit this. It's not needed. Kyle fixed all the issues.

Oct 27 2018, 3:53 AM

Oct 26 2018

imp committed rS339802: Fix pointer arithmetic.
Fix pointer arithmetic
Oct 26 2018, 11:45 PM
imp committed rS339801: Fix pointer arithmetic botch..
Fix pointer arithmetic botch.
Oct 26 2018, 11:44 PM
imp committed rS339800: Ensure we have a full EFI_DEVICE_PATH header before we try to look at.
Ensure we have a full EFI_DEVICE_PATH header before we try to look at
Oct 26 2018, 11:08 PM
imp committed rS339799: Ensure that the device path is sane before trying to decode and print.
Ensure that the device path is sane before trying to decode and print
Oct 26 2018, 10:49 PM
imp committed rS339798: Require that we have at least a device path header before.
Require that we have at least a device path header before
Oct 26 2018, 10:49 PM
imp committed rS339797: Implenent --fromfile to read variable values when printing variables.
Implenent --fromfile to read variable values when printing variables
Oct 26 2018, 10:13 PM
imp committed rS339778: Remove empty directories after r339776..
Remove empty directories after r339776.
Oct 26 2018, 4:34 PM
imp committed rS339777: Add statistics for TRIM comands.
Add statistics for TRIM comands
Oct 26 2018, 4:24 PM
imp committed rS339776: Redo r339563: Remove joy(4) driver..
Redo r339563: Remove joy(4) driver.
Oct 26 2018, 4:03 PM
imp committed rS339775: Put a workaround in for command timeout malfunctioning.
Put a workaround in for command timeout malfunctioning
Oct 26 2018, 2:27 PM
imp closed D17708: Put a workaround in for command timeout malfunctioning.
Oct 26 2018, 2:27 PM
imp committed rS339766: Remove #warning since it breaks libsysdecode.
Remove #warning since it breaks libsysdecode
Oct 26 2018, 4:53 AM
imp committed rS339765: Bump to 1300002 for sys/joystick.h removal reversion..
Bump to 1300002 for sys/joystick.h removal reversion.
Oct 26 2018, 4:14 AM
imp committed rS339764: Add warning to sys/joystick.h announcing its planned demise..
Add warning to sys/joystick.h announcing its planned demise.
Oct 26 2018, 4:12 AM
imp committed rS339763: Revert r339563..
Revert r339563.
Oct 26 2018, 4:10 AM
imp committed rS339762: add modules/joy before revert of r339563.
add modules/joy before revert of r339563
Oct 26 2018, 4:05 AM
imp committed rS339761: Put sys/dev/joy back for the moment.
Put sys/dev/joy back for the moment
Oct 26 2018, 3:59 AM

Oct 25 2018

imp added inline comments to D17708: Put a workaround in for command timeout malfunctioning.
Oct 25 2018, 10:35 PM
imp updated the diff for D17708: Put a workaround in for command timeout malfunctioning.

Fix jim's issues.

Oct 25 2018, 10:33 PM
imp added inline comments to D17708: Put a workaround in for command timeout malfunctioning.
Oct 25 2018, 10:33 PM
imp added reviewers for D17708: Put a workaround in for command timeout malfunctioning: jimharris, chuck.
Oct 25 2018, 8:52 PM
imp created D17708: Put a workaround in for command timeout malfunctioning.
Oct 25 2018, 8:52 PM
imp abandoned D16894: Put building of drm and drm2 modules behind options and Add big, nasty abandonware tags to this code..

This has been committed..

Oct 25 2018, 7:46 PM
imp accepted D16468: ACPI Hardware ID match routine to distinguish _HID match and _CID match..

This looks good to me as well...

Oct 25 2018, 6:46 PM
imp committed rS339736: Update comment for AMI00[12]0 override..
Update comment for AMI00[12]0 override.
Oct 25 2018, 5:17 PM
imp accepted D17701: Remove useless call to access(2).

This looks good to my naive eye.

Oct 25 2018, 4:11 PM
imp committed rS339727: MFC r339493: add wdc as an alias for wds.
MFC r339493: add wdc as an alias for wds
Oct 25 2018, 3:35 PM
imp added a comment to D17686: efivar(3): Fix some typos and improve style.
In D17686#378101, @0mp wrote:

Thanks for your reviews!

BTW, @imp & @bcr, should I MFC this one?

Oct 25 2018, 3:32 PM
imp committed rS339704: MFC: r339562 (remove obsolete drivers from GENERIC).
MFC: r339562 (remove obsolete drivers from GENERIC)
Oct 25 2018, 5:18 AM
imp accepted D17694: lualoader: Improve module loading diagnostics.
Oct 25 2018, 1:44 AM

Oct 24 2018

imp accepted D17689: wmt(4): Add PNP metadata.

The USB_PNP_HOST_INFO part looks good to me.

Oct 24 2018, 8:58 PM
imp accepted D17686: efivar(3): Fix some typos and improve style.

lgtm

Oct 24 2018, 8:24 PM
imp committed rS339693: add links to the saga of CTM.
add links to the saga of CTM
Oct 24 2018, 7:21 PM

Oct 23 2018

imp accepted D17677: Fix stand/ build after r339671..

This will fix the build. I'll look into the unused crc32 and sort out what can/should be common here after this commit.

Oct 23 2018, 10:52 PM
First
Prev
Next