I'm OK with this. It's an improvement and clearly better w/o any new issues I can spot.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Jan 2 2018
Jan 1 2018
Dec 31 2017
looks totally fine. The ifs were there to keep bad dirs from getting into the SUBDIR list. Since SUBDIR supports .WAIT, this should be no worse than before. And nobody is going to call a subdir .WAIT because of other issues with that. Looks good to me.
Forgot to put the phab in the commit.
LGTM, though I haven't through through all the implications of weird cases (like loading a hardware watchdog after boot)....
Dec 30 2017
Dec 29 2017
Dec 28 2017
my naive reading says this is right.
Dec 27 2017
A question: Does it make sense to 'resilver' those sectors that return EIO rather than simply kicking the disk to the curb and only kicking it to the curb if the resilver fails to readback correctly?
Dec 26 2017
The LPC3200 series is guaranteed a 10 year run by NXP. It was introduced 2009. There's a few other ARM9 products they have.
In D13625#284877, @manu wrote:In D13625#284875, @imp wrote:Is there any better justification than "it's old" for removing it? It seems like it might be a good one to have go, but what's the hardware support we'd be losing, who did the original work? Do we know if it still works?
Chances are answering these questions will push me into the 'delete' category, but mere age isn't an indication it needs to go.
It's an ARM9 core is my google skills are correct, I'm not even sure that we can run on this hardware nowadays.
In D13624#284888, @manu wrote:In D13624#284876, @imp wrote:I like this.
Have you consider the testing requirements for making sure that one can write a config file with these w/o them breaking over time?
The only "bad" thing that could happen is that someone add a "device blah" in multiple vendor file and so config will warn.
If every change to the GENERIC file is to add a generic driver and every change to a vendor file is to add a vendor driver everything is fine (tm).
I have other plan for config to allow a much better conf files but for now it's still in my brain.
Dec 25 2017
You should also delete the AML8726 kernel config which is useless w/o this stuff.
How long has it been broken? I see it's tagged as NO_UNIVERSE last summer as part of the INTRNG stuff, was that when it died?
6 months broken is close the limit on how long something should be broken in the tree.
I like this.
Is there any better justification than "it's old" for removing it? It seems like it might be a good one to have go, but what's the hardware support we'd be losing, who did the original work? Do we know if it still works?
Dec 24 2017
flagged the ones I thought were upstream code...
Dec 23 2017
Dec 22 2017
In D13586#284245, @jhb wrote:Yes, let's kill these and fix DDB instead.
Dec 21 2017
I believe that this violates the UEFI Boot Manager Spec. If you fail for any reason, you have to return failure, not drop into the debugger...
Dec 20 2017
My first reading I like it. Don't have the time to give it a very close reading though.
Updated with all these suggestions.
Simplify the code a bit, make changes from review (except
one). Prepare for landing.