Page MenuHomeFreeBSD
Feed Advanced Search

Jan 2 2018

imp accepted D13559: Fix gmirror BIO_FLUSH and sync collision queuing..

I'm OK with this. It's an improvement and clearly better w/o any new issues I can spot.

Jan 2 2018, 4:42 PM

Jan 1 2018

imp committed rS327467: Be less verbose and more precise..
Be less verbose and more precise.
Jan 1 2018, 7:04 PM
imp committed rS327466: Add note that assert.h may be included multiple times.
Add note that assert.h may be included multiple times
Jan 1 2018, 6:59 PM
imp committed rS327465: assert(3) appeared first in the 7th Edition Unix, not the 6th, at.
assert(3) appeared first in the 7th Edition Unix, not the 6th, at
Jan 1 2018, 6:55 PM
imp abandoned D13020: If device path returns NULL, don't use it..
Jan 1 2018, 5:33 PM
imp committed rS327462: Remove empty directories... silly git svn w/o --rmdir..
Remove empty directories... silly git svn w/o --rmdir.
Jan 1 2018, 5:18 AM
imp committed rS327461: Remove sys/mips/rmi. It's been unmaintained since 2011. This hardware.
Remove sys/mips/rmi. It's been unmaintained since 2011. This hardware
Jan 1 2018, 5:13 AM
imp committed rS327460: Remove support for IDT. Only the RouterBoard RB533 used this chip, and.
Remove support for IDT. Only the RouterBoard RB533 used this chip, and
Jan 1 2018, 4:10 AM
imp committed rS327459: Retire old ADM 5120 port. It never grew much beyond the original port..
Retire old ADM 5120 port. It never grew much beyond the original port.
Jan 1 2018, 4:10 AM
imp committed rS327458: Remove sys/mips/alchemy. It was still-born when I committed it and it.
Remove sys/mips/alchemy. It was still-born when I committed it and it
Jan 1 2018, 4:10 AM
imp committed rS327457: Remove sys/mips/rt305x. It's been replaced by sys/mips/mediatek..
Remove sys/mips/rt305x. It's been replaced by sys/mips/mediatek.
Jan 1 2018, 4:06 AM

Dec 31 2017

imp accepted D13622: Allow use of .WAIT in the LOCAL_DIRS and LOCAL_LIB_DIRS lists..

looks totally fine. The ifs were there to keep bad dirs from getting into the SUBDIR list. Since SUBDIR supports .WAIT, this should be no worse than before. And nobody is going to call a subdir .WAIT because of other issues with that. Looks good to me.

Dec 31 2017, 6:00 PM
imp closed D13679: Fix ubldr by fixing uboot/lib/Makefile.

Forgot to put the phab in the commit.

Dec 31 2017, 5:57 PM
imp accepted D13713: make SW_WATCHDOG dynamic.

LGTM, though I haven't through through all the implications of weird cases (like loading a hardware watchdog after boot)....

Dec 31 2017, 5:11 PM

Dec 30 2017

imp committed rS327379: On further testing on actual machines with this hardware, we should.
On further testing on actual machines with this hardware, we should
Dec 30 2017, 8:16 AM
imp committed rS327378: Remove two stray references to wl driver, removed some time ago..
Remove two stray references to wl driver, removed some time ago.
Dec 30 2017, 7:59 AM
imp accepted D13688: stand/fdt: Swap libfdt include order.
Dec 30 2017, 6:18 AM

Dec 29 2017

imp committed rS327351: Fix ubldr. uboot/lib uses defines for the loader. It's part of the.
Fix ubldr. uboot/lib uses defines for the loader. It's part of the
Dec 29 2017, 6:08 PM
imp added a reviewer for D13679: Fix ubldr by fixing uboot/lib/Makefile: kevans.
Dec 29 2017, 5:31 PM
imp created D13679: Fix ubldr by fixing uboot/lib/Makefile.
Dec 29 2017, 5:29 PM
imp added reviewers for D13672: Inline ccbque.h into scsi_low.h and delete from i386/isa.: kib, jhb, scottl.
Dec 29 2017, 12:48 AM
imp created D13672: Inline ccbque.h into scsi_low.h and delete from i386/isa..
Dec 29 2017, 12:48 AM

Dec 28 2017

imp accepted D13664: stand/fdt: Consistently apply fdt_overlays.
Dec 28 2017, 4:57 PM
imp accepted D13663: stand/fdt: Avoid bailout when dtbo has no fixups.
Dec 28 2017, 4:56 PM
imp committed rS327279: Close fd when we're done dv-sending the file..
Close fd when we're done dv-sending the file.
Dec 28 2017, 5:34 AM
imp committed rS327278: Free mp on a couple of error paths..
Free mp on a couple of error paths.
Dec 28 2017, 5:34 AM
imp committed rS327276: When bind fails, make sure we closed the socket we tried to bind the.
When bind fails, make sure we closed the socket we tried to bind the
Dec 28 2017, 5:34 AM
imp committed rS327277: Close the fp rather than the fd since we fdopen the fd so we don't.
Close the fp rather than the fd since we fdopen the fd so we don't
Dec 28 2017, 5:34 AM
imp committed rS327275: Close fd and fd1 before returning now that we're done with them..
Close fd and fd1 before returning now that we're done with them.
Dec 28 2017, 5:34 AM
imp committed rS327273: Plug memory leak by freeing wantedblk{32,64}..
Plug memory leak by freeing wantedblk{32,64}.
Dec 28 2017, 5:34 AM
imp committed rS327272: Free zbuf when kflag is true too..
Free zbuf when kflag is true too.
Dec 28 2017, 5:34 AM
imp committed rS327274: Don't leak outfile. Free it before we return from bincvt..
Don't leak outfile. Free it before we return from bincvt.
Dec 28 2017, 5:34 AM
imp committed rS327271: Close slave on fork error to prevent pty fd leak..
Close slave on fork error to prevent pty fd leak.
Dec 28 2017, 5:34 AM
imp committed rS327269: Close cpfrom in an error case..
Close cpfrom in an error case.
Dec 28 2017, 5:34 AM
imp committed rS327270: Free path before returnig..
Free path before returnig.
Dec 28 2017, 5:34 AM
imp committed rS327268: Free data after we're done with it..
Free data after we're done with it.
Dec 28 2017, 5:33 AM
imp committed rS327267: Free inb on error return..
Free inb on error return.
Dec 28 2017, 5:33 AM
imp committed rS327266: Free some variables before they go out of scope..
Free some variables before they go out of scope.
Dec 28 2017, 5:33 AM
imp committed rS327265: Plug two resource leaks..
Plug two resource leaks.
Dec 28 2017, 5:33 AM
imp committed rS327264: Use proper failure path rather than just returning..
Use proper failure path rather than just returning.
Dec 28 2017, 5:33 AM
imp committed rS327263: Explicitly ignore return value from remove. We wouldn't do anything.
Explicitly ignore return value from remove. We wouldn't do anything
Dec 28 2017, 5:33 AM
imp committed rS327262: Don't leak resources on duplicate -m or -M arguments. Last one wins..
Don't leak resources on duplicate -m or -M arguments. Last one wins.
Dec 28 2017, 5:33 AM
imp accepted D13659: stand/fdt: Fix loading of multiple fdt_overlays.

my naive reading says this is right.

Dec 28 2017, 1:50 AM
imp accepted D13658: Remove LINK_MAX..
Dec 28 2017, 12:59 AM

Dec 27 2017

imp committed rS327246: Use strl* here too..
Use strl* here too.
Dec 27 2017, 8:33 PM
imp added a comment to D13559: Fix gmirror BIO_FLUSH and sync collision queuing..

A question: Does it make sense to 'resilver' those sectors that return EIO rather than simply kicking the disk to the curb and only kicking it to the curb if the resilver fails to readback correctly?

Dec 27 2017, 6:37 PM
imp committed rS327241: Fix a bunch of issues (and a few non-issues but appeasement is easier.
Fix a bunch of issues (and a few non-issues but appeasement is easier
Dec 27 2017, 6:30 PM

Dec 26 2017

imp added a comment to D13625: sys/arm/lpc: Remove support for it.

The LPC3200 series is guaranteed a 10 year run by NXP. It was introduced 2009. There's a few other ARM9 products they have.

Dec 26 2017, 5:34 PM
imp added a comment to D13625: sys/arm/lpc: Remove support for it.
In D13625#284877, @manu wrote:
In D13625#284875, @imp wrote:

Is there any better justification than "it's old" for removing it? It seems like it might be a good one to have go, but what's the hardware support we'd be losing, who did the original work? Do we know if it still works?

Chances are answering these questions will push me into the 'delete' category, but mere age isn't an indication it needs to go.

It's an ARM9 core is my google skills are correct, I'm not even sure that we can run on this hardware nowadays.

Dec 26 2017, 5:10 PM
imp committed rS327189: Fix typo.
Fix typo
Dec 26 2017, 4:07 AM
imp added a comment to D13624: arm: Split GENERIC into vendor files.
In D13624#284888, @manu wrote:
In D13624#284876, @imp wrote:

I like this.

Have you consider the testing requirements for making sure that one can write a config file with these w/o them breaking over time?

The only "bad" thing that could happen is that someone add a "device blah" in multiple vendor file and so config will warn.
If every change to the GENERIC file is to add a generic driver and every change to a vendor file is to add a vendor driver everything is fine (tm).
I have other plan for config to allow a much better conf files but for now it's still in my brain.

Dec 26 2017, 1:52 AM

Dec 25 2017

imp accepted D13627: sys/arm/amlogic: remove support for it.

You should also delete the AML8726 kernel config which is useless w/o this stuff.
How long has it been broken? I see it's tagged as NO_UNIVERSE last summer as part of the INTRNG stuff, was that when it died?
6 months broken is close the limit on how long something should be broken in the tree.

Dec 25 2017, 11:31 PM
imp added a comment to D13624: arm: Split GENERIC into vendor files.

I like this.

Dec 25 2017, 11:20 PM
imp added a comment to D13625: sys/arm/lpc: Remove support for it.

Is there any better justification than "it's old" for removing it? It seems like it might be a good one to have go, but what's the hardware support we'd be losing, who did the original work? Do we know if it still works?

Dec 25 2017, 11:18 PM
imp committed rS327178: Doh! Never test in one tree and commit from another:.
Doh! Never test in one tree and commit from another:
Dec 25 2017, 7:08 PM
imp committed rS327177: Match unattached devices on the system to potential kernel modules..
Match unattached devices on the system to potential kernel modules.
Dec 25 2017, 6:56 PM

Dec 24 2017

imp added a comment to D13601: Fix several typos and minor errors.

flagged the ones I thought were upstream code...

Dec 24 2017, 7:05 PM
imp committed rS327166: Further investigation shows this shouldn't have been added at all..
Further investigation shows this shouldn't have been added at all.
Dec 24 2017, 6:00 PM
imp accepted D13607: nandtool: Add missing mode for open() with O_CREAT.
Dec 24 2017, 4:41 PM
imp committed rS327162: Comment this out until I have time to get to the bottom of why it's.
Comment this out until I have time to get to the bottom of why it's
Dec 24 2017, 4:37 PM

Dec 23 2017

imp committed rS327120: Warn when nonPNP ISA devices are attached in GENERIC that they are.
Warn when nonPNP ISA devices are attached in GENERIC that they are
Dec 23 2017, 10:57 PM
imp committed rS327103: Fix cut-and-paste error s/pccard/isa/.
Fix cut-and-paste error s/pccard/isa/
Dec 23 2017, 7:03 AM
imp committed rS327102: Create a new ISA_PNP_INFO macro. Use this macro every where we have.
Create a new ISA_PNP_INFO macro. Use this macro every where we have
Dec 23 2017, 6:49 AM
imp committed rS327101: Expand cryptic comment with inforation I've learned in the mean time.
Expand cryptic comment with inforation I've learned in the mean time
Dec 23 2017, 6:11 AM
imp committed rS327100: These drivers have a sentinel at the end of the device list. Exclude.
These drivers have a sentinel at the end of the device list. Exclude
Dec 23 2017, 5:32 AM
imp committed rS327098: The device tables end with a sentinel in iflib. Don't include the.
The device tables end with a sentinel in iflib. Don't include the
Dec 23 2017, 4:51 AM

Dec 22 2017

imp committed rS327095: Fix typos from last commit, these should have been #..
Fix typos from last commit, these should have been #.
Dec 22 2017, 8:49 PM
imp added a comment to D13586: Adapt assembler implementations of atomic_load_64() and atomic_store_64() on o32 mips to new calling conventions..
In D13586#284245, @jhb wrote:

Yes, let's kill these and fix DDB instead.

Dec 22 2017, 8:44 PM · MIPS
imp committed rS327089: Use '#' rather than some made up name for fields we want to ignore..
Use '#' rather than some made up name for fields we want to ignore.
Dec 22 2017, 5:53 PM
imp committed rS327085: Need to NULL terminate this list. It worked before by accidental data.
Need to NULL terminate this list. It worked before by accidental data
Dec 22 2017, 5:14 PM
imp committed rS327084: PC Card PNP tables are terminated by a NULL sentinel. This shouldn't.
PC Card PNP tables are terminated by a NULL sentinel. This shouldn't
Dec 22 2017, 5:00 PM
imp added inline comments to D13586: Adapt assembler implementations of atomic_load_64() and atomic_store_64() on o32 mips to new calling conventions..
Dec 22 2017, 4:22 PM · MIPS

Dec 21 2017

imp requested changes to D13577: loader.efi: Don't fail if we cannot find the current device.

I believe that this violates the UEFI Boot Manager Spec. If you fail for any reason, you have to return failure, not drop into the debugger...

Dec 21 2017, 9:16 PM
imp committed rS327068: When -v is specified with -p dev, print the same verbose output as.
When -v is specified with -p dev, print the same verbose output as
Dec 21 2017, 7:19 PM
imp committed rS327067: Fix markup and bump .Dd..
Fix markup and bump .Dd.
Dec 21 2017, 6:58 PM
imp committed rS327066: Implement "-p dev" to print the path to the given device back to the.
Implement "-p dev" to print the path to the given device back to the
Dec 21 2017, 6:52 PM
imp committed rS327055: Provide a nda man page. Add cross referneces. Bump dates..
Provide a nda man page. Add cross referneces. Bump dates.
Dec 21 2017, 4:23 AM
imp committed rS327054: Bump number that's an insane number of devices from 1,000 to 10,000. I.
Bump number that's an insane number of devices from 1,000 to 10,000. I
Dec 21 2017, 4:22 AM

Dec 20 2017

imp added a comment to D13559: Fix gmirror BIO_FLUSH and sync collision queuing..

My first reading I like it. Don't have the time to give it a very close reading though.

Dec 20 2017, 11:12 PM
imp committed rS327038: Add nvme wiring example.
Add nvme wiring example
Dec 20 2017, 7:14 PM
imp committed rS327036: Document new pci device hints wiring..
Document new pci device hints wiring.
Dec 20 2017, 7:14 PM
imp committed rS327037: Simplify the code a bit..
Simplify the code a bit.
Dec 20 2017, 7:14 PM
imp committed rS327035: Add device location wiring to the pci bus..
Add device location wiring to the pci bus.
Dec 20 2017, 7:14 PM
imp closed D13546: New pci device hints wiring..
Dec 20 2017, 7:14 PM
imp committed rS327034: Return domain, bus, slot, and function for the transport settings in.
Return domain, bus, slot, and function for the transport settings in
Dec 20 2017, 7:14 PM
imp committed rS327027: Flesh out the reason for the need for tmpfs a little..
Flesh out the reason for the need for tmpfs a little.
Dec 20 2017, 4:02 PM
imp added a comment to D13546: New pci device hints wiring..

Updated with all these suggestions.

Dec 20 2017, 3:48 PM
imp updated the diff for D13546: New pci device hints wiring..

missed one .Xr

Dec 20 2017, 3:41 PM
imp updated the diff for D13546: New pci device hints wiring..

Simplify the code a bit, make changes from review (except
one). Prepare for landing.

Dec 20 2017, 3:38 PM
imp added a reviewer for D13546: New pci device hints wiring.: rpokala.
Dec 20 2017, 1:21 AM
imp added inline comments to D13546: New pci device hints wiring..
Dec 20 2017, 1:21 AM
imp updated the test plan for D13546: New pci device hints wiring..
Dec 20 2017, 1:20 AM
imp created D13546: New pci device hints wiring..
Dec 20 2017, 1:17 AM

Dec 19 2017

imp committed rS326964: When doing a dump, the scheduler is normally not running, so this.
When doing a dump, the scheduler is normally not running, so this
Dec 19 2017, 4:13 AM
imp closed D13531: Test dumping instead of SCHEDULER_STOPPED() since the latter isn'ttrue when doadump is called from ddb..
Dec 19 2017, 4:13 AM
imp committed rS326963: No need to use relative paths like this here..
No need to use relative paths like this here.
Dec 19 2017, 4:06 AM
imp committed rS326962: Hoist btx include stuff to i386/Makefile.inc.
Hoist btx include stuff to i386/Makefile.inc
Dec 19 2017, 4:06 AM
imp committed rS326961: Interact is always called with NULL. Simplify code a little by.
Interact is always called with NULL. Simplify code a little by
Dec 19 2017, 4:06 AM
imp committed rS326960: Simplify things a little. The RETURN macro isn't required. It's only.
Simplify things a little. The RETURN macro isn't required. It's only
Dec 19 2017, 4:05 AM
imp committed rS326954: Support more images (but still no geli).
Support more images (but still no geli)
Dec 19 2017, 12:18 AM