Page MenuHomeFreeBSD
Feed Advanced Search

Mar 1 2022

debdrup added a comment to D33073: Notifying that the release documents of -CURRENT and -STABLE are not provided.
In D33073#779221, @fel1x.mintchoco.development_gmail.com wrote:

After you commit this, can you close these related bugzillas? 1 2

Mar 1 2022, 12:38 PM

Feb 28 2022

debdrup added a comment to D34385: Update Apple descriptions in the handbook..

I think my suggestion is generic enough to give an indication of the amount of code used, without making it appear like a big portion of the code is taken from FreeBSD (which is a pretty common myth).

Feb 28 2022, 12:31 PM

Feb 27 2022

debdrup accepted D33073: Notifying that the release documents of -CURRENT and -STABLE are not provided.

I'll accept as docs and wait for releng, then I'll commit once it's been accepted by them.

Feb 27 2022, 9:04 PM
debdrup added a comment to D34385: Update Apple descriptions in the handbook..

To add to what I said before, they've gotten pretty good at publishing what they include, if you can make head or tails of their snapshot release style.

Feb 27 2022, 8:53 PM
debdrup added a comment to D34385: Update Apple descriptions in the handbook..

I'm not sure I like this change, because without mentioning Mac OS X/macOS (the latter of which should probably be used), there's a lot more information to cover about the links between macOS and the Apple OSS distribution collection which includes XNU (where parts of the code enumerated here come from FreeBSD, because they originally came from BSD out of CSRG), along with the userland and the toolchain, libraries - and it's really not the FreeBSDs responsibility to keep track of all of that.

Feb 27 2022, 8:50 PM
debdrup added a comment to D33073: Notifying that the release documents of -CURRENT and -STABLE are not provided.
In D33073#778803, @fel1x.mintchoco.development_gmail.com wrote:

My name is 'Minsoo Choo', and email is 'fel1x.mintchoco.development@gmail.com'.
And I have a question. Can I change my email in my previous commits if I change my email address for development?(I'm considering to use ProtonMail)

Feb 27 2022, 8:34 PM
debdrup added a comment to D33073: Notifying that the release documents of -CURRENT and -STABLE are not provided.

While waiting for @releng to approve this, I'd like to know what you'd like to have listed as the author?
Usually it's in the form of git commit --author "Givenname Familyname <user AT example.org>".

Feb 27 2022, 5:15 PM
debdrup added inline comments to D33073: Notifying that the release documents of -CURRENT and -STABLE are not provided.
Feb 27 2022, 11:44 AM
debdrup accepted D30350: acpiconf(8): Add libxo(3) support.

Manual page change looks good to me.

Feb 27 2022, 11:38 AM

Feb 24 2022

debdrup added a comment to D34360: ctf: Add definitions for CTFv3.

What about changes to src/share/man/man5/ctf.5?

Feb 24 2022, 11:42 AM

Feb 18 2022

debdrup added inline comments to D33275: Add a manual page for boottrace.
Feb 18 2022, 8:28 PM

Feb 16 2022

debdrup accepted D34169: freebsd-update.8: Document CreateBootEnv.

Looks good to me :)

Feb 16 2022, 4:33 PM

Feb 14 2022

debdrup accepted D34100: handbook: Misc fixes to Introduction chapter.

I think this is ready to land now? So far as I can see everything's been addressed and a one-over didn't make anything else stand out.

Feb 14 2022, 5:17 PM

Feb 13 2022

debdrup added a comment to D34259: Report I/O stats from the CAM_IOSCHED_DYNAMIC extension.

Please run igor and mandoc -Tlint on the manual page - because among other things that they check for, I see that .Dd isn't bumped.

Feb 13 2022, 11:45 AM

Feb 11 2022

debdrup accepted D32978: cleankernel: A target to delete the kernel compile file.

Looks good to me, though the summary (and thereby, the commit) should be "there's times". :)

Feb 11 2022, 5:31 PM

Feb 7 2022

debdrup added a comment to D34169: freebsd-update.8: Document CreateBootEnv.

Other than the nit and the question of when it should be pushed, this change looks good to me.

Feb 7 2022, 1:23 PM

Feb 3 2022

debdrup accepted D34100: handbook: Misc fixes to Introduction chapter.

I think this is ready to go now?

Feb 3 2022, 7:22 PM
debdrup accepted D34139: tcpsso, a tool to set socket options for TCP endpoints via the command line.

OK from manpages then. :)

Feb 3 2022, 12:27 PM
debdrup added a comment to D34012: sysctl: Add -F option to display sysctl format, refactor for a function to display info options for and added test cases.

Have you run mandoc -Tlint and igor on the manual page?

Feb 3 2022, 12:01 PM
debdrup added a comment to D34139: tcpsso, a tool to set socket options for TCP endpoints via the command line.

mandoc -Tlint shows a few nits that I'd like to see corrected before this is committed.

Feb 3 2022, 11:58 AM
debdrup accepted D34154: Disallow setting of ECN bits with setsockopt().

mdoc changes look good to me

Feb 3 2022, 11:50 AM

Feb 2 2022

debdrup added a comment to D33275: Add a manual page for boottrace.

I made some comments here - but it looks to me like both my comments have or will be addressed shortly?

Feb 2 2022, 3:31 PM
debdrup accepted D34128: filemon: Reject FILEMON_SET_FD commands when the fd is a kqueue.

Manual page changes look good to me, can't comment on the code.

Feb 2 2022, 8:01 AM

Jan 31 2022

debdrup added inline comments to D31929: boottrace(1): small wrapper utility.
Jan 31 2022, 6:53 PM
debdrup updated subscribers of D34099: Add GNU/Linux instructions.

ObMeta; I can't make edit suggestions on this review as the button is missing from inline comments for some reason.

Jan 31 2022, 6:14 PM
debdrup added a comment to D31929: boottrace(1): small wrapper utility.

I'd also encourage you to run mandoc -Tlint, as you're missing some cross-references.

Jan 31 2022, 6:10 PM

Jan 30 2022

debdrup added inline comments to D34099: Add GNU/Linux instructions.
Jan 30 2022, 6:11 PM
debdrup accepted D34092: handbook: Update the list of websites/community services.
Jan 30 2022, 6:08 PM
debdrup accepted D34100: handbook: Misc fixes to Introduction chapter.
Jan 30 2022, 6:07 PM
debdrup accepted D34093: handbook: Describe FreeBSD Foundation in intro.
Jan 30 2022, 6:07 PM

Jan 29 2022

debdrup added inline comments to D34093: handbook: Describe FreeBSD Foundation in intro.
Jan 29 2022, 3:39 PM
debdrup added a comment to D34092: handbook: Update the list of websites/community services.

Here's a few things I noticed.

Jan 29 2022, 3:39 PM
debdrup accepted D34091: handbook: Point the user at HTTP mirrors, not FTP.
Jan 29 2022, 3:33 PM

Jan 28 2022

debdrup accepted D34061: handbook: Shorten the Git section.

Seems like everything's been addressed, so let's get this committed.

Jan 28 2022, 6:01 PM
debdrup accepted D34004: website: Rework the downloads table.

Yeah, I'll submit the other changes for separate reviews.

Regarding "Installer images" - problem is, not all of those are installer images. I wonder if I should perhaps split off SD card images like it was before...

Also: is there a way to make cells vertically aligned up, as opposed to vertically centered, as it is now? The example from AsciiDoc didn't seem to work for some reason.

Jan 28 2022, 2:17 AM
debdrup accepted D34067: livedump: add event handler hooks.

mdoc looks good, you can fix the nit Pau Amma pointed out

Jan 28 2022, 2:07 AM

Jan 26 2022

debdrup accepted D30984: man(1): Add full search (-K) flag.

I think it's time we land this, as I've been recently reminded just how nice it'd be to have this. :)

Jan 26 2022, 9:01 AM

Jan 25 2022

debdrup accepted D33968: handbook: Drop the git mailing lists list from Mirrors.
Jan 25 2022, 11:58 AM

Jan 23 2022

debdrup added a comment to D34004: website: Rework the downloads table.

Shouldn't you also be changing things for 12.3-RELEASE?

Jan 23 2022, 5:07 AM

Jan 22 2022

debdrup accepted D33982: handbook: Drop duplicated URLs in Mirrors.

Seems fine, but I hope you're checking with nc -z from freefall.f.o if they're working. ;)

Jan 22 2022, 12:55 AM

Jan 21 2022

debdrup added a comment to D33968: handbook: Drop the git mailing lists list from Mirrors.

That's fair - perhaps link to it instead?

Jan 21 2022, 4:45 PM
debdrup added a comment to D33967: handbook: Don't mention svnlite; it's obsolete.

The handbook is as much, if not more, for -RELEASE than it is for -CURRENT - so I'm of the belief that something is in the process of being deprecated when it has been removed in -CURRENT and until it's final existence in the last -RELEASE is end-of-life'd.

Jan 21 2022, 4:44 PM
debdrup accepted D33965: handbook: drop the "(ftp)" suffixes from the mirrors list.
Jan 21 2022, 12:05 AM
debdrup accepted D33966: handbook: Don't mention certificates in Mirrors.
Jan 21 2022, 12:04 AM
debdrup accepted D33967: handbook: Don't mention svnlite; it's obsolete.
Jan 21 2022, 12:04 AM
debdrup added a comment to D33968: handbook: Drop the git mailing lists list from Mirrors.

I don't think we should be removing references to these mailing lists as I know for a fact that I'm not the only one that uses them or might need them in the future.

Jan 21 2022, 12:04 AM

Jan 20 2022

debdrup added a comment to D33963: handbook: Drop nonexistant Bulgarian mirrors.

Have you contacted the hostmaster for the domain, before removing it?

Jan 20 2022, 4:20 PM

Jan 19 2022

debdrup accepted D33952: handbook: Split off HTTP mirrors into a separate section.

Looks good to me, but make sure you build- and view-test it in a browser before pushing, please.

Jan 19 2022, 6:40 PM
debdrup accepted D33948: handbook: Clean up the bits on ext2.
Jan 19 2022, 6:39 PM
debdrup accepted D33949: handbook: Don't start the Obtaining chapter with snail mail.
Jan 19 2022, 5:03 PM
debdrup added inline comments to D33948: handbook: Clean up the bits on ext2.
Jan 19 2022, 5:02 PM

Jan 18 2022

debdrup accepted D33883: Switch to using drive-supplied timeouts for the sa(4) driver..

Manual page looks good.

Jan 18 2022, 5:46 PM

Jan 16 2022

debdrup accepted D33909: handbook: Further tweaks to Linuxulator chapter.

After a40cf4175c901 that you implemented last year, is a privileged prompt necessary, or would it be better to recommend using unprivileged chroot after toggling the sysctl OID?

Jan 16 2022, 6:32 PM
debdrup accepted D33908: security.7: Minor fixes for ASLR sysctl descriptions.
Jan 16 2022, 4:02 PM
debdrup accepted D33883: Switch to using drive-supplied timeouts for the sa(4) driver..

I'm gonna go ahead and approve this, and leave the choice of macro up to you prior to when you commit and push. :)

Jan 16 2022, 2:48 AM

Jan 14 2022

debdrup committed rG9f0b56872c1f: carp(4): Make regex additionally match on VLAN interfaces (authored by debdrup).
carp(4): Make regex additionally match on VLAN interfaces
Jan 14 2022, 8:45 PM
debdrup added a comment to D33883: Switch to using drive-supplied timeouts for the sa(4) driver..

I have a little bit of mdoc(7) feedback.

Jan 14 2022, 7:14 PM

Jan 11 2022

debdrup accepted D33738: handbook: Update the first chunk of Linuxulator chapter.

With my final 2 nitpicks, I think it is. Approve at will once they're addressed.

Jan 11 2022, 5:34 PM
debdrup accepted D33842: linux: Make compat.linux.preserve_vstatus default to 1.

mdoc(7) changes look good to me, don't really have opinions on whether it should be the default but it seems like a good idea from a brief look at what termios(4) is.

Jan 11 2022, 2:20 PM
debdrup added a comment to D33738: handbook: Update the first chunk of Linuxulator chapter.

Is this ready for approval so it can land? It looks to me like it is.

Jan 11 2022, 2:07 PM
debdrup accepted D33840: man: Remove mention of EXT_RESOURCES.

Looks good to me.

Jan 11 2022, 2:02 PM
debdrup added a member for manpages: debdrup.
Jan 11 2022, 2:02 PM

Jan 10 2022

debdrup accepted D33738: handbook: Update the first chunk of Linuxulator chapter.

Thanks! I wonder, should perhaps igor(1) warn about this, or am I using the wrong tool?

Jan 10 2022, 4:43 PM
debdrup requested changes to D33738: handbook: Update the first chunk of Linuxulator chapter.

I just noticed one other thing:
The document goes from using one line per sentence to splitting sentences in the middle, which as far as I know causes problems.

Jan 10 2022, 1:49 PM

Jan 8 2022

debdrup added a comment to D33677: Mention vendor driver for if_re.

thanks for looking at the patch!

adding a note to the bugs section is prob the most appropriate as we are directing ppl to check out the vendor driver in case they have problems with the in-source one.

Jan 8 2022, 1:30 PM

Jan 7 2022

debdrup accepted D33772: linux: More man page tweaks.

You know, I think you're right that it looks better. Do your thing!

Jan 7 2022, 1:01 PM

Jan 6 2022

debdrup added a comment to D33772: linux: More man page tweaks.

Only spotted one minor thing which I think is just an honest mistake.

Jan 6 2022, 3:14 PM

Jan 5 2022

debdrup added a comment to D33750: handbook: Get rid of "(R)" in "Linux(R)".

Maybe it's worth mentioning that (R) gets rendered by AsciiDoctor as ® as is both outlined here and can be spotted on the rendered output of the existing page.

Jan 5 2022, 6:32 PM

Jan 4 2022

debdrup accepted D33733: Add a "bgnow" NFS mount option that causes the mount to go background immediately.

mdoc formatting looks good to me too, but maybe someone else wants to chime in on the code?

Jan 4 2022, 11:59 AM

Jan 3 2022

debdrup requested changes to D33677: Mention vendor driver for if_re.

Firstly, please see the Phabricator wiki article for information on how to create a full-context diff - it makes it easier for us to make in-line suggestions.

Jan 3 2022, 11:17 AM

Jan 2 2022

debdrup accepted D33720: linux(4): man page tweaks.

Looks good to me too.

Jan 2 2022, 11:55 PM

Jan 1 2022

debdrup accepted D33713: iwlwifi: clarify page update.

This looks good to me, and I'm sure bcr approves of you remembering to bump .Dd too ;)

Jan 1 2022, 7:42 PM

Dec 12 2021

debdrup added a comment to D33394: style.mdoc.5: Document the conventions for -width.
In D33394#755020, @0mp wrote:

Perhaps it would be nice to mention that sometimes the best idea is to set -width to the longest item "of reasonable length" (less than 10 characters?).

Dec 12 2021, 11:40 PM
debdrup accepted D33394: style.mdoc.5: Document the conventions for -width.
Dec 12 2021, 11:39 PM
debdrup added a comment to D33392: handbook: Update the section about Nvidia drivers.

I think it's better to recommend nvidia-modeset, since it should let Xorg use the modesetting driver that's being used for i915kms, radeonkms, and amdgpu.

Dec 12 2021, 11:38 PM

Dec 11 2021

debdrup accepted D33385: intro(3): Fix formatting.

LGTM. :)

Dec 11 2021, 2:47 PM
debdrup accepted D33386: hier(7): add some new Xrs, remove some unrelated ones.

LGTM. :)

Dec 11 2021, 2:47 PM
debdrup added a comment to D20468: if_vether, ported from OpenBSD.

Is something going wrong with some tooling? Because it looks like your diffs are being applied as comments, not to the revision itself?

Dec 11 2021, 2:47 PM

Dec 5 2021

debdrup added a comment to D33275: Add a manual page for boottrace.

Would it be an idea to refer to this manual page from boot(9), boot(8), and/or some other relevant manual pages - to make it easier to discover?

Dec 5 2021, 11:29 PM
debdrup added inline comments to D20468: if_vether, ported from OpenBSD.
Dec 5 2021, 12:17 PM

Dec 2 2021

debdrup committed R9:fbb8fe55531a: website/docproj: Correct link to wiki article (authored by debdrup).
website/docproj: Correct link to wiki article
Dec 2 2021, 8:02 PM
debdrup accepted D33232: style.mdoc: Prefer Ql to Dq Li for literal display.

LGTM. :)

Dec 2 2021, 5:27 PM

Nov 30 2021

debdrup abandoned D30330: rc.conf(5): Add _limits, _login_class, and _oomprotect.

This landed with commit bd6dce978c1a, but I forgot to add the differential revision tag.

Nov 30 2021, 1:15 AM
debdrup committed rGbd6dce978c1a: rc.conf(5): Add _limits, _login_class, and _oomprotect (authored by debdrup).
rc.conf(5): Add _limits, _login_class, and _oomprotect
Nov 30 2021, 1:09 AM

Nov 27 2021

debdrup added inline comments to D33138: elf.5: Document compressed section headers.
Nov 27 2021, 4:08 PM
debdrup added a comment to D33138: elf.5: Document compressed section headers.

I think it'd be nice to get all other functions marked up properly too, unless they're part of display blocks (Bd Ed macros in mdoc).

Nov 27 2021, 3:11 PM

Nov 26 2021

debdrup updated the diff for D30330: rc.conf(5): Add _limits, _login_class, and _oomprotect.

Address feedback by PauAmma

Nov 26 2021, 9:40 PM
debdrup retitled D30330: rc.conf(5): Add _limits, _login_class, and _oomprotect from rc.conf(5): Add _limits, _loginclass, and _oomprotect to rc.conf(5): Add _limits, _login_class, and _oomprotect.
Nov 26 2021, 9:40 PM

Nov 22 2021

debdrup added a comment to D31919: Finiding hugo, python, asciidoctor, asciidoctor-pdf, rougify in different platform so users do not need to create symbolic links manually.

The proper way to solve this would be to use /usr/bin/env $BINARY because if that doesn't work, the OS that the tree is being built on isn't POSIX-compliant at all.

Nov 22 2021, 12:23 AM · docs

Nov 18 2021

debdrup accepted D33043: add new entries related to NFS to rc.conf.5.

This looks good to me.

Nov 18 2021, 3:24 PM

Nov 17 2021

debdrup added inline comments to D33031: git-arc: with "create" allow to specify parent of the first commit.
Nov 17 2021, 3:03 PM

Nov 16 2021

debdrup accepted D32976: Initial clean up the language in the manual pages..

There's only one minor nit, but otherwise it looks good to me.

Nov 16 2021, 1:56 PM

Nov 15 2021

debdrup committed R9:d4b1dbdb8347: status: Correct heading levels (authored by debdrup).
status: Correct heading levels
Nov 15 2021, 6:01 PM
debdrup committed R9:999ad0261c59: status: Announce the July-September 2021 status report (authored by debdrup).
status: Announce the July-September 2021 status report
Nov 15 2021, 4:46 PM
debdrup committed R9:041d8d974298: status: Add the third status report for 2021 (authored by debdrup).
status: Add the third status report for 2021
Nov 15 2021, 4:25 PM

Nov 13 2021

debdrup added a comment to D32979: ps(1): let J flag list all jailed processes.

Are there other places where -(j|J) -1 is used to list all jails, instead of simply doing -(j|J)?

Nov 13 2021, 12:39 AM
debdrup added a comment to D32976: Initial clean up the language in the manual pages..

Also, to channel bcr:
Remember to bump .Dd :)

Nov 13 2021, 12:36 AM

Nov 10 2021

debdrup added inline comments to D30012: cp(1): Make -P work without -R as per POSIX.
Nov 10 2021, 11:36 PM

Nov 3 2021

debdrup updated the diff for D30330: rc.conf(5): Add _limits, _login_class, and _oomprotect.

Try to address feedback by a.wolk

Nov 3 2021, 2:43 PM

Oct 16 2021

debdrup added a comment to D32299: [docs] Remove i386-wine from docs.

I don't think enough context was included, because I'm still seeing "Context not available" - any chance you can use arcanist from ports/packages (as described on the wiki article I linked earlier) or src/tools/tools/git/git-arc.sh (which can be installed by doing make -C /usr/src/tools/tools/git/ install (which requires arcanist, git, and textproc/jq?

Oct 16 2021, 4:13 PM · docs