Page MenuHomeFreeBSD
Feed Advanced Search

Feb 7 2021

debdrup requested review of D28519: git-arc(1): Add manual page.
Feb 7 2021, 2:52 AM
debdrup accepted D28486: Update shared library advice now that a.out no longer is a consideration.

Looks good to me, let's land this. :)

Feb 7 2021, 1:07 AM

Feb 6 2021

debdrup committed R9:4ace6ff83ed4: handbook/virtualization: Suggest using supported RELEASE for bhyve (authored by debdrup).
handbook/virtualization: Suggest using supported RELEASE for bhyve
Feb 6 2021, 1:59 AM

Feb 5 2021

debdrup committed R9:b45a44fa61ca: report-2020-04-2020-06: Fix missing stylesheet (authored by debdrup).
report-2020-04-2020-06: Fix missing stylesheet
Feb 5 2021, 9:40 PM
debdrup added a comment to D28486: Update shared library advice now that a.out no longer is a consideration.

I spotted a few minor nits.

Feb 5 2021, 8:00 PM

Feb 4 2021

debdrup accepted D28486: Update shared library advice now that a.out no longer is a consideration.

Looks good to me too, let's get this in.

Feb 4 2021, 9:23 PM

Jan 30 2021

debdrup accepted D27783: wg(4): Add a man page.

Looks good to me.

Jan 30 2021, 6:02 PM

Jan 29 2021

debdrup added a comment to D28409: documentation: fdp-primer: update the build chapter.

Bullet point 4 in the quickstart needs to be removed, since move-shared no longer exists. :)
I don't know if you wanna fix it, but {git-doc-all} doesn't render properly, although that might be due to missing definitions?
The Website Makefile segment also needs to be updated with references to ./shared becoming ../shared/

Jan 29 2021, 2:13 PM

Jan 26 2021

debdrup added a comment to D28355: net-mgmt/nfs-exporter: new port.

It looks good to me, but I'm not a porter, so I'll respectfully forward it to the people who are. :)

Jan 26 2021, 3:51 PM
debdrup added a comment to D28353: news.toml: Remove paragraph tags left-over from conversion..

The alternative to this is, of course, to wrap everything in paragraph tags.
The advantage of this is that it won't be necessary to include <br /> tags for when multiple things happen on the same day, but I lean towards that being easier to do, than wrapping everything in each own paragraph.

Jan 26 2021, 3:13 PM
debdrup requested review of D28353: news.toml: Remove paragraph tags left-over from conversion..
Jan 26 2021, 3:10 PM
debdrup committed R9:25277fae4419: status/README: Correct paths and sample for newsflash (authored by debdrup).
status/README: Correct paths and sample for newsflash
Jan 26 2021, 2:43 PM
debdrup accepted D28264: Fix issues in past and present CheriBSD quarterly reports.

Looks great to me, let's get this one landed post-haste (or whenever you get around to it)! :)

Jan 26 2021, 2:28 PM

Jan 25 2021

debdrup added a comment to D28334: Add git-arc.

I might also be convinced to write a git-arc(8) man-page. ;)

Jan 25 2021, 7:07 PM

Jan 24 2021

debdrup committed rP562510: multimedia/kodi: Add support for SSSE3, SSE4.1 and SSE4.2 on AMD64.
multimedia/kodi: Add support for SSSE3, SSE4.1 and SSE4.2 on AMD64
Jan 24 2021, 8:26 PM

Jan 21 2021

debdrup added a comment to D28264: Fix issues in past and present CheriBSD quarterly reports.

Ah, I hadn't twigged that it was going read-only so far in advance of the migration. The error message is technically correct I guess, needs a doceng approval, and this kind of thing is a bit of a special case.

Jan 21 2021, 8:27 PM
debdrup added a comment to D28264: Fix issues in past and present CheriBSD quarterly reports.
Jan 21 2021, 8:25 PM
debdrup added a comment to D28264: Fix issues in past and present CheriBSD quarterly reports.

Don't know if I'm supposed to be able to push with a Reviewed by: + Approved by: debdrup, or if something just hates me, but I get "FATAL: VREF/APPROVERS-CHECK/doc: helper program exit status 65280", so could you please commit this for me?

Jan 21 2021, 3:41 AM
debdrup accepted D28264: Fix issues in past and present CheriBSD quarterly reports.

Looks good to me, thank you for your attention to detail. :)

Jan 21 2021, 3:06 AM
debdrup added a comment to D28255: Add some more non-portable acl_* functions..

From a manual page point of view, this looks good to me.

Jan 21 2021, 2:15 AM
debdrup committed R9:3200fb1e31f2: 2020q4 report: Fix more mistakes, some from md>db conversion (authored by debdrup).
2020q4 report: Fix more mistakes, some from md>db conversion
Jan 21 2021, 2:02 AM

Jan 20 2021

debdrup added a comment to D28255: Add some more non-portable acl_* functions..

Interacting with kyau, the test suite, is described here on the wiki.

Jan 20 2021, 4:27 PM
debdrup added a reviewer for D28248: Convert the FDP primer from using svn to using git.: carlavilla.

Haven't run it through xmllint or igor yet, I first wanted to get a substantive review on my first draft. I will do so before submitting a 2nd draft, although perhaps I should wait to hear from Carlavilla before doing that. What's their username here?

Jan 20 2021, 4:12 PM
debdrup accepted D28252: Add freebsd-office-hours-2021-01-27.

Looks good to me now. :)

Jan 20 2021, 1:58 PM
debdrup added a comment to D28252: Add freebsd-office-hours-2021-01-27.

Just a few nits, otherwise it looks good to me. :)

Jan 20 2021, 1:41 PM
debdrup added a comment to D28248: Convert the FDP primer from using svn to using git..

Have you checked with xmllint?

Jan 20 2021, 7:45 AM

Jan 19 2021

debdrup committed R9:1e7c4a3928bf: doc.docbook.mk: Fix LATESTREVISION determination, causes build failure on non… (authored by Olivier Certner <olce.freebsd@certner.fr>).
doc.docbook.mk: Fix LATESTREVISION determination, causes build failure on non…
Jan 19 2021, 2:20 PM
debdrup committed R9:f2a33a330d5a: articles/nanobsd: Add section on customizing NanoBSD (authored by yoanadida_gmail.com).
articles/nanobsd: Add section on customizing NanoBSD
Jan 19 2021, 2:17 AM

Jan 17 2021

debdrup closed D28201: mpt.4: Warn about unexpected behaviour on older controllers.
Jan 17 2021, 1:07 PM

Jan 16 2021

debdrup committed rG0ec6c03c7682: mpt.4: Warn about unexpected behaviour on older controllers (authored by Sebastian Oswald <sebastian at rostwald.de>).
mpt.4: Warn about unexpected behaviour on older controllers
Jan 16 2021, 11:44 PM
debdrup updated the diff for D28201: mpt.4: Warn about unexpected behaviour on older controllers.

Address feedback from 0mp

Jan 16 2021, 11:31 PM
debdrup added inline comments to D28197: service.8: Provide example for adding completions to (t)csh.
Jan 16 2021, 11:02 PM
debdrup updated the test plan for D28201: mpt.4: Warn about unexpected behaviour on older controllers.
Jan 16 2021, 10:56 PM
debdrup requested review of D28201: mpt.4: Warn about unexpected behaviour on older controllers.
Jan 16 2021, 10:56 PM
debdrup closed D28198: service.8: Use entire section of literally displayed text.
Jan 16 2021, 10:22 PM
debdrup committed rGbce5d6aa2485: service.8: Use entire section of literally displayed text (authored by debdrup).
service.8: Use entire section of literally displayed text
Jan 16 2021, 10:22 PM
debdrup updated the diff for D28198: service.8: Use entire section of literally displayed text.

Address feedback by 0mp

Jan 16 2021, 9:53 PM
debdrup added a reviewer for D28198: service.8: Use entire section of literally displayed text: 0mp.
Jan 16 2021, 9:25 PM
debdrup updated the diff for D28198: service.8: Use entire section of literally displayed text.
Jan 16 2021, 9:25 PM
debdrup requested review of D28198: service.8: Use entire section of literally displayed text.
Jan 16 2021, 9:22 PM
debdrup closed D28197: service.8: Provide example for adding completions to (t)csh.
Jan 16 2021, 9:06 PM
debdrup committed rGc6a112cf84d2: service.8: Provide example for adding completions to (t)csh (authored by debdrup).
service.8: Provide example for adding completions to (t)csh
Jan 16 2021, 9:06 PM
debdrup requested review of D28197: service.8: Provide example for adding completions to (t)csh.
Jan 16 2021, 9:00 PM
debdrup committed R9:127579f0318e: 2020q4-status: Fix md>docbook conversion issue (authored by debdrup).
2020q4-status: Fix md>docbook conversion issue
Jan 16 2021, 7:37 PM
debdrup committed R9:62cb62879c2d: 2020q4 report: Fix md>db conversion issues, linebreaks, links (authored by debdrup).
2020q4 report: Fix md>db conversion issues, linebreaks, links
Jan 16 2021, 5:10 PM
debdrup committed R9:37dd052a7dc8: status.xml: Add link to report (authored by debdrup).
status.xml: Add link to report
Jan 16 2021, 3:37 PM
debdrup closed D28177: Add 2020Q4 status report to the newsflash.
Jan 16 2021, 3:16 PM
debdrup committed R9:31f481ca1c38: Add 2020Q4 status report to the newsflash (authored by debdrup).
Add 2020Q4 status report to the newsflash
Jan 16 2021, 3:16 PM
debdrup closed D28175: Add Status Report for 2020Q4.
Jan 16 2021, 2:30 PM
debdrup closed D28179: status/README: Fix phrasing, paths, news example, and nits..
Jan 16 2021, 2:30 PM
debdrup committed R9:af1a1261248b: Add 2020Q4 quarterly status report (authored by debdrup).
Add 2020Q4 quarterly status report
Jan 16 2021, 2:30 PM
debdrup committed R9:2369dc8ceb4e: status/README: Fix phrasing, paths, news example, and nits. (authored by debdrup).
status/README: Fix phrasing, paths, news example, and nits.
Jan 16 2021, 2:30 PM
debdrup updated the diff for D28175: Add Status Report for 2020Q4.

Address feedback by PauAmma

Jan 16 2021, 11:02 AM

Jan 15 2021

debdrup updated the diff for D28179: status/README: Fix phrasing, paths, news example, and nits..

Address feedback from PauAmma.

Jan 15 2021, 9:13 PM
debdrup updated the diff for D28177: Add 2020Q4 status report to the newsflash.

Address feedback by PauAmma.

Jan 15 2021, 8:57 PM
debdrup updated the diff for D28179: status/README: Fix phrasing, paths, news example, and nits..

Address feedback from PauAmma.

Jan 15 2021, 8:53 PM
debdrup updated the diff for D28175: Add Status Report for 2020Q4.

Addressed feedback from PauAmma.

Jan 15 2021, 8:18 PM
debdrup added reviewers for D28175: Add Status Report for 2020Q4: trasz, allanjude, 0mp.
Jan 15 2021, 5:34 PM
debdrup retitled D28175: Add Status Report for 2020Q4 from Add Quarterly Status Report for 2020Q4 to Add Status Report for 2020Q4.
Jan 15 2021, 5:31 PM
debdrup updated the diff for D28175: Add Status Report for 2020Q4.

Remember that we're in 2021 now

Jan 15 2021, 5:23 PM
debdrup updated the diff for D28175: Add Status Report for 2020Q4.

Bump future deadline

Jan 15 2021, 5:22 PM
debdrup requested review of D28179: status/README: Fix phrasing, paths, news example, and nits..
Jan 15 2021, 5:16 PM
debdrup updated the diff for D28177: Add 2020Q4 status report to the newsflash.

Fix whitespace issues

Jan 15 2021, 4:27 PM
debdrup updated the test plan for D28177: Add 2020Q4 status report to the newsflash.
Jan 15 2021, 4:24 PM
debdrup requested review of D28177: Add 2020Q4 status report to the newsflash.
Jan 15 2021, 4:24 PM
debdrup updated the diff for D28175: Add Status Report for 2020Q4.

Fix whitespaces

Jan 15 2021, 3:50 PM
debdrup requested review of D28175: Add Status Report for 2020Q4.
Jan 15 2021, 3:29 PM
debdrup added a comment to D28150: jail: Don't allow resurrection of dead jails.

You might also consider adding this, below the EXAMPLES section header:
".Sh COMPATABILITY
The
.Va allow.dying
parameter has been deprecated and doesn't work like it used to, but is still supported."

Jan 15 2021, 12:27 PM

Jan 14 2021

debdrup committed R9:47b7f1f71636: usergroups: Remove Iran User Group (authored by debdrup).
usergroups: Remove Iran User Group
Jan 14 2021, 1:11 PM

Jan 13 2021

debdrup added a comment to D28131: [handbook]: Document how to mount NTFS disks.

Here's a few nits I noticed.
Otherwise, it looks good to me.

Jan 13 2021, 11:19 AM

Jan 12 2021

debdrup added a comment to D28091: Add -NODEBUG variant of GENERIC-MMCCAM kernel configuration..

Hm, my instinct would be to make it include GENERIC-MMCCAM instead and then turn of debugging, especially given the name.

Jan 12 2021, 9:14 PM
debdrup committed R9:eab1c5d1f64d: books/: Address more instances of sentences beginning with 'Because...' (authored by Ceri Davies <ceri@submonkey.net>).
books/: Address more instances of sentences beginning with 'Because...'
Jan 12 2021, 6:35 PM

Jan 11 2021

debdrup added a comment to D27989: events2020: clean up cancelled events.

Looks good to me (but that's not surprising, since it's just trimming). :)

Jan 11 2021, 4:31 PM

Jan 8 2021

debdrup committed R9:e194334c7994: Arch handbook and articles: Reword sentences beginning with 'Because...' (authored by debdrup).
Arch handbook and articles: Reword sentences beginning with 'Because...'
Jan 8 2021, 1:24 PM

Jan 6 2021

debdrup added inline comments to D27833: Restructure the crypto(7) manpage and add authentication algorithms..
Jan 6 2021, 8:09 PM
debdrup updated subscribers of D27833: Restructure the crypto(7) manpage and add authentication algorithms..
Jan 6 2021, 1:00 PM
debdrup added inline comments to D27906: if_vtnet: improve and cleanup the receive code.
Jan 6 2021, 12:43 PM
debdrup updated subscribers of D27915: if_vtnet: Move remaining ioctl handlers to separate functions.

I noticed @grehan is missing from this review, but is attached to the others - is that intentional?

Jan 6 2021, 12:31 PM

Dec 24 2020

debdrup accepted D27715: Add a section about Zstandard compression to the ZFS handbook.

I think you've addressed all the feedback and had approvals from everyone attached ;)

Dec 24 2020, 6:52 PM

Dec 23 2020

debdrup added inline comments to D27715: Add a section about Zstandard compression to the ZFS handbook.
Dec 23 2020, 6:48 PM
debdrup added a comment to D27715: Add a section about Zstandard compression to the ZFS handbook.

Do I remember wrong, or does Zstd also offer the option to adaptively compress at as high a level as possible while maintaining bandwidth, or is that only for zfs send|receive? If so, should that also be mentioned?

Dec 23 2020, 6:33 PM

Dec 18 2020

debdrup added a comment to D27668: kerberos(8): Replace dead link to FAQ.

For something as specific as kerberos, I think it makes sense to link to the internet archive of the page, rather than getting rid of the link as it's not typically something that people would easily find on their own.

Dec 18 2020, 2:03 PM

Nov 27 2020

debdrup accepted D27386: [fdp-primer][manpages] Add Testing section.

Looks good to me, too. :)

Nov 27 2020, 4:21 PM

Nov 26 2020

debdrup added a comment to D27386: [fdp-primer][manpages] Add Testing section.

How about something like:

<para>Spell-checking with fully-featured dictionaries is encouraged, and can
  be accomplished by using <package>textproc/hunspell</package> or
  <package>textproc/aspell</package> combined with
  <package>textproc/en-hunspell</package> or
  <package>textproc/en-aspell</package>, respectively.</para>
Nov 26 2020, 7:48 PM
debdrup added a comment to D27386: [fdp-primer][manpages] Add Testing section.

Would it make sense to mention hunspell/aspell too? While igor does do some spellchecking, it does so on a rather limited set of words defined in the init_spellingerrors function.

Nov 26 2020, 6:31 PM

Nov 19 2020

debdrup closed D27284: Add missing pages to the introduction of section 7.
Nov 19 2020, 4:58 PM
debdrup committed rS367846: intro.7: Add missing manual page.
intro.7: Add missing manual page
Nov 19 2020, 4:57 PM
debdrup updated the diff for D27284: Add missing pages to the introduction of section 7.

Reattach text that was accidentally cut off

Nov 19 2020, 4:51 PM
debdrup updated the diff for D27284: Add missing pages to the introduction of section 7.

Fix wording and alphabetically list cross-references

Nov 19 2020, 4:39 PM
debdrup requested review of D27284: Add missing pages to the introduction of section 7.
Nov 19 2020, 4:01 PM

Nov 16 2020

debdrup abandoned D27033: Replace youtube_dl dependencies with youtube_dlc.

And youtube-dl is back

Nov 16 2020, 9:04 PM

Nov 2 2020

debdrup added a comment to D27033: Replace youtube_dl dependencies with youtube_dlc.
In D27033#603653, @bapt wrote:

First this has nothing to do with BINARY_ALIAS it tries to import a python module and fails, it does not tries to find a binary in the path.

Second youtube-dl is not dead, they just made a release downloadable at https://youtube-dl.org/

Nov 2 2020, 5:35 PM

Nov 1 2020

debdrup added a comment to D27033: Replace youtube_dl dependencies with youtube_dlc.

www/py-pafy will require some care:

Traceback (most recent call last):
  File "/wrkdirs/usr/ports/www/py-pafy/work-py38/pafy-0.5.5/pafy/pafy.py", line 51, in <module>
    import youtube_dl
ModuleNotFoundError: No module named 'youtube_dl'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "setup.py", line 13, in <module>
    from pafy import __version__
  File "/wrkdirs/usr/ports/www/py-pafy/work-py38/pafy-0.5.5/pafy/__init__.py", line 7, in <module>
    from .pafy import new
  File "/wrkdirs/usr/ports/www/py-pafy/work-py38/pafy-0.5.5/pafy/pafy.py", line 54, in <module>
    raise ImportError(
ImportError: pafy: youtube-dl not found; you can use the internal backend by setting the environmental variable PAFY_BACKEND to "internal". It is not enabled by default because it is not as well maintained as the youtube-dl backend.
*** Error code 1
Nov 1 2020, 6:58 PM

Oct 31 2020

debdrup updated the diff for D27033: Replace youtube_dl dependencies with youtube_dlc.

Address feedback

Oct 31 2020, 7:50 PM
debdrup requested review of D27033: Replace youtube_dl dependencies with youtube_dlc.
Oct 31 2020, 6:46 PM

Oct 29 2020

debdrup accepted D26998: Update due date of the quarterly status report.

Approved with gusto :)

Oct 29 2020, 1:52 PM
debdrup accepted D27006: June has only 30 days.

Approved :)

Oct 29 2020, 1:51 PM
debdrup requested changes to D26998: Update due date of the quarterly status report.

This is an exceptionally good idea that I should have thought of, since I've been following the calendar discussion on the mailing lists.
However, the dates aren't quite right - the "new" official deadlines are listed in ./doc/en_US.ISO8859-1/htdocs/news/status/README and basically amount to being the last day of a given quarter (barring the exception for late reports and portmgr@).

Oct 29 2020, 11:00 AM

Oct 23 2020

debdrup closed D26919: Fix multiple minor nits in status report for July-September 2020.
Oct 23 2020, 6:19 PM
debdrup committed rD54627: Fix multiple minor nits in status report for July-September 2020.
Fix multiple minor nits in status report for July-September 2020
Oct 23 2020, 6:19 PM