Looks good to me, let's land this. :)
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Feb 7 2021
Feb 6 2021
Feb 5 2021
I spotted a few minor nits.
Feb 4 2021
Looks good to me too, let's get this in.
Jan 30 2021
Jan 29 2021
Bullet point 4 in the quickstart needs to be removed, since move-shared no longer exists. :)
I don't know if you wanna fix it, but {git-doc-all} doesn't render properly, although that might be due to missing definitions?
The Website Makefile segment also needs to be updated with references to ./shared becoming ../shared/
Jan 26 2021
It looks good to me, but I'm not a porter, so I'll respectfully forward it to the people who are. :)
The alternative to this is, of course, to wrap everything in paragraph tags.
The advantage of this is that it won't be necessary to include <br /> tags for when multiple things happen on the same day, but I lean towards that being easier to do, than wrapping everything in each own paragraph.
Looks great to me, let's get this one landed post-haste (or whenever you get around to it)! :)
Jan 25 2021
I might also be convinced to write a git-arc(8) man-page. ;)
Jan 24 2021
Jan 21 2021
In D28264#632315, @jrtc27 wrote:Ah, I hadn't twigged that it was going read-only so far in advance of the migration. The error message is technically correct I guess, needs a doceng approval, and this kind of thing is a bit of a special case.
In D28264#632202, @jrtc27 wrote:Don't know if I'm supposed to be able to push with a Reviewed by: + Approved by: debdrup, or if something just hates me, but I get "FATAL: VREF/APPROVERS-CHECK/doc: helper program exit status 65280", so could you please commit this for me?
Looks good to me, thank you for your attention to detail. :)
From a manual page point of view, this looks good to me.
Jan 20 2021
Interacting with kyau, the test suite, is described here on the wiki.
In D28248#631871, @pauamma_gundo.com wrote:Haven't run it through xmllint or igor yet, I first wanted to get a substantive review on my first draft. I will do so before submitting a 2nd draft, although perhaps I should wait to hear from Carlavilla before doing that. What's their username here?
Looks good to me now. :)
Just a few nits, otherwise it looks good to me. :)
Have you checked with xmllint?
Jan 19 2021
Jan 17 2021
Jan 16 2021
Address feedback from 0mp
Address feedback by 0mp
Address feedback by PauAmma
Jan 15 2021
Address feedback from PauAmma.
Address feedback by PauAmma.
Address feedback from PauAmma.
Addressed feedback from PauAmma.
Remember that we're in 2021 now
Bump future deadline
Fix whitespace issues
Fix whitespaces
You might also consider adding this, below the EXAMPLES section header:
".Sh COMPATABILITY
The
.Va allow.dying
parameter has been deprecated and doesn't work like it used to, but is still supported."
Jan 14 2021
Jan 13 2021
Here's a few nits I noticed.
Otherwise, it looks good to me.
Jan 12 2021
In D28091#627733, @jrtc27 wrote:Hm, my instinct would be to make it include GENERIC-MMCCAM instead and then turn of debugging, especially given the name.
Jan 11 2021
Looks good to me (but that's not surprising, since it's just trimming). :)
Jan 8 2021
Jan 6 2021
I noticed @grehan is missing from this review, but is attached to the others - is that intentional?
Dec 24 2020
I think you've addressed all the feedback and had approvals from everyone attached ;)
Dec 23 2020
Do I remember wrong, or does Zstd also offer the option to adaptively compress at as high a level as possible while maintaining bandwidth, or is that only for zfs send|receive? If so, should that also be mentioned?
Dec 18 2020
For something as specific as kerberos, I think it makes sense to link to the internet archive of the page, rather than getting rid of the link as it's not typically something that people would easily find on their own.
Nov 27 2020
Looks good to me, too. :)
Nov 26 2020
How about something like:
<para>Spell-checking with fully-featured dictionaries is encouraged, and can be accomplished by using <package>textproc/hunspell</package> or <package>textproc/aspell</package> combined with <package>textproc/en-hunspell</package> or <package>textproc/en-aspell</package>, respectively.</para>
Would it make sense to mention hunspell/aspell too? While igor does do some spellchecking, it does so on a rather limited set of words defined in the init_spellingerrors function.
Nov 19 2020
Reattach text that was accidentally cut off
Fix wording and alphabetically list cross-references
Nov 16 2020
In D27033#608294, @lbartoletti wrote:And youtube-dl is back
Nov 2 2020
In D27033#603653, @bapt wrote:First this has nothing to do with BINARY_ALIAS it tries to import a python module and fails, it does not tries to find a binary in the path.
Second youtube-dl is not dead, they just made a release downloadable at https://youtube-dl.org/
Nov 1 2020
In D27033#603441, @tcberner wrote:www/py-pafy will require some care:
Traceback (most recent call last): File "/wrkdirs/usr/ports/www/py-pafy/work-py38/pafy-0.5.5/pafy/pafy.py", line 51, in <module> import youtube_dl ModuleNotFoundError: No module named 'youtube_dl' During handling of the above exception, another exception occurred: Traceback (most recent call last): File "<string>", line 1, in <module> File "setup.py", line 13, in <module> from pafy import __version__ File "/wrkdirs/usr/ports/www/py-pafy/work-py38/pafy-0.5.5/pafy/__init__.py", line 7, in <module> from .pafy import new File "/wrkdirs/usr/ports/www/py-pafy/work-py38/pafy-0.5.5/pafy/pafy.py", line 54, in <module> raise ImportError( ImportError: pafy: youtube-dl not found; you can use the internal backend by setting the environmental variable PAFY_BACKEND to "internal". It is not enabled by default because it is not as well maintained as the youtube-dl backend. *** Error code 1
Oct 31 2020
Address feedback
Oct 29 2020
Approved with gusto :)
This is an exceptionally good idea that I should have thought of, since I've been following the calendar discussion on the mailing lists.
However, the dates aren't quite right - the "new" official deadlines are listed in ./doc/en_US.ISO8859-1/htdocs/news/status/README and basically amount to being the last day of a given quarter (barring the exception for late reports and portmgr@).