Page MenuHomeFreeBSD
Feed Advanced Search

Dec 21 2016

sepherosa_gmail.com added a comment to D8876: mlx4_en_free_resources(): fix error handling for priv->stat_ctx.

It's probably better to call sysctl_ctx_init for the stat_ctx, when priv->sysctl is assigned. Or just moving the ctx_inits and sysctl assignment to common place. TAILQ requires explicit initialization, and we normally treat sysctl_ctx as opaque struct in drivers.

Dec 21 2016, 3:05 AM

Dec 20 2016

sepherosa_gmail.com retitled D8863: hyperv: Implement userspace gettimeofday(2) w/ Hyper-V TSC for 32bit compat. from to hyperv: Implement userspace gettimeofday(2) w/ Hyper-V TSC for 32bit compat..
Dec 20 2016, 4:45 AM
sepherosa_gmail.com added a comment to D8789: hyperv: Implement userspace gettimeofday(2) with Hyper-V reference TSC.
In D8789#183254, @kib wrote:
In D8789#183250, @kib wrote:
In D8789#183203, @kib wrote:

So you did not added support to 32bit libc. Why ?

It currently requires mulq, which is not available on 32 bits system.

The code doesn't require 128bit multiplication support, it is useful for optimization but not critical. It is possible to express the same calculation using the big numbers multiplication (or, if you prefer it, a term from russian elementary school, 'multiplication in column').

If 64bit values are X=a*g+b and Y=c*g+d, where g is 2^32, a,b, and c,d are 32bit high and low words of the corresponding 64bit values, then X*Y = a*c*g*g + (a*d + b*c)*g + b*d. You need to care about the carry bit. It is slightly more cumbersome then mulq, but not too complicated.

You could copy/paste the code from contrib/libcompiler_rt/lib/builtins/multi3.c, the __mulddi3() function.

Dec 20 2016, 1:21 AM

Dec 19 2016

sepherosa_gmail.com added a comment to D8789: hyperv: Implement userspace gettimeofday(2) with Hyper-V reference TSC.
In D8789#183203, @kib wrote:

So you did not added support to 32bit libc. Why ?

Dec 19 2016, 2:34 PM
sepherosa_gmail.com retitled D8851: hyperv/storvsc: The max channel in PDU actually means the max sub-chans. from to hyperv/storvsc: The max channel in PDU actually means the max sub-chans..
Dec 19 2016, 8:20 AM
sepherosa_gmail.com retitled D8850: hyperv/ic: Rename cleaned up files. from to hyperv/ic: Rename cleaned up files..
Dec 19 2016, 5:35 AM
sepherosa_gmail.com retitled D8849: hyperv/ic: Cleanup driver glue. from to hyperv/ic: Cleanup driver glue..
Dec 19 2016, 5:17 AM
sepherosa_gmail.com retitled D8848: hyperv/ic: Rname cleaned up file. from to hyperv/ic: Rname cleaned up file..
Dec 19 2016, 3:45 AM
sepherosa_gmail.com retitled D8847: hyperv/ic: Inclusion cleanup from to hyperv/ic: Inclusion cleanup.
Dec 19 2016, 3:26 AM
sepherosa_gmail.com retitled D8846: hyperv/ic: Rename cleaned up header file. from to hyperv/ic: Rename cleaned up header file..
Dec 19 2016, 3:18 AM
sepherosa_gmail.com retitled D8845: hyperv/ic: Cleanup common struct and functions. from to hyperv/ic: Cleanup common struct and functions..
Dec 19 2016, 3:06 AM
sepherosa_gmail.com retitled D8844: hyperv/utils: Factor out function to send IC response from to hyperv/utils: Factor out function to send IC response.
Dec 19 2016, 2:40 AM

Dec 16 2016

sepherosa_gmail.com updated the diff for D8789: hyperv: Implement userspace gettimeofday(2) with Hyper-V reference TSC.
Dec 16 2016, 2:29 AM
sepherosa_gmail.com added inline comments to D8789: hyperv: Implement userspace gettimeofday(2) with Hyper-V reference TSC.
Dec 16 2016, 1:11 AM

Dec 15 2016

sepherosa_gmail.com updated the diff for D8789: hyperv: Implement userspace gettimeofday(2) with Hyper-V reference TSC.
Dec 15 2016, 2:53 AM

Dec 14 2016

sepherosa_gmail.com retitled D8789: hyperv: Implement userspace gettimeofday(2) with Hyper-V reference TSC from to hyperv: Implement userspace gettimeofday(2) with Hyper-V reference TSC.
Dec 14 2016, 8:49 AM
sepherosa_gmail.com updated the diff for D8768: hyperv: Allow userland to ro-mmap reference TSC page.

Use d_open to prevent write mmap, pointed out by kib

Dec 14 2016, 2:21 AM
sepherosa_gmail.com added inline comments to D8768: hyperv: Allow userland to ro-mmap reference TSC page.
Dec 14 2016, 1:35 AM

Dec 13 2016

sepherosa_gmail.com retitled D8768: hyperv: Allow userland to ro-mmap reference TSC page from to hyperv: Allow userland to ro-mmap reference TSC page.
Dec 13 2016, 8:17 AM
sepherosa_gmail.com updated the diff for D8763: hyperv: Implement "enlightened" time counter, which is rdtsc based..

Add compiler fence through atomic_*_acq, suggested by kib

Dec 13 2016, 4:56 AM
sepherosa_gmail.com added inline comments to D8763: hyperv: Implement "enlightened" time counter, which is rdtsc based..
Dec 13 2016, 2:24 AM

Dec 12 2016

sepherosa_gmail.com updated the diff for D8763: hyperv: Implement "enlightened" time counter, which is rdtsc based..

Fix reversed logic

Dec 12 2016, 9:04 AM
sepherosa_gmail.com updated the diff for D8763: hyperv: Implement "enlightened" time counter, which is rdtsc based..

Fallback to other timecounter's tc_get_timecount is not a good idea.

Dec 12 2016, 8:47 AM
sepherosa_gmail.com retitled D8763: hyperv: Implement "enlightened" time counter, which is rdtsc based. from to hyperv: Implement "enlightened" time counter, which is rdtsc based..
Dec 12 2016, 8:30 AM

Dec 9 2016

sepherosa_gmail.com retitled D8739: hyperv/hn: Add polling support from to hyperv/hn: Add polling support.
Dec 9 2016, 6:43 AM
sepherosa_gmail.com retitled D8738: hyperv/vmbus: Add channel polling support. from to hyperv/vmbus: Add channel polling support..
Dec 9 2016, 6:37 AM

Dec 8 2016

sepherosa_gmail.com accepted D8724: Fix the failure of attaching disk on ws2012r2.
Dec 8 2016, 9:24 AM

Dec 7 2016

sepherosa_gmail.com retitled D8723: hyperv/timesync: Support "sent TC" to improve accuracy. from to hyperv/timesync: Support "sent TC" to improve accuracy..
Dec 7 2016, 8:15 AM

Dec 1 2016

sepherosa_gmail.com retitled D8686: hyperv/vmbus: Utilize vmbus_chan_run_task() from to hyperv/vmbus: Utilize vmbus_chan_run_task().
Dec 1 2016, 8:00 AM

Nov 30 2016

sepherosa_gmail.com added reviewers for D8676: hyperv/hn: Add 'options RSS' support.: adrian, rwatson.
Nov 30 2016, 8:17 AM
sepherosa_gmail.com retitled D8676: hyperv/hn: Add 'options RSS' support. from to hyperv/hn: Add 'options RSS' support..
Nov 30 2016, 8:16 AM
sepherosa_gmail.com added a comment to D8656: hyperv/storvsc: Don't use timedwait; mainly to unbreak EARLY_AP_STARTUP.
In D8656#179616, @jhb wrote:

If you don't need the timeout, that is fine to remove of course. If you need the timeout for other reasons, see if rS309148 fixes the panics for you.

Nov 30 2016, 8:12 AM
sepherosa_gmail.com retitled D8675: hyperv/hn: Don't hold txdesc, if no BPFs are attached. from to hyperv/hn: Don't hold txdesc, if no BPFs are attached..
Nov 30 2016, 6:29 AM
sepherosa_gmail.com retitled D8674: hyperv/hn: Add HN_DEBUG kernel option. from to hyperv/hn: Add HN_DEBUG kernel option..
Nov 30 2016, 2:43 AM

Nov 28 2016

sepherosa_gmail.com retitled D8660: hypver/vmbus: Remove extra assertion. from to hypver/vmbus: Remove extra assertion..
Nov 28 2016, 8:26 AM
sepherosa_gmail.com retitled D8659: hyperv/hn: Allow TX to share event taskqueues. from to hyperv/hn: Allow TX to share event taskqueues..
Nov 28 2016, 8:09 AM
sepherosa_gmail.com retitled D8658: hyperv/vmbus: Add DEVMETHOD to map cpu to event taskq. from to hyperv/vmbus: Add DEVMETHOD to map cpu to event taskq..
Nov 28 2016, 8:06 AM
sepherosa_gmail.com retitled D8656: hyperv/storvsc: Don't use timedwait; mainly to unbreak EARLY_AP_STARTUP from to hyperv/storvsc: Don't use timedwait; mainly to unbreak EARLY_AP_STARTUP.
Nov 28 2016, 6:09 AM
sepherosa_gmail.com retitled D8655: hyperv/hn: Allow multiple TX taskqueues. from to hyperv/hn: Allow multiple TX taskqueues..
Nov 28 2016, 5:18 AM
sepherosa_gmail.com retitled D8654: hyperv/hn: Nuke the unused TX taskqueue CPU binding tunable. from to hyperv/hn: Nuke the unused TX taskqueue CPU binding tunable..
Nov 28 2016, 3:14 AM

Nov 25 2016

sepherosa_gmail.com retitled D8636: hyperv/vmbus: Use poll/cancel APIs to wait for the CHOPEN response. from to hyperv/vmbus: Use poll/cancel APIs to wait for the CHOPEN response..
Nov 25 2016, 7:56 AM
sepherosa_gmail.com retitled D8635: hyperv/vmbus: Add exec cancel support for message Hypercall API. from to hyperv/vmbus: Add exec cancel support for message Hypercall API..
Nov 25 2016, 7:54 AM
sepherosa_gmail.com retitled D8634: hyperv/vmbus: Add result polling support for message Hypercall API. from to hyperv/vmbus: Add result polling support for message Hypercall API..
Nov 25 2016, 7:52 AM
sepherosa_gmail.com retitled D8633: hyperv/vmbus: Add result polling support for xact API. from to hyperv/vmbus: Add result polling support for xact API..
Nov 25 2016, 7:51 AM
sepherosa_gmail.com retitled D8632: hyperv/vmbus: Stringent GPADL parameter assertion. from to hyperv/vmbus: Stringent GPADL parameter assertion..
Nov 25 2016, 5:31 AM
sepherosa_gmail.com retitled D8631: hyperv/vmbus: Make sure that the allocated GPADL is not zero. from to hyperv/vmbus: Make sure that the allocated GPADL is not zero..
Nov 25 2016, 5:24 AM
sepherosa_gmail.com retitled D8630: hyperv/hn: Simplify RSS indirect table fixup API from to hyperv/hn: Simplify RSS indirect table fixup API.
Nov 25 2016, 4:58 AM
sepherosa_gmail.com retitled D8629: hyperv/hn: Fix vmbus_chan_subidx usage. from to hyperv/hn: Fix vmbus_chan_subidx usage..
Nov 25 2016, 3:29 AM

Nov 23 2016

sepherosa_gmail.com retitled D8621: hyperv/hn: Enable multi-packet RNDIS message support by default. from to hyperv/hn: Enable multi-packet RNDIS message support by default..
Nov 23 2016, 9:32 AM
sepherosa_gmail.com retitled D8620: hyperv/hn: Fix attach error handling from to hyperv/hn: Fix attach error handling.
Nov 23 2016, 9:25 AM
sepherosa_gmail.com retitled D8619: hyperv/hn: Fix multi-packet RNDIS message aggregation size setting. from to hyperv/hn: Fix multi-packet RNDIS message aggregation size setting..
Nov 23 2016, 2:59 AM
sepherosa_gmail.com accepted D8572: share/man/man4/Makefile: only install Hyper-V manuals on amd64 and i386.
Nov 23 2016, 1:38 AM

Nov 22 2016

sepherosa_gmail.com retitled D8613: hyperv/hn: Fix detach error handling. from to hyperv/hn: Fix detach error handling..
Nov 22 2016, 8:08 AM
sepherosa_gmail.com retitled D8612: hyperv/hn: Utilize vmbus_chan_xact_wait from to hyperv/hn: Utilize vmbus_chan_xact_wait.
Nov 22 2016, 5:33 AM
sepherosa_gmail.com accepted D8572: share/man/man4/Makefile: only install Hyper-V manuals on amd64 and i386.
Nov 22 2016, 5:27 AM
sepherosa_gmail.com retitled D8611: hyperv/vmbus: Add supportive transaction wait function. from to hyperv/vmbus: Add supportive transaction wait function..
Nov 22 2016, 5:10 AM
sepherosa_gmail.com accepted D8572: share/man/man4/Makefile: only install Hyper-V manuals on amd64 and i386.
Nov 22 2016, 1:01 AM

Nov 21 2016

sepherosa_gmail.com retitled D8601: hyperv/vmbus: Zero out GPADL if error happens. from to hyperv/vmbus: Zero out GPADL if error happens..
Nov 21 2016, 6:12 AM
sepherosa_gmail.com added inline comments to D8572: share/man/man4/Makefile: only install Hyper-V manuals on amd64 and i386.
Nov 21 2016, 5:53 AM
sepherosa_gmail.com accepted D8572: share/man/man4/Makefile: only install Hyper-V manuals on amd64 and i386.
Nov 21 2016, 5:49 AM
sepherosa_gmail.com retitled D8600: hyperv/vmbus: Add a simplified version of channel close. from to hyperv/vmbus: Add a simplified version of channel close..
Nov 21 2016, 3:37 AM
sepherosa_gmail.com retitled D8599: hyperv/vmbus: Propagate close error. from to hyperv/vmbus: Propagate close error..
Nov 21 2016, 3:35 AM
sepherosa_gmail.com retitled D8598: hyperv/vmbus: Always try disconnect/free bufring memory upon channel close from to hyperv/vmbus: Always try disconnect/free bufring memory upon channel close.
Nov 21 2016, 2:54 AM

Nov 18 2016

sepherosa_gmail.com retitled D8570: hyperv/vmbus: Don't free the bufring if its GPADL can't be disconnected. from to hyperv/vmbus: Don't free the bufring if its GPADL can't be disconnected..
Nov 18 2016, 9:03 AM
sepherosa_gmail.com retitled D8569: hyperv/vmbus: Return EISCONN if the bufring GPADL can't be disconnected. from to hyperv/vmbus: Return EISCONN if the bufring GPADL can't be disconnected..
Nov 18 2016, 8:33 AM
sepherosa_gmail.com retitled D8568: hyperv/vmbus: No stranded bufring GPADL is allowed. from to hyperv/vmbus: No stranded bufring GPADL is allowed..
Nov 18 2016, 7:49 AM
sepherosa_gmail.com retitled D8567: hyperv/vmbus: GPADL disconnect error on a revoked channel is benign. from to hyperv/vmbus: GPADL disconnect error on a revoked channel is benign..
Nov 18 2016, 7:47 AM
sepherosa_gmail.com retitled D8566: hyperv/vmbus: Don't close unopened channels. from to hyperv/vmbus: Don't close unopened channels..
Nov 18 2016, 6:13 AM
sepherosa_gmail.com retitled D8565: hyperv/vmbus: Fix sysctl tree leakage, if channel open fails. from to hyperv/vmbus: Fix sysctl tree leakage, if channel open fails..
Nov 18 2016, 5:48 AM
sepherosa_gmail.com retitled D8564: hyperv/vmbus: Minor style changes. from to hyperv/vmbus: Minor style changes..
Nov 18 2016, 5:27 AM
sepherosa_gmail.com retitled D8563: hyperv/vmbus: Commit the GPADL id only after the connection succeeds. from to hyperv/vmbus: Commit the GPADL id only after the connection succeeds..
Nov 18 2016, 5:02 AM
sepherosa_gmail.com retitled D8560: hyperv/hn: Implement RNDIS multi-packet message support. from to hyperv/hn: Implement RNDIS multi-packet message support..
Nov 18 2016, 3:45 AM
sepherosa_gmail.com retitled D8559: hyperv/hn: Fix primary channel revocation from to hyperv/hn: Fix primary channel revocation.
Nov 18 2016, 3:17 AM

Nov 17 2016

sepherosa_gmail.com retitled D8546: hyperv/vmbus: Fix the multi-channel revoking on vmbus side. from to hyperv/vmbus: Fix the multi-channel revoking on vmbus side..
Nov 17 2016, 9:13 AM
sepherosa_gmail.com retitled D8545: hyperv/vmbus: Fix the primary channel revoking on vmbus side. from to hyperv/vmbus: Fix the primary channel revoking on vmbus side..
Nov 17 2016, 2:42 AM
sepherosa_gmail.com updated the diff for D8525: hyperv/vmbus: Implement orphan support for transaction API.

Allow double-orphan on destroy path. Make the life easier for xact API consumers.

Nov 17 2016, 2:02 AM

Nov 15 2016

sepherosa_gmail.com retitled D8525: hyperv/vmbus: Implement orphan support for transaction API from to hyperv/vmbus: Implement orphan support for transaction API.
Nov 15 2016, 9:15 AM
sepherosa_gmail.com retitled D8524: hyperv/vmbus: Merge free/active locks. from to hyperv/vmbus: Merge free/active locks..
Nov 15 2016, 7:31 AM
sepherosa_gmail.com retitled D8522: hyperv/vmbus: Set a mark on the revoked channel. from to hyperv/vmbus: Set a mark on the revoked channel..
Nov 15 2016, 6:30 AM
sepherosa_gmail.com retitled D8520: hyperv/hn: Don't abuse hn_{tx,rx}_ring_inuse. from to hyperv/hn: Don't abuse hn_{tx,rx}_ring_inuse..
Nov 15 2016, 3:47 AM
sepherosa_gmail.com retitled D8519: hyperv/hn: If the mbuf does not have flowid, fallback to m_ether_hash from to hyperv/hn: If the mbuf does not have flowid, fallback to m_ether_hash.
Nov 15 2016, 3:22 AM

Nov 14 2016

sepherosa_gmail.com accepted D8332: hyperv: enable PCIe pass-through (a.k.a. Discrete Device Assignment).
Nov 14 2016, 5:40 AM

Nov 10 2016

sepherosa_gmail.com retitled D8490: hyperv/hn: Allow enabling IPv6 TX checksum offloading and IPv6 TSO. from to hyperv/hn: Allow enabling IPv6 TX checksum offloading and IPv6 TSO..
Nov 10 2016, 8:40 AM
sepherosa_gmail.com retitled D8489: hyperv/hn: Fix WITNESS warnings from to hyperv/hn: Fix WITNESS warnings.
Nov 10 2016, 8:09 AM
sepherosa_gmail.com retitled D8488: hyperv/vmbus: Support transction result busy-wait. from to hyperv/vmbus: Support transction result busy-wait..
Nov 10 2016, 8:07 AM

Nov 9 2016

sepherosa_gmail.com added a comment to D5431: Reduce thread count in driver to reduce out of order transmit processing.

The try lock scheme you have used will cause two types of issues:

Nov 9 2016, 3:30 AM
sepherosa_gmail.com added inline comments to D5431: Reduce thread count in driver to reduce out of order transmit processing.
Nov 9 2016, 3:09 AM

Nov 8 2016

sepherosa_gmail.com added inline comments to D8224: hyperv/vss: implement the VSS (Volume Shadow Copy Service).
Nov 8 2016, 3:14 AM

Nov 3 2016

sepherosa_gmail.com accepted D8409: hyperv/vmbus: add new vmbus methods to support PCIe pass-through.
Nov 3 2016, 9:32 AM
sepherosa_gmail.com added a comment to D8409: hyperv/vmbus: add new vmbus methods to support PCIe pass-through.
In D8409#175275, @jhb wrote:

This looks fine. Note that there is some existing code this somewhat duplicates. For example, the ACPI Host-PCI bridge driver also parses _CRS to determine valid ranges. It uses the pcib_host_res_* API to add those ranges to a list that it then iterates on allocation requests. I'm not sure if does the same trick of preferring > 4G ranges for 64-bit BARs (though if pcib_host_res_*() would otherwise work for you I'd be fine with fixing it to do the same).

Nov 3 2016, 1:35 AM

Nov 2 2016

sepherosa_gmail.com accepted D8409: hyperv/vmbus: add new vmbus methods to support PCIe pass-through.

Ship it!

Nov 2 2016, 2:31 AM
sepherosa_gmail.com accepted D8410: hyperv/vmbus: add a new method to get vcpu_id.

Ship it!

Nov 2 2016, 2:28 AM
sepherosa_gmail.com accepted D8410: hyperv/vmbus: add a new method to get vcpu_id.
Nov 2 2016, 1:19 AM
sepherosa_gmail.com accepted D8409: hyperv/vmbus: add new vmbus methods to support PCIe pass-through.
Nov 2 2016, 1:19 AM
sepherosa_gmail.com added inline comments to D8409: hyperv/vmbus: add new vmbus methods to support PCIe pass-through.
Nov 2 2016, 1:19 AM
sepherosa_gmail.com added inline comments to D8410: hyperv/vmbus: add a new method to get vcpu_id.
Nov 2 2016, 1:15 AM

Nov 1 2016

sepherosa_gmail.com added inline comments to D8409: hyperv/vmbus: add new vmbus methods to support PCIe pass-through.
Nov 1 2016, 9:25 AM
sepherosa_gmail.com accepted D8391: hyperv/utility: share status return values.
Nov 1 2016, 6:39 AM
sepherosa_gmail.com retitled D8406: hyperv: GC unused functions. from to hyperv: GC unused functions..
Nov 1 2016, 2:13 AM

Oct 31 2016

sepherosa_gmail.com retitled D8395: hyperv/vmbus: Avoid extra header copy. from to hyperv/vmbus: Avoid extra header copy..
Oct 31 2016, 9:34 AM