Don't you need to handle the G'MIC changes announced in https://krita.org/en/release-notes-for-krita-3-2/ (i.e. port and depend on gmic-qt)?
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Sep 29 2017
I've added one inline comment about the CMake bit, but what I have in mind is basically this: https://paste.kde.org/pl55sr7am/ludwj5 I've tried that one out (together with your src/parts/CMakeLists.txt change) and it all built fine.
Sep 28 2017
Almost there IMO. One important thing to keep in mind is that, when landing, you're supposed to svn cp the old kgraphviz port and land your changes on top of it instead of svn add'ing it from scratch.
Sep 27 2017
Sep 24 2017
Sep 22 2017
shipit!
we just need an exp-run now
Sep 21 2017
lgtm, but you must ask for an exp-run before landing.
Sep 20 2017
You also need to update devel/cmake-doc and devel/cmake-gui.
Sep 19 2017
Sep 18 2017
Sep 16 2017
Sep 15 2017
Sep 14 2017
plase make sure you upstream the CC->c++ change to CMake.
Sep 13 2017
The patch looks mostly good; I've added some inline questions and comments due to the amount of ports being changed in this update. In general, I'm asking for clarification on whether some changes are really related to this change and also asking for some context in the patches being added, otherwise we end up in a very confusing situation in the future.
Sep 12 2017
shipit! I don't think there's any need to ping anyone else
Sep 10 2017
Sep 9 2017
Sep 3 2017
Aug 31 2017
Assuming the pending changes that Ade mentioned have been incorporated, shipit!
Aug 27 2017
Landed in rP448821, I forgot to mention the Phab link in the commit message :(
Aug 26 2017
Aug 23 2017
Aug 18 2017
Aug 17 2017
Aug 16 2017
Aug 13 2017
Aug 12 2017
Aug 11 2017
not sure if you're waiting for feedback; still looks good to me.
Aug 8 2017
As they used to say in WebKit-land, "lgtm with nits" :-)
Aug 7 2017
With Fedora and Arch Linux having switched to this fork, I guess it's time to move in the same direction. The GitHub project has some official release tarballs. Have you tried using them and dropping the Makefile hacks?
Aug 6 2017
Aug 5 2017
Aug 4 2017
Aug 3 2017
Aug 2 2017
lgtm modulo ade's comments. Overall, I think it's good to go!
Aug 1 2017
Add to new fixes (already reported).
Jul 28 2017
Jul 26 2017
Jul 17 2017
How far do you actually get with the Qt4 ports on arm64? The header you're patching is also used by several other Qt4 ports, as well as ports depending on Qt. Fedora's patch looks quite bigger.
Jul 15 2017
Jul 14 2017
Jul 12 2017
lgtm as long as the exp-run works.
Jul 9 2017
Jul 8 2017
Looks fine to me. I'd take the opportunity and set LICENSE_FILE and USES=cmake:outsource. However, didn't you say something about it crashing when it's started on IRC?