Thank you for taking care of this @dbaio

Looks good, thank you for looking after this @dbaio

LGTM if it passes QA (portlint, poudriere (py 2/3), make test)

In D21229#466138, @Vladimir.Chukharev_gmail.com wrote:

I discussed the tests failure with developers. The source of it is that Qt in FreeBSD uses three dots instead of the unicode ellipsis symbol (supposedly, elidedText() function).
The test has been changed to admit "..." as ellipsis. This will come with the next release.
We can simply ignore the test failure for now. I plan to find the exact place where ellipsis is inserted, and to try using the unicode ellipsis symbol (but don't hold your breath).

@nwhitehorn Looks good!

@dbaio Could you combine this and D21303 along with the changes necessary to switch py-fabric to py-fabric1 into a single differential

@dbaio Could you combine this and D21304 along with the changes necessary to switch py-fabric to py-fabric1 into a single differential

Also, tests are available upstream (but not in the sdist), but it would be great to be able to QA this complex port properly.

The FreeBSD Python ports policy has recently been updated to clarify USES=python guidelines.

In D20683#462669, @dbaio wrote:

In D20683#462167, @koobs wrote:

@dbaio Can you add these to the diff please:

• Copies py-fabric -> py-fabric1
• Updates dependents that require fabric < 2 to devel/py-fabric1

Alternatively, create a separate differential for them, and set this as dependent (child) of it

To update this review I'll need to get it with the Commandeer Revision, is that ok ?

@dbaio Can you add these to the diff please:

If the port installs files in shared (for multiple Python verion) locations, port must be concurrent safe

LGTM (previous revision was accepted, with additional comments)

In D17459#456514, @loader wrote:

I'm not sure if it's okay to update the OPTION descriptioins in some ports or just keep them as is,
for example, GIT_DESC in www/moinmoincl/Makefile:

GIT_DESC=        Install git to use git-diff(1) instead of diff(1) for colored output

In D17459#456222, @adamw wrote:

Perhaps these could say Git repository support or, even better, Git code repository support.

I'm sick of LibXYZ support descriptions.

In D17459#456234, @loader wrote:

In D17459#456127, @koobs wrote:

For all options added in Mk/bsd.options.desc.mk I think we should have 'version control` in the description, like

MERCURIAL_DESC= Mercurial version control support

After changing the names in Mk/bsd.options.desc.mk to their full names, update ports that use those names too

Should I also change the SVN_DESC?= Subversion support to SUBVERSION_DESC?= Subversion version control support in Mk/bsdoptions.desc.mk?

Looks OK. Questions:

Mk/bsd.options.desc.mk MAINTAINER is:

For all options added in Mk/bsd.options.desc.mk I think we should have 'version control` in the description, like

Feel free to re-add me as reviewer after updating

Our SVN commit hooks dont like Changes: in commit log messages. Needs to be Changelog: and I'd probably separate software changelog lines from the freebsd commit log attributes section, like:

concurrent should always be used when anything is installed by a package in locations (filenames/pathnames) that are not version-specific, like /usr/local/bin.

Looks good (with minor patch comment), ship it.

Oh, you didn't use my commit log message verbatim ;(~ *tear*

Fixed in pypa/pip today: https://github.com/pypa/pip/issues/1890

Sorry I meant get this into 2019Q2 (MFH) *and* into 2019Q3 (before its cut

@sbz I'd like this to get into 2019Q3 before the branch is cut. Could you take a quick look?

Fix portlint issues:

Closed by rP505000, I forgot to remove the _ in Differential_Revision

In D20754#449357, @loader wrote:

Sure thing.

armv6: https://pastebin.com/raw/QGGQXwaw
armv7: https://pastebin.com/raw/tf9dTnUy
aarch64: https://pastebin.com/raw/XjJCPnYE
mips64: https://pastebin.com/raw/4TAsghbd

armv6 was tested in a jail running on the armv7 kernel.