Is there anything that needs to be done, except committing this?
If finding a committer is a challenge, then I can do i myself.

Self approve.

Incorporate review comments from Mathieu.

Great review! I very much appreciate your attention to detail!

Incorporate review comments from mat@ (thanks!):

• Add WWW line to pkg-descr.
• Use make makeplist to generate pkg-plist. Manually edited to declare sample configuration with @sample
• Added libtool and ssl to USES
• Remove MASTER_SITES

We can't use the required_files variable given that start_precmd creates files mentioned there. Manually check for having the required files in start_precmd.

LGTM -- I don't think this will impact building makefs on non-FreeBSD...

I've been thinking about encoding this with the partition specification (i.e. as part of the -p option), but the specification is cryptic enough as it is. Maybe when there's a different way of specifying partitions (say, using a JSON or YAML file given instead of a number of -p options), will it be easier to add a "bootme" attribute that translates into setting the active flag. For now, this is simple and it works...

Committed

Fixes to the previous diff:
o Have the generic GPT uuid definition match the UUID constants so that the header is self-consistent and usable without "external" definition for UUIDs.
o Typedef gpt_uuid_t from GPT_UUID_TYPE to make it more palatable for applications to use the GPT type for UUIDs themselves.
o Fix a comment in sys/sys/disklabel.h

Fix was committed.

Author mentioned SVN revision with fix.

Code was committed.

Code committed

Self-approve

I'm cool with that

I can document .po, .pico, etc but prefer to do so in a separate commit. The need for such documentation isn't created by this change, but has always been there. I'll do a followup commit (plus email to @current, etc) after this change is approved.

Adding my response to bdrewery@ for posterity:

Probably good to get feedback from people on arm@ or re@.
I'll approve in case there has been silence so far...

If mkimg still returns 0 when it doesn't like the command line options, then we should definitely fix that. You want scripts to be able to check for (or just fail) in that case and not create a broken image.

Very nice!

I double-checked the code and there's actually no binary search logic. It's all linear. Technically speaking, the reordering was not necessary, but I really appreciate the effort. It's a lot easier now to implement a binary search for cases where the linear search gets too time consuming.

LGTM

LGTM

IIRC, aliases must be sorted so that the binary search works. ms-recovery before ms-reserved, please.
I see we disordered ntfs before netbsd-* as well, so we have a pre-existing bug if the binary search still holds.

I would not rework the patch. While mav@'s comments are good, they go beyond the simple problem that the hold solved. The hold only solved the holding off of mounting root while interrupt-driven discovery was still ongoing. You patch, trasz@, avoids that we wait mounting root when there was no point waiting, as the device was already there. That is a good change.

Sorry. Looks good!

Overall: I like the change. You may want to get a second thumbs up though.

Looking at the ifconfig in 4.4 lite, it looks like the netmask has always been printed as a hex number and I've always found that to be less than ideal. Having options for how the subnet is displayed is a good suggestion. I like the CIDR notion for example.

Overall: nicely done!

LGTM