Looks good to me. Please build-test before commit.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Jul 14 2017
Jul 7 2017
Jun 23 2017
Jun 16 2017
I think this was in program output text, but that cannot be seen from the diff. Please update the diff with context as shown in https://wiki.freebsd.org/action/show/Phabricator?action=show&redirect=CodeReview
Committed in r50349.
Jun 10 2017
Jun 9 2017
Jun 8 2017
Jun 7 2017
May 26 2017
May 19 2017
Please update .Dd also.
Please also bump .Dd.
May 15 2017
May 14 2017
May 13 2017
In D7665#221728, @cem wrote:In D7665#221698, @wblock wrote:Removed mention of etcupdate, leaving that for someone who actually uses it.
Etcupdate was the main improvement (for me) in this change :-(.
May 12 2017
Removed mention of etcupdate, leaving that for someone who actually uses it. Switch from deleting /usr/obj to using 'make cleanworld' on advice of bdrewery.
May 9 2017
May 5 2017
In D10454#218453, @bcr wrote:I'm not sure whether the non-dash version of the word is more correct. What do you say, Warren?
Apr 28 2017
Apr 7 2017
Mar 31 2017
Mar 27 2017
Mar 24 2017
One suggestion, but looks good otherwise. Thank you!
Mar 17 2017
Had to stop here, not even a quarter of the way through. This is too large a change. Please consider breaking it up into changes to individual sections that can be reviewed more easily.
Mar 11 2017
In D9958#205730, @danfe wrote:I don't see much value in having trivial examples; arguably, e.g. giving a link to famous http://sed.sourceforge.net/sed1line.txt would be more useful (and a smaller change).
Mar 9 2017
Mar 4 2017
Mar 3 2017
Approved for great justice!
As long as this still renders correctly, works for me.
Changes look fine to me, although I can't speak to the technical side, not having used PPP in a very long time.
In D9601#202724, @imp wrote:I can't think of a better name....
This looks better, thank you. A few additional suggestions, and a note that textproc/igor can be used to check for some basic mdoc formatting standards, sentences starting on a new line and that type of thing, along with a few thousand misspellings common in the FreeBSD community. Thanks!
Feb 28 2017
Feb 27 2017
Edited. Lots of whitespace fixes, some text editing for clarity.
Feb 17 2017
A couple of minor things. Incidentally, this is a pretty cool feature.
Man page looks okay to me. Please check with textproc/igor and mandoc -Tlint. Thanks!