Wed, Sep 11
Wed, Sep 4
Sun, Aug 25
Thank you, @kevans! fixed.
Thu, Aug 22
Fix regression found thanks to tests:
- "jail -r jailname" returned error: jail not found.
Add basic jail tests:
- create/stop/list/restart jails
- create/list nested jail
- execute commands prestart and prestop
Aug 20 2019
Fix SEGFAULT on uninitialized jails_byname.
Aug 19 2019
Jun 20 2019
May 27 2019
May 2 2019
Apr 29 2019
Mar 21 2019
Generally looks good. Please fix easy remarks.
Jan 24 2019
Dec 16 2018
I prefer to deprecate chips / sub-arch, but not removal. Honestly approach with "unimplementable" atomic_64_swap looks too aggressive.
I and @yamori813_yahoo.co.jp have boards with mips4k SoCs and to be honest such chips do their job well.
Another point: I saw plenty of emails with information that 8Mb is very slow. If it looks small for certain group of people, it doesn't mean that it's small in wide audience. I see that firmware with kernel, modules, 20Mb of uncompressed UFS/CD9660 filesystem is powerful to handle plenty of tasks: routing, monitoring of sensors, graphical output to LCD, keyboard/IR control and so on.
Nov 28 2018
Nov 26 2018
Nov 16 2018
Nov 13 2018
Nov 12 2018
Thank you for submission!
Phabricator highlights style(9) issues like spacing/tabs, so it's easy to fix it.
Nov 10 2018
Oct 8 2018
Oct 2 2018
Sep 8 2018
Aug 29 2018
Thank you for review, @mat !
Patch has been corrected according to comment. :) Hope it's OK now.
Aug 28 2018
Aug 12 2018
Aug 11 2018
Many thanks for the patch!
Jan 25 2018
@jhb, many thanks for review!
Jan 22 2018
Dec 27 2017
Small cosmetic changes are required.
But I don't get idea why this marker lookup can't be done by flash_slicer code.
Could you please clarify benefit?
Dec 22 2017
Dec 19 2017
Dec 7 2017
Dec 5 2017
MIPS is fine:
Dec 3 2017
- move check to vm_phys_alloc_freelist_pages
- assert input parameter freelist instead of uninitialized flind
Nov 24 2017
Cosmetic change: increase MIPS_MAX_TCB_SIZE from 0x20 to 0x1000
In D13134#274207, @meloun-miracle-cz wrote:
with full respect, I don’t think that this is right way. Moreover, I think that you papering over real problem there.
With this patch, what’s happen if someone requests any higher alignment (that actual 16) for TLS data? Or, can patched kernel run the old init (pre r324938)?
After day of digging, I’m still not sure which TLS model mips uses. Mainly which value is expected to be returned by tls_get_tp() function.
It’s clear that mips doesn’t follow Variant I of TLS standard (which require TP pointing to TCB), but it takes relaxed model of this. Something like
“The "thread pointer register" points to some fixed offset from the beginning of the TLS segment. This offset varies by arch“.
If is this true, then my change in libc/gen/tls.h has been significantly incomplete and the arch specific bits need to be implemented.
Nov 19 2017
I don't touch "Summary" because original patch is still good IMHO, but it breaks ABI.
This revision of patch is only kernel change and doesn't break ABI, i.e. buildkernel/installkernel is enough.
Nov 17 2017
On kernel side, we calculate TLS size (td->td_md.md_tls_tcb_offset) in several places used by static & dynamic at same time. So if we roundup2 it, /sbin/init works, but /bin/sh fails.
As of now, I suppose that current fix is the only quick solution :\
Is this needed at all after rS325364? We should now be respecting the alignment of the PT_TLS section. If the PT_TLS section isn't correctly aligned then fixing that is the right answer rather than trashing the ABI.
Nov 9 2017
Oct 30 2017
Few cosmetic style issues...
Oct 21 2017
Oct 20 2017
Oct 16 2017
All is fine, one improvement is possible (gpio_pins for non-fdt case).
Jul 26 2017
Jun 5 2017
May 28 2017
May 2 2017
May 1 2017
Apr 13 2017
Generally speaking, I'm happy with patch. The only thing I worry is CD9660 image (inspired by ZRouter) vs. UFS1 zipped image (inspired by freebsd-wifi-build). This patch is based on CD9660 and it can be committed, but in future it will be nice to support both image types.
Mar 26 2017
Feb 27 2017
@sgalabov , could you please have a look? Thanks!
Feb 10 2017
Of course I like it. More broadcom features. I hope to see ARM BHND support in future :) I'll cross fingers before start rebase
Feb 9 2017
Jan 23 2017
Jan 20 2017
Jan 14 2017
Jan 9 2017
Dec 15 2016
Why delete my added gpio_delay() in gpiospi.c ? My KSZ8995MA code don't work no gpio_delay() on my target. I think current code clock is wrong.
Dec 14 2016
Dec 12 2016
Thanks for your contribution!