I don't see any problems with the new version.
Thu, Feb 13
Wed, Feb 12
I've been using this and noticed no problems with both BIOS and UEFI boot. And now "currdev" matches "loaddev".
Updated for 13-CURRENT.
Tue, Feb 11
I don't notice any problems apart from that minor thing.
Sat, Feb 8
Restored the previous behavior of showing "***" when the number is too large instead of a truncated (and possibly misleading) humanize_number() output. It's not great but it's not worse than it was before.
Fri, Feb 7
Noticed a bug. Some calculations were sometimes being done with 32 bits integers and overflowing.
There are other problems with systat -vmstat as we talked about on IRC. I'm going to create another diff and add you guys as reviewers if you don't mind. I'm sure that this patch is correct after spending more time with it and it's very small so I'll leave it as is to not lose it. The other changes might be more problematic.
Thu, Feb 6
Still had this in my tree, updated for 13-CURRENT.
Wed, Feb 5
Tue, Feb 4
I think this just broke make world because libmemstat needs to be updated for this.
Thu, Jan 30
Forgot to add the new stand/efi/loader/help.efi file. There's no EFI-specific help yet but there could be.
Alright I couldn't let this go. Here's my attempt to fix it correctly with as little changes as possible. This installs a different help file for the EFI and non-EFI loaders.
Jan 13 2020
Dec 30 2019
wrt to the help files being installed multiple times, kevans already figured it out, but just to make it clear, the loader has some architecture specific help files but they also don't work.
Dec 29 2019
Also, I just did a make world to test this patch (even though it's probably not fully correct) and there were no apparent problems apart from loader.help getting installed multiple times (once for all of the loader variants).
Just did a test booting in non-UEFI mode and then loaddev is set the same as currdev here. So the second problem seems to be specific to the EFI loader.
Jul 20 2019
Probably not safe to start trimming the swap device *after* the kernel has been told to start using it for swapping (even if the window is probably small).
Sep 26 2018
Don't mind me, just enjoying my very fast cmp (and wc -l).
Sep 10 2018
Some cleanups, added a wc test case, fixed a cmp test case, fixed some wc logic that made it avoid its (already existing) fast path on STDIN.
Sep 4 2018
Ok. I just read the comment. Apart from the bit twiddling hack the code looks straightforward enough. Maybe it’s not fair to ask this, but it would be comforting if there were regression tests attached to this change.
> If you care about 32 bit performance perhaps have an ifdef LP64 around the type used.
Sep 3 2018
After testing on an old Pentium 4, turns out the line counting algorithm was slower than the naive implementation because operations on 64 bits long longs were slow. Changing it to use 32 bits long makes it faster but only 1.5 times or so faster.