Page MenuHomeFreeBSD
Feed Advanced Search

Thu, Feb 13

sigsys_gmail.com accepted D23597: Respect PATH from login.conf in cron..

I don't see any problems with the new version.

Thu, Feb 13, 6:15 PM

Wed, Feb 12

sigsys_gmail.com accepted D23390: efiloader: don't execute hooks when setting currdev/loaddev.

I've been using this and noticed no problems with both BIOS and UEFI boot. And now "currdev" matches "loaddev".

Wed, Feb 12, 9:29 PM
sigsys_gmail.com updated the diff for D17105: Enhance install(1) -C's handling of hardlinked files.

Updated for 13-CURRENT.

Wed, Feb 12, 6:15 PM

Tue, Feb 11

sigsys_gmail.com accepted D23597: Respect PATH from login.conf in cron..

I don't notice any problems apart from that minor thing.

Tue, Feb 11, 5:15 AM
sigsys_gmail.com added inline comments to D23597: Respect PATH from login.conf in cron..
Tue, Feb 11, 5:06 AM

Sat, Feb 8

sigsys_gmail.com updated the diff for D23575: Fix various issues with systat's -vmstat screen.

Restored the previous behavior of showing "***" when the number is too large instead of a truncated (and possibly misleading) humanize_number() output. It's not great but it's not worse than it was before.

Sat, Feb 8, 5:05 AM

Fri, Feb 7

sigsys_gmail.com updated the diff for D23575: Fix various issues with systat's -vmstat screen.

Noticed a bug. Some calculations were sometimes being done with 32 bits integers and overflowing.

Fri, Feb 7, 9:30 PM
sigsys_gmail.com created D23575: Fix various issues with systat's -vmstat screen.
Fri, Feb 7, 8:01 PM
sigsys_gmail.com added a comment to D23547: systat -vmstat incorrectly formatting rates between certain ranges.

There are other problems with systat -vmstat as we talked about on IRC. I'm going to create another diff and add you guys as reviewers if you don't mind. I'm sure that this patch is correct after spending more time with it and it's very small so I'll leave it as is to not lose it. The other changes might be more problematic.

Fri, Feb 7, 7:58 PM

Thu, Feb 6

sigsys_gmail.com created D23548: daily/200.backup-passwd periodic script not hiding the password field of certain users.
Thu, Feb 6, 10:01 PM
sigsys_gmail.com added inline comments to D23547: systat -vmstat incorrectly formatting rates between certain ranges.
Thu, Feb 6, 9:47 PM
sigsys_gmail.com created D23547: systat -vmstat incorrectly formatting rates between certain ranges.
Thu, Feb 6, 9:46 PM
sigsys_gmail.com updated the diff for D16998: making cmp faster, especially on special files (and speed up wc -l too while at it).

Still had this in my tree, updated for 13-CURRENT.

Thu, Feb 6, 2:49 AM

Wed, Feb 5

sigsys_gmail.com added inline comments to D21481: Make a start at supporting login.conf environment settings.
Wed, Feb 5, 12:42 AM

Tue, Feb 4

sigsys_gmail.com added a comment to D23493: Use a STAILQ instead of a TAILQ to shrink the bucket size by one pointer..

I think this just broke make world because libmemstat needs to be updated for this.

Tue, Feb 4, 4:44 AM

Thu, Jan 30

sigsys_gmail.com updated the diff for D22951: "help" loader command broken.

Forgot to add the new stand/efi/loader/help.efi file. There's no EFI-specific help yet but there could be.

Thu, Jan 30, 7:20 AM
sigsys_gmail.com updated the diff for D22951: "help" loader command broken.

Alright I couldn't let this go. Here's my attempt to fix it correctly with as little changes as possible. This installs a different help file for the EFI and non-EFI loaders.

Thu, Jan 30, 3:40 AM

Jan 13 2020

sigsys_gmail.com created D23154: pipe log destination process limits for syslogd.
Jan 13 2020, 7:05 PM

Dec 30 2019

sigsys_gmail.com added inline comments to D22951: "help" loader command broken.
Dec 30 2019, 4:26 AM
sigsys_gmail.com added inline comments to D22951: "help" loader command broken.
Dec 30 2019, 4:04 AM
sigsys_gmail.com added a comment to D22951: "help" loader command broken.

wrt to the help files being installed multiple times, kevans already figured it out, but just to make it clear, the loader has some architecture specific help files but they also don't work.

Dec 30 2019, 2:34 AM

Dec 29 2019

sigsys_gmail.com added a comment to D22951: "help" loader command broken.

Also, I just did a make world to test this patch (even though it's probably not fully correct) and there were no apparent problems apart from loader.help getting installed multiple times (once for all of the loader variants).

Dec 29 2019, 2:18 AM
sigsys_gmail.com added a comment to D22951: "help" loader command broken.

Just did a test booting in non-UEFI mode and then loaddev is set the same as currdev here. So the second problem seems to be specific to the EFI loader.

Dec 29 2019, 1:25 AM
sigsys_gmail.com created D22951: "help" loader command broken.
Dec 29 2019, 12:37 AM

Jul 20 2019

sigsys_gmail.com added a comment to D21006: swapon before closing trimming fd.

Call swapon(2) after trimming, but before closing the trimming fd.

Jul 20 2019, 7:27 AM
sigsys_gmail.com added a comment to D21006: swapon before closing trimming fd.

Probably not safe to start trimming the swap device *after* the kernel has been told to start using it for swapping (even if the window is probably small).

Jul 20 2019, 4:46 AM

Sep 26 2018

sigsys_gmail.com updated the diff for D16998: making cmp faster, especially on special files (and speed up wc -l too while at it).

Don't mind me, just enjoying my very fast cmp (and wc -l).

Sep 26 2018, 12:30 AM
sigsys_gmail.com created D17325: apply same fix to cp(1) as mv(1) when copying to filesystems that do not support file flags.
Sep 26 2018, 12:26 AM

Sep 10 2018

sigsys_gmail.com updated the diff for D16998: making cmp faster, especially on special files (and speed up wc -l too while at it).

Some cleanups, added a wc test case, fixed a cmp test case, fixed some wc logic that made it avoid its (already existing) fast path on STDIN.

Sep 10 2018, 4:48 PM
sigsys_gmail.com created D17105: Enhance install(1) -C's handling of hardlinked files.
Sep 10 2018, 4:45 PM

Sep 4 2018

sigsys_gmail.com added a comment to D16998: making cmp faster, especially on special files (and speed up wc -l too while at it).

Ok. I just read the comment. Apart from the bit twiddling hack the code looks straightforward enough. Maybe it’s not fair to ask this, but it would be comforting if there were regression tests attached to this change.

Sep 4 2018, 2:25 AM
sigsys_gmail.com added a comment to D16998: making cmp faster, especially on special files (and speed up wc -l too while at it).

> If you care about 32 bit performance perhaps have an ifdef LP64 around the type used.

Sep 4 2018, 1:56 AM

Sep 3 2018

sigsys_gmail.com updated the diff for D16998: making cmp faster, especially on special files (and speed up wc -l too while at it).

After testing on an old Pentium 4, turns out the line counting algorithm was slower than the naive implementation because operations on 64 bits long longs were slow. Changing it to use 32 bits long makes it faster but only 1.5 times or so faster.

Sep 3 2018, 8:46 PM
sigsys_gmail.com created D16998: making cmp faster, especially on special files (and speed up wc -l too while at it).
Sep 3 2018, 4:42 AM