Page MenuHomeFreeBSD
Feed Advanced Search

May 9 2019

ngie committed rS347396: MFC r346578:.
MFC r346578:
May 9 2019, 5:02 PM

May 8 2019

ngie accepted D20186: Add simple regression tests for tree(3)..

seemslegit

May 8 2019, 11:31 PM
ngie created Image Macro "seemslegit".
May 8 2019, 11:31 PM
ngie created Image Macro "byefelicia".
May 8 2019, 11:30 PM

May 7 2019

ngie added a comment to D20092: [new port] devel/linux-ltp: Linux Test Project (openSUSE Leap 42.3).
In D20092#433990, @ngie wrote:

This looks good to me (not a ports committer though, so just reviewing the change).
As a volunteer/co-maintainer on the LTP project, your suggestions make sense.
The only thing that I would do is install LTP to /compat/linux/opt, if at all possible. If not, we can come up with a better way to build/relocate LTP (I wrote the current build system about a decade ago for the project).

But it does install to /compat/linux/opt - except for the documentation (where it follows Linux conventions) and two binaries - not sure what's going on with those two.

May 7 2019, 3:48 PM
ngie accepted D19908: Provide accounting of user-wired pages..

The user space and test changes all look great. I’ll defer to someone else (like kib@) about the VM changes.

May 7 2019, 12:49 AM

May 4 2019

ngie committed rS347076: MFhead@r347075.
MFhead@r347075
May 4 2019, 2:11 AM
ngie committed rS347075: Fix `clang -Wcast-qual` issues.
Fix `clang -Wcast-qual` issues
May 4 2019, 2:09 AM
ngie edited P257 Masterwork From Distant Lands.
May 4 2019, 1:50 AM

May 3 2019

ngie added a comment to D20005: Fix sys.kern.coredump_phnum_test.coredump_phnum on i386.
In D20005#430003, @cem wrote:

It's not a static number, AFAICT, depending on how the kernel maps libraries or waves hands does stuff with virtual memory. Hence the sloppy 66xxx match. I think @lwhsu's proposal is something like atf_check [ "$num" -gt 65535 ], which verifies that the number exceeds the lower 16 bit limit (which is the coredump feature the regression test is attempting to verify).

May 3 2019, 10:23 PM
ngie accepted D20092: [new port] devel/linux-ltp: Linux Test Project (openSUSE Leap 42.3).

This looks good to me (not a ports committer though, so just reviewing the change).

May 3 2019, 9:20 PM

May 2 2019

ngie edited P256 Masterwork From Distant Lands.
May 2 2019, 3:13 PM
ngie committed rS347018: Guard against cases where GCNOS would be empty, resulting in failed builds.
Guard against cases where GCNOS would be empty, resulting in failed builds
May 2 2019, 2:40 PM
ngie committed rS347014: Don't try building coverage binaries with crunchgen.
Don't try building coverage binaries with crunchgen
May 2 2019, 4:16 AM
ngie committed rS347011: Compile lib/libclang_rt/profile if MK_CLANG == no.
Compile lib/libclang_rt/profile if MK_CLANG == no
May 2 2019, 2:08 AM

May 1 2019

ngie added a comment to D20124: Mention atf(7) in tests(7).
In D20124#433272, @ngie wrote:

I’m a bit ambivalent about this change, because it’s up on the wiki in greater detail: https://wiki.freebsd.org/TestingFreeBSD . kyua(1) references atf(7) IIRC, but it’s a level of indirection.
My point is, I’d personally prefer not mentioning just ATF in tests(7), but I want it to be enough of a living document where multiple sources can contribute to it, but mentioning the wiki page doesn’t seem like something that’s generally done from a manpage because the location and content in a wiki page can change.

May 1 2019, 9:48 PM
ngie added a comment to D20124: Mention atf(7) in tests(7).

I’m a bit ambivalent about this change, because it’s up on the wiki in greater detail: https://wiki.freebsd.org/TestingFreeBSD . kyua(1) references atf(7) IIRC, but it’s a level of indirection.

May 1 2019, 8:50 PM
ngie accepted D20125: Add MLINKS to atf-c.3.

Macro thankyou_dog:

May 1 2019, 1:20 PM

Apr 30 2019

ngie accepted D20111: directory.3: add a STANDARDS section.

lgtm

Apr 30 2019, 6:31 PM

Apr 29 2019

ngie committed rS346936: MFC r345351:.
MFC r345351:
Apr 29 2019, 11:07 PM
ngie committed rS346927: MFC r345351:.
MFC r345351:
Apr 29 2019, 8:53 PM
ngie committed rS346926: MFhead@r346925.
MFhead@r346925
Apr 29 2019, 8:22 PM
ngie committed rS346925: MFhead@r346924.
MFhead@r346924
Apr 29 2019, 8:19 PM
ngie committed rS346924: Pass `MK_COVERAGE_SUPPORT` from _libraries instead of libraries.
Pass `MK_COVERAGE_SUPPORT` from _libraries instead of libraries
Apr 29 2019, 8:18 PM
ngie resigned from D20092: [new port] devel/linux-ltp: Linux Test Project (openSUSE Leap 42.3).

I'm ok with the changes, but there are some kinks that should probably be worked out before committing this.

Apr 29 2019, 8:04 PM
ngie committed rS346920: MFC r346571,r346572:.
MFC r346571,r346572:
Apr 29 2019, 7:36 PM
ngie committed rS346919: MFC r345723:.
MFC r345723:
Apr 29 2019, 7:35 PM
ngie committed rS346918: MFC r346571,r346572:.
MFC r346571,r346572:
Apr 29 2019, 7:34 PM
ngie committed rS346917: MFC r345723:.
MFC r345723:
Apr 29 2019, 7:32 PM
ngie committed rS346912: MFC r346539:.
MFC r346539:
Apr 29 2019, 7:12 PM
ngie committed rS346911: MFC r346539:.
MFC r346539:
Apr 29 2019, 7:12 PM
ngie committed rS346909: MFC r346542:.
MFC r346542:
Apr 29 2019, 7:10 PM
ngie committed rS346904: Update/reformat maintainer entries that I am a part of.
Update/reformat maintainer entries that I am a part of
Apr 29 2019, 6:49 PM

Apr 28 2019

ngie accepted D20078: fsx: seed more randomly with the -S0 option.

thankyou_dog

Apr 28 2019, 5:24 PM
ngie created Image Macro "thankyou_dog".
Apr 28 2019, 5:24 PM
ngie requested changes to D20092: [new port] devel/linux-ltp: Linux Test Project (openSUSE Leap 42.3).

I don't think benchmarks is an appropriate category. LTP consists primarily of functional and crash tests.

Apr 28 2019, 5:11 PM
ngie accepted D20078: fsx: seed more randomly with the -S0 option.

This change is very reasonable.

Apr 28 2019, 5:09 PM
ngie committed rS346809: Fix "make universe" pathing by adding a missing tmp path component.
Fix "make universe" pathing by adding a missing tmp path component
Apr 28 2019, 9:41 AM
ngie committed rS346801: MFhead@r346800.
MFhead@r346800
Apr 28 2019, 2:27 AM
ngie committed rS346800: Handle installing the coverage libraries to the directory used by.
Handle installing the coverage libraries to the directory used by
Apr 28 2019, 2:24 AM

Apr 26 2019

ngie committed rS346738: Make --coverage work by building the coverage libraries for the toolchain prior….
Make --coverage work by building the coverage libraries for the toolchain prior…
Apr 26 2019, 11:29 AM
ngie committed rS346736: Revert -target -> -target= change from r346732.
Revert -target -> -target= change from r346732
Apr 26 2019, 9:06 AM
ngie committed rS346735: Fix another typo from r346732 (lib/clang_rt/profile -> lib/libclang_rt/profile).
Fix another typo from r346732 (lib/clang_rt/profile -> lib/libclang_rt/profile)
Apr 26 2019, 9:03 AM
ngie committed rS346734: Use CROSSENV when building `_coverage_libs` instead of just a part of CFLAGS.
Use CROSSENV when building `_coverage_libs` instead of just a part of CFLAGS
Apr 26 2019, 8:16 AM
ngie committed rS346733: Fix typo introduced in r346732 (.endif -> .endfor).
Fix typo introduced in r346732 (.endif -> .endfor)
Apr 26 2019, 8:03 AM
ngie committed rS346732: Retry building lib/libclang_rt/profile for buildworld.
Retry building lib/libclang_rt/profile for buildworld
Apr 26 2019, 7:43 AM
ngie committed rS346731: MFhead@r346730.
MFhead@r346730
Apr 26 2019, 6:59 AM

Apr 25 2019

ngie committed rS346711: MFC r346056:.
MFC r346056:
Apr 25 2019, 9:42 PM

Apr 24 2019

ngie abandoned D20017: Expect *localsctp* to fail.

Abandoning review based on in-depth analysis from @tuexen.

Apr 24 2019, 1:27 PM
ngie committed rS346627: Use `range` instead of `xrange`.
Use `range` instead of `xrange`
Apr 24 2019, 5:52 AM
ngie committed rS346626: Fix typo: `Plen` should be `plen`.
Fix typo: `Plen` should be `plen`
Apr 24 2019, 5:50 AM
ngie committed rS346625: Don't leak `fd` when manipulating the device via `_getdev()`.
Don't leak `fd` when manipulating the device via `_getdev()`
Apr 24 2019, 5:47 AM
ngie committed rS346623: Chase PEP-3110.
Chase PEP-3110
Apr 24 2019, 4:50 AM
ngie committed rS346622: except EnvironmentError, e -> except EnvironmentError as e for py3 compat.
except EnvironmentError, e -> except EnvironmentError as e for py3 compat
Apr 24 2019, 4:45 AM
ngie committed rS346621: MFhead@r346620.
MFhead@r346620
Apr 24 2019, 4:44 AM
ngie committed rS346620: Reapply whitespace style changes from r346443 after recent changes to….
Reapply whitespace style changes from r346443 after recent changes to…
Apr 24 2019, 4:40 AM
ngie added a comment to D20017: Expect *localsctp* to fail.

ncat is from nmap port and has nothing to do with nc, their names are similar but they are different things.
It's fine to install tests requirements from ports, after all, kyua is installed from ports and it's an essential tool for running the tests.
For marking the tests, what I was saying is "skip the tests (and not report failure) when there is no nmap (ncat) installed, and have a message to users to install nmap."

Apr 24 2019, 1:17 AM

Apr 23 2019

ngie added a comment to D20017: Expect *localsctp* to fail.

OK, I just check we have nmap in the test vm image and it does the work: https://github.com/freebsd/freebsd-ci/commit/689e19c8c71e1892f476c9ef9392f6b443d0ed15
The other failures are due to some perl stuff which I haven't had time on it: https://ci.freebsd.org/job/FreeBSD-head-amd64-dtrace_test/lastCompletedBuild/testReport/common.ip/t_dtrace_contrib/tst_ipv4localsctp_ksh/

I'm debugging this now. Seems to be a kernel issue. Will let you know once I have understood and fixed the issue.
Is using ncat and issue?

Apr 23 2019, 10:48 PM
ngie added a comment to D20017: Expect *localsctp* to fail.

I'd prefer let's fix these test cases.

Apr 23 2019, 10:47 PM
ngie updated the summary of D20017: Expect *localsctp* to fail.
Apr 23 2019, 10:45 PM
ngie committed rS346613: Don't forget sys import!.
Don't forget sys import!
Apr 23 2019, 10:43 PM
ngie committed rS346612: Ugh. Deal with encoding/decoding UTF-8 strings to bytes as needed.
Ugh. Deal with encoding/decoding UTF-8 strings to bytes as needed
Apr 23 2019, 10:43 PM
ngie committed rS346611: Chase more needed `.{de,en}code()` -> `binascii.(un)?hexlify` changes.
Chase more needed `.{de,en}code()` -> `binascii.(un)?hexlify` changes
Apr 23 2019, 10:40 PM
ngie committed rS346610: KATParser: don't leak `self.fp`.
KATParser: don't leak `self.fp`
Apr 23 2019, 10:38 PM
ngie added inline comments to D19978: Test the AES-CCM test vectors from the NIST Known Answer Tests..
Apr 23 2019, 10:25 PM
ngie accepted D19978: Test the AES-CCM test vectors from the NIST Known Answer Tests..

Ok, let's proceed with this change. I'll work on fixing the style issues on my branch.

Apr 23 2019, 10:24 PM
ngie accepted D19958: Skip test component_selection:run_latest_genid if gmirror/gnop GEOM classes aren't available.

@olivier: Approved! Please be sure to update the commit message before you commit. Thank you so very much <3!

Apr 23 2019, 7:59 PM
ngie retitled D19958: Skip test component_selection:run_latest_genid if gmirror/gnop GEOM classes aren't available from Skip test component_selection:run_latest_genid if gmirror/gnop GEOMclasses aren't available to Skip test component_selection:run_latest_genid if gmirror/gnop GEOM classes aren't available.
Apr 23 2019, 7:58 PM
ngie added inline comments to D19958: Skip test component_selection:run_latest_genid if gmirror/gnop GEOM classes aren't available.
Apr 23 2019, 2:49 PM
ngie requested changes to D19958: Skip test component_selection:run_latest_genid if gmirror/gnop GEOM classes aren't available.
Apr 23 2019, 2:47 PM

Apr 22 2019

ngie committed rP499695: Backport patch to fix error check with access(3) failures.
Backport patch to fix error check with access(3) failures
Apr 22 2019, 11:34 PM
ngie closed D20002: Backport patch to fix error check with access(3) failures.
Apr 22 2019, 11:34 PM
ngie updated the test plan for D20017: Expect *localsctp* to fail.
Apr 22 2019, 10:33 PM
ngie created D20017: Expect *localsctp* to fail.
Apr 22 2019, 10:28 PM
ngie committed rS346585: Remove a superfluous `)`.
Remove a superfluous `)`
Apr 22 2019, 9:28 PM
ngie committed rS346584: Update the comment above the coverage COMPILER_FEATURES test.
Update the comment above the coverage COMPILER_FEATURES test
Apr 22 2019, 9:26 PM
ngie committed rS346583: Add `coverage` to *COMPILER_FEATURES variable to bsd.compiler.mk and test for it.
Add `coverage` to *COMPILER_FEATURES variable to bsd.compiler.mk and test for it
Apr 22 2019, 9:24 PM
ngie closed D19895: Fix up CXXSTD support, added in r345708.

Committed as rS346574 and rS346576.

Apr 22 2019, 7:58 PM
ngie committed rS346578: Build libclang_rt/profile on all clang-supported architectures.
Build libclang_rt/profile on all clang-supported architectures
Apr 22 2019, 7:21 PM
ngie closed D20003: Build libclang_rt/profile on all clang-supported architectures.
Apr 22 2019, 7:21 PM
ngie updated the diff for D20003: Build libclang_rt/profile on all clang-supported architectures.

Move the SUBDIR+= profile outside the architecture dependent blocks

Apr 22 2019, 7:18 PM
ngie committed rS346577: Prune branch, merged as r346574 and r346576.
Prune branch, merged as r346574 and r346576
Apr 22 2019, 7:03 PM
ngie committed rS346576: Fix up CXXSTD support originally added in r345708.
Fix up CXXSTD support originally added in r345708
Apr 22 2019, 6:40 PM
ngie committed rS346574: Rework CXXSTD setting via r345708.
Rework CXXSTD setting via r345708
Apr 22 2019, 6:39 PM
ngie committed rS346572: Update the spelling of my name (continuation of r346571).
Update the spelling of my name (continuation of r346571)
Apr 22 2019, 6:05 PM
ngie committed rS346571: Update the spelling of my name.
Update the spelling of my name
Apr 22 2019, 5:52 PM
ngie committed rS346542: Fix sys.kern.coredump_phnum_test.coredump_phnum on i386.
Fix sys.kern.coredump_phnum_test.coredump_phnum on i386
Apr 22 2019, 11:21 AM
ngie closed D20005: Fix sys.kern.coredump_phnum_test.coredump_phnum on i386.
Apr 22 2019, 11:21 AM
ngie added a comment to D20005: Fix sys.kern.coredump_phnum_test.coredump_phnum on i386.

Thanks for the better fix. BTW, I still think these checks would be better to be rewritten as getting the real number and compare with 65535.

Apr 22 2019, 11:17 AM
ngie committed rS346539: Fix `get_int_via_sysctlbyname(..)` on Jenkins.
Fix `get_int_via_sysctlbyname(..)` on Jenkins
Apr 22 2019, 11:09 AM
ngie added a comment to D18495: Fix sys.kern.coredump_phnum_test.coredump_phnum on i386.

I've proposed a different solution in D20005.

Apr 22 2019, 10:15 AM
ngie created D20005: Fix sys.kern.coredump_phnum_test.coredump_phnum on i386.
Apr 22 2019, 10:14 AM
ngie committed rS346536: MFC r339473,r340075,r342918,r343592,r343593,r343614,r343665,r343669:.
MFC r339473,r340075,r342918,r343592,r343593,r343614,r343665,r343669:
Apr 22 2019, 8:59 AM
ngie committed rS346534: Switch the conditional to only disable COVERAGE/COVERAGE_SUPPORT when not….
Switch the conditional to only disable COVERAGE/COVERAGE_SUPPORT when not…
Apr 22 2019, 8:22 AM
ngie committed rS346533: Rely on the MACHINE_CPUARCH, etc logic in lib/libclang_rt.
Rely on the MACHINE_CPUARCH, etc logic in lib/libclang_rt
Apr 22 2019, 8:02 AM
ngie committed rS346532: Really compile profile/ on all clang-supported arches.
Really compile profile/ on all clang-supported arches
Apr 22 2019, 7:59 AM
ngie planned changes to D20003: Build libclang_rt/profile on all clang-supported architectures.

This moved SUBDIR+= profile inside another .if block :/...

Apr 22 2019, 7:56 AM
ngie committed rS346531: Only try building lib/libclang_rt/profile if MK_CLANG != no.
Only try building lib/libclang_rt/profile if MK_CLANG != no
Apr 22 2019, 7:33 AM
ngie committed rS346529: Import patch from D19895 for reworking how CXXSTD is handled.
Import patch from D19895 for reworking how CXXSTD is handled
Apr 22 2019, 7:17 AM
ngie committed rS346528: Revert r346527.
Revert r346527
Apr 22 2019, 7:13 AM