Sidenote: given that it's been over 2 weeks since you put this out for review, I think you can put in Approved by: jmg (maintainer timeout) and commit the change.

Requesting changes because there are a handful of non-style nits that should be resolved before this is committed to ^/head .

LGTM! Please commit this change to ^/head.

Fix accidental diff update in last revision

That's not what I wanted to do >_>...

Update the comment

In D19906#427977, @asomers wrote:

That's a lot of tiny files! Would it be possible and desirable to reduce the file count by using here documents or something?

I reworded the commit message/review name. Please use -g, not -d.

Try again with a patched libcurl

Let's try triggering the issue in bug 233177 again

Sort the Makefile variables per style.Makefile(9)

Remove bogus (unsigned) cast with call to MIN().

In D19854#426171, @asomers wrote:

I don't know why you added a blank line at 179, but otherwise LGTM.

In D19854#426189, @pjd wrote:

Do you mind elaborating why cleaning up like that is wrong? The reason I did it was to avoid creating multiple md devices. Here we only have 8 iterations of the loop, but I could easly imagine tests were I'd have hundreds and cleaning as I go would be a good thing then, IMHO. But maybe I'm missing something obvious here, so if you could explain that would be great. Thanks.

PS. The patch is fine.

Add forgotten Makefile.inc

LGTM!