Page MenuHomeFreeBSD
Feed Advanced Search

Jun 21 2021

luporl requested review of D30843: aacraid: ignore data overrun on INQUIRY.
Jun 21 2021, 2:41 PM

Jun 17 2021

luporl added reviewers for D30799: aacraid: log DMA failures: jhibbits, scottl, emaste.
Jun 17 2021, 1:14 PM
luporl added reviewers for D30798: aacraid: reduce max I/O size to avoid DMA issues: jhibbits, scottl, emaste.
Jun 17 2021, 1:14 PM
luporl updated the summary of D30798: aacraid: reduce max I/O size to avoid DMA issues.
Jun 17 2021, 1:13 PM
luporl requested review of D30799: aacraid: log DMA failures.
Jun 17 2021, 12:50 PM
luporl requested review of D30798: aacraid: reduce max I/O size to avoid DMA issues.
Jun 17 2021, 12:11 PM
luporl requested review of D30797: powerpc64: make radix with superpages default.
Jun 17 2021, 11:20 AM · PowerPC

Jun 2 2021

luporl committed rG4a66b8083cc6: powerpc: fix boot on pseries without hugepages (authored by luporl).
powerpc: fix boot on pseries without hugepages
Jun 2 2021, 7:29 PM

May 14 2021

luporl accepted D29809: Make ISA_206_ATOMICS a kernel option.
May 14 2021, 12:01 PM

May 10 2021

luporl added inline comments to D29000: Export RGB offsets with FBIO_GETRGBOFFS.
May 10 2021, 7:25 PM · PowerPC

May 5 2021

luporl accepted D30071: powerpc64: Split out DMAP and non-DMAP implementations of some methods.

LGTM. The code is also easier to read now, without those hw_direct_map conditionals.

May 5 2021, 12:16 PM

Apr 22 2021

luporl committed rG019cdd20bbd3: powerpc64: add missing TLB invalidations to radix (authored by luporl).
powerpc64: add missing TLB invalidations to radix
Apr 22 2021, 2:32 PM
luporl committed rGf05174ed3547: powerpc64: clear low-order bits of ARPN (authored by luporl).
powerpc64: clear low-order bits of ARPN
Apr 22 2021, 2:31 PM

Apr 20 2021

luporl accepted D26040: Fix mprutil endianness.
Apr 20 2021, 7:22 PM · PowerPC

Apr 16 2021

luporl accepted D29063: [POWERPC] opal_console: fix serial console output corruption.
Apr 16 2021, 2:32 PM · PowerPC

Apr 9 2021

luporl added inline comments to D29063: [POWERPC] opal_console: fix serial console output corruption.
Apr 9 2021, 12:09 PM · PowerPC

Apr 6 2021

luporl committed rG32b50b8520d0: powerpc64: support superpages on pmap_mincore (authored by luporl).
powerpc64: support superpages on pmap_mincore
Apr 6 2021, 11:49 AM
luporl closed D29511: powerpc64: add missing TLB invalidations to radix.
Apr 6 2021, 11:43 AM · PowerPC
luporl committed rG28d14569c873: powerpc64: add missing TLB invalidations to radix (authored by luporl).
powerpc64: add missing TLB invalidations to radix
Apr 6 2021, 11:43 AM
luporl committed rG1805ce694542: powerpc64: enforce natural alignment in bcopy (authored by luporl).
powerpc64: enforce natural alignment in bcopy
Apr 6 2021, 11:30 AM
luporl committed rGe21b6ce854f2: [PowerPC64] Port optimized strcpy to PPC64LE (authored by luporl).
[PowerPC64] Port optimized strcpy to PPC64LE
Apr 6 2021, 11:28 AM

Apr 5 2021

luporl updated the diff for D29511: powerpc64: add missing TLB invalidations to radix.

Address jhibbits' comments

Apr 5 2021, 6:00 PM · PowerPC

Mar 31 2021

luporl added reviewers for D29511: powerpc64: add missing TLB invalidations to radix: bdragon, jhibbits, PowerPC.
Mar 31 2021, 12:13 PM · PowerPC
luporl requested review of D29511: powerpc64: add missing TLB invalidations to radix.
Mar 31 2021, 12:12 PM · PowerPC

Mar 30 2021

luporl committed rG75e67b4920f2: powerpc64: support superpages on pmap_mincore (authored by luporl).
powerpc64: support superpages on pmap_mincore
Mar 30 2021, 7:14 PM
luporl closed D29230: Add support for superpages - pmap_mincore [powerpc64].
Mar 30 2021, 7:13 PM · PowerPC

Mar 25 2021

luporl committed rG3d0399c718b2: [PowerPC64] Clear low-order bits of ARPN (authored by luporl).
[PowerPC64] Clear low-order bits of ARPN
Mar 25 2021, 5:06 PM
luporl closed D29067: powerpc64le: port optimized strcpy for LE version of processor.
Mar 25 2021, 4:21 PM · PowerPC
luporl committed rG9f50aa45be18: [PowerPC64] Port optimized strcpy to PPC64LE (authored by luporl).
[PowerPC64] Port optimized strcpy to PPC64LE
Mar 25 2021, 4:21 PM
luporl committed rG2f561284033c: [PowerPC64] Enforce natural alignment in bcopy (authored by luporl).
[PowerPC64] Enforce natural alignment in bcopy
Mar 25 2021, 4:12 PM
luporl closed D28776: powerpc/powerpc64: Enforce natural alignment in bcopy.
Mar 25 2021, 4:11 PM · PowerPC

Mar 24 2021

luporl accepted D29230: Add support for superpages - pmap_mincore [powerpc64].

LGTM

Mar 24 2021, 11:39 AM · PowerPC

Mar 22 2021

luporl committed rG3aa6cc000f74: ofwfb: fix boot on LE (authored by luporl).
ofwfb: fix boot on LE
Mar 22 2021, 1:53 PM

Mar 9 2021

luporl committed rG043577b721ec: ofwfb: fix boot on LE (authored by luporl).
ofwfb: fix boot on LE
Mar 9 2021, 4:44 PM
luporl closed D27475: ofwfb: fix boot on LE.
Mar 9 2021, 4:43 PM · PowerPC
luporl accepted D29067: powerpc64le: port optimized strcpy for LE version of processor.

LGTM.

Mar 9 2021, 11:48 AM · PowerPC

Mar 8 2021

luporl updated the diff for D27475: ofwfb: fix boot on LE.

Rebased.

Mar 8 2021, 6:37 PM · PowerPC
luporl added inline comments to D29067: powerpc64le: port optimized strcpy for LE version of processor.
Mar 8 2021, 6:00 PM · PowerPC
luporl added a comment to D29063: [POWERPC] opal_console: fix serial console output corruption.

Your changes look good to me overall.

Mar 8 2021, 5:45 PM · PowerPC

Mar 1 2021

luporl added reviewers for D29000: Export RGB offsets with FBIO_GETRGBOFFS: alfredo, bdragon, jhibbits, nwhitehorn.
Mar 1 2021, 6:27 PM · PowerPC
luporl requested review of D29000: Export RGB offsets with FBIO_GETRGBOFFS.
Mar 1 2021, 6:22 PM · PowerPC

Feb 24 2021

luporl added inline comments to D27475: ofwfb: fix boot on LE.
Feb 24 2021, 7:49 PM · PowerPC
luporl accepted D28776: powerpc/powerpc64: Enforce natural alignment in bcopy.

It looks great now! Since this changes core libc functions, can you perform a buildworld on a system with the modified libc installed to confirm everything works fine?

Feb 24 2021, 12:36 PM · PowerPC

Feb 22 2021

luporl added a comment to D28776: powerpc/powerpc64: Enforce natural alignment in bcopy.

@bruno.larsen_eldorado.org.br, overall your changes look good to me.
I have only one more suggestion and some nitpicks.

Feb 22 2021, 6:37 PM · PowerPC
luporl added a comment to D28776: powerpc/powerpc64: Enforce natural alignment in bcopy.
  • improved formatting
  • solution to the problem outlined by luporl

The alignment problem is solved, but this patch makes bcopy performance go down by a factor of 10. I think a third version of the code should be considered, restricting this patch only to POWER7 CPUs.

Does it produce any gain over original non-optimized code on Power7? If there's no gain I'd suggest restrict optimizations to ISA >= v.2.07 (POWER8). And in this case, remove unaligned access handling since newer CPUs can handle it transparently.

If there's still a gain I agree with having two optimized versions one handling VSX & ISA <=2.06 and the other for VSX & ISA >=2.07 (probably removing unaligned handling to make code simpler if no negative performance impact)

Feb 22 2021, 5:02 PM · PowerPC

Feb 19 2021

luporl accepted D28604: ofwfb: fix incorrect colors on powerpc*, add new tunable parameters.

Worked fine on PPC64LE, both on Talos and QEMU, with D27475 to fix boot with ofwfb on LE.

Feb 19 2021, 12:02 PM · PowerPC

Feb 18 2021

luporl added inline comments to D27475: ofwfb: fix boot on LE.
Feb 18 2021, 9:07 PM · PowerPC
luporl added inline comments to D28776: powerpc/powerpc64: Enforce natural alignment in bcopy.
Feb 18 2021, 7:14 PM · PowerPC
luporl added inline comments to D27475: ofwfb: fix boot on LE.
Feb 18 2021, 5:50 PM · PowerPC

Feb 12 2021

luporl added a comment to D28604: ofwfb: fix incorrect colors on powerpc*, add new tunable parameters.

Looks good. I have been using a slightly modified version of this on Talos II and it is working well.

Feb 12 2021, 12:44 PM · PowerPC

Feb 5 2021

luporl added a comment to D28494: mrsas: unbreak i386 build.

Using only htole64() won't work in all cases.

Feb 5 2021, 4:30 PM

Dec 4 2020

luporl requested review of D27475: ofwfb: fix boot on LE.
Dec 4 2020, 2:56 PM · PowerPC

Nov 25 2020

luporl accepted D26531: mrsas: Add big-endian support.
Nov 25 2020, 7:36 PM · PowerPC

Nov 17 2020

luporl closed D27156: [PowerPC] Don't overwrite vm.pmap sysctl node.
Nov 17 2020, 11:36 AM · PowerPC
luporl committed rS367758: [PowerPC] Don't overwrite vm.pmap sysctl node.
[PowerPC] Don't overwrite vm.pmap sysctl node
Nov 17 2020, 11:36 AM

Nov 16 2020

luporl added a comment to D26531: mrsas: Add big-endian support.

The changes look good to me overall.

Nov 16 2020, 6:10 PM · PowerPC
luporl updated the diff for D27156: [PowerPC] Don't overwrite vm.pmap sysctl node.

Leave superpages disabled by default

Nov 16 2020, 4:48 PM · PowerPC

Nov 13 2020

luporl accepted D27201: [POWERPC] msun: fix incorrect flag in fesetexceptflag.
Nov 13 2020, 7:54 PM · PowerPC
luporl accepted D27181: [PowerPC64LE] Radix fixes for LE.

Wow, that's really a lot of endianness fixes, nice job!

Nov 13 2020, 2:13 PM · PowerPC

Nov 9 2020

luporl requested review of D27156: [PowerPC] Don't overwrite vm.pmap sysctl node.
Nov 9 2020, 8:31 PM · PowerPC

Nov 6 2020

luporl committed rS367427: Fix powerpc and LINT builds.
Fix powerpc and LINT builds
Nov 6 2020, 6:50 PM
luporl closed D25237: Implement superpages for PowerPC64 (HPT).
Nov 6 2020, 2:13 PM · PowerPC
luporl committed rS367417: Implement superpages for PowerPC64 (HPT).
Implement superpages for PowerPC64 (HPT)
Nov 6 2020, 2:12 PM

Nov 5 2020

luporl committed rS367397: Fix powerpc and powerpcspe builds.
Fix powerpc and powerpcspe builds
Nov 5 2020, 8:18 PM
luporl closed D26114: pmcstat: fix PPC kernel symbol resolution.
Nov 5 2020, 8:10 PM · PowerPC
luporl closed D26113: libpmc: add support for POWER8/9 PMCs.
Nov 5 2020, 8:10 PM
luporl committed rS367392: pmcstat: fix PPC kernel symbol resolution.
pmcstat: fix PPC kernel symbol resolution
Nov 5 2020, 8:10 PM
luporl committed rS367391: libpmc: add support for POWER8/9 PMCs.
libpmc: add support for POWER8/9 PMCs
Nov 5 2020, 8:10 PM
luporl closed D26110: [PowerPC64] hwpmc: add support for POWER8/9 PMCs.
Nov 5 2020, 4:37 PM · PowerPC
luporl committed rS367390: [PowerPC] hwpmc: add support for POWER8/9 PMCs.
[PowerPC] hwpmc: add support for POWER8/9 PMCs
Nov 5 2020, 4:37 PM
luporl closed D26532: [PowerPC] Make PPC 970 PMC SPRs the standard ones.
Nov 5 2020, 2:16 PM · PowerPC
luporl committed rS367383: [PowerPC] Make PPC 970 PMC SPRs the standard ones.
[PowerPC] Make PPC 970 PMC SPRs the standard ones
Nov 5 2020, 2:16 PM
luporl added inline comments to D25237: Implement superpages for PowerPC64 (HPT).
Nov 5 2020, 2:11 PM · PowerPC
luporl updated the diff for D25237: Implement superpages for PowerPC64 (HPT).

Restore comment about tlbie instruction forms

Nov 5 2020, 2:07 PM · PowerPC

Oct 23 2020

luporl updated the diff for D25237: Implement superpages for PowerPC64 (HPT).
  • improve performance
    • force inline in new moea64_pte_* functions to avoid extra overhead with clang -O now defaulting -O1
    • look for superpage PVO in moea64_enter only when superpages are enabled
    • use multiple PV locks for superpage ops, instead of making a single PV lock cover a superpage
Oct 23 2020, 5:11 PM · PowerPC

Sep 23 2020

luporl updated the diff for D26113: libpmc: add support for POWER8/9 PMCs.

Rename ppcpnv/powernv to power8.

Sep 23 2020, 6:19 PM
luporl updated the diff for D26110: [PowerPC64] hwpmc: add support for POWER8/9 PMCs.

This diff has several changes on top of the previous one. The main ones are:

Sep 23 2020, 5:59 PM · PowerPC
luporl requested review of D26532: [PowerPC] Make PPC 970 PMC SPRs the standard ones.
Sep 23 2020, 5:27 PM · PowerPC

Sep 14 2020

luporl added a reviewer for D26110: [PowerPC64] hwpmc: add support for POWER8/9 PMCs: bdragon.
Sep 14 2020, 5:24 PM · PowerPC

Sep 10 2020

luporl added inline comments to D25237: Implement superpages for PowerPC64 (HPT).
Sep 10 2020, 5:46 PM · PowerPC
luporl updated the diff for D25237: Implement superpages for PowerPC64 (HPT).

Fix ERAT multi-hit issue

Sep 10 2020, 5:33 PM · PowerPC

Sep 1 2020

luporl committed rS365033: [PowerPC] Fix PMCLOG address width.
[PowerPC] Fix PMCLOG address width
Sep 1 2020, 11:34 AM
luporl closed D26112: [PowerPC64] Fix PMCLOG address width.
Sep 1 2020, 11:34 AM
luporl closed D26111: [PowerPC] Move pmc_hook out of critical section.
Sep 1 2020, 11:30 AM
luporl committed rS365032: [PowerPC] Move pmc_hook out of critical section.
[PowerPC] Move pmc_hook out of critical section
Sep 1 2020, 11:30 AM

Aug 31 2020

luporl accepted D26234: [PowerPC64LE] Fix Lua 5.2 runtime issue.

Looks good to me.

Aug 31 2020, 4:48 PM · PowerPC

Aug 28 2020

luporl added inline comments to D25237: Implement superpages for PowerPC64 (HPT).
Aug 28 2020, 5:39 PM · PowerPC
luporl updated the diff for D25237: Implement superpages for PowerPC64 (HPT).
  • address (part of) markj's comments
Aug 28 2020, 5:35 PM · PowerPC

Aug 24 2020

luporl added inline comments to D25237: Implement superpages for PowerPC64 (HPT).
Aug 24 2020, 8:17 PM · PowerPC
luporl closed D25651: [PPC] Make new auxv format default.
Aug 24 2020, 1:40 PM · PowerPC
luporl committed rS364675: [PowerPC] Make new auxv format default.
[PowerPC] Make new auxv format default
Aug 24 2020, 1:40 PM

Aug 21 2020

luporl updated the diff for D26114: pmcstat: fix PPC kernel symbol resolution.

Address jhibbits' comments

Aug 21 2020, 5:46 PM · PowerPC
luporl updated the diff for D25651: [PPC] Make new auxv format default.

Address bdragon's comments

Aug 21 2020, 5:33 PM · PowerPC
luporl added a comment to D26114: pmcstat: fix PPC kernel symbol resolution.

Makes sense to me. Is there a good way to test this?

Additionally, I believe this would also be relevant to ppc32, perhaps use the __powerpc__ ifdef instead.

Aug 21 2020, 2:43 PM · PowerPC

Aug 20 2020

luporl added a comment to D26113: libpmc: add support for POWER8/9 PMCs.

One thing we do have is the full power8/9 pmcs in src/lib/libpmc/pmu-events/arch. I think these just need to be hooked up

Aug 20 2020, 2:49 PM
luporl accepted D26040: Fix mprutil endianness.

Looks good to me.

Aug 20 2020, 11:46 AM · PowerPC

Aug 18 2020

luporl requested review of D26114: pmcstat: fix PPC kernel symbol resolution.
Aug 18 2020, 7:26 PM · PowerPC
luporl requested review of D26113: libpmc: add support for POWER8/9 PMCs.
Aug 18 2020, 7:08 PM
luporl requested review of D26112: [PowerPC64] Fix PMCLOG address width.
Aug 18 2020, 7:00 PM
luporl requested review of D26111: [PowerPC] Move pmc_hook out of critical section.
Aug 18 2020, 6:37 PM