_atomic_subword.h LGTM.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Jan 27 2020
Jan 25 2020
Jan 24 2020
Try to clean up size selection loop. Does this seem more clear, or
still obscure?
Jan 23 2020
Looks good. Thanks. I applied this patch and rebooted about ten times and saw no issues (previous frequency for me was maybe 1/3).
Jan 22 2020
In D23318#511196, @jeff wrote:mea culpa. Can you commit to 12.x as well?
Jan 20 2020
Jan 18 2020
review feedback: leave pmap_pdpt_allocf alone, just tag the zone.
Review feedback: man page and comment wording. Also s/0x%#b/0x%b/.
Jan 17 2020
Yes, that's right. In fact, the smaller mbufs are actually still okay with multipage slabs due to their power-of-2 size, but I thought it was better to make the constraint explicit.
Jan 14 2020
Jan 13 2020
markj feedback: style(9)
missed one, and messed one up
markj feedback, don't print threads
Jan 12 2020
Jan 9 2020
In D22963#506510, @cem wrote:I don't think expecting misaligned atomics to work is reasonable. We could KASSERT alignment? Asking for 2-byte alignment isn't asking much.
I only looked at _atomic_subword.h.
Jan 8 2020
Looks good. Did this fix the bus-sc accounting?
jeff feedback, s/ipers_nohdr/ipers_offpage/ too
forgot jeff feedback s/eff_nohdr/eff_offpage/
jeff & markj feedback
Code looks good.
Jan 6 2020
@jeff Will do for the rest of the comments. A couple clarifying questions.
Jeff asked that the old code be left in place for posting the diff, for readability of the diff. The #ifdef 0 code will be deleted before commit.
Jan 4 2020
Latest revision LGTM.
Jan 3 2020
Dec 30 2019
This one blames to 1998, so I guess it was legit :)
Dec 25 2019
Here's what changing it to no-error for the clang build does (amd64):
Dec 24 2019
Looks good, after fixing up the keg_alloc_slab comment and the keg_dtor printf format.
Rebase LGTM.
Looks good but I do have a question about how uma_zone_reserve() is supposed to work now.
Looks good. Recommend building at least INVARIANTS and non-INVARIANTS kernels before commit.
Dec 23 2019
Fixups look good. I agree with leaving an XXX and coming back later to the problem of transitioning between no-limit and limit.
Generally looking good, but I do have a few more comments.
Dec 22 2019
Fixups look good.
Fixups look good.
Dec 21 2019
I can prepare a follow up. What I did here was exactly what we already do for clang. I will change both. And then I assume you'd have the same comment for the user build?
Dec 20 2019
In D22876#501221, @jhb wrote:Maybe include share/mk/bsd.sys.mk at the same time as userland needs it as well (at least it did for me)?
In D22888#501195, @imp wrote:So it worked! Yippy! Of course I'd love you to commit this :)
imp's suggestion
Ah. Yes. I'll check if that builds. Thanks.
A non-intrusive Makefile solution could be to lower camcontrol's WARNS to 3, either unconditionally or conditional on gcc.
In D22888#501055, @imp wrote:It is actually properly aligned. Let's not do silly crap like this. Let's say it really is properly aligned.