Jul 30 2015
Jul 29 2015
Jul 28 2015
Jul 2 2015
Jul 1 2015
Jun 30 2015
What about svnlite in base?
Jun 19 2015
Jun 16 2015
Jun 12 2015
I haven't reviewed the patch, but the hot patching was a nice idea. However, if it hasn't been implemented until now...
Jun 11 2015
Please commit this fix.
Jun 10 2015
Jun 2 2015
May 29 2015
May 26 2015
May 25 2015
May 23 2015
May 20 2015
May 16 2015
May 14 2015
May 13 2015
May 10 2015
May 6 2015
Only minor comments.
May 5 2015
If you really must, go ahead and commit this patch, but please understand this code was never compiled in FreeBSD.
Apr 25 2015
Apr 18 2015
Apr 11 2015
I agree with Warner that it would be nice to keep the 'cd boot/foo && make' compatibility without requiring buildenv.
Apr 6 2015
Apr 4 2015
Apr 2 2015
===> License BSD3CLAUSE accepted by the user
===> dump1090_mr-1.15 depends on file: /usr/local/sbin/pkg - found
=> dump1090_mr-v1.15_GH0.tar.gz doesn't seem to exist in /usr/ports/distfiles/.
=> Attempting to fetch https://codeload.github.com/flightaware/dump1090_mr/tar.gz/v1.15?dummy=/dump1090_mr-v1.15_GH0.tar.gz
dump1090_mr-v1.15_GH0.tar.gz 0 B 0 Bps
===> Fetching all distfiles required by dump1090_mr-1.15 for building
===> Extracting for dump1090_mr-1.15
=> SHA256 Checksum OK for dump1090_mr-v1.15_GH0.tar.gz.
===> Patching for dump1090_mr-1.15
===> Applying FreeBSD patches for dump1090_mr-1.15
===> dump1090_mr-1.15 depends on executable: gmake - found
===> dump1090_mr-1.15 depends on shared library: librtlsdr.so - found (/usr/local/lib/librtlsdr.so.0.0.5)
===> Configuring for dump1090_mr-1.15
===> Building for dump1090_mr-1.15
gmake[1]: Entering directory '/home/rpaulo/svn/ports/head/comms/dump1090_mr/work/dump1090_mr-1.15'
gmake[1]: Nothing to be done for 'Makefile'.
cc -O2 -pipe -fstack-protector -fno-strict-aliasing `pkg-config --cflags librtlsdr` -DHTMLPATH=\"/usr/local/share/dump1090/public_html\" -c dump1090.c
cc -O2 -pipe -fstack-protector -fno-strict-aliasing `pkg-config --cflags librtlsdr` -DHTMLPATH=\"/usr/local/share/dump1090/public_html\" -c anet.c
In file included from dump1090.c:31:
In file included from ./dump1090.h:54:
/usr/include/sys/timeb.h:42:2: warning: "this file includes <sys/timeb.h> which is deprecated" [-W#warnings]
#warning "this file includes <sys/timeb.h> which is deprecated"
^
cc -O2 -pipe -fstack-protector -fno-strict-aliasing `pkg-config --cflags librtlsdr` -DHTMLPATH=\"/usr/local/share/dump1090/public_html\" -c interactive.c
In file included from interactive.c:31:
In file included from ./dump1090.h:54:
/usr/include/sys/timeb.h:42:2: warning: "this file includes <sys/timeb.h> which is deprecated" [-W#warnings]
#warning "this file includes <sys/timeb.h> which is deprecated"
^
1 warning generated.
cc -O2 -pipe -fstack-protector -fno-strict-aliasing `pkg-config --cflags librtlsdr` -DHTMLPATH=\"/usr/local/share/dump1090/public_html\" -c mode_ac.c
1 warning generated.
cc -O2 -pipe -fstack-protector -fno-strict-aliasing `pkg-config --cflags librtlsdr` -DHTMLPATH=\"/usr/local/share/dump1090/public_html\" -c mode_s.c
In file included from mode_ac.c:31:
In file included from ./dump1090.h:54:
/usr/include/sys/timeb.h:42:2: warning: "this file includes <sys/timeb.h> which is deprecated" [-W#warnings]
#warning "this file includes <sys/timeb.h> which is deprecated"
^
1 warning generated.
cc -O2 -pipe -fstack-protector -fno-strict-aliasing `pkg-config --cflags librtlsdr` -DHTMLPATH=\"/usr/local/share/dump1090/public_html\" -c net_io.c
In file included from mode_s.c:31:
In file included from ./dump1090.h:54:
/usr/include/sys/timeb.h:42:2: warning: "this file includes <sys/timeb.h> which is deprecated" [-W#warnings]
#warning "this file includes <sys/timeb.h> which is deprecated"
^
In file included from net_io.c:31:
In file included from ./dump1090.h:54:
/usr/include/sys/timeb.h:42:2: warning: "this file includes <sys/timeb.h> which is deprecated" [-W#warnings]
#warning "this file includes <sys/timeb.h> which is deprecated"
^
1 warning generated.
cc -O2 -pipe -fstack-protector -fno-strict-aliasing `pkg-config --cflags librtlsdr` -DHTMLPATH=\"/usr/local/share/dump1090/public_html\" -c view1090.c
In file included from view1090.c:31:
In file included from ./view1090.h:35:
In file included from ./dump1090.h:54:
/usr/include/sys/timeb.h:42:2: warning: "this file includes <sys/timeb.h> which is deprecated" [-W#warnings]
#warning "this file includes <sys/timeb.h> which is deprecated"
^
1 warning generated.
cc -g -o dump1090 dump1090.o anet.o interactive.o mode_ac.o mode_s.o net_io.o `pkg-config --libs librtlsdr` -lpthread -lm -lcompat -fstack-protector
1 warning generated.
cc -g -o view1090 view1090.o anet.o interactive.o mode_ac.o mode_s.o net_io.o `pkg-config --libs librtlsdr` -lpthread -lm -lcompat -fstack-protector
gmake[1]: Leaving directory '/home/rpaulo/svn/ports/head/comms/dump1090_mr/work/dump1090_mr-1.15'
===> Staging for dump1090_mr-1.15
===> Generating temporary packing list
install -s -o root -g wheel -m 555 /home/rpaulo/svn/ports/head/comms/dump1090_mr/work/dump1090_mr-1.15/dump1090 /home/rpaulo/svn/ports/head/comms/dump1090_mr/work/stage/usr/local/bin
install -s -o root -g wheel -m 555 /home/rpaulo/svn/ports/head/comms/dump1090_mr/work/dump1090_mr-1.15/view1090 /home/rpaulo/svn/ports/head/comms/dump1090_mr/work/stage/usr/local/bin
/bin/mkdir -p /home/rpaulo/svn/ports/head/comms/dump1090_mr/work/stage/usr/local/share/dump1090_mr/public_html
/bin/mkdir -p /home/rpaulo/svn/ports/head/comms/dump1090_mr/work/stage/usr/local/share/dump1090_mr/public_html/coolclock
install -o root -g wheel -m 0644 /home/rpaulo/svn/ports/head/comms/dump1090_mr/work/dump1090_mr-1.15/public_html/*.html /home/rpaulo/svn/ports/head/comms/dump1090_mr/work/stage/usr/local/share/dump1090_mr/public_html
install -o root -g wheel -m 0644 /home/rpaulo/svn/ports/head/comms/dump1090_mr/work/dump1090_mr-1.15/public_html/*.js /home/rpaulo/svn/ports/head/comms/dump1090_mr/work/stage/usr/local/share/dump1090_mr/public_html
install -o root -g wheel -m 0644 /home/rpaulo/svn/ports/head/comms/dump1090_mr/work/dump1090_mr-1.15/public_html/*.css /home/rpaulo/svn/ports/head/comms/dump1090_mr/work/stage/usr/local/share/dump1090_mr/public_html
install -o root -g wheel -m 0644 /home/rpaulo/svn/ports/head/comms/dump1090_mr/work/dump1090_mr-1.15/public_html/coolclock/* /home/rpaulo/svn/ports/head/comms/dump1090_mr/work/stage/usr/local/share/dump1090_mr/public_html/coolclock
====> Compressing man pages (compress-man)
====> Running Q/A tests (stage-qa)
===> Installing for dump1090_mr-1.15
===> Checking if dump1090_mr already installed
===> Registering installation for dump1090_mr-1.15
Installing dump1090_mr-1.15...
===> SECURITY REPORT:
This port has installed the following files which may act as network
servers and may therefore pose a remote security risk to the system.
/usr/local/bin/view1090
/usr/local/bin/dump1090This is cool: it let us keep the /dev/dtrace char devices with strict permissions because the probes will only be registered when you run dtrace(1), which usually has root privileges.
Mar 31 2015
I have not reviewed the ipf code.
Mar 28 2015
The FBT probes depend on how the code is laid out and if the function name changes, so will the FBT probe. The other problem with FBT probes is when the functions move from global to static and the FBT probe disappears (because the function is no longer defined or because it was inlined by the compiler).
The proc provider was providing a stable D interface, but I'm not sure how many people are useful and that's why I would be reluctant to remove it.
Mar 27 2015
Mar 26 2015
- The PRU driver needs to be changed as well, but the vendor DTS don't contain the PRU description block.
- The WDT driver should work ok.
- The mailbox driver probably needs to be changed to use ti,omap4-mailbox as the compatible string.
Mar 13 2015
Mar 11 2015
Thanks for fixing your other drivers!
Mar 8 2015
Mar 5 2015
Mar 4 2015
Mar 3 2015
How is install(1) executed? What controls "stripping" via install(1) is the STRIP make variable, so if I set that to null, won't that also avoid stripping crunched binaries? Is that expected?
The reason why we have DTrace and ZFS only as modules is because of the CDDL. Can you please make sure core is okay with this change? They will have access to all the email archives discussing the problems and the outcomes. They can tell you exactly the reasons why we never had DTrace/ZFS in the kernel.
Mar 2 2015
Mar 1 2015
Feb 28 2015
Feb 27 2015
Feb 26 2015
Looks good to me.
Feb 23 2015
Thanks, this is very useful.
If no one objects, I'll commit it.
Feb 22 2015
Should probably be approved by one more person.
Feb 20 2015
Feb 17 2015
The only reason it needed libelf was because I thought it required our linker to patch the symbols when linking. It appears that's not the case, which is good. Regarding the code, you keep writing "#ifndef illumos", so I suspect that's your preferred version and I won't argue.
Well, we might not read the whole symbol table. We just read enough to find our symbol. If the symbol is at the end of the table, we have iterated the whole table like you said, but if it's in the beginning, it won't be as bad. I guess it depends on how many functions we end up resolving. libc.so has about 3096 symbols. I'm still wondering if it's ok to cache all of that in memory. Perhaps it's going to be less than 512k which would be ok even on ARM given the size of DTrace now. This would negatively impact the startup size, though.
I think the code is fine and what I pointed out is minor. You could try to find someone else to review this, but it might be difficult since it's been broken so long and no one cared :-/
Feb 16 2015
Feb 13 2015
Quick glance and the approach looks reasonable to me.
Hmm, I think these memory barriers were in the tree but were removed recently. I think it would be nice to use the atomic load acq/rel because this change could negatively impact x86.
Feb 11 2015
I agree with kib that this deserves a comment. And perhaps add another comment in D1819 explaining why it isn't needed for .rel relocations.
Andrew should approve, but this looks sane to me.