Thanks, that was fast! I only started using FreeBSD since 24 days ago, I never expected to get something merged into the upstream within 2 days.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Jan 6 2021
In D27952#625379, @emaste wrote:Code changes in this commit were obtained from straight from OpenBSD's uplcom.c
Is there an additional copyright statement in OpenBSD's uplcom.c that we should bring over?
I just completed the tests.
I already did a basic go/no-go test before submitting the revised patch. Now you've said that, just to be extra careful, I'm going to verify the waveforms on my oscilloscope for all supported baud rates and report back ASAP.
Jan 4 2021
New patch uploaded. This one fixes the RTS/CTS bug.
This is embarrassing, but do not commit the current version of this patch yet. I just did a final reread of the code and found a bug.
Really recreate patch with context. Also fix the accidental and useless empty line change.
Hold on, the empty line change in line 883 is still there, I accidentally submitted the original patch again ;(... Let me fix that first.
In D27952#624330, @hselasky wrote:Changes look good. Do you have a reference to the OpenBSD patches?
Remove an accidental empty line change. Recreate patch with context "9999".