Page MenuHomeFreeBSD
Feed Advanced Search

Jan 6 2021

tomli_tomli.me added a comment to D27952: uplcom: support new chip revision PL2303HXN..

Thanks, that was fast! I only started using FreeBSD since 24 days ago, I never expected to get something merged into the upstream within 2 days.

Jan 6 2021, 7:58 PM
tomli_tomli.me added a comment to D27952: uplcom: support new chip revision PL2303HXN..

Code changes in this commit were obtained from straight from OpenBSD's uplcom.c

Is there an additional copyright statement in OpenBSD's uplcom.c that we should bring over?

Jan 6 2021, 5:48 PM
tomli_tomli.me added a comment to D27952: uplcom: support new chip revision PL2303HXN..

I just completed the tests.

Jan 6 2021, 5:41 PM
tomli_tomli.me added a comment to D27952: uplcom: support new chip revision PL2303HXN..

I already did a basic go/no-go test before submitting the revised patch. Now you've said that, just to be extra careful, I'm going to verify the waveforms on my oscilloscope for all supported baud rates and report back ASAP.

Jan 6 2021, 1:20 PM

Jan 4 2021

tomli_tomli.me added a comment to D27952: uplcom: support new chip revision PL2303HXN..

New patch uploaded. This one fixes the RTS/CTS bug.

Jan 4 2021, 7:27 PM
tomli_tomli.me updated the diff for D27952: uplcom: support new chip revision PL2303HXN..
Jan 4 2021, 7:24 PM
tomli_tomli.me added a comment to D27952: uplcom: support new chip revision PL2303HXN..

This is embarrassing, but do not commit the current version of this patch yet. I just did a final reread of the code and found a bug.

Jan 4 2021, 7:20 PM
tomli_tomli.me updated tomli_tomli.me.
Jan 4 2021, 5:04 PM
tomli_tomli.me updated the diff for D27952: uplcom: support new chip revision PL2303HXN..

Really recreate patch with context. Also fix the accidental and useless empty line change.

Jan 4 2021, 4:06 PM
tomli_tomli.me added a comment to D27952: uplcom: support new chip revision PL2303HXN..

Hold on, the empty line change in line 883 is still there, I accidentally submitted the original patch again ;(... Let me fix that first.

Jan 4 2021, 3:58 PM
tomli_tomli.me added a comment to D27952: uplcom: support new chip revision PL2303HXN..

Changes look good. Do you have a reference to the OpenBSD patches?

Jan 4 2021, 3:54 PM
tomli_tomli.me updated the diff for D27952: uplcom: support new chip revision PL2303HXN..

Remove an accidental empty line change. Recreate patch with context "9999".

Jan 4 2021, 3:42 PM
tomli_tomli.me updated the summary of D27952: uplcom: support new chip revision PL2303HXN..
Jan 4 2021, 3:28 PM
tomli_tomli.me requested review of D27952: uplcom: support new chip revision PL2303HXN..
Jan 4 2021, 3:17 PM