Page MenuHomeFreeBSD
Feed Advanced Search

Oct 17 2015

jmg added a comment to D3929: Replace sys/crypto/sha2/sha2.c with lib/libmd/sha512c.c.

Just a few comments.

Oct 17 2015, 9:14 PM

Oct 12 2015

jmg added a comment to V6: Should /usr/local be included in FreeBSD's toolchain paths?.

I said Yes, but I think that we need to clean up our base libraries first. We need to make most/all libs private. If it isn't part of posix, it needs a man page which links to functions provided.

Oct 12 2015, 10:27 PM

Aug 27 2015

jmg committed rS287218: add documentation for timers that silby added in r197244, almost 6 years.
add documentation for timers that silby added in r197244, almost 6 years
Aug 27 2015, 7:12 PM

Aug 16 2015

jmg added a comment to D3390: improvements to kproc/kthread man pages.

Thanks. changed.

Aug 16 2015, 4:31 AM
jmg updated the diff for D3390: improvements to kproc/kthread man pages.
  • change a needs to to a must to be more correct.. If there are threads
Aug 16 2015, 4:30 AM

Aug 15 2015

jmg added a comment to D3390: improvements to kproc/kthread man pages.

Address all but /The/That/ change.. I understand why you suggested it, but it reads not as easily for me... We are only referencing the once example.

Aug 15 2015, 11:53 PM
jmg updated the diff for D3390: improvements to kproc/kthread man pages.
  • address comments from bjk...
Aug 15 2015, 11:51 PM
jmg updated the diff for D3390: improvements to kproc/kthread man pages.

hopefully update the diff w/ complete change..

Aug 15 2015, 11:47 PM
jmg abandoned D3394: improvements to kproc/kthread man pages.

ok, this is an issue w/ git and arc locally, not with phabric...

Aug 15 2015, 11:40 PM
jmg retitled D3394: improvements to kproc/kthread man pages from to improvements to kproc/kthread man pages.
Aug 15 2015, 11:39 PM
jmg updated the diff for D3390: improvements to kproc/kthread man pages.
  • Fix date..
Aug 15 2015, 11:36 PM
jmg updated the diff for D3390: improvements to kproc/kthread man pages.

add documentation to kthread, and fix up kproc Sx

Aug 15 2015, 11:31 PM
jmg added inline comments to D3354: Reintroduce loadable modules for random(4).
Aug 15 2015, 10:21 PM
jmg added a reviewer for D3390: improvements to kproc/kthread man pages: jhb.
Aug 15 2015, 7:06 PM
jmg retitled D3390: improvements to kproc/kthread man pages from to improvements to kproc/kthread man pages.
Aug 15 2015, 7:06 PM
jmg added a comment to D3354: Reintroduce loadable modules for random(4).

Minor comments.

Aug 15 2015, 5:54 PM

Aug 12 2015

jmg accepted D3364: Perform cleanups in response to D3307..

Thanks, looks good.

Aug 12 2015, 5:44 PM

Aug 11 2015

jmg added a comment to D3354: Reintroduce loadable modules for random(4).
In D3354#68427, @markm wrote:

I have only glanced over the code and it seems good overall.

Thanks!

One thought: can we make DEV_RANDOM something like NO_DEV_RANDOM? That way it would be an opt-out feature, as most systems still need it.

Nope, sorry. The DEV_RANDOM pseudo-option comes for free from 'device random' in the kernel config file. There is no negative variant, but it is safe enough given that the kernel configs that need this device have it.

Aug 11 2015, 10:52 PM
jmg added a comment to D3354: Reintroduce loadable modules for random(4).

Are you opening this up to more reviewers? Or still only for SO (aka delphij)? The reason I ask is that secteam only consists of delphij, so adding secteam doesn't add any new reviewers.

Aug 11 2015, 7:43 PM
jmg accepted D3308: Make poll() and kqueue() on CloudABI work..

Comments are not required to be addressed.

Aug 11 2015, 7:38 PM
jmg added a comment to D3307: Add support for anonymous kqueues..

Look good.. Please address the comments.

Aug 11 2015, 7:27 PM

Aug 4 2015

jmg added a comment to D3303: Make it possible to implement poll(2) on top of kqueue(2)..
In D3303#66772, @ed wrote:
In D3303#66768, @jmg wrote:

I don't see an issue w/ this, though if this is committed, but then CloudABI decided to not use it anymore, I request that it be removed.

Of course. Would it make sense to #ifdef _KERNEL it and revert the man page changes? That way we can be certain that userspace won't use it.

Aug 4 2015, 9:52 PM
jmg added a comment to D3303: Make it possible to implement poll(2) on top of kqueue(2)..

I don't see an issue w/ this, though if this is committed, but then CloudABI decided to not use it anymore, I request that it be removed.

Aug 4 2015, 9:01 PM
jmg committed rS286292: Make IPsec work with AES-GCM and AES-ICM (aka CTR) in OCF... IPsec.
Make IPsec work with AES-GCM and AES-ICM (aka CTR) in OCF... IPsec
Aug 4 2015, 5:47 PM

Aug 2 2015

jmg committed rS286213: looks like all archs either have clang or cdefs included before...
looks like all archs either have clang or cdefs included before..
Aug 2 2015, 9:33 PM
jmg committed rS286170: mark this function as deprecated, and put the warning first, since I.
mark this function as deprecated, and put the warning first, since I
Aug 2 2015, 12:22 AM
jmg committed rS286168: convert to C11's _Static_assert, and pull in sys/cdefs.h for.
convert to C11's _Static_assert, and pull in sys/cdefs.h for
Aug 2 2015, 12:16 AM

Aug 1 2015

jmg committed rS286159: use : instead of true....
use : instead of true...
Aug 1 2015, 5:28 PM

Jul 31 2015

jmg added inline comments to D3254: Fix buffer overflow in syslogd, wall and talkd..
Jul 31 2015, 4:29 PM
jmg committed rS286110: temporarily fix build.. This isn't the final fix, and testing is.
temporarily fix build.. This isn't the final fix, and testing is
Jul 31 2015, 7:48 AM
jmg committed rS286103: The implementation note isn't true anymore...
The implementation note isn't true anymore..
Jul 31 2015, 3:28 AM
jmg committed rS286101: these are comparing authenticators and need to be constant time....
these are comparing authenticators and need to be constant time...
Jul 31 2015, 12:32 AM
jmg committed rS286100: Clean up this header file....
Clean up this header file...
Jul 31 2015, 12:23 AM

Jul 30 2015

jmg added a comment to D3254: Fix buffer overflow in syslogd, wall and talkd..

I'm fine w/ this change.

Jul 30 2015, 11:45 PM

Jul 29 2015

jmg committed rS286049: const'ify an arg that we don't update....
const'ify an arg that we don't update...
Jul 29 2015, 11:37 PM
jmg removed a reviewer for D3236: Make pipes in CloudABI work.: jmg.
Jul 29 2015, 3:55 PM
jmg committed rS286000: RFC4868 section 2.3 requires that the output be half... This fixes.
RFC4868 section 2.3 requires that the output be half... This fixes
Jul 29 2015, 7:15 AM

Jul 28 2015

jmg committed rD47124: DES is a terrible suggestion, and it MUST NOT be used per RFC7321...
DES is a terrible suggestion, and it MUST NOT be used per RFC7321..
Jul 28 2015, 5:22 PM

Jul 25 2015

jmg requested changes to D3197: Do not compile in the really expensive entropy harvesting unless it is requested..

Please post a complete patch that includes both sets of changes, and adds proper documentation.

Jul 25 2015, 5:55 PM

Jul 18 2015

jmg committed rS285683: move the prototype to the lib.h header.. This makes more sense, and.
move the prototype to the lib.h header.. This makes more sense, and
Jul 18 2015, 10:58 PM
jmg committed rS285682: other fixes to make boot2 compile for IXP... Properly end the asm.
other fixes to make boot2 compile for IXP... Properly end the asm
Jul 18 2015, 8:26 PM
jmg committed rS285681: revert r278579, this is in a different compile environment than the.
revert r278579, this is in a different compile environment than the
Jul 18 2015, 8:20 PM

Jul 15 2015

jmg committed rD46991: remove a stray semi-colon....
remove a stray semi-colon...
Jul 15 2015, 11:08 PM
jmg committed rS285615: fix the docs, the number of frags per inode (NFPI) changed in r228794.
fix the docs, the number of frags per inode (NFPI) changed in r228794
Jul 15 2015, 9:35 PM
jmg added a comment to D3084: add option to invert data set so you can convert seconds into per seconds...

errx needed to be used instead of err as errno will not be set in this case.

Jul 15 2015, 6:18 AM
jmg updated the diff for D3084: add option to invert data set so you can convert seconds into per seconds...

Update to add error when d == 0...

Jul 15 2015, 6:15 AM
jmg committed rS285595: fix error message... errx since errno may not be set (if we didn't.
fix error message... errx since errno may not be set (if we didn't
Jul 15 2015, 6:14 AM
jmg added a comment to D3084: add option to invert data set so you can convert seconds into per seconds...

I could also use the term reciprocal, but for me invert makes sense and is more common.

Jul 15 2015, 6:04 AM
jmg added a comment to D3084: add option to invert data set so you can convert seconds into per seconds...
In D3084#61045, @imp wrote:

Invert isn't the right terminology.
You are converting from the time domain to the frequency domain.
This is a fundamental conceptual faux pas.

Jul 15 2015, 5:56 AM
jmg added a member for security: jmg.
Jul 15 2015, 5:44 AM
jmg retitled D3084: add option to invert data set so you can convert seconds into per seconds.. from to add option to invert data set so you can convert seconds into per seconds...
Jul 15 2015, 12:17 AM

Jul 14 2015

jmg accepted D3053: Implement the CloudABI random_get() system call..

Other than the set/true change, the changes to the manpage are great.

Jul 14 2015, 6:00 PM
jmg committed rS285526: Fix XTS, and name things a bit better....
Fix XTS, and name things a bit better...
Jul 14 2015, 7:45 AM
jmg retitled D3074: add support for NO_ROOT installs in the traditional kernel install... from to add support for NO_ROOT installs in the traditional kernel install....
Jul 14 2015, 7:14 AM
jmg committed rS285525: fix typos...
fix typos..
Jul 14 2015, 6:35 AM
jmg committed rS285523: cryptodev is not needed for TCP_SIGNATURE....
cryptodev is not needed for TCP_SIGNATURE...
Jul 14 2015, 5:10 AM

Jul 12 2015

jmg added a comment to D3053: Implement the CloudABI random_get() system call..

Please make it clear how the function behaves. Too much is unspecified.

Jul 12 2015, 9:44 PM

Jul 11 2015

jmg committed rS285381: some additional improvements to the documentation....
some additional improvements to the documentation...
Jul 11 2015, 4:20 AM
jmg committed rS285366: Complete the move that was started w/ r263218.. For some reason I.
Complete the move that was started w/ r263218.. For some reason I
Jul 11 2015, 3:12 AM

Jul 10 2015

jmg added a comment to D1503: Use explicitly specified ivsize instead of blocksize, when we mean IV size..

does rS285336 have all these changes in it?

Jul 10 2015, 8:21 AM

Jul 9 2015

jmg committed rS285324: increase buffer size to significantly increase performance....
increase buffer size to significantly increase performance...
Jul 9 2015, 4:13 PM

Jul 8 2015

jmg added a comment to D3016: Add proper locking to the fpu_ctx allocated by aesni...

the pause has been removed in rS285297, it was unneeded because another lock by the crypto driver prevented it. I have also documented this in the man page.

Jul 8 2015, 10:50 PM
jmg committed rS285297: upon further examination, it turns out that _unregister_all already.
upon further examination, it turns out that _unregister_all already
Jul 8 2015, 10:48 PM
jmg committed rS285296: yet more documentation improvements... Many changes were made to the.
yet more documentation improvements... Many changes were made to the
Jul 8 2015, 10:46 PM
jmg committed rS285290: Now that aesni won't reuse fpu contexts (D3016), add seatbelts to the.
Now that aesni won't reuse fpu contexts (D3016), add seatbelts to the
Jul 8 2015, 7:26 PM
jmg closed D3015: add INUSE flag to x86 fpu routines by committing rS285290: Now that aesni won't reuse fpu contexts (D3016), add seatbelts to the.
Jul 8 2015, 7:26 PM
jmg closed D3016: Add proper locking to the fpu_ctx allocated by aesni.. by committing rS285289: address an issue where consumers, like IPsec, can reuse the same.
Jul 8 2015, 7:15 PM
jmg committed rS285289: address an issue where consumers, like IPsec, can reuse the same.
address an issue where consumers, like IPsec, can reuse the same
Jul 8 2015, 7:15 PM
jmg updated the diff for D3016: Add proper locking to the fpu_ctx allocated by aesni...

address a couple of kib's comments...

Jul 8 2015, 7:03 PM
jmg added inline comments to D3016: Add proper locking to the fpu_ctx allocated by aesni...
Jul 8 2015, 6:31 PM

Jul 7 2015

jmg committed rS285254: unroll the loop slightly... This improves performance enough to.
unroll the loop slightly... This improves performance enough to
Jul 7 2015, 8:31 PM
jmg committed rS285247: we may get here w/ non-sleepable locks held, so switch to _NOWAIT when.
we may get here w/ non-sleepable locks held, so switch to _NOWAIT when
Jul 7 2015, 6:45 PM
jmg retitled D3015: add INUSE flag to x86 fpu routines from add INUSE flag to amd64's fpu to add INUSE flag to x86 fpu routines.
Jul 7 2015, 5:44 PM
jmg updated the diff for D3015: add INUSE flag to x86 fpu routines.

remove ifdef INVARIANTS, and add i386 support..

Jul 7 2015, 5:44 PM
jmg retitled D3016: Add proper locking to the fpu_ctx allocated by aesni.. from to Add proper locking to the fpu_ctx allocated by aesni...
Jul 7 2015, 4:25 PM
jmg retitled D3015: add INUSE flag to x86 fpu routines from to add INUSE flag to amd64's fpu.
Jul 7 2015, 4:21 PM

Jul 6 2015

jmg added a comment to D2025: Tidy up random(4) driver after developer feedback and code audit..

Are you to busy to make the requested changes? If I create a patch addressing the changes, would you accept that, or do you reject the requested changes?

Jul 6 2015, 9:32 PM
jmg committed rS285216: Fix for non-random IV's when CRD_F_IV_PRESENT and CRD_F_IV_EXPLICIT.
Fix for non-random IV's when CRD_F_IV_PRESENT and CRD_F_IV_EXPLICIT
Jul 6 2015, 7:30 PM
jmg committed rS285215: remove _NORMAL flag which isn't suppose to be used w/ _alloc_ctx....
remove _NORMAL flag which isn't suppose to be used w/ _alloc_ctx...
Jul 6 2015, 7:18 PM

Jul 5 2015

jmg requested changes to D2990: Allow aesni(4) module to be loaded on all VMs.
Jul 5 2015, 7:18 AM

Jul 4 2015

jmg committed rS285127: improve dependencies for this module a bit... not great, but at.
improve dependencies for this module a bit... not great, but at
Jul 4 2015, 8:16 AM
jmg updated the diff for D2651: libcpufeats and amd64 assembly for sha256.

add rule to tell the user how to rebuild the .o.uu when it is out
of date...

Jul 4 2015, 2:14 AM
jmg added a comment to D2651: libcpufeats and amd64 assembly for sha256.

Marking uudecode as done as bapt hasn't replied to my question for over a month and there are already existing requirements on uudecode.

Jul 4 2015, 1:55 AM

Jul 3 2015

jmg added inline comments to D2651: libcpufeats and amd64 assembly for sha256.
Jul 3 2015, 9:26 PM
jmg added a comment to D2651: libcpufeats and amd64 assembly for sha256.
In D2651#58654, @kib wrote:
In D2651#58647, @imp wrote:

Don't like the generated code that's committed to the tree, nor the yasm sources.

I have exactly the same opinion about this issue. IMO we should provide consistent source which can be self-rebuilt. We do accept .o blobs for obscure hardware, or keep such blobs in the ports. Having the sensitive crypto code in blob, for which the external tool is needed, does not feel right. Also note that there are many offspring x86 assemblers, which are known to be badly maintained and eventually fall into the stagnation.
I noted some options which could be tried, e.g. using intel mode for gas/clang, or whole file convertion to the att syntax.
Whatever the decision is, I dislike the .o for core kernel component very much.

Jul 3 2015, 9:24 PM
jmg added a comment to D2651: libcpufeats and amd64 assembly for sha256.

I plan to commit this next week if I don't get any reviews. This has been in review for over a month w/o comments.

Jul 3 2015, 6:20 PM
jmg added a comment to D2936: Add support for AES modes to IPSec. This patch is as yet incomplete but this is the place where we're starting the discussion..
In D2936#57341, @eri wrote:

The only issue i have with jmg@ locking patch is that it provides consistency for userland threads but i still do not see how it solves the panic due to FPU on a migrated thread!

Jul 3 2015, 6:16 PM
jmg committed rS285070: more word smithing wrt the crd_inject field....
more word smithing wrt the crd_inject field...
Jul 3 2015, 1:55 AM
jmg committed rS285065: update the documentation of the _IV_ flags... _IV_PRESENT doesn't.
update the documentation of the _IV_ flags... _IV_PRESENT doesn't
Jul 3 2015, 12:37 AM

Jul 1 2015

jmg added a comment to D2025: Tidy up random(4) driver after developer feedback and code audit..

I only reviewed the changes in the new diff, I have not verified that my other comments were addressed.

Jul 1 2015, 10:58 PM
jmg added a comment to D2025: Tidy up random(4) driver after developer feedback and code audit..

Some more comments.

Jul 1 2015, 8:35 PM
jmg added inline comments to D2025: Tidy up random(4) driver after developer feedback and code audit..
Jul 1 2015, 7:15 PM

Jun 30 2015

jmg added a comment to D2025: Tidy up random(4) driver after developer feedback and code audit..

Ok, added my comments. I need to get going, and will complete the review later.

Jun 30 2015, 7:38 PM
jmg committed rS284967: add units to the length and count so that it's clear what they.
add units to the length and count so that it's clear what they
Jun 30 2015, 7:06 PM

Jun 27 2015

jmg added inline comments to D1755: Kernel Test Framework (built for the callout testing).
Jun 27 2015, 7:14 AM

Jun 25 2015

jmg committed rS284861: If INVARIANTS is specified, add ctor/dtor to junk memory if they are.
If INVARIANTS is specified, add ctor/dtor to junk memory if they are
Jun 25 2015, 8:44 PM
jmg closed D2725: Add extra INVARIANTS check for ctor/dtor by committing rS284861: If INVARIANTS is specified, add ctor/dtor to junk memory if they are.
Jun 25 2015, 8:44 PM
jmg added a comment to D2378: Introduce ITS support for ARM64.
In D2378#56588, @zbb wrote:

What do we do with it?
BTW. Does anyone know why diffs are not visible :-) ?

Jun 25 2015, 6:25 PM

Jun 23 2015

jmg added a comment to D2725: Add extra INVARIANTS check for ctor/dtor.

INVARIANTS already covers this. If you didn't want your machine to panic when it detects code failures, you shouldn't have compiled w/ INVARIANTS. :)

Jun 23 2015, 6:51 PM
jmg updated the diff for D2725: Add extra INVARIANTS check for ctor/dtor.

remove the vfs change as it has already been committed... This patch will be
committed in 24 hours unless comments are added.. It's languished too long..

Jun 23 2015, 6:49 PM