Page MenuHomeFreeBSD
Feed Advanced Search

Jul 20 2021

dchagin accepted D31251: linux: Fix declaration of rt_sigreturn().

I think you should start by adapting arm64 sendsig and sigreturn, and trampoline

That’s precisely what I’ve done, except that I stole the trampoline from Linux. It’s three instructions, and I’d rather not diverge here, to avoid complicating matters for native Linux debuggers or unwinders.

Jul 20 2021, 9:29 PM
dchagin added a comment to D31251: linux: Fix declaration of rt_sigreturn().

as sigreturn called only from trampolines so it decl depends on how trampoline call it

Jul 20 2021, 8:20 PM
dchagin added a comment to D31251: linux: Fix declaration of rt_sigreturn().

I think you should start by adapting arm64 sendsig and sigreturn, and trampoline

Jul 20 2021, 8:03 PM
dchagin updated the summary of D31250: umtx: Add new pi_futex type..
Jul 20 2021, 7:35 PM
dchagin updated the diff for D31240: linux(4): Implement pi futexes using umtx..

followup D31248

Jul 20 2021, 7:34 PM
dchagin requested review of D31250: umtx: Add new pi_futex type..
Jul 20 2021, 7:33 PM
dchagin updated the diff for D31238: umtx: Split do_unlock_pi on two counterparts..

followup D31248

Jul 20 2021, 7:31 PM
dchagin updated the diff for D31237: umtx: Expose some of the pi umtx structures and API to the rest of the kernel..

followup D31248

Jul 20 2021, 7:30 PM
dchagin updated the diff for D31236: linux(4): Reimplement futexes using umtx..

followup D31248

Jul 20 2021, 7:29 PM
dchagin updated the diff for D31235: umtx: Add umtxq_requeue Linux emulation layer extension..

followup D31248

Jul 20 2021, 7:28 PM
dchagin updated the diff for D31234: umtx: Add bitset member to the struct umtx_q..

followup D31248

Jul 20 2021, 7:28 PM
dchagin updated the diff for D31233: umtx: Expose some of the umtx structures and API to the rest of the kernel..

agree, done, D31245 - D31249

Jul 20 2021, 7:26 PM
dchagin added reviewers for D31249: umtx: Expose struct abs_timeout to the rest of the kernel.: kib, markj.
Jul 20 2021, 7:25 PM
dchagin added reviewers for D31248: umtx: Split umtx.h on two counterparts.: kib, markj.
Jul 20 2021, 7:24 PM
dchagin added reviewers for D31247: freebsd32: Remove the unnecessary spaces.: kib, markj.
Jul 20 2021, 7:24 PM
dchagin added reviewers for D31246: freebsd32: Remove unused umtx.h include.: kib, markj.
Jul 20 2021, 7:23 PM
dchagin added reviewers for D31245: freebsd32: Eliminate spaces at end of line.: kib, markj.
Jul 20 2021, 7:23 PM
dchagin requested review of D31249: umtx: Expose struct abs_timeout to the rest of the kernel..
Jul 20 2021, 7:22 PM
dchagin requested review of D31248: umtx: Split umtx.h on two counterparts..
Jul 20 2021, 7:21 PM
dchagin requested review of D31247: freebsd32: Remove the unnecessary spaces..
Jul 20 2021, 7:20 PM
dchagin requested review of D31246: freebsd32: Remove unused umtx.h include..
Jul 20 2021, 7:19 PM
dchagin requested review of D31245: freebsd32: Eliminate spaces at end of line..
Jul 20 2021, 7:19 PM
dchagin updated the diff for D31236: linux(4): Reimplement futexes using umtx..

fix futex_wakep, it was a separate commit

Jul 20 2021, 2:44 PM
dchagin added reviewers for D31240: linux(4): Implement pi futexes using umtx.: kib, markj.
Jul 20 2021, 2:23 PM
dchagin added reviewers for D31239: linux(4): Replace copyin() by fueword32() in handle_futex_death().: kib, markj.
Jul 20 2021, 2:22 PM
dchagin added reviewers for D31238: umtx: Split do_unlock_pi on two counterparts.: kib, markj.
Jul 20 2021, 2:21 PM
dchagin added reviewers for D31237: umtx: Expose some of the pi umtx structures and API to the rest of the kernel.: kib, markj.
Jul 20 2021, 2:21 PM
dchagin added reviewers for D31236: linux(4): Reimplement futexes using umtx.: kib, markj.
Jul 20 2021, 2:20 PM
dchagin added reviewers for D31235: umtx: Add umtxq_requeue Linux emulation layer extension.: kib, markj.
Jul 20 2021, 2:20 PM
dchagin added reviewers for D31234: umtx: Add bitset member to the struct umtx_q.: kib, markj.
Jul 20 2021, 2:19 PM
dchagin added reviewers for D31233: umtx: Expose some of the umtx structures and API to the rest of the kernel.: kib, markj.
Jul 20 2021, 2:18 PM
dchagin requested review of D31240: linux(4): Implement pi futexes using umtx..
Jul 20 2021, 2:18 PM
dchagin requested review of D31239: linux(4): Replace copyin() by fueword32() in handle_futex_death()..
Jul 20 2021, 2:17 PM
dchagin requested review of D31238: umtx: Split do_unlock_pi on two counterparts..
Jul 20 2021, 2:14 PM
dchagin requested review of D31237: umtx: Expose some of the pi umtx structures and API to the rest of the kernel..
Jul 20 2021, 2:12 PM
dchagin requested review of D31236: linux(4): Reimplement futexes using umtx..
Jul 20 2021, 2:11 PM
dchagin requested review of D31235: umtx: Add umtxq_requeue Linux emulation layer extension..
Jul 20 2021, 2:10 PM
dchagin requested review of D31234: umtx: Add bitset member to the struct umtx_q..
Jul 20 2021, 2:09 PM
dchagin requested review of D31233: umtx: Expose some of the umtx structures and API to the rest of the kernel..
Jul 20 2021, 2:08 PM
dchagin committed R10:75cb2382b84d: linux(4): Factor out the futex_wait() op into linux_futex_wait(). (authored by dchagin).
linux(4): Factor out the futex_wait() op into linux_futex_wait().
Jul 20 2021, 11:42 AM
dchagin committed R10:ef4251e27148: linux(4): Prevent an endless loop. (authored by dchagin).
linux(4): Prevent an endless loop.
Jul 20 2021, 11:42 AM
dchagin committed R10:80b8d6b144c2: linux(4): Eliminate bogus comment. (authored by dchagin).
linux(4): Eliminate bogus comment.
Jul 20 2021, 11:42 AM
dchagin committed R10:cf8d74e3fe63: linux(4): Allow musl brand to use FUTEX_REQUEUE op. (authored by dchagin).
linux(4): Allow musl brand to use FUTEX_REQUEUE op.
Jul 20 2021, 11:42 AM
dchagin committed R10:bb62a91944fa: linux(4): Factor out the FUTEX_CMP_REQUEUE op into linux_futex_requeue(). (authored by dchagin).
linux(4): Factor out the FUTEX_CMP_REQUEUE op into linux_futex_requeue().
Jul 20 2021, 11:42 AM
dchagin committed R10:4c361d7a5acc: linux(4): Factor out the FUTEX_WAKE_OP op into linux_futex_wakeop(). (authored by dchagin).
linux(4): Factor out the FUTEX_WAKE_OP op into linux_futex_wakeop().
Jul 20 2021, 11:42 AM
dchagin committed R10:19f7e2c2fb44: linux(4): Factor out the FUTEX_WAKE op into linux_futex_wake(). (authored by dchagin).
linux(4): Factor out the FUTEX_WAKE op into linux_futex_wake().
Jul 20 2021, 11:42 AM
dchagin closed D30332: linuxulator: Add FUTEX_REQUEUE for musl libc. .
Jul 20 2021, 11:42 AM · Linux Emulation
dchagin committed R10:f6b0d275eb9e: linux(4): Factor out the FUTEX_WAIT op into linux_futex_wait(). (authored by dchagin).
linux(4): Factor out the FUTEX_WAIT op into linux_futex_wait().
Jul 20 2021, 11:42 AM
dchagin committed R10:1866eef48435: linux(4): Refactor the struct linux_futex_args. (authored by dchagin).
linux(4): Refactor the struct linux_futex_args.
Jul 20 2021, 11:41 AM
dchagin committed R10:1ca6b15bbdce: Drop "All rights reserved" from my copyright statements. (authored by dchagin).
Drop "All rights reserved" from my copyright statements.
Jul 20 2021, 7:11 AM
dchagin committed R10:2b3818633090: Drop rdivacky@ "All rights reserved" from linux_event. (authored by dchagin).
Drop rdivacky@ "All rights reserved" from linux_event.
Jul 20 2021, 7:11 AM
dchagin committed R10:ae8330b44868: linux(4): Add arch name to the some printfs. (authored by dchagin).
linux(4): Add arch name to the some printfs.
Jul 20 2021, 7:11 AM
dchagin committed R10:fe7409530c54: linprocfs: Fixup vDSO name in the procmaps after 9931033bbf. (authored by dchagin).
linprocfs: Fixup vDSO name in the procmaps after 9931033bbf.
Jul 20 2021, 7:11 AM
dchagin committed R10:09cffde975b8: linux(4): Fixup the vDSO initialization order. (authored by dchagin).
linux(4): Fixup the vDSO initialization order.
Jul 20 2021, 7:11 AM
dchagin committed R10:a543556c8128: linux(4): Constify vdso install/deinstall. (authored by dchagin).
linux(4): Constify vdso install/deinstall.
Jul 20 2021, 7:11 AM
dchagin committed R10:9931033bbfbe: linux(4); Almost complete the vDSO. (authored by dchagin).
linux(4); Almost complete the vDSO.
Jul 20 2021, 7:11 AM
dchagin closed D30912: Drop "All rights reserved" from my copyright statements..
Jul 20 2021, 7:11 AM
dchagin closed D30913: Drop rdivacky@ "All rights reserved" from linux_event..
Jul 20 2021, 7:11 AM
dchagin committed R10:5fd9cd53d256: linux(4): Modify sv_onexec hook to return an error. (authored by dchagin).
linux(4): Modify sv_onexec hook to return an error.
Jul 20 2021, 7:11 AM
dchagin committed R10:62ba4cd34067: Call sv_onexec hook after the process VA is created. (authored by dchagin).
Call sv_onexec hook after the process VA is created.
Jul 20 2021, 7:11 AM
dchagin closed D30904: linux(4): Add arch name to the some printfs..
Jul 20 2021, 7:11 AM
dchagin closed D30903: linprocfs: Fixup vDSO name in the procmaps..
Jul 20 2021, 7:11 AM
dchagin closed D30902: linux(4): Fixup the vDSO initialization order..
Jul 20 2021, 7:11 AM
dchagin committed R10:b39fa4770dd1: Remove bogus cast from exec_sysvec_init(). (authored by dchagin).
Remove bogus cast from exec_sysvec_init().
Jul 20 2021, 7:11 AM
dchagin committed R10:21629e2a4564: Modify exec_sysvec_init() to allow non-native abi to setup their sysentvecs. (authored by dchagin).
Modify exec_sysvec_init() to allow non-native abi to setup their sysentvecs.
Jul 20 2021, 7:11 AM
dchagin closed D30901: linux(4): Constify vdso install/deinstall..
Jul 20 2021, 7:11 AM
dchagin closed D30900: linux(4); Almost complete the vDSO..
Jul 20 2021, 7:11 AM
dchagin committed R10:815165be201e: linux(4): Remove function prototypes from the vDSO. (authored by dchagin).
linux(4): Remove function prototypes from the vDSO.
Jul 20 2021, 7:11 AM
dchagin closed D30911: Modify sv_onexec hook to return error..
Jul 20 2021, 7:11 AM
dchagin closed D30899: Call sv_onexec handler after the process VA is created..
Jul 20 2021, 7:10 AM
dchagin closed D30910: Remove bogus cast from exec_sysvec_init()..
Jul 20 2021, 7:10 AM
dchagin closed D30898: Add exec_sysvec_init_abi() to setup non native sysentvecs..
Jul 20 2021, 7:10 AM

Jul 7 2021

dchagin added a comment to D30900: linux(4); Almost complete the vDSO..

'all rights' removed, adapted to the previous changes

Jul 7 2021, 2:26 PM
dchagin accepted D31091: linux(4): remove unfinished vsyscall bits on arm64.

AFAIR, this is used on amd64 only

Jul 7 2021, 2:00 PM

Jul 6 2021

dchagin added a comment to D30987: Only handle robust mutexes and sigfastblock on exec and exit for native FreeBSD ABIs.
In D30987#698633, @kib wrote:
In D30987#698405, @kib wrote:

Looks ok, but why? Now in the native case we converted direct function calls to an indirect call, but umtx and sigfastblock already do nothing in the !native case.

It was requested by dchagin. Obvious but vague reason is to not call freebsd-abi specific methods on other ABIs. But my guess is that linuxolator would get robust mutexes rework that might reuse parts of native code, including the structures pointed from struct thread. Then calling freebsd-native directly would be problematic.

It makes some sense to hide sigfastblock this way, but umtx is not really tied to any particular ABI as I understand it. So it feels to me that the umtx code should internally handle any extensions required to support the futex implementation. Probably I'm just quibbling.

IMO umtx is very FreeBSD-specific. But I wonder what Dmitry would end up with.

Jul 6 2021, 11:14 AM

Jul 5 2021

dchagin added a comment to D31037: Improve the epoll for socket to be compatible with Linux.

hi, how was it tested? also, could you please resend a patch with full context?

Jul 5 2021, 11:58 AM
dchagin accepted D30987: Only handle robust mutexes and sigfastblock on exec and exit for native FreeBSD ABIs.

thanks!

Jul 5 2021, 8:05 AM

Jul 1 2021

dchagin accepted D30988: clock_gettime: Add Linux aliases for CLOCK_*.
Jul 1 2021, 9:58 PM
dchagin added a comment to D30987: Only handle robust mutexes and sigfastblock on exec and exit for native FreeBSD ABIs.

it would be nice to eliminate umtx_thread_exit() call from linux_exit().
I'm AFK till monday, went to pick up the boat after repair, so im ok with the proposed change

Jul 1 2021, 9:45 PM

Jun 29 2021

dchagin committed R10:5ca9d4170007: LinuxKPI: Rename a short description of the kmalloc type. (authored by dchagin).
LinuxKPI: Rename a short description of the kmalloc type.
Jun 29 2021, 5:21 PM
dchagin committed R10:1fd26da926d5: LinuxKPI: Put compat code under appropriate condition. (authored by dchagin).
LinuxKPI: Put compat code under appropriate condition.
Jun 29 2021, 5:21 PM
dchagin committed R10:5d9f790191fe: Eliminate p_elf_machine from struct proc. (authored by dchagin).
Eliminate p_elf_machine from struct proc.
Jun 29 2021, 5:21 PM
dchagin committed R10:945accf502db: LinuxKPI: Use the proper API to determine the ABI of the running process. (authored by dchagin).
LinuxKPI: Use the proper API to determine the ABI of the running process.
Jun 29 2021, 5:21 PM
dchagin committed R10:615f22b2fb6d: Add a link to the Elf_Brandinfo into the struc proc. (authored by dchagin).
Add a link to the Elf_Brandinfo into the struc proc.
Jun 29 2021, 5:21 PM
dchagin closed D30928: LinuxKPI: Rename a short description of kmalloc type..
Jun 29 2021, 5:21 PM
dchagin closed D30927: LinuxKPI: Put compat code under appropriate condition..
Jun 29 2021, 5:21 PM
dchagin closed D30926: Eliminate p_elf_machine from struct proc..
Jun 29 2021, 5:20 PM
dchagin closed D30924: LinuxKPI: Use the proper API to determine the ABI of the running process..
Jun 29 2021, 5:20 PM
dchagin closed D30918: Add a link to the Elf_Brandinfo into the struct sysentvec..
Jun 29 2021, 5:20 PM
dchagin added a comment to D30918: Add a link to the Elf_Brandinfo into the struct sysentvec..

Why would we want ABI to do this, though?

Jun 29 2021, 2:42 PM

Jun 28 2021

dchagin added a comment to D30927: LinuxKPI: Put compat code under appropriate condition..

Roll this into D30924?

Jun 28 2021, 6:19 PM
dchagin added a reviewer for D30926: Eliminate p_elf_machine from struct proc.: jhb.
Jun 28 2021, 5:34 PM
dchagin added reviewers for D30928: LinuxKPI: Rename a short description of kmalloc type.: hselasky, markj, kib.
Jun 28 2021, 5:33 PM
dchagin added reviewers for D30927: LinuxKPI: Put compat code under appropriate condition.: hselasky, kib.
Jun 28 2021, 5:32 PM
dchagin added reviewers for D30926: Eliminate p_elf_machine from struct proc.: markj, kib.
Jun 28 2021, 5:31 PM
dchagin requested review of D30928: LinuxKPI: Rename a short description of kmalloc type..
Jun 28 2021, 5:30 PM
dchagin requested review of D30927: LinuxKPI: Put compat code under appropriate condition..
Jun 28 2021, 5:29 PM
dchagin requested review of D30926: Eliminate p_elf_machine from struct proc..
Jun 28 2021, 5:25 PM
dchagin added inline comments to D30918: Add a link to the Elf_Brandinfo into the struct sysentvec..
Jun 28 2021, 2:23 PM
dchagin added reviewers for D30924: LinuxKPI: Use the proper API to determine the ABI of the running process.: hselasky, markj, kib.
Jun 28 2021, 2:08 PM