Thanks for looking at the code. We are able to see sporadic problems when running "diskinfo -i /dev/daX" doing large asynchronous random reads (1024 kbytes) . The patch resolves the problem.

In D41550#946927, @imp wrote:

In D41550#946911, @scott.benesh_microsemi.com wrote:

Not sure what sys/contrib/dev would buy us. We would want the driver in the kernel so doesn't it have to be in sys/dev ?

sys/contrib/dev buys two things (and doesn't do one thing you think)

1. It turns off a number of formatting and pedantic requirements for formatting. This will become increasingly more important as time rolls on and the FreeBSD project tries to get more in line with other projects.
2. You can use a 'vendor tree' to merge in your vendor changes. This lets you more easily manage the diffs that FreeBSD has added to keep the driver up to date with the latest APIs between imports from the vendor.

It does not mean it won't be in the GENERIC kernel. That's controlled via a different mechanism.

It's also just a suggestion based on microchip's recent publication of its latest linux driver on github.

Not sure what sys/contrib/dev would buy us. We would want the driver in the kernel so doesn't it have to be in sys/dev ?

We have been testing the changes and everything looks good.

In D34469#781024, @imp wrote:

are similar changes needed for FreeBSD's main branch?

In D30182#685826, @imp wrote:

OK. This has landed. Please double check me and let me know if I've botched something.... I hope to MFC this in a week or so.

In D29584#668508, @imp wrote:

In D29584#668490, @mav wrote:

It's a pretty big patch with many changes to easily review. I barely looked through 1/8th of it. It would be good if you at least separated formatting from substantial changes.

Thats' why I've not looked more deeply at it. OTOH, since this is basically vendor code, I'm inclined to not worry so much about the formatting and similar issues, but they do make it hard to review whether or not new bugs are sneaking in with all the bug fixes and formatting changes. It's tough to know how to balance these issues. Though reports of lockups here are concerning enough that I think some response to them is needed before proceeding.

We haven't had any problems with testing. I'm ok with it from our side.

In D22598#494456, @imp wrote:

In D22598#494383, @jhb wrote:

@sbruno Do you have a PoC for this driver?

IIRC, it was from HP. But I'm not sure how well PQI with SOP has been accepted in the marketplace...

No problems. Will make sure the message is clear that this is for new hardware that has never been released.

This hardware has not been released yet. Isn't this the best time to do this?