Page MenuHomeFreeBSD
Feed Advanced Search

Nov 17 2023

kjopek_gmail.com added a comment to D42638: Rockchip RNG.

Generally speaking, lot of style issues.

Nov 17 2023, 9:56 AM

Apr 28 2023

kjopek_gmail.com added a comment to D39846: Fix BeagleBone Black panic on system start.

When used with latest DTB we still face panic, however related to event timer:

Apr 28 2023, 3:22 PM

Apr 27 2023

kjopek_gmail.com requested review of D39846: Fix BeagleBone Black panic on system start.
Apr 27 2023, 9:21 AM

Aug 18 2022

kjopek_gmail.com abandoned D32387: dwmmc: switch to double-buffer structure.

There is no visible benefits so far from that change apart from more efficient usage of descriptors. Abandoning it for now.

Aug 18 2022, 9:02 AM

Jul 30 2022

kjopek_gmail.com added a comment to D35998: TPM: do not set device description if probe fails.

@kd Feel free to commit it - I have no particular preferences on committer.

Jul 30 2022, 5:55 PM
kjopek_gmail.com added a reviewer for D35998: TPM: do not set device description if probe fails: contact_artur-rojek.eu.
Jul 30 2022, 7:59 AM
kjopek_gmail.com requested review of D35998: TPM: do not set device description if probe fails.
Jul 30 2022, 7:58 AM

Jul 1 2022

kjopek_gmail.com added inline comments to D35686: ifconfig.8: Polish.
Jul 1 2022, 8:59 AM

May 26 2022

kjopek_gmail.com updated the diff for D35314: Implement sticky ARP mode for interfaces..

Bump date for ifconfig.8

May 26 2022, 7:37 PM
kjopek_gmail.com updated the diff for D35314: Implement sticky ARP mode for interfaces..

Adjust ifconfig.8 after review.

May 26 2022, 7:08 PM

May 25 2022

kjopek_gmail.com added a reviewer for D35314: Implement sticky ARP mode for interfaces.: contact_artur-rojek.eu.
May 25 2022, 12:08 PM
kjopek_gmail.com updated the summary of D35314: Implement sticky ARP mode for interfaces..
May 25 2022, 6:23 AM
kjopek_gmail.com requested review of D35314: Implement sticky ARP mode for interfaces..
May 25 2022, 6:22 AM

Nov 2 2021

kjopek_gmail.com updated the diff for D32387: dwmmc: switch to double-buffer structure.

Update according to comments. IDMAC_MAX_SIZE will be changed in another MR.

Nov 2 2021, 9:20 AM
kjopek_gmail.com added inline comments to D32387: dwmmc: switch to double-buffer structure.
Nov 2 2021, 9:18 AM

Oct 9 2021

kjopek_gmail.com requested review of D32387: dwmmc: switch to double-buffer structure.
Oct 9 2021, 1:54 AM

Sep 26 2021

kjopek_gmail.com updated the diff for D30387: Make the code consistent with the comments.

Update patch according to latest comments.

Sep 26 2021, 11:17 AM

Sep 24 2021

kjopek_gmail.com added a comment to D30387: Make the code consistent with the comments.

@manu: The handling of bouncing buffers itself is correct in this case. I did not observe any issues in sys/arm64/arm64/busdma_bounce.c. However this is needed, because currently it returns invalid value: instead of making reservation for 2 segments it makes reservation for 3/4 segment which in turns leads to crashes in bouncing buffers code. Comment above the line is valid - for sure we need to reserve two segments (it works for one reserved segment too, but I am not sure about all edge cases), but we need to correctly reserve 2 segments, not 3 sectors.

Sep 24 2021, 8:50 AM

Sep 10 2021

kjopek_gmail.com added a comment to D30387: Make the code consistent with the comments.

@mmel I think we need to do something with this review. We have at least one bug report: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=256822 (similar to what I observe).

Sep 10 2021, 9:32 PM

Jul 14 2021

kjopek_gmail.com added a comment to D30786: rk805: add system poweroff support.

Works nice on my RockPro64 board. Thanks!

Jul 14 2021, 3:50 PM

Jun 15 2021

kjopek_gmail.com added a comment to D30387: Make the code consistent with the comments.

I performed again test with

Jun 15 2021, 7:43 AM

May 26 2021

kjopek_gmail.com abandoned D28274: Solve problems with rk3399 dwmmc failing to update clock..

Superseded by https://reviews.freebsd.org/D30387

May 26 2021, 5:19 AM

May 21 2021

kjopek_gmail.com updated the diff for D30387: Make the code consistent with the comments.

Remove redundant space.

May 21 2021, 3:56 PM
kjopek_gmail.com requested review of D30387: Make the code consistent with the comments.
May 21 2021, 3:52 PM

Mar 30 2021

kjopek_gmail.com abandoned D28261: Return errors in bus_dmamap_load.
Mar 30 2021, 11:26 AM

Jan 22 2021

kjopek_gmail.com added a reviewer for D28274: Solve problems with rk3399 dwmmc failing to update clock.: manu.
Jan 22 2021, 12:30 AM
kjopek_gmail.com requested review of D28274: Solve problems with rk3399 dwmmc failing to update clock..
Jan 22 2021, 12:29 AM

Jan 20 2021

kjopek_gmail.com requested review of D28261: Return errors in bus_dmamap_load.
Jan 20 2021, 10:12 PM
kjopek_gmail.com created P478 dwmmc bug after patching off-by-one.
Jan 20 2021, 5:33 PM
kjopek_gmail.com created P477 (An Untitled Masterwork).
Jan 20 2021, 1:20 PM
kjopek_gmail.com created P476 dwmmc debug.
Jan 20 2021, 12:07 PM

Jan 6 2021

kjopek_gmail.com created P473 RK3399 clk update problem - reproduction.
Jan 6 2021, 4:49 PM
kjopek_gmail.com created P472 RK3399 clk update problem.
Jan 6 2021, 12:35 PM

Jan 2 2021

kjopek_gmail.com updated kjopek_gmail.com.
Jan 2 2021, 12:20 AM

Jan 1 2021

kjopek_gmail.com added a comment to D27864: Call close(2) after errno is used..

Submitted by: Konrad Sewiłło-Jopek

Jan 1 2021, 11:48 PM
kjopek_gmail.com updated the diff for D27864: Call close(2) after errno is used..

Provide different dbg messages for different types of errors.

Jan 1 2021, 3:16 PM

Dec 31 2020

kjopek_gmail.com updated the diff for D27864: Call close(2) after errno is used..

Actually, we don't need to use errno_copy in first occurence of described problem.

Dec 31 2020, 3:31 PM
kjopek_gmail.com updated the diff for D27864: Call close(2) after errno is used..

Fix similar problems in different locations. Save original errno value from function it originally generated it.

Dec 31 2020, 3:19 PM
kjopek_gmail.com updated the diff for D27864: Call close(2) after errno is used..

Update patch accordingly to comments.

Dec 31 2020, 2:53 PM
kjopek_gmail.com retitled D27864: Call close(2) after errno is used. from Reduce code duplication to Call close(2) after errno is used..
Dec 31 2020, 2:52 PM
kjopek_gmail.com added a comment to D27864: Call close(2) after errno is used..

Oh, that means the current (in repo) code is wrong anyway. close(2) should be then called just before return.

Dec 31 2020, 2:44 PM
kjopek_gmail.com requested review of D27864: Call close(2) after errno is used..
Dec 31 2020, 1:57 PM

Dec 27 2020

kjopek_gmail.com updated the diff for D26761: Add driver for Synopsys Designware Watchdog timer..

Fixed calibration issue: we should add one tick, not substract.

Dec 27 2020, 12:24 AM

Dec 26 2020

kjopek_gmail.com changed the repository for D26761: Add driver for Synopsys Designware Watchdog timer. from rS FreeBSD src repository - subversion to rG FreeBSD src repository.
Dec 26 2020, 7:34 AM

Dec 22 2020

kjopek_gmail.com added inline comments to D26761: Add driver for Synopsys Designware Watchdog timer..
Dec 22 2020, 8:55 AM

Dec 19 2020

kjopek_gmail.com updated the diff for D26761: Add driver for Synopsys Designware Watchdog timer..

Rework code to remove workarounds, remove clock definition, be more precise on calibration.

Dec 19 2020, 12:28 AM

Dec 18 2020

kjopek_gmail.com updated the summary of D26761: Add driver for Synopsys Designware Watchdog timer..
Dec 18 2020, 1:05 PM
kjopek_gmail.com updated the diff for D26761: Add driver for Synopsys Designware Watchdog timer..

Add calibration.

Dec 18 2020, 1:38 AM

Nov 11 2020

kjopek_gmail.com added a comment to D27174: Allow user to configure endpoints twice.

your patch works perfectly. BladeRF is usable again.

Nov 11 2020, 11:31 PM
kjopek_gmail.com added a comment to D27174: Allow user to configure endpoints twice.

Maybe I will share results from my investigation.

Nov 11 2020, 10:19 AM
kjopek_gmail.com requested review of D27174: Allow user to configure endpoints twice.
Nov 11 2020, 4:44 AM

Nov 4 2020

kjopek_gmail.com requested review of D27085: Plug minor memory leak in dwc3 USB2/USB3 controller..
Nov 4 2020, 7:57 AM

Oct 28 2020

kjopek_gmail.com added a comment to D26847: Add driver for RK3399 non-secure efuse..

Regarding sysctl interface: allwinner driver has data cells hardcoded - should I follow the same way and add hardcoded values to this driver also? Or maybe there is some more elegant way to do so?

Oct 28 2020, 2:23 AM
kjopek_gmail.com updated the diff for D26847: Add driver for RK3399 non-secure efuse..

Rework patch (part 1 of 2):

Oct 28 2020, 2:20 AM

Oct 20 2020

kjopek_gmail.com added a comment to D26735: Improve loading of multipage aligned buffers..

This MR solved problem with eMMC cards on RK3399. Previously card slot was not initialized correctly due to some DMA mapping issues.

Oct 20 2020, 10:12 AM
kjopek_gmail.com added a watcher for arm64: kjopek_gmail.com.
Oct 20 2020, 7:07 AM

Oct 18 2020

kjopek_gmail.com requested review of D26847: Add driver for RK3399 non-secure efuse..
Oct 18 2020, 11:04 PM

Oct 15 2020

kjopek_gmail.com updated the diff for D26761: Add driver for Synopsys Designware Watchdog timer..

Fix interrupt handling: we should clear interrupt bit only if we want to tap watchdog. Minor fixes to build system, remove clock configuration in RK3399 - this should be done in separated commit.

Oct 15 2020, 11:44 PM

Oct 13 2020

kjopek_gmail.com updated the summary of D26761: Add driver for Synopsys Designware Watchdog timer..
Oct 13 2020, 6:25 PM
kjopek_gmail.com added inline comments to D26761: Add driver for Synopsys Designware Watchdog timer..
Oct 13 2020, 5:56 PM
kjopek_gmail.com requested review of D26761: Add driver for Synopsys Designware Watchdog timer..
Oct 13 2020, 5:49 PM

Jun 23 2020

kjopek_gmail.com requested review of D25114: Add entry in rtwn_usb(4) for TP-Link Archer T2U Plus.
Jun 23 2020, 3:20 AM

Mar 22 2020

kjopek_gmail.com added a comment to D24142: Add support for TP-Link Archer T2U Plus.

@hselasky
I think anyone with src commit bit (at least I don't have one). dmesg output is attached at the end of my comment.
Also output of usbconfig:

root@1e66c783a77f:~ # usbconfig -d 0.2 dump_device_desc
ugen0.2: <Realtek 802.11ac WLAN Adapter> at usbus0, cfg=0 md=HOST spd=HIGH (480Mbps) pwr=ON (500mA)
Mar 22 2020, 11:35 AM · network

Mar 21 2020

kjopek_gmail.com created D24142: Add support for TP-Link Archer T2U Plus.
Mar 21 2020, 11:18 PM · network