Page MenuHomeFreeBSD
Feed Advanced Search

Jun 12 2019

ota_j.email.ne.jp added reviewers for D20618: [archivers/nulib] PR 21519 - Use dirent.h instead of sys/dir.h: delphij, emaste.
Jun 12 2019, 3:37 AM
ota_j.email.ne.jp created D20618: [archivers/nulib] PR 21519 - Use dirent.h instead of sys/dir.h.
Jun 12 2019, 1:17 AM

Jun 7 2019

ota_j.email.ne.jp updated the diff for D20545: Break down swap_pager_swapoff function into small functions..

Move vm_object_pip_wakeup() and vm_pager_page_unswapped() back to swp_pager_force_pagein().

Jun 7 2019, 5:21 AM
ota_j.email.ne.jp updated the diff for D13484: swapoff to release multiple swap blocks at a time.

Change -= SWAP_META_PAGES to %= SWAP_META_PAGES.

Jun 7 2019, 1:22 AM
ota_j.email.ne.jp created D20545: Break down swap_pager_swapoff function into small functions..
Jun 7 2019, 1:08 AM

Jun 6 2019

ota_j.email.ne.jp updated the diff for D13484: swapoff to release multiple swap blocks at a time.

Revert back some changes.

Jun 6 2019, 4:41 AM
ota_j.email.ne.jp added a comment to D13484: swapoff to release multiple swap blocks at a time.

I don't think swp_pager_find_continuous() was a good idea/implementation. I will revert it shortly.

Jun 6 2019, 3:01 AM

Jun 5 2019

ota_j.email.ne.jp added a comment to D20271: geom_uzip to update zlib version 1.0.4 to 1.2.11..

Thank you for taking a look.

Jun 5 2019, 5:28 AM
ota_j.email.ne.jp updated the diff for D13484: swapoff to release multiple swap blocks at a time.

Created swp_pager_find_continuous instead of calling swap_pager_haspage().

Jun 5 2019, 3:24 AM

Jun 4 2019

ota_j.email.ne.jp planned changes to D13484: swapoff to release multiple swap blocks at a time.

Doug, thank you for elaboration.
Let's see how that approach works this time.
When I started and tried, it wasn't as easy and I decided to take advantages of existing functions.

Jun 4 2019, 10:29 PM
ota_j.email.ne.jp updated the diff for D13484: swapoff to release multiple swap blocks at a time.

Resolve conflicts, fix style, and break a function.

Jun 4 2019, 10:22 PM

Jun 1 2019

ota_j.email.ne.jp added inline comments to D13484: swapoff to release multiple swap blocks at a time.
Jun 1 2019, 10:48 PM

May 31 2019

ota_j.email.ne.jp added a comment to D20479: Delete sys/dir.h which was deprecated since 1997..

Exp-run info: https://www.freebsd.org/doc/en/articles/committers-guide/ports.html#ports-exp-run
For example https://bugs.freebsd.org/214864 is the exp-run I requested for lld.
I agree that there shouldn't be any ports using sys/dir.h still but it is still good to confirm that prior to the commit. (Here it's almost certainly been long enough that it's not necessary, but is a best practice.)

I'll ask in the #bsdports channel if anyone there thinks it's necessary.

May 31 2019, 3:55 AM
ota_j.email.ne.jp added a comment to D13484: swapoff to release multiple swap blocks at a time.

I updated test case section with performance measurement.

May 31 2019, 2:38 AM
ota_j.email.ne.jp added a comment to D20479: Delete sys/dir.h which was deprecated since 1997..

What do you mean by "an exp-run?" I had made buildworld and buildkernel successful on i386. Universe will be better but I don't have enough disk space.

May 31 2019, 2:13 AM
ota_j.email.ne.jp updated the summary of D20479: Delete sys/dir.h which was deprecated since 1997..
May 31 2019, 12:44 AM
ota_j.email.ne.jp created D20479: Delete sys/dir.h which was deprecated since 1997..
May 31 2019, 12:43 AM

May 30 2019

ota_j.email.ne.jp updated the test plan for D13484: swapoff to release multiple swap blocks at a time.
May 30 2019, 3:27 AM

May 29 2019

ota_j.email.ne.jp updated the diff for D20193: Relocate crc32 functions from libkern.h to gsb_crc32.h/c.

Fix KERN to GSB.

May 29 2019, 1:05 AM
ota_j.email.ne.jp retitled D20193: Relocate crc32 functions from libkern.h to gsb_crc32.h/c from Relocate crc32 functions from libkern.h to crc32.h and rename crc32.c to kern_crc32.c to Relocate crc32 functions from libkern.h to gsb_crc32.h/c.
May 29 2019, 12:47 AM
ota_j.email.ne.jp updated the diff for D20193: Relocate crc32 functions from libkern.h to gsb_crc32.h/c.

After research, I found that our crc32 functions are based on the code written
by Gary S Brown. We also have many other *crc32.[hc] files, too. Rather than,
prefixing with kern, prefix with his initial to honor his work.
It looks kern prefix is used for sub-systems.

May 29 2019, 12:34 AM

May 25 2019

ota_j.email.ne.jp added inline comments to D13484: swapoff to release multiple swap blocks at a time.
May 25 2019, 9:46 PM
ota_j.email.ne.jp updated the diff for D13484: swapoff to release multiple swap blocks at a time.

Fix style.

May 25 2019, 6:37 PM
ota_j.email.ne.jp added inline comments to D13484: swapoff to release multiple swap blocks at a time.
May 25 2019, 2:10 PM
ota_j.email.ne.jp updated the diff for D13484: swapoff to release multiple swap blocks at a time.

KASSERT rearragements.

May 25 2019, 2:06 PM
ota_j.email.ne.jp added inline comments to D13484: swapoff to release multiple swap blocks at a time.
May 25 2019, 2:59 AM

May 24 2019

ota_j.email.ne.jp updated the diff for D13484: swapoff to release multiple swap blocks at a time.

Reverted few of experiments back to a working code.

May 24 2019, 9:22 PM
ota_j.email.ne.jp updated the diff for D13484: swapoff to release multiple swap blocks at a time.

This also crashed.

May 24 2019, 9:12 PM
ota_j.email.ne.jp updated the diff for D13484: swapoff to release multiple swap blocks at a time.

This crashed.

May 24 2019, 9:04 PM
ota_j.email.ne.jp updated the diff for D13484: swapoff to release multiple swap blocks at a time.

Reverted KASSERT.
Also experimented without calling swap_pager_haspage().
The result was instant reboot.

May 24 2019, 6:00 PM
ota_j.email.ne.jp planned changes to D13484: swapoff to release multiple swap blocks at a time.

I will revert and fix KASSERTs.
I will also test removing swap_pager_haspage() call.

May 24 2019, 5:11 AM
ota_j.email.ne.jp added inline comments to D13484: swapoff to release multiple swap blocks at a time.
May 24 2019, 2:17 AM
ota_j.email.ne.jp updated the diff for D13484: swapoff to release multiple swap blocks at a time.

Moved i -= SWAP_META_PAGES decrement and update variables to print in KASSERT.

May 24 2019, 2:01 AM

May 23 2019

ota_j.email.ne.jp planned changes to D13484: swapoff to release multiple swap blocks at a time.

Thank you for review comments.
Given loops changed a lot, I'd like to send more time testing the recent changes.
I also want to update some comments in the code to be more descriptive and clear.

May 23 2019, 2:57 AM
ota_j.email.ne.jp updated the diff for D13484: swapoff to release multiple swap blocks at a time.

Simplify the swp_blks loop and adjust style.

May 23 2019, 2:40 AM

May 22 2019

ota_j.email.ne.jp updated the diff for D13484: swapoff to release multiple swap blocks at a time.

Delete an extra empty line.

May 22 2019, 5:13 AM
ota_j.email.ne.jp updated the diff for D13484: swapoff to release multiple swap blocks at a time.

It is boolean_t type and thus check TRUE instead of true.

May 22 2019, 5:09 AM
ota_j.email.ne.jp updated the diff for D13484: swapoff to release multiple swap blocks at a time.

Take return value of vm_pager_has_page() as boolean instead of int.

May 22 2019, 5:01 AM
ota_j.email.ne.jp updated the diff for D13484: swapoff to release multiple swap blocks at a time.

Fixed typo.

May 22 2019, 4:40 AM
ota_j.email.ne.jp updated the diff for D13484: swapoff to release multiple swap blocks at a time.

Adjusted baesd on review comments for function names and nested loop to a loop.

May 22 2019, 4:36 AM
ota_j.email.ne.jp planned changes to D13484: swapoff to release multiple swap blocks at a time.

I didn't realize I had had comments on this.
I sincerely apologize.
Doug have made lots of improvements in this area and I'm not sure if this patch/changeset applies to the latest code base.
I will take a look.

May 22 2019, 1:52 AM

May 20 2019

ota_j.email.ne.jp updated the diff for D20193: Relocate crc32 functions from libkern.h to gsb_crc32.h/c.

Svn up and resolved conflicts.

May 20 2019, 10:16 PM
ota_j.email.ne.jp planned changes to D20193: Relocate crc32 functions from libkern.h to gsb_crc32.h/c.

r347984 creates conflicts for lio_bsd.h and if_cdce.c.
I need to svn up and rebase.

May 20 2019, 5:09 AM

May 17 2019

ota_j.email.ne.jp updated the diff for D20193: Relocate crc32 functions from libkern.h to gsb_crc32.h/c.

More _KERNEL adjustments.

May 17 2019, 2:51 AM
ota_j.email.ne.jp updated the test plan for D20193: Relocate crc32 functions from libkern.h to gsb_crc32.h/c.
May 17 2019, 2:19 AM
ota_j.email.ne.jp added inline comments to D20193: Relocate crc32 functions from libkern.h to gsb_crc32.h/c.
May 17 2019, 2:17 AM
ota_j.email.ne.jp added inline comments to D20193: Relocate crc32 functions from libkern.h to gsb_crc32.h/c.
May 17 2019, 2:15 AM
ota_j.email.ne.jp updated the diff for D20193: Relocate crc32 functions from libkern.h to gsb_crc32.h/c.

Remove one more extra prototype.

May 17 2019, 2:04 AM
ota_j.email.ne.jp updated the diff for D20193: Relocate crc32 functions from libkern.h to gsb_crc32.h/c.

Replace ifdef USERSPACE_TESTING to ifndef _KERNEL.

May 17 2019, 1:57 AM

May 16 2019

ota_j.email.ne.jp added reviewers for D20272: if_mxge to update zlib version 1.0.4 to 1.2.11.: jmg, delphij, kib.
May 16 2019, 4:35 AM
ota_j.email.ne.jp created D20272: if_mxge to update zlib version 1.0.4 to 1.2.11..
May 16 2019, 4:34 AM
ota_j.email.ne.jp updated the summary of D20271: geom_uzip to update zlib version 1.0.4 to 1.2.11..
May 16 2019, 4:17 AM
ota_j.email.ne.jp added reviewers for D20271: geom_uzip to update zlib version 1.0.4 to 1.2.11.: kib, delphij, jmg.
May 16 2019, 4:15 AM
ota_j.email.ne.jp created D20271: geom_uzip to update zlib version 1.0.4 to 1.2.11..
May 16 2019, 4:13 AM

May 15 2019

ota_j.email.ne.jp planned changes to D20248: Delete kgzip and kgzldr..

It looks this change hasn't yet committed.

May 15 2019, 8:00 AM
ota_j.email.ne.jp updated the diff for D20248: Delete kgzip and kgzldr..

Delete unneeded comments and put 2019 May.

May 15 2019, 1:21 AM

May 14 2019

ota_j.email.ne.jp updated the summary of D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..
May 14 2019, 3:19 AM
ota_j.email.ne.jp planned changes to D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..

This change requires https://reviews.freebsd.org/D20193 to address duplicate crc32() API between zlib and libkern.h.
I will make some minor adjustments after that's done.

May 14 2019, 3:16 AM
ota_j.email.ne.jp retitled D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib. from Kernel to use the latest contrib/zlib. to Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..
May 14 2019, 3:13 AM
ota_j.email.ne.jp updated the diff for D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..

Don't touch ZFS module, yet.

May 14 2019, 3:10 AM
ota_j.email.ne.jp retitled D20193: Relocate crc32 functions from libkern.h to gsb_crc32.h/c from Relocate crc32 functtions from libkern.h to crc32.h to Relocate crc32 functions from libkern.h to crc32.h and rename crc32.c to kern_crc32.c.
May 14 2019, 3:07 AM
ota_j.email.ne.jp updated the diff for D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..

I split the original change-set to multiple ones.

May 14 2019, 3:06 AM
ota_j.email.ne.jp added a comment to D20222: Drop z_stream zbuf.state->dummy from SDT probe..

I was able to link both old and new versions of zlib at same time over weekend.
So, this change became no longer immediate blocker.
I thought it would be nicer to address zlib conversion in a single commit instead of two commits once upon time.

May 14 2019, 2:41 AM
ota_j.email.ne.jp updated the diff for D20222: Drop z_stream zbuf.state->dummy from SDT probe..

Exclude unintended files... :(

May 14 2019, 2:35 AM
ota_j.email.ne.jp updated the diff for D20222: Drop z_stream zbuf.state->dummy from SDT probe..

Delete comments about usage of STD_PROBE5.

May 14 2019, 2:35 AM

May 13 2019

ota_j.email.ne.jp updated the summary of D20248: Delete kgzip and kgzldr..
May 13 2019, 10:48 AM
ota_j.email.ne.jp planned changes to D20222: Drop z_stream zbuf.state->dummy from SDT probe..

It looks I can put 2 versions of zlib into kernel.
Let's wait and see.

May 13 2019, 10:46 AM

May 12 2019

ota_j.email.ne.jp created D20248: Delete kgzip and kgzldr..
May 12 2019, 7:05 PM
ota_j.email.ne.jp updated the diff for D20193: Relocate crc32 functions from libkern.h to gsb_crc32.h/c.

Rename libkern/crc32.c to libkern/kern_crc32.c to avoid having same object
filename as zlib/crc32.c.

May 12 2019, 2:51 PM
ota_j.email.ne.jp planned changes to D20193: Relocate crc32 functions from libkern.h to gsb_crc32.h/c.

I'd like to rename libkern/crc32.c to libkern/kern_crc32.c so that we don't get object filename conflict with zlib/crc32.c as well.
I'm having difficulties with arc diff...

May 12 2019, 4:02 AM

May 10 2019

ota_j.email.ne.jp updated the summary of D20222: Drop z_stream zbuf.state->dummy from SDT probe..
May 10 2019, 10:05 AM
ota_j.email.ne.jp created D20222: Drop z_stream zbuf.state->dummy from SDT probe..
May 10 2019, 12:15 AM

May 9 2019

ota_j.email.ne.jp added inline comments to D20193: Relocate crc32 functions from libkern.h to gsb_crc32.h/c.
May 9 2019, 4:37 AM
ota_j.email.ne.jp retitled D20193: Relocate crc32 functions from libkern.h to gsb_crc32.h/c from Split crc32 functions libkern.h to crc32.h to Relocate crc32 functtions from libkern.h to crc32.h.
May 9 2019, 4:33 AM
ota_j.email.ne.jp updated the diff for D20193: Relocate crc32 functions from libkern.h to gsb_crc32.h/c.

Fixed function prototype style.

May 9 2019, 12:21 AM

May 8 2019

ota_j.email.ne.jp updated the test plan for D20193: Relocate crc32 functions from libkern.h to gsb_crc32.h/c.
May 8 2019, 2:12 AM
ota_j.email.ne.jp updated the diff for D20193: Relocate crc32 functions from libkern.h to gsb_crc32.h/c.

Combine SCTP cases.

May 8 2019, 2:10 AM
ota_j.email.ne.jp added reviewers for D20191: Relocate contrib/zlib to sys/contrib/zlib so that we can use this in kernel.: kib, jmg, delphij.
May 8 2019, 2:01 AM
ota_j.email.ne.jp added reviewers for D20190: Delete #include <sys/inflate.h> from sys/mips.: kib, delphij, jmg.
May 8 2019, 2:00 AM
ota_j.email.ne.jp created D20193: Relocate crc32 functions from libkern.h to gsb_crc32.h/c.
May 8 2019, 12:30 AM
ota_j.email.ne.jp updated the diff for D20191: Relocate contrib/zlib to sys/contrib/zlib so that we can use this in kernel..

Exclude unintended change.

May 8 2019, 12:10 AM
ota_j.email.ne.jp created D20191: Relocate contrib/zlib to sys/contrib/zlib so that we can use this in kernel..
May 8 2019, 12:06 AM
ota_j.email.ne.jp created D20190: Delete #include <sys/inflate.h> from sys/mips..
May 8 2019, 12:03 AM

May 7 2019

ota_j.email.ne.jp added a comment to D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..

Relocation of contrib/zlib to sys/contrib/zilb is making the biggest noise in the diff.

May 7 2019, 3:16 AM

May 4 2019

ota_j.email.ne.jp updated the summary of D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..
May 4 2019, 3:50 AM

May 3 2019

ota_j.email.ne.jp updated the diff for D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..

Deleted uncalled functions from ng_zlib.c and reverted z_ prefixes.

May 3 2019, 11:30 PM

May 2 2019

ota_j.email.ne.jp updated the diff for D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..

Reverted aout.4 and also add "zlib" in sys/conf/files (I think we need this for "device").

May 2 2019, 1:08 AM
ota_j.email.ne.jp updated the diff for D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..

Use zlib uncompress function and updated README.

May 2 2019, 12:57 AM

Apr 23 2019

ota_j.email.ne.jp updated the diff for D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..

Created "device zlib" and updated dependencies.

Apr 23 2019, 3:09 AM

Apr 21 2019

ota_j.email.ne.jp retitled D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib. from Kernel code to upgrade to use the latest contrib/zlib. to Kernel to use the latest contrib/zlib..
Apr 21 2019, 4:25 PM
ota_j.email.ne.jp updated the diff for D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..

Deleted sys/inflate.h from mips and i386's kgzip and kgzldr.

Apr 21 2019, 2:33 PM

Apr 12 2019

ota_j.email.ne.jp updated the diff for D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..

Removed personal notes.

Apr 12 2019, 1:47 AM

Apr 10 2019

ota_j.email.ne.jp planned changes to D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..

Both buildworld and buildkernel finises without a problem.

Apr 10 2019, 5:36 AM
ota_j.email.ne.jp updated the diff for D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..

Use bsd.kmod.mk to share ZLIB_CFLAGS.

Apr 10 2019, 3:55 AM
ota_j.email.ne.jp updated the diff for D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..

Moved contrib/zlib to sys/contrib/zlib.

Apr 10 2019, 1:38 AM

Apr 9 2019

ota_j.email.ne.jp updated the diff for D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..

Created own std header wrapper instead of using zstd's.

Apr 9 2019, 12:37 PM

Apr 8 2019

ota_j.email.ne.jp updated the diff for D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..

Few changes were missed in the last review.

Apr 8 2019, 1:05 AM
ota_j.email.ne.jp updated the diff for D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..

ZLIB was modified to compile with -DNO_GZIP to avoid including stdlib.h once.
However, ZFS uses GZIP in its own zlib clone and thus adjusted again to work
ZLIB without -DNO_GZIP.
With ZFS's zconf.h, ZLIB symols were renamed to z_* and few of them were zz_*.
zmod implementatoins are prefixed with zmod_* to avoid conflicts.

Apr 8 2019, 12:58 AM

Apr 5 2019

ota_j.email.ne.jp updated the diff for D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..

Actually zfs uses zlib but its own copy, zmod, and it has few extra funcions.

Apr 5 2019, 4:44 AM

Apr 3 2019

ota_j.email.ne.jp retitled D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib. from Use from and upgrade kernel code to the latest contrib/zlib. to Kernel code to upgrade to use the latest contrib/zlib..
Apr 3 2019, 4:36 AM