Btw, ever since "goto fail" I've made adding braces even for single-line conditionals a habit. Removed that here to match your style, but noting that this does include exactly a "goto fail" (well, "goto again") scenario. ;-)
- All Stories
- Advanced Search
- Transaction Logs
Fri, May 26
Updated diff to address christos's comments.
Addressing christos's comments.
Feb 13 2023
Jan 30 2023
Dec 20 2022
You know what, you can ditch this review. The changes in-tree diverged or superseded already from what was in https://reviews.freebsd.org/D37674.
Full context diff (second try, I guess).
Full context diff (git diff -U999999).
I don't have the repository checked out right now (was working off the web-ui). Based on https://wiki.freebsd.org/GitWorkflow, I gather the recommended tree is the one from GitHub? I'll go and grab that one and will update here if the diff ends up different from what I just posted.
Diff against https://cgit.freebsd.org/src/plain/share/man/man7/sizeof.7 (hopefully correctly, this time).
Dec 13 2022
Removed 'All rights reserved.'
Rephrasing a few things based on pstef's feedback.
Dec 12 2022
In D37674#856694, @kib wrote:
Can you send the git patch to me, with proper metadata (mostly author) set? Thanks.
Add uint64_t example, elide "at runtime".
Mention NBBY, ntimes(), and standards.
Update with pauamma@'s feedback.
Dec 11 2022
Minor formatting tweaks.