Page MenuHomeFreeBSD
Feed Advanced Search

Mar 10 2023

pauamma_gundo.com requested review of D39022: 2023Q1 Valgrind status report.
Mar 10 2023, 11:32 PM
pauamma_gundo.com accepted D39016: 13.2 relnotes: additions/changes suggested by emaste.
Mar 10 2023, 9:06 PM
pauamma_gundo.com added a comment to D39016: 13.2 relnotes: additions/changes suggested by emaste.

Minor nit, fixable on commit.

Mar 10 2023, 9:06 PM

Mar 9 2023

pauamma_gundo.com committed R9:f622f1f7d54f: 2023Q1 kinst DTrace status report submission (authored by christos).
2023Q1 kinst DTrace status report submission
Mar 9 2023, 8:40 PM
pauamma_gundo.com added a comment to D38976: cap_*(2): Document ENOSYS behavior..

Ignore the "request changes" from Doc Committers. I'm not allowed to approve as that group while under mentorship, but (unless I missed something) Phabricator didn't let me uncheck any checkboxes when I requested changes earlier. :-(

Mar 9 2023, 3:40 PM
pauamma_gundo.com accepted D38976: cap_*(2): Document ENOSYS behavior..
Mar 9 2023, 3:38 PM

Mar 8 2023

pauamma_gundo.com requested changes to D38976: cap_*(2): Document ENOSYS behavior..
Mar 8 2023, 10:33 PM
pauamma_gundo.com closed D38917: Add 13.2-RC1 actual date to 13.2 schedule.
Mar 8 2023, 9:44 PM
pauamma_gundo.com committed R9:4efab9583194: Add 13.2-RC1 actual date to 13.2 schedule (authored by pauamma_gundo.com).
Add 13.2-RC1 actual date to 13.2 schedule
Mar 8 2023, 9:44 PM
pauamma_gundo.com added a comment to D38917: Add 13.2-RC1 actual date to 13.2 schedule.

@cperciva: since it's Wednesday evening UTC and I haven't had mentor approval yet, do you want to commit this yourself before next Friday requires another change?

Mar 8 2023, 8:24 PM

Mar 7 2023

pauamma_gundo.com accepted D38890: status/report-2023-01-2023-03/gcc.adoc: Add report.
Mar 7 2023, 8:30 PM

Mar 6 2023

pauamma_gundo.com accepted D38919: freebsd-status-report-process: Add article.

Missed one. Fixable on commit.

Mar 6 2023, 7:21 PM
pauamma_gundo.com accepted D38890: status/report-2023-01-2023-03/gcc.adoc: Add report.

English LGTM.

Mar 6 2023, 2:50 PM
pauamma_gundo.com added a comment to D38367: Better error checking in code example..
In D38367#878182, @pauamma wrote:
In D38367#872754, @pauamma wrote:

Over to mentors

ping @carlavilla @gjb

Mar 6 2023, 10:51 AM
pauamma_gundo.com added a comment to D38509: Split 'About FreeBSD Ports' to 1 sentence per line..

ping @carlavilla @gjb (this is blocking https://reviews.freebsd.org/D38510, which is already mentor-approved).

Mar 6 2023, 10:49 AM
pauamma_gundo.com requested changes to D38919: freebsd-status-report-process: Add article.
Mar 6 2023, 1:30 AM

Mar 5 2023

pauamma_gundo.com updated the diff for D37094: Suggest port maintainers submit bugs for VuXML updates..
  • Address edit comments by riggs and grahamperrin
Mar 5 2023, 11:43 PM
pauamma_gundo.com added a comment to D37094: Suggest port maintainers submit bugs for VuXML updates..

Updated patch to follow after it finishes building and I look it over.

Mar 5 2023, 10:59 PM
pauamma_gundo.com requested review of D38917: Add 13.2-RC1 actual date to 13.2 schedule.
Mar 5 2023, 7:38 PM
pauamma_gundo.com added a comment to D38915: Prepare Handbook and FAQ for 13.2-RELEASE.

Only commit once 13.2-RELEASE is officially announced. (It needs that date inserted anyway.)

Mar 5 2023, 5:42 PM
pauamma_gundo.com requested review of D38915: Prepare Handbook and FAQ for 13.2-RELEASE.
Mar 5 2023, 5:40 PM

Mar 4 2023

pauamma_gundo.com accepted D38891: 13.2 relnotes: correct/expand linux(4) and cpuset items.
Mar 4 2023, 11:49 AM

Mar 3 2023

pauamma_gundo.com accepted D38890: status/report-2023-01-2023-03/gcc.adoc: Add report.

Minor nits, fixable on commit.

Mar 3 2023, 10:17 PM

Mar 1 2023

pauamma_gundo.com committed rG07f1d6b99587: Fix a slew of mdoc warnings/errors. (authored by brueffer).
Fix a slew of mdoc warnings/errors.
Mar 1 2023, 10:19 AM

Feb 28 2023

pauamma_gundo.com accepted D38827: 13.2 relnotes: misc updates.
Feb 28 2023, 10:56 PM
pauamma_gundo.com accepted D38827: 13.2 relnotes: misc updates.

English LGTM.

Feb 28 2023, 8:31 PM

Feb 26 2023

pauamma_gundo.com accepted D38771: CONTRIBUTING.md: Add in for github pull requests.
Feb 26 2023, 11:16 PM
pauamma_gundo.com accepted D38771: CONTRIBUTING.md: Add in for github pull requests.

LGTM as far as English is concerned with these typos fixed and the spurious word removed.

Feb 26 2023, 10:05 PM
pauamma_gundo.com accepted D38796: Contributors to FreeBSD: make the article more relevant and appealing.

Other than that nit (fixable on commit), LGTM.

Feb 26 2023, 12:59 PM
pauamma_gundo.com committed R9:f677eade7d13: Add Beta3 actual build date (authored by pauamma_gundo.com).
Add Beta3 actual build date
Feb 26 2023, 12:43 PM
pauamma_gundo.com closed D38788: Add Beta3 actual build date.
Feb 26 2023, 12:43 PM
pauamma_gundo.com added a comment to D37094: Suggest port maintainers submit bugs for VuXML updates..
In D37094#866667, @pauamma wrote:

Good questions all. Waiting for a ports secteam member to address them so I can revise this usefully.

Feb 26 2023, 10:40 AM
pauamma_gundo.com accepted D38783: route.8: Add information about ROUTE_MPATH and FIB_ALGO.

English LGTM. Can't attest to the consistency with source code.

Feb 26 2023, 9:42 AM
pauamma_gundo.com added a comment to D38788: Add Beta3 actual build date.

Over to @carlavilla and or @gjb for mentor approval.

Feb 26 2023, 8:48 AM
pauamma_gundo.com requested review of D38788: Add Beta3 actual build date.
Feb 26 2023, 1:53 AM
pauamma_gundo.com added inline comments to D38771: CONTRIBUTING.md: Add in for github pull requests.
Feb 26 2023, 12:50 AM

Feb 25 2023

pauamma_gundo.com requested changes to D38783: route.8: Add information about ROUTE_MPATH and FIB_ALGO.
Feb 25 2023, 11:45 PM
pauamma_gundo.com added a comment to D38768: Import spell(1) and deroff(1) from OpenBSD.
In D38768#882357, @mjg wrote:

is there really use for it in base instead of as a port? especially the deroff thing is kind of... niche

Feb 25 2023, 10:38 PM
pauamma_gundo.com accepted D37724: internal/developer.adoc (Resources for FreeBSD Committers): update and corrections.
Feb 25 2023, 7:19 PM

Feb 23 2023

pauamma_gundo.com accepted D38644: netinet6: allow disabling excess log messages.
Feb 23 2023, 10:23 PM
pauamma_gundo.com added inline comments to D38745: 13.2 release notes: dpdk_lpm4 and dpdk_lpm6 modules are now available.
Feb 23 2023, 10:12 PM

Feb 22 2023

pauamma_gundo.com added inline comments to D38644: netinet6: allow disabling excess log messages.
Feb 22 2023, 11:17 PM
pauamma_gundo.com requested changes to D38644: netinet6: allow disabling excess log messages.
Feb 22 2023, 7:36 PM
pauamma_gundo.com closed D38720: Make "which subdomains" comment reflect current code and future-proof it Discussed with dbaio..
Feb 22 2023, 5:51 PM
pauamma_gundo.com committed R9:14a267f652a6: Make "which subdomains" comment reflect current code and future-proof it (authored by pauamma_gundo.com).
Make "which subdomains" comment reflect current code and future-proof it
Feb 22 2023, 5:51 PM
pauamma_gundo.com requested review of D38720: Make "which subdomains" comment reflect current code and future-proof it Discussed with dbaio..
Feb 22 2023, 2:17 AM

Feb 21 2023

pauamma_gundo.com accepted D27959: kldxref: skip .pkgsave files.

Minor nit fixable on commit.

Feb 21 2023, 11:10 PM
pauamma_gundo.com accepted D27959: kldxref: skip .pkgsave files.

Please remember to bump .Dd :)

Feb 21 2023, 5:38 PM
pauamma_gundo.com added a reviewer for D27959: kldxref: skip .pkgsave files: manpages.
Feb 21 2023, 5:32 PM

Feb 20 2023

pauamma_gundo.com accepted D38675: open.2: describe O_RESOLVE_BENEATH errors correctly.

Minor nits, fixable on commit.

Feb 20 2023, 9:31 PM
pauamma_gundo.com added a comment to D27959: kldxref: skip .pkgsave files.

You didn't ask for manpages approval. Is that deliberate?

Feb 20 2023, 8:13 PM

Feb 19 2023

pauamma_gundo.com added a comment to D38675: open.2: describe O_RESOLVE_BENEATH errors correctly.

Hopefully more clear this way?

Feb 19 2023, 9:48 PM
pauamma_gundo.com added inline comments to D38675: open.2: describe O_RESOLVE_BENEATH errors correctly.
Feb 19 2023, 8:47 PM
pauamma_gundo.com accepted D38667: 13.2 release notes: 233ab015c0d7 and 1dcb6002c500.
Feb 19 2023, 4:46 PM

Feb 18 2023

pauamma_gundo.com accepted D38654: netstat.1: Clarify -i and -I priorities.
Feb 18 2023, 4:48 PM

Feb 17 2023

pauamma_gundo.com accepted D38639: 13.2R relnotes: numerous additions plus edits.

LGTM.

Feb 17 2023, 11:28 PM

Feb 16 2023

pauamma_gundo.com requested changes to D38639: 13.2R relnotes: numerous additions plus edits.

Other than those, English LGTM.

Feb 16 2023, 3:32 PM

Feb 15 2023

pauamma_gundo.com added a comment to D38108: man9: Add an smr(9) manual page.

Grammar and markup LGTM. Everything else is above my head.

Feb 15 2023, 9:59 PM
pauamma_gundo.com closed D38598: Light copyedit of draft 13.2 relnotes..
Feb 15 2023, 5:18 PM
pauamma_gundo.com committed R9:20e74b2690a9: Light copyedit of draft 13.2 relnotes (authored by pauamma_gundo.com).
Light copyedit of draft 13.2 relnotes
Feb 15 2023, 5:18 PM
pauamma_gundo.com added inline comments to D38598: Light copyedit of draft 13.2 relnotes..
Feb 15 2023, 5:04 PM
pauamma_gundo.com added a comment to D38598: Light copyedit of draft 13.2 relnotes..

Over to @carlavilla and or @gjb for mentor approval.

Feb 15 2023, 1:03 AM

Feb 14 2023

pauamma_gundo.com requested review of D38598: Light copyedit of draft 13.2 relnotes..
Feb 14 2023, 11:00 PM
pauamma_gundo.com accepted D38591: Remove libmchain man pages.

LGTM given the stated rationale and background.

Feb 14 2023, 9:54 PM
pauamma_gundo.com added a comment to D38367: Better error checking in code example..
In D38367#872754, @pauamma wrote:

Over to mentors

Feb 14 2023, 8:04 PM
pauamma_gundo.com committed R9:19e26cd14902: Add 3rd-party review slush dates (authored by pauamma_gundo.com).
Add 3rd-party review slush dates
Feb 14 2023, 7:02 PM
pauamma_gundo.com closed D38525: Add 3rd-party review slush dates.
Feb 14 2023, 7:02 PM
pauamma_gundo.com added a comment to D38510: Swap ports and packages as suggested by wosch..

@carlavilla, can I take your approval here as approving https://reviews.freebsd.org/D38509 as well?

Feb 14 2023, 12:26 AM

Feb 12 2023

pauamma_gundo.com added a comment to D38490: ping: Accept ToS keywords with -z.

Thank you @pauamma! Those are great suggestions. I took man page changes from pf.conf.5, so I consider it to be my "upstream".
How about a change there, and then pull in those changes here?

Feb 12 2023, 6:02 PM

Feb 11 2023

pauamma_gundo.com updated the diff for D38525: Add 3rd-party review slush dates.
  • Reword per comments.
Feb 11 2023, 10:51 PM
pauamma_gundo.com added reviewers for D38525: Add 3rd-party review slush dates: carlavilla, gjb.
Feb 11 2023, 8:03 PM
pauamma_gundo.com requested review of D38525: Add 3rd-party review slush dates.
Feb 11 2023, 8:02 PM
pauamma_gundo.com requested review of D38510: Swap ports and packages as suggested by wosch..
Feb 11 2023, 7:08 PM
pauamma_gundo.com requested review of D38509: Split 'About FreeBSD Ports' to 1 sentence per line..
Feb 11 2023, 7:08 PM
pauamma_gundo.com added inline comments to D38490: ping: Accept ToS keywords with -z.
Feb 11 2023, 2:08 PM

Feb 9 2023

pauamma_gundo.com accepted D33248: Optionally deliver SIGCAP on capsicum violations..

Other than the date bumps, manual pages LGTM.

Feb 9 2023, 7:34 PM

Feb 6 2023

pauamma_gundo.com accepted D38398: status: Update report submission methods.

call.txt.template and _index.adoc both LGTM.

Feb 6 2023, 9:11 PM

Feb 5 2023

pauamma_gundo.com added a comment to D38367: Better error checking in code example..

Over to mentors

Feb 5 2023, 3:04 PM

Feb 3 2023

pauamma_gundo.com updated the diff for D38367: Better error checking in code example..
  • Remove unneeded cast.
Feb 3 2023, 10:49 PM
pauamma_gundo.com added inline comments to D38108: man9: Add an smr(9) manual page.
Feb 3 2023, 9:06 PM
pauamma_gundo.com requested review of D38367: Better error checking in code example..
Feb 3 2023, 2:09 AM

Feb 2 2023

pauamma_gundo.com accepted D38244: daemon: add long_opts.

Manual page changes LGTM. Can't attest to source code or consistency between them.

Feb 2 2023, 1:31 PM

Feb 1 2023

pauamma_gundo.com accepted D30350: acpiconf(8): Add libxo(3) support.

Manual page change LGTM. Can't assess the source.

Feb 1 2023, 10:58 PM
pauamma_gundo.com accepted D38343: man4: Add a manual page for kvmclock.

Device name correction (if I'm right) can be fixed on commit.

Feb 1 2023, 10:27 PM
pauamma_gundo.com accepted D38282: shm: Document shm_create_largepage().
Feb 1 2023, 5:51 PM
pauamma_gundo.com added a comment to D38343: man4: Add a manual page for kvmclock.

Since the driver is in 13.1, perhaps MFC?

Feb 1 2023, 5:43 PM

Jan 31 2023

pauamma_gundo.com accepted D38283: netlink: return optional metadata with the operation result..

Manual page change LGTM. Can't speak to consistency with source code.

Jan 31 2023, 6:01 PM
pauamma_gundo.com added inline comments to D37753: Add tarfs, a filesystem backed by tarballs..
Jan 31 2023, 4:33 PM
pauamma_gundo.com requested changes to D38282: shm: Document shm_create_largepage().
Jan 31 2023, 4:23 PM
pauamma_gundo.com accepted D37753: Add tarfs, a filesystem backed by tarballs..

Manual page changes LGTM, but did some unrelated changes leak into this?

Jan 31 2023, 12:05 PM

Jan 29 2023

pauamma_gundo.com added inline comments to D38244: daemon: add long_opts.
Jan 29 2023, 11:10 PM

Jan 25 2023

pauamma_gundo.com accepted D38188: rtalloc.9: remove obsolete man page.

Manual page change LGTM. Can't evaluate the rest.

Jan 25 2023, 12:06 PM
pauamma_gundo.com accepted D38187: PCBGROUP.9: remove obsolete man page.

Manual page change LGTM. No basis for an informed opinion on the rest.

Jan 25 2023, 12:04 PM

Jan 24 2023

pauamma_gundo.com added inline comments to D26161: valectl(8) patch to use the new netmap API.
Jan 24 2023, 5:43 PM

Jan 23 2023

pauamma_gundo.com accepted D38166: growfs(7): conditionalize mention of adding dump device.

English in change LGTM.

Jan 23 2023, 9:09 AM

Jan 22 2023

pauamma_gundo.com added inline comments to D37753: Add tarfs, a filesystem backed by tarballs..
Jan 22 2023, 7:22 PM
pauamma_gundo.com added a comment to D37094: Suggest port maintainers submit bugs for VuXML updates..

Good questions all. Waiting for a ports secteam member to address them so I can revise this usefully.

Jan 22 2023, 1:03 PM

Jan 20 2023

pauamma_gundo.com accepted D38131: Trim a paragraph from the software license policy..

This answers my concern inasmuch as regards this document. I agree with the need to document how to deal with this wrt ports elsewhere. Would the Porter's Handbook be a good place?

Jan 20 2023, 12:38 AM

Jan 19 2023

pauamma_gundo.com accepted D37973: wtapctl(8): Introduce new tool for wtap(4).

Manual page now LGTM.

Jan 19 2023, 8:24 PM · wireless
pauamma_gundo.com added a comment to D38047: Multiple fixes to the NSS caching system.

Does this need any corresponding updates to manual pages, eg getpwent(3), getgrent(3), nsswitch.conf(5), or nscd(8)? My C reading skills aren't up to telling conclusively.

Jan 19 2023, 1:55 PM · Src Committers