Page MenuHomeFreeBSD
Feed Advanced Search

Today

pauamma_gundo.com accepted D32540: iSCSI: Fast and per-session timeouts.

Manual pages English looks good to me.

Sun, Dec 10, 3:00 AM

Yesterday

pauamma_gundo.com accepted D42980: dummynet: add simple gilbert-elliott channel model.

Manual page change LGTM. I can't speak to consistency with code.

Sat, Dec 9, 2:55 PM
pauamma_gundo.com added a reviewer for D42980: dummynet: add simple gilbert-elliott channel model: manpages.
Sat, Dec 9, 3:21 AM
pauamma_gundo.com added inline comments to D42980: dummynet: add simple gilbert-elliott channel model.
Sat, Dec 9, 3:21 AM

Fri, Dec 8

pauamma_gundo.com accepted D42032: semctl(2): Add SEM_STAT to the list of operations.

Wording nit fixable on commit. (Sorry for the delay. I'm way behind in my email.)

Fri, Dec 8, 2:43 AM

Tue, Dec 5

pauamma_gundo.com accepted D42916: security: Inter-link between SA and EN pages for greater visibility.

Other than that typo (and maybe using "classified": "classed" looks unfamiliar to me but readily understandable), LGTM.

Tue, Dec 5, 10:58 PM

Sep 8 2023

pauamma_gundo.com added inline comments to D41768: save-entropy.sh: Add manual page.
Sep 8 2023, 5:47 PM

Aug 31 2023

pauamma_gundo.com added a comment to D41507: Add portoptscli FreeBSD 3q2023 Status Report.

Maybe, now that the call for testing is out, add a link to https://lists.freebsd.org/archives/freebsd-accessibility/2023-August/000034.html at the end of the report so people know how to test?

Aug 31 2023, 8:25 PM · Accessibility

Aug 28 2023

pauamma_gundo.com accepted D30056: pf: Remove DIOCCLRSTATES and DIOCKILLSTATES.

With .Dd bumped (fixable on commit), manual page change LGTM.

Aug 28 2023, 11:30 PM

Aug 27 2023

pauamma_gundo.com added inline comments to D30056: pf: Remove DIOCCLRSTATES and DIOCKILLSTATES.
Aug 27 2023, 5:32 PM

Aug 25 2023

pauamma_gundo.com added inline comments to D16132: New cmb(3) library and cmb(1) utility.
Aug 25 2023, 8:52 PM

Aug 24 2023

pauamma_gundo.com accepted D27161: growfs: make exit codes more consistent.

Manual page nits fixable on commit if nothing else requires an updated diff.

Aug 24 2023, 5:26 PM

Aug 23 2023

pauamma_gundo.com added inline comments to D41560: pmap: add pmap_kextract(9) man page.
Aug 23 2023, 1:42 AM · manpages, Src Committers

Aug 21 2023

pauamma_gundo.com accepted D25380: syslogd: allow network and local messages to use different formats.

Manual page English LGTM.

Aug 21 2023, 6:11 PM · network, manpages

Aug 20 2023

pauamma_gundo.com accepted D41507: Add portoptscli FreeBSD 3q2023 Status Report.
Aug 20 2023, 2:09 PM · Accessibility

Aug 19 2023

pauamma_gundo.com added a comment to D41507: Add portoptscli FreeBSD 3q2023 Status Report.

I like this new trend of getting reports earlier in the quarter.

Aug 19 2023, 6:08 PM · Accessibility

Aug 18 2023

pauamma_gundo.com accepted D41113: sysctl(8): Mention more security.bsd knobs; Refer to security(7).
Aug 18 2023, 12:57 PM
pauamma_gundo.com accepted D41109: ptrace(2): Disabling: Describe influence of security.bsd.see_jail_proc.
Aug 18 2023, 2:27 AM
pauamma_gundo.com accepted D41108: security(7): security.bsd.see*: Be more accurate.

Sorry for the delay.

Aug 18 2023, 2:21 AM

Aug 17 2023

pauamma_gundo.com added a comment to D35776: vtspeakd(1): Initial version of console speaker daemon..

I am interested to take/continue this feature. Are others already working?

Aug 17 2023, 10:33 PM

Aug 15 2023

pauamma_gundo.com added a comment to D40094: Add a virtio-gpu 2D driver.

Other than these 2 nits and what others mentioned, manual page English LGTM.

Aug 15 2023, 1:45 PM

Aug 7 2023

pauamma_gundo.com abandoned D38915: Prepare Handbook and FAQ for 13.2-RELEASE.
Aug 7 2023, 3:30 PM
pauamma_gundo.com added a comment to D37094: Suggest port maintainers submit bugs for VuXML updates..

Still waiting for feedback on how to reconcile incompatible requests, which I think is the only thing holding this at this time.

Aug 7 2023, 3:28 PM

Aug 2 2023

pauamma_gundo.com requested review of D41292: Use official example domain names in sample makefiles.
Aug 2 2023, 3:42 PM

Aug 1 2023

pauamma_gundo.com accepted D41285: Document USES=guile..
Aug 1 2023, 8:14 PM
pauamma_gundo.com added inline comments to D41285: Document USES=guile..
Aug 1 2023, 7:52 PM

Jul 15 2023

pauamma_gundo.com added inline comments to D40644: cr_canseeothergids(): Policy change's manual pages impact.
Jul 15 2023, 1:29 AM

Jul 5 2023

pauamma_gundo.com accepted D40792: 2023Q2 status report for NVMe over Fabrics.
Jul 5 2023, 6:21 PM

Jul 3 2023

pauamma_gundo.com accepted D40839: Man page cross-reference for smbmsg.

English LGTM.

Jul 3 2023, 2:26 AM
pauamma_gundo.com accepted D40637: p_cansee(9): Bring up-to-date, misc fixes.
Jul 3 2023, 2:17 AM
pauamma_gundo.com accepted D40831: jexec man: Add examples section.

Nits fixable on commit

Jul 3 2023, 12:37 AM
pauamma_gundo.com added a comment to D20967: new MAC policy module - mac_ipacl.

Manual page LGTM now, will rereview once the source code is finalized.

Jul 3 2023, 12:21 AM · GSoC Students, GSoC Admins

Jun 30 2023

pauamma_gundo.com accepted D40809: siftr: add documentation to man page.
Jun 30 2023, 10:59 PM
pauamma_gundo.com accepted D40638: p_candebug(9): cr_bsd_visible() impacts, misc fixes.
Jun 30 2023, 10:11 PM
pauamma_gundo.com added inline comments to D40637: p_cansee(9): Bring up-to-date, misc fixes.
Jun 30 2023, 10:03 PM
pauamma_gundo.com accepted D40631: cr_canseejailproc(9): New man page.
Jun 30 2023, 9:41 PM

Jun 29 2023

pauamma_gundo.com added a comment to D40639: prison_check(9): Bring up-to-date with hierarchical jails.

English LGTM.

Jun 29 2023, 10:01 PM
pauamma_gundo.com added a comment to D40638: p_candebug(9): cr_bsd_visible() impacts, misc fixes.

Minor nit, fixable on commit.

Jun 29 2023, 9:56 PM
pauamma_gundo.com added a comment to D40637: p_cansee(9): Bring up-to-date, misc fixes.

Other than bcr's suggestion, English LGTM.

Jun 29 2023, 9:49 PM
pauamma_gundo.com added a comment to D40632: cr_bsd_visible(9): New man page.

English LGTM.

Jun 29 2023, 9:39 PM
pauamma_gundo.com added a comment to D40633: cr_canseeothergids(9): Revamp, mark as internal.

English LGTM.

Jun 29 2023, 9:35 PM
pauamma_gundo.com added a comment to D40631: cr_canseejailproc(9): New man page.

English LGTM. (Was the added subscriber a request for manpages review, or just for information?)

Jun 29 2023, 9:30 PM
pauamma_gundo.com requested changes to D40792: 2023Q2 status report for NVMe over Fabrics.

In addition to the line edits, could you rewrap this so each sentence is on a single line of its own?

Jun 29 2023, 7:31 PM
pauamma_gundo.com accepted D40788: Restore and document -ps / -nps option..

Manual page English LGTM. Can't attest to anything else.

Jun 29 2023, 1:32 AM

Jun 28 2023

pauamma_gundo.com added a comment to D40756: 2023Q2 status report for boot performance.

Dumb question, am I supposed to commit this to the docs tree, or do I just leave the review hanging here and let someone else commit it?

Jun 28 2023, 12:28 AM

Jun 26 2023

pauamma_gundo.com accepted D40756: 2023Q2 status report for boot performance.
Jun 26 2023, 9:26 PM
pauamma_gundo.com accepted D40755: 2023Q2 status report for FreeBSD/EC2.
Jun 26 2023, 9:09 PM

Jun 22 2023

pauamma_gundo.com accepted D40595: Bug 268052: Extend -p option of ps(1) with some clarifications.
Jun 22 2023, 10:12 PM
pauamma_gundo.com updated the diff for D37094: Suggest port maintainers submit bugs for VuXML updates..
  • Address edit comments by riggs and grahamperrin
  • More revisions after grahamperrin feedback.
Jun 22 2023, 8:19 PM
pauamma_gundo.com added inline comments to D37094: Suggest port maintainers submit bugs for VuXML updates..
Jun 22 2023, 8:11 PM

Jun 19 2023

pauamma_gundo.com added inline comments to D40595: Bug 268052: Extend -p option of ps(1) with some clarifications.
Jun 19 2023, 10:21 PM
pauamma_gundo.com accepted D34747: ls(1): Change -g and make -n imply -l to implement POSIX.

English in manual page still LGTM.

Jun 19 2023, 5:56 PM

Jun 18 2023

pauamma_gundo.com added a comment to D37094: Suggest port maintainers submit bugs for VuXML updates..

ping @riggs @grahamperrin Is either of you waiting for more changes from me?

Jun 18 2023, 12:26 AM

Jun 16 2023

pauamma_gundo.com added a comment to D20967: new MAC policy module - mac_ipacl.

Some nits in the manual page, which can probably be fixed in a follow-up commit (with .Dd bumped) if the code still works.

Jun 16 2023, 11:08 PM · GSoC Students, GSoC Admins

Jun 15 2023

pauamma_gundo.com accepted D40547: Add a sentence to mount_nfs.8 w.r.t. use of the nconnect option.

English LGTM.

Jun 15 2023, 11:18 PM

Jun 13 2023

pauamma_gundo.com accepted D40484: rc.suspend: update man pages for new keyword.

English LGTM now. Can't attest to consistency with source code.

Jun 13 2023, 2:14 AM

Jun 12 2023

pauamma_gundo.com accepted D40485: mac(9): update SEE ALSO.
Jun 12 2023, 4:15 PM
pauamma_gundo.com added inline comments to D40484: rc.suspend: update man pages for new keyword.
Jun 12 2023, 2:28 PM
pauamma_gundo.com accepted D40483: mac(4): update the references to MAC modules.

English in changes LGTM.

Jun 12 2023, 2:28 PM

Jun 3 2023

pauamma_gundo.com added a comment to D40313: fdp-primer: Add Weblate chapter.

English LGTM now.

Jun 3 2023, 3:37 AM

Jun 2 2023

pauamma_gundo.com added inline comments to D40313: fdp-primer: Add Weblate chapter.
Jun 2 2023, 2:05 AM

May 29 2023

pauamma_gundo.com accepted D40285: libtacplus: Allow additional AV pairs to be configured..
May 29 2023, 3:39 PM

May 28 2023

pauamma_gundo.com added inline comments to D40285: libtacplus: Allow additional AV pairs to be configured..
May 28 2023, 11:41 PM

May 25 2023

pauamma_gundo.com added inline comments to D40258: handbook: remove portmaster et al.
May 25 2023, 1:51 AM

Apr 27 2023

pauamma_gundo.com accepted D39804: [phb]: Add note when deprecating ports..
Apr 27 2023, 12:13 AM

Apr 26 2023

pauamma_gundo.com accepted D36594: Document library types in the intro(3) manual page.

Other than the missing "space", English LGTM, but I can't speak about correctness.

Apr 26 2023, 9:42 PM

Apr 20 2023

pauamma_gundo.com accepted D39714: tzcode: Clean up the ctime(3) manual page..

English LGTM other maybe than rpokala's wording nit.

Apr 20 2023, 11:44 PM
pauamma_gundo.com added inline comments to D39714: tzcode: Clean up the ctime(3) manual page..
Apr 20 2023, 10:35 PM
pauamma_gundo.com accepted D39710: bectl: document the -r flag to bectl.

Better UX FTW!

Apr 20 2023, 8:03 PM

Apr 19 2023

pauamma_gundo.com added a comment to D35754: vt(4): Add support for console screen reader using sysctls..

Expected: at steps 6 and 9, reading each line is aborted on successive control-B presses and vtspeakd skips to the next line.
Observed: at step 6, each line is read out in full (incorrect); at step 9, vtspeak aborts and skips to the next line on every control-B press (correct).

If the console is in input mode or not reading any text, then CTRL+B doesn't work, like reading a line. Maybe I should fix that?

Apr 19 2023, 9:00 PM
pauamma_gundo.com accepted D39555: [fw]mark implementation for ipfw.
Apr 19 2023, 8:06 PM · network, manpages
pauamma_gundo.com added inline comments to D35776: vtspeakd(1): Initial version of console speaker daemon..
Apr 19 2023, 2:46 AM
pauamma_gundo.com accepted D39643: tzsetup(8): update paths to zone tab and tzdata source.

LGTM.

Apr 19 2023, 1:57 AM
pauamma_gundo.com accepted D39555: [fw]mark implementation for ipfw.

Minor nits, fixable on commit if nothing else requires another round.

Apr 19 2023, 1:47 AM · network, manpages

Apr 18 2023

pauamma_gundo.com requested changes to D39555: [fw]mark implementation for ipfw.
Apr 18 2023, 3:32 AM · network, manpages

Apr 15 2023

pauamma_gundo.com accepted D39401: Status/2023Q1: Sort reports.

Don't want to delay this further. Nothing that can't be fixed on commit, if need be.

Apr 15 2023, 11:13 PM
pauamma_gundo.com added inline comments to D39401: Status/2023Q1: Sort reports.
Apr 15 2023, 11:02 PM

Mar 22 2023

pauamma_gundo.com added a comment to D39168: Update mountd.8 for use in jails.

Oops, I missed the reviewed by pauamma (manpages),
since it happened just when I did the commit.

Mar 22 2023, 9:25 PM

Mar 21 2023

pauamma_gundo.com added a comment to D38367: Better error checking in code example..

Can a committer take this? My commit access was revoked.

Mar 21 2023, 11:26 PM
pauamma_gundo.com added a reviewer for D39172: 13.2 release notes: 12-char gitref; zfskeys keys on ZFS: karels.
Mar 21 2023, 11:06 PM

Mar 20 2023

pauamma_gundo.com accepted D39168: Update mountd.8 for use in jails.
Mar 20 2023, 10:15 PM
pauamma_gundo.com removed a member for committers: pauamma_gundo.com.
Mar 20 2023, 9:51 PM
pauamma_gundo.com removed a member for Doc Committers: pauamma_gundo.com.
Mar 20 2023, 9:51 PM

Mar 19 2023

pauamma_gundo.com accepted D39130: critical(9): small updates.

English LGTM. Can't attest to consistency with source code.

Mar 19 2023, 10:35 PM
pauamma_gundo.com accepted D39136: callout(9): adopt old references to timeout(9).

English LGTM.

Mar 19 2023, 8:05 PM
pauamma_gundo.com added a comment to D39135: kern_reboot(9): describe event handlers.

Very minor, fixable on commit.

Mar 19 2023, 7:58 PM
pauamma_gundo.com accepted D39134: kern_reboot(9): document shutdown_nice().

Language LGTM.

Mar 19 2023, 7:45 PM
pauamma_gundo.com added a comment to D39133: kern_reboot(9): some updates.

Minor nits, fixable on commit if nothing else stands out.

Mar 19 2023, 7:39 PM
pi renamed pauamma_gundo.com from pauamma to pauamma_gundo.com.
Mar 19 2023, 9:29 AM

Mar 16 2023

pauamma_gundo.com accepted D39131: KASSERT(9): some updates.

Minor nits fixable on commit.

Mar 16 2023, 8:48 PM

Mar 14 2023

pauamma_gundo.com accepted D39033: Update jail.8 for the NFS server daemons running in a vnet jail.

Fixable on commit.

Mar 14 2023, 8:51 PM
pauamma_gundo.com added inline comments to D39068: Correct the pacakge names of GCC12 for cross compiling.
Mar 14 2023, 8:36 PM
pauamma_gundo.com added a comment to D37322: Remove invalid ports and links in Handbook.

@carlavilla, since you're working on the Handbook, do you plan to rereview and commit this? Otherwise I'd like to take it over and ready it for committing.

Mar 14 2023, 1:57 PM
pauamma_gundo.com added a comment to D39023: 13.2RC2 actual build date + RC3 will happen.

Over to @carlavilla @gjb for (preferrably fast) mentor approval.

Mar 14 2023, 7:51 AM

Mar 13 2023

pauamma_gundo.com added a comment to D39022: 2023Q1 Valgrind status report.

Over to @carlavilla @gjb for mentor approval

Mar 13 2023, 11:04 PM
pauamma_gundo.com added a comment to D39022: 2023Q1 Valgrind status report.

Should take care of all comments.

Mar 13 2023, 10:33 PM
pauamma_gundo.com updated the diff for D39022: 2023Q1 Valgrind status report.
  • Fix nits salvadore pointed out and a few more I spotted meanwhile.
Mar 13 2023, 10:29 PM

Mar 11 2023

pauamma_gundo.com accepted D31273: Strengthen warnings about ext4.

I completely forgot about that. Sorry.

Mar 11 2023, 5:48 PM
pauamma_gundo.com updated the diff for D39023: 13.2RC2 actual build date + RC3 will happen.
  • Remove unreferenced "as-needed" note.
Mar 11 2023, 2:37 AM
pauamma_gundo.com requested review of D39023: 13.2RC2 actual build date + RC3 will happen.
Mar 11 2023, 1:01 AM