English and markup still LGTM.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Yesterday
Mon, Apr 22
Sun, Apr 21
There are 2 spurious ) after eaccess and faccessat in the change summary.
Mon, Apr 8
English and markup LGTM.
In D22012#1018620, @editor_callfortesting.org wrote:This clearly has quite a bit of attention!
Is it PkgBase-friendly?
Sun, Mar 31
Approving with these changes.
Mar 26 2024
Grammar and spelling LGTM. Correctness (or portability) of the recommended error-checking is beyond my ken.
Mar 25 2024
Mar 18 2024
I'd move "as a last resort" to the head of the sentence as well, but that's fixable on commit.
Mar 17 2024
@riggs (or anyone from ports secteam), could you (re)review?
- Address (I think) all pending review comments.
Mar 16 2024
Mar 15 2024
Mar 13 2024
A few typos remain, but getting close, I think.
Mar 12 2024
English and markup LGTM.
Mar 11 2024
Mar 4 2024
Over to a doc committer.
Mar 3 2024
Bunch of small things I spotted.
Mar 2 2024
Language and spelling LGTM.
Feb 25 2024
Feb 24 2024
Spelling, grammar, and clarity all LGTM.
Feb 23 2024
Feb 22 2024
Feb 21 2024
I'd like someone who knows about this system call to review this as well.
Feb 20 2024
Feb 18 2024
Feb 16 2024
English in the manual page LGTM.
Feb 13 2024
In D43840#1000924, @karels wrote:Has anyone else from docs looked at this? Anyone willing to approve?
In D43845#1000784, @cy wrote:Added docs for man page review.
Feb 12 2024
Noting that this has incorrect title "Status/2023Q4/ci.adoc: Add report", since it's about Azure and HyperV.
Feb 11 2024
Feb 9 2024
Feb 8 2024
Feb 4 2024
Jan 24 2024
Not sure what you mean by "unrelated to the content", but this is the output of the command above with kern.securelevel having its initial value.
Jan 23 2024
LGTM too, but I'm no longer a doc committer.
Jan 22 2024
English LGTM.
Jan 20 2024
In D37094#941534, @carlavilla wrote:I'm gonna send an email to ping the Security Team.
English nitpicks fixable on commit.
Jan 19 2024
Jan 14 2024
English LGTM.
Worth adding releng as reviewer, since this probably needs to be kept consistent with their tools?
Jan 10 2024
Jan 5 2024
Almost there, just one remaining nit.
Jan 4 2024
Jan 1 2024
Dec 31 2023
Bunch of small copyediting nits, but LGTM overall.
Dec 29 2023
In D43227#985196, @rmacklem wrote:Ok, I'm not seeing the typo in the man page name?
Dec 22 2023
Approved with s/imbedded/embedded/ throughout.
Dec 21 2023
Dec 20 2023
Other than that 404ing URL, LGTM.
Dec 19 2023
English in changes LGTM.
English LGTM.
Dec 18 2023
Change consistent with summary, as far as I can tell.
Dec 14 2023
Manual page English still LGTM.
Dec 12 2023
No manual page to review, yet manpages is a group reviewer. Did a file get accidentally left out?
Dec 10 2023
Manual pages English looks good to me.
Dec 9 2023
Manual page change LGTM. I can't speak to consistency with code.
Dec 8 2023
Wording nit fixable on commit. (Sorry for the delay. I'm way behind in my email.)
Dec 5 2023
Other than that typo (and maybe using "classified": "classed" looks unfamiliar to me but readily understandable), LGTM.
Sep 8 2023
Aug 31 2023
Maybe, now that the call for testing is out, add a link to https://lists.freebsd.org/archives/freebsd-accessibility/2023-August/000034.html at the end of the report so people know how to test?
Aug 28 2023
With .Dd bumped (fixable on commit), manual page change LGTM.
Aug 27 2023
Aug 25 2023
Aug 24 2023
Manual page nits fixable on commit if nothing else requires an updated diff.
Aug 23 2023
Aug 21 2023
Manual page English LGTM.