Manual pages English looks good to me.
Manual page change LGTM. I can't speak to consistency with code.
Fri, Dec 8
Wording nit fixable on commit. (Sorry for the delay. I'm way behind in my email.)
Tue, Dec 5
Other than that typo (and maybe using "classified": "classed" looks unfamiliar to me but readily understandable), LGTM.
Sep 8 2023
Aug 31 2023
Maybe, now that the call for testing is out, add a link to https://lists.freebsd.org/archives/freebsd-accessibility/2023-August/000034.html at the end of the report so people know how to test?
Aug 28 2023
With .Dd bumped (fixable on commit), manual page change LGTM.
Aug 27 2023
Aug 25 2023
Aug 24 2023
Manual page nits fixable on commit if nothing else requires an updated diff.
Aug 23 2023
Aug 21 2023
Manual page English LGTM.
Aug 20 2023
Aug 19 2023
I like this new trend of getting reports earlier in the quarter.
Aug 18 2023
Sorry for the delay.
Aug 17 2023
I am interested to take/continue this feature. Are others already working?
Aug 15 2023
Other than these 2 nits and what others mentioned, manual page English LGTM.
Aug 7 2023
Still waiting for feedback on how to reconcile incompatible requests, which I think is the only thing holding this at this time.
Aug 2 2023
Aug 1 2023
Jul 15 2023
Jul 5 2023
Jul 3 2023
Nits fixable on commit
Manual page LGTM now, will rereview once the source code is finalized.
Jun 30 2023
Jun 29 2023
Minor nit, fixable on commit.
Other than bcr's suggestion, English LGTM.
English LGTM. (Was the added subscriber a request for manpages review, or just for information?)
In addition to the line edits, could you rewrap this so each sentence is on a single line of its own?
Manual page English LGTM. Can't attest to anything else.
Jun 28 2023
Dumb question, am I supposed to commit this to the docs tree, or do I just leave the review hanging here and let someone else commit it?
Jun 26 2023
Jun 22 2023
- Address edit comments by riggs and grahamperrin
- More revisions after grahamperrin feedback.
Jun 19 2023
English in manual page still LGTM.
Jun 18 2023
Jun 16 2023
Some nits in the manual page, which can probably be fixed in a follow-up commit (with .Dd bumped) if the code still works.
Jun 15 2023
Jun 13 2023
English LGTM now. Can't attest to consistency with source code.
Jun 12 2023
English in changes LGTM.
Jun 3 2023
English LGTM now.
Jun 2 2023
May 29 2023
May 28 2023
May 25 2023
Apr 27 2023
Apr 26 2023
Other than the missing "space", English LGTM, but I can't speak about correctness.
Apr 20 2023
English LGTM other maybe than rpokala's wording nit.
Better UX FTW!
Apr 19 2023
Expected: at steps 6 and 9, reading each line is aborted on successive control-B presses and vtspeakd skips to the next line.
Observed: at step 6, each line is read out in full (incorrect); at step 9, vtspeak aborts and skips to the next line on every control-B press (correct).
If the console is in input mode or not reading any text, then CTRL+B doesn't work, like reading a line. Maybe I should fix that?
Minor nits, fixable on commit if nothing else requires another round.
Apr 18 2023
Apr 15 2023
Don't want to delay this further. Nothing that can't be fixed on commit, if need be.
Mar 22 2023
Oops, I missed the reviewed by pauamma (manpages),
since it happened just when I did the commit.
Mar 21 2023
Can a committer take this? My commit access was revoked.
Mar 20 2023
Mar 19 2023
English LGTM. Can't attest to consistency with source code.
Very minor, fixable on commit.
Minor nits, fixable on commit if nothing else stands out.
Mar 16 2023
Minor nits fixable on commit.
Mar 14 2023
Fixable on commit.
@carlavilla, since you're working on the Handbook, do you plan to rereview and commit this? Otherwise I'd like to take it over and ready it for committing.
Mar 13 2023
Should take care of all comments.
- Fix nits salvadore pointed out and a few more I spotted meanwhile.
Mar 11 2023
I completely forgot about that. Sorry.
- Remove unreferenced "as-needed" note.