my tests are green
good to land!

Hi back today from holidays.
I'll run my tests on it ASAP (tomorrow morning or during EuroBSD).
Sorry for the delay, I'll keep you posted

Put spl back to _USE_PHP_ALL, as it correctly belongs.
Sorry for the poor word choice, I wanted only remove the DEPENDS line
that refer to a package that doesn't exist.

I've tested the patch on my laptop and I've found no issues.
I don't have commit bit for src, only for port, so it would be nice if one of you can commit it, now that the patch is approved.
In this way it would be possible to close PR176671 and PR184149.
thanks for all your feedback!

Style cleanups

Adopt the proposed approach based on jenkins_hash32

In D15329#323510, @eugen_grosbein.net wrote:

In D15329#323385, @wollman wrote:

It's probably worth a little bit of thought as to what is the more common case, a zillion epair interfaces on one host (read: half a zillion vnet jails) or a much smaller number of epairs on a larger number of hosts. It sounds like you are well placed to assign your own addresses, whatever the default may be.

Well, this is not network hot path and we now have jenkins_hash32() kernel function in all supported branches, so we could just allocate additional uint32_t key[3] array on stack of this function, copy there all 64 bits of (long)hostid plus (uint32_t)if_index and make use of jenkins_hash32() to get them mixed to 32-bit hash value. Then use it as-is for eaddr[1]-eaddr[4] similar to current manner or switch to using 58:9C:FC for upper half of MAC and use lower 24 bits of the hash for the rest of MAC resetting lowest bit to 0 for first interface and to 1 for second one.

Further cleaning, remove dead code

I'm not 100% happy with hostid as well, I've just followed what already implemented in if_bridge(4).
I can just use arc4rand for those 2 bytes, that should help to mitigate possible collisions and simplify the code.
What do you think?