- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Oct 4 2023
Sep 25 2023
Great work! Thanks very much. This should help me not get behind on FreeBSD SAs going forward.
This is great! Thanks for doing this work. This can save me a lot of time. ๐
Sep 7 2023
Aug 31 2023
Aug 30 2023
May 16 2023
I think this is a good compromise. I suggest some minor grammar/wording changes to clarify the comment. Nothing consequential. This looks good to me.
If neither allow_severity or deny_severity are referenced anywhere else, this looks good to me.
I have only reviewed the patch. I haven't actually tested it.
This looks good to me.
May 2 2023
Apr 27 2023
Thank you very much!
Apr 25 2023
This branch passes my build tests and my functional tests.
Please let it sit in main for a couple of days before merging to stable.
Apr 22 2023
I think this looks good now. Thanks you!
Apr 20 2023
Thanks for doing this! My builds are still running. I'll take a closer look at this patch my morning.
This looks good. Thanks for submitting this upstream too. I saw your post on tz@.
Apr 18 2023
I like this idea, but I don't think this should live under /usr/share/zoneinfo. I believe that zoneinfo should *only* contain files generated by tzdata.
Apr 14 2023
I think this is good to go. Thank you!
Apr 12 2023
Apr 11 2023
This change looks good in principle, but please adjust the commentary and constant naming to more closely reflect the standard. This makes the code easier to read and understand.
Apr 10 2023
Apr 8 2023
Apr 7 2023
I don't have these systems to test on. I trust you've tested this patch well. Your patch compiles and, as far as I can tell, doesn't break the system I've cursorily tested (Supermicro).
Mar 29 2023
Mar 25 2023
Mar 24 2023
Mar 23 2023
Feb 28 2023
Feb 25 2023
I would like to see an entry in UPDATING please.
Feb 22 2023
Feb 16 2023
Excellent work! Thank you.
Feb 15 2023
I'm okay with this in principle (though I've not tested it).
Feb 14 2023
I think this makes sense. I am also generally in favour of anything that reduces our diffs to upstream.
Jan 16 2023
This looks good! Thank you!
Jan 12 2023
Thanks for working on this!
Dec 27 2022
Dec 2 2022
Dec 1 2022
Nov 30 2022
Nov 24 2022
Looks good.
Nov 16 2022
Nov 14 2022
Nov 3 2022
Nov 1 2022
Oct 29 2022
Oct 16 2022
Looks good to me. Thank you!
No need for the choice.
Oct 12 2022
Oct 6 2022
@jhb: that's odd ... etcupdate -p failed for me last week after building main on 13.1 as described in my earlier comment. Perhaps I messed something else up. I'll try to reproduce and narrow it down.
Oct 5 2022
(It should go *before* make buildworld because etcupdate extract needs to be done with the source tree of the *running* system. I've been bitten multiple times by "oh rats; git checkout freebsd/release/XXX; etcupdate extract; git checkout main; make installworld and finding that installworld fails because Git changed timestamps.)
Thanks! This looks good but please add a note about bootstrapping etcupdate. I always forget about etcupdate extract on new development machines.
Sep 28 2022
Sep 25 2022
Sep 16 2022
Absolutely. Go for it. :-)
This looks good! And very useful.
Sep 5 2022
Sep 1 2022
Perfect! Thanks for the rework. :-)
Looks good to me! Thank you.
The use case definitely makes sense!
Aug 31 2022
This should probably be documented somewhere.
Aug 29 2022
This looks good.