Looks good to me.

Good catch!

This looks good to me.

Approved by: philip (mentor)

Looks good.

In D29209#654049, @phk wrote:

Many years ago, we're talking 386BSD/FreeBSD1 days, I made a patch where you could set any damn rate you wanted, and the math would happen.

It wasn't particularly hard to implement, but it got brucified so bad I just dropped it.

I have had a local patch for this for ages. My patch has:

Looks good to me. I'll go and commit this now.

It may be helpful to add a comment somewhere at the top of the file about what units are used.

Committed as r564758.

I'm happy to commit this later today if @koobs doesn't beat me to it.

I confirm that this compiles on latest main and doesn't blow up in my face. I'll do more testing with hostapd today but I don't expect problems.

Looks good to me.

I agree that this makes the code more readable.
The patch should be rebased though. There's a conflict in netinet/libalias/alias.c.

Thanks for the changes!

I've been testing this after I found a pointer to this review on the hostapd mailing list.

Speaking nitpicking: I would also consistently capitalise Ethertype and VLAN as the IEEE does. :)

I am okay with this in principle, modulo the documentation nitpicking, but I wonder if it wouldn't be better to change the *default* to something more sensible -- i.e., have 802.1ad work out of the box. One of the "local experimentation" types come to mind. Or set it to one of the types assigned to Intel!

Looks good to me.

If the iflib changes have been tested and are known to work, they're probably okay.

Still looks good to me.

Works for me! Thanks for clarifying.

Looks good, modulo minor initialisation nit/remark.

This looks good. Thank you!

Tested on ampere1.nyi.freebsd.org and ampere2.nyi.freebsd.org. Both eMAG systems. They boot and PCIe still works.

Minor nits in commentary. Functionally looks good!