- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Jan 13 2019
Jan 9 2019
If this is only for mounting filesystems, starting mirror/raid and the like, then the new error makes sense to me, including mapping it to EINVAL in the Linux compatibility layer.
Jan 8 2019
A case could be made that it is really login(1) and sshd(8)'s job to set PWD along with chdir(2), but this will do.
Jan 7 2019
In D18765#400410, @mckusick wrote:Mirror might be able to read both sides but find that they have different values. So it would not know which one to return. Here EIO is not really the right answer as the media is fine, it is just the data that is inconsistent. So saying EINTEGRITY gives a hint that a higher level tool might be able to figure out which one was right and correct the wrong one. None of that is done today, but it is conceivable that it could be done. That said, my main intent is to return this error from UFS when it detects inconsistencies or when a check-hash fails.
Jan 6 2019
Jan 5 2019
Jan 3 2019
Dec 31 2018
A new test in bin/dd/tests that does dd if=/dev/null of=/dev/null status=none conv=trim would be nice (by not writing/trimming any bytes, it does not need a fake disk setup, but it does verify that the option is recognized). Even better would be something using md but that would need more ATF/Kyua magic.
Dec 30 2018
Dec 28 2018
Dec 27 2018
It seems like the idea is that we're stuck with that ugly \h/\$ bashism anyway so we might as well use it.
Dec 18 2018
A world-readable pidfile can be locked in shared mode by any user, which may cause the real daemon to act as if it is already running when it is not (e.g. after it crashed).
Dec 12 2018
Dec 9 2018
Dec 8 2018
Nov 28 2018
Nov 27 2018
Nov 13 2018
"Cookie" or "handle" are definitely good words here. The part "to position the directory descriptor to the start of the entry next to the current" could be simplified a bit to "to position the directory descriptor to the next entry" since the position cannot be in the middle of an entry.
Nov 9 2018
Oct 28 2018
The man page seems to contain the right content now. I just have some English language comments.
Oct 27 2018
Oct 20 2018
Oct 19 2018
In D17547#375528, @kib wrote:In D17547#375474, @jilles wrote:Unconditionally allowing absolute paths with O_BENEATH seems a bit strange, as I expect this to be used for partially untrusted paths. An application can easily check for absolute paths and cause either behaviour (allowing or disallowing).
This was one of my questions. But, it is not clear to me what change, if any, you are proposing.
Oct 17 2018
OUTBUFSIZ is somewhat of a strange name given that these buffers contain shell input.
Oct 16 2018
I think it would make more sense to define a new buffer size constant than modifying BUFSIZ.
Unconditionally allowing absolute paths with O_BENEATH seems a bit strange, as I expect this to be used for partially untrusted paths. An application can easily check for absolute paths and cause either behaviour (allowing or disallowing).
Oct 14 2018
I don't think "Show time for sorting" is better than "Use time for sorting". If you want to avoid the weak "use", something like "Sort by (with .Fl t) or write (with .Fl l) time when file ..." may be better.
Sep 28 2018
Sep 16 2018
This is not wrong, but perhaps some details about different types of errors may be helpful, such as that nonexistent usernames in -U are immediately fatal while an empty result (such as from only nonexistent process IDs in -p or only existing users that do not currently run any process in -U) still writes the header line (if not disabled) and also returns a non-zero exit status.
Sep 6 2018
Aug 26 2018
I would like to see a consistent behaviour in handling chown/chmod failures between creating directories and installing files. A -e flag looks ugly and should only be added if both behaviours are necessary in different situations.
There is actually another important difference between reboot and shutdown -r now: reboot does not run /etc/rc.shutdown. This is because reboot has its own shutdown procedure and does not signal init like init 6 and shutdown -r now do (except in the case of rerooting via reboot -r).
Aug 14 2018
Aug 13 2018
This is useful, but some parts seem too specific to usage in appliances.
Aug 11 2018
Aug 10 2018
Jul 15 2018
Jul 3 2018
I think this looks good except that I would like to consider a new errno again.
iflag= and oflag= would be better than inventing something new.
NetBSD and GNU instead have iflag= and oflag= operands that accept various open flags such as direct. I think that makes more sense, even though conv=notrunc could be considered to belong with oflag instead (but does not for historical reasons).
Jul 1 2018
In D16075#340644, @eadler wrote:For my edification: the two possible solutions to cast alignment are (a) memcpy and (b) aligned_alloc. The issue with the latter is that the compiler likely won't understand it, and thus still warn.
Jun 30 2018
Jun 29 2018
Perhaps the alternative of listing and extracting iso images using tar(1) can be mentioned as well.
Jun 26 2018
Looks good to me apart from the comment. Sorry for the delay.
Jun 21 2018
Jun 19 2018
Jun 10 2018
Jun 9 2018
Jun 7 2018
Jun 6 2018
Thanks for working on this, but I think pedantic compilation modes should be kept working.
May 30 2018
May 21 2018
I agree that the man page should be changed, but I think it can be done better.
May 20 2018
May 11 2018
May 6 2018
May 3 2018
Apr 29 2018
Apr 25 2018
Apr 18 2018
Apr 17 2018
The code itself looks good, but something could be improved in the man page and test.
Apr 15 2018
Even though it is from January, this is still a useful patch.
Apr 10 2018
I found two minor issues. It looks good otherwise.
Apr 8 2018
Apr 3 2018
Apr 2 2018
I like the idea. Apparently, the idea of the designers of setfacl was to pipe in a list of filenames from find, but this cannot handle filenames containing newlines and race conditions (such as where an untrusted user replaces a file with a symlink to a different location).
Thanks for writing missing documentation.
Mar 18 2018
In D14725#309715, @cem wrote:In D14725#309655, @jilles wrote:I think this kind of compatibility should be provided only if necessary for old code that cannot be changed (such as third party code). If it is just to avoid churn, we should keep using the old timespecadd and timespecsub (that is, abandon this change).
I don't follow that line of argument — that compatibility means we should abandon 3-arg timespecfoo, or bringing timespecfoo into userspace. But I will bow to quorum here, which seems to be: we'd rather churn it than have compatibility.
The changes to adapt to the new API look correct to me.
Mar 8 2018
This patch only affects the -d case. Failure to change owner and modes when installing regular files is fatal in any case. Perhaps the directory case should work the same way?
Mar 4 2018
This seems sensible, but I found some small mistakes in the man page.
Mar 2 2018
I agree that this should be based on unlinkat(), not unlink(). The new call will therefore take two file descriptors.
Feb 26 2018
Feb 18 2018
Feb 13 2018
I agree that hash table resizing would be nicer, but this is acceptable to commit.
Feb 6 2018
Feb 2 2018
Jan 24 2018
Hmm, it is remarkable to see this after the monotonic clock has existed for so long. Also, GNU time and mksh's keyword appear to use CLOCK_REALTIME without configurability.