- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Oct 13 2020
Looks correct to me.
Oct 12 2020
The code refers what you named "processing actions" as "policy levels". Take a look at netipsec/ipsec.h
Oct 9 2020
Oct 8 2020
Oct 5 2020
Yes. But I don't think the patch is heavy. Lets try to look from a different point.
SO_REUSEPORT_LB was introduced in D11003 with several fixes later, it has the same purpose - extend scalability of user space programs, that was used for example by DNS server.
The kernel should provide useful features for applications. Your app can use simple sockets API to send data, but also it can use more productive sendfile(2) syscall, etc.
OpenVPN is free opensource application that is widely used and supports different OSes. When all employee in your company are going work remotely, you can buy some hardware and thousands of licenses or can just use relatively small patch. This patch helps to extend scalability of OpenVPN for us, but it can be used for another apps that we don't use. I'm not forcing to commit it into base system, just share our experience and ask for comments.
Oct 2 2020
I think IF_ADDR_WLOCK() is not required for this ioctl. It is enough to use NET_EPOCH_ENTER().
Sep 23 2020
It seems you missed hash calculation for udp[6]_output(), when socket isn't connected and destination address is specified by caller.
Sep 15 2020
Sep 11 2020
Committed as rS365628.
Sep 10 2020
I think this patch is too complicated. Can you properly test this patch instead? https://people.freebsd.org/~ae/ipfw_frag.diff
Sep 8 2020
Aug 12 2020
Aug 11 2020
Aug 5 2020
Aug 3 2020
I sent a more generic patch in the reply to your email a week ago, can you check your spam folder and test it?
Jul 30 2020
LGTM.
Jul 27 2020
I think it should be possible solve the problem without introducing extra configuration parameter. I'll take a look.
Jul 13 2020
LGTM.
Jun 25 2020
LGTM.
Jun 10 2020
Jun 9 2020
Jun 5 2020
Jun 3 2020
Jun 1 2020
In D24989#552576, @avg wrote:I have a vague memory, maybe wrong, that commonly used fixed RSS keys were selected because they had some property (-ies).
So, maybe just being random is not good enough?
I think that hypothetical rss_isbadkey was mentioned for a reason?
How many subscribers do you expect? I think you will replace some existing. Maybe it would be better to have separate list for each subscription type?
May 29 2020
You can just use another option name to specify excludes.
May 26 2020
May 25 2020
May 22 2020
I have no objection against this. Just one test case to test - create several EBR partitions (e.g. s5, s6, s7), then remove one from the middle (i.e. s6), then create two smaller in this free space (and then optionally reboot, and see what we will have after reboot).
May 20 2020
I'll try to test this and commit with small modifications after weekend. Thanks!
May 14 2020
May 6 2020
It seems rt_pktsent is already unused in head/, thus its removal is reasonable. According to your calculations for offsets, this change can give some performance boost, and I'll try to measure it in the lab, but I'm not sure this will happen very soon. Also maybe is it worth to add some explicit alignment requirements to rtentry structure or some of its fields? We can use __aligned(CACHE_LINE_SIZE)
I also agree that these messages should be removed. But moving them to nd6 debugging seems wrong.
JFYI, this code will be removed when refactoring to the epoch(9) will be finished.
Apr 23 2020
Do you have performance test results for already existing linux implementation?
From a quick look it seems to me there will be bottleneck regarding locking that seems can be reduced using CK and epoch. But this task can be done in future, if you plan support this code.
Apr 16 2020
Apr 14 2020
Apr 13 2020
Apr 11 2020
In D24232#535905, @melifaro wrote:I'm going to commit it on Sunday, April 12 unless anyone has any objection.
Apr 9 2020
Apr 7 2020
Apr 6 2020
Apr 2 2020
Apr 1 2020
Mar 31 2020
Mar 26 2020
Mar 24 2020
Mar 20 2020
how did you test this change?
Feb 28 2020
Looks good to me. But I'd wait for @melifaro, there are several places where this KPI is used and I didn't check how it can affect it :)
This code, probably, was written with hope of depreciation of scope embedding into addresses.
If you plan to remove these, please leave the comment that returned address has embedded scope.
Also you will probably want to remove related XXX hack from fast forwarding code.
Feb 25 2020
It seems some of these macros should be fixed to respect style(9) and use tab instead of space after #define.
Feb 19 2020
Also, how did test your changes? :)
NAT64 currently is not widely used, thus changes here can break something and you will know about breakage when it will be not so easy to fix, e.g. after release.
In D23737#521593, @neel_neelc.org wrote:Here, I also compare the destination addresses. Is this what you want?
Feb 18 2020
The patch is not correct. IPv4 address can be embedded in different places depending from configuration.