Page MenuHomeFreeBSD
Feed Advanced Search

May 18 2026

marius.h_lden.org accepted D57045: tcp: Make RFC 6191 support configurable.
May 18 2026, 2:32 PM

Apr 9 2026

marius.h_lden.org accepted D56321: tcp: use RFC 6191 for connection recycling in TIME-WAIT.

As noted in the other review this should solve the problem we're having.

Apr 9 2026, 9:34 AM

Apr 8 2026

marius.h_lden.org added a comment to D56307: tcp: Allow recycling of TIME_WAIT connections on differnet ISN.

Thanks, I think that should do the trick.

Apr 8 2026, 9:33 PM
marius.h_lden.org abandoned D56307: tcp: Allow recycling of TIME_WAIT connections on differnet ISN.

Thanks for the feedback. You're right, I didn't think about in flight packets from the previous connection. I see also RFC 6191 references it as a potential problem. (And apparently the ISN generation isn't as random as I for some reason though.)

Apr 8 2026, 8:37 PM
marius.h_lden.org added a comment to D56307: tcp: Allow recycling of TIME_WAIT connections on differnet ISN.

I think something like this should work if using TCP timestamps instead. Would this be preferable?

Apr 8 2026, 8:01 PM
marius.h_lden.org added a comment to D56307: tcp: Allow recycling of TIME_WAIT connections on differnet ISN.

I would like to understand why this change is proposed?

Apr 8 2026, 7:25 PM
marius.h_lden.org requested review of D56307: tcp: Allow recycling of TIME_WAIT connections on differnet ISN.
Apr 8 2026, 1:12 PM

Oct 22 2025

marius.h_lden.org accepted D53167: w: Trim whitespace and commas from time and uptime.

The output looks god to me.

Oct 22 2025, 7:15 PM

Oct 20 2025

marius.h_lden.org added a comment to D53167: w: Trim whitespace and commas from time and uptime.

I think you can do something as simple as this to get an extra white space it the plain text output, since it's outside the "uptime-human" format string it won't be included in the encoded outputs.

Oct 20 2025, 4:54 PM
marius.h_lden.org added a comment to D53167: w: Trim whitespace and commas from time and uptime.

The json and xml output looks good to me, but in the plain text output it's missing a space between "up" and the time.

Oct 20 2025, 3:03 PM

Aug 29 2025

marius.h_lden.org updated the diff for D52237: w: Fix idle time in json output, add login/idle times to json output.

Add braces after if/else where the following expression is split over multiple lines

Aug 29 2025, 1:57 PM
marius.h_lden.org requested review of D52237: w: Fix idle time in json output, add login/idle times to json output.
Aug 29 2025, 1:40 PM

Dec 17 2021

marius.h_lden.org requested review of D33536: Fix carp being unable to recover from demotion due to send errors.
Dec 17 2021, 6:55 PM

Dec 14 2021

marius.h_lden.org abandoned D18358: Update modsecurity 3 plugin for www/nginx.
Dec 14 2021, 4:38 PM
marius.h_lden.org abandoned D18356: Update VTS plugin for www/nginx.
Dec 14 2021, 4:38 PM

Nov 27 2018

marius.h_lden.org created D18358: Update modsecurity 3 plugin for www/nginx.
Nov 27 2018, 4:08 PM
marius.h_lden.org updated the diff for D18357: Update security/modsecurity3 to v3.0.3.

Fix typo in LICENSE_FILE variable name.

Nov 27 2018, 4:01 PM
marius.h_lden.org updated the summary of D18357: Update security/modsecurity3 to v3.0.3.
Nov 27 2018, 3:53 PM
marius.h_lden.org created D18357: Update security/modsecurity3 to v3.0.3.
Nov 27 2018, 3:22 PM
marius.h_lden.org updated the diff for D18356: Update VTS plugin for www/nginx.

Update format of diff and bump port revison.

Nov 27 2018, 2:49 PM
marius.h_lden.org created D18356: Update VTS plugin for www/nginx.
Nov 27 2018, 1:14 PM
marius.h_lden.org accepted D18353: Rename www/mod_security3 to www/modsecurity3..

Just ignore my previous question, it's because of libxml2. Looks good to me.

Nov 27 2018, 10:03 AM
marius.h_lden.org added inline comments to D18353: Rename www/mod_security3 to www/modsecurity3..
Nov 27 2018, 10:00 AM