put {} back info if blocks because that's actually good idea
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Jan 23 2026
Jan 23 2026
reviews-freebsd-org412_ketas.si.pri.ee updated the diff for D54759: spi: use better logic for earlier change.
Jan 19 2026
Jan 19 2026
reviews-freebsd-org412_ketas.si.pri.ee updated the diff for D54759: spi: use better logic for earlier change.
assert is before loop now
Jan 17 2026
Jan 17 2026
reviews-freebsd-org412_ketas.si.pri.ee updated the diff for D54759: spi: use better logic for earlier change.
add assert
reviews-freebsd-org412_ketas.si.pri.ee added a comment to D54759: spi: use better logic for earlier change.
In D54759#1251338, @kevans wrote:I'm not sure I'm convinced that dir is actually always set, but I haven't spent that much time reading the above logic. An assertion on that here might be good to try and do something useful instead of infinitely looping, but I don't insist
reviews-freebsd-org412_ketas.si.pri.ee added reviewers for D54759: spi: use better logic for earlier change: ziaee, imp.
reviews-freebsd-org412_ketas.si.pri.ee added reviewers for D54759: spi: use better logic for earlier change: adrian, kevans.
reviews-freebsd-org412_ketas.si.pri.ee requested review of D54759: spi: use better logic for earlier change.
reviews-freebsd-org412_ketas.si.pri.ee added a comment to D54734: spi(8) - "-S" option for continuous stream from standard input to bus.
i was thinking of that already. that there must be way to run that while loop once with stream == 0. this is even better maybe as it shoots first and asks questions later. maybe it fits as there's no extra useless check. anyway i was always like how about an Actual C Coder (TM) *also* reviewing this
Jan 16 2026
Jan 16 2026
reviews-freebsd-org412_ketas.si.pri.ee added a comment to D54734: spi(8) - "-S" option for continuous stream from standard input to bus.
In D54734#1250682, @adrian wrote:The manpage could do with a bit more work but we can work on that a bit after landing. Lemme get some more eyeballs on this.
Jan 15 2026
Jan 15 2026
Nov 5 2025
Nov 5 2025
reviews-freebsd-org412_ketas.si.pri.ee requested review of D53597: rc: better method to load rc.conf's.