A much needed refresh for a very frequently referenced page. Good stuff!

No worries - glad it made it in :)

My bad - forgot to specify the man ref entities file to my macro :-/ Will switch to arc after this review :)

Fix possibility

Updated based on review feedback.

Updated based on review and fix a few more spelling mistakes in the file.

@wblock should we at least get this changed for now so that the information online is accurate?

Updated diff based on review comments

Updated diff based on review comments

Updated diff based on review comments

Done - patch coming soon.

Updated - patch to follow soon.

Lesson learned - these texts dont have to be verbatim copies of what the customer provider. Will add new patch soon.

Remove .com from Delimeter title.

changed Arp Networks to ARP Networks

Better to use variable to obtain size to allocate so that in the future if variable type changes, compiler's won't produce warnings and harder to track down.

Updated diff to remove igor fixes and focus only on content. We can do a igor cleanup pass separately.

In D6156#131660, @gjb wrote:

Actually, on closer review, your change contains non-content changes (whitespace, etc).

Missed removing an unnecessary section, note about user accounts must exist removed as its covered in the text prior to the example.

Updated diff based on review feedback

Updated review comments - diff to follow.

In addition to adding 10.2 under releases/

• added 10.2 to production list on homepage
• added 10.2 release section on ‘where’ aka download page

Abandoning again :)

@kristof, glad this issue is on the top of your head at all times :)

Updated based on wblock's review comments

No need to re-open. Abandoning again.

@kp, might have been closed with the wrong review/commit pair.

Updated based on review comments.

Igor cleanup, note on smbpassword being obsoleted, and note on pdbedit tool requiring unix accounts to exist.

Per comments, closing review. Will create new review linked to the same bug once I have something tangible.

@kristof - perfect. I should have enough info to start digging. Will close this review for now. Would you mind if I ping you separately if questions come up. Thanks

Thanks for your response. I have started reading the bridge code in if_bridge.c and located the bridge_ioctl_add() and bridge_ioctl_del() functions. I should be able to add some instrumentation code to see what is causing this behavior and even try to patch it so the bridge sticks with the mac address of the first interface it was assigned unless that was being removed. Been meaning to jump in and write some code so this is a perfect opportunity.

I found the issue when using jails. My setup involves em0 having a static ip and 2 cloned interfaces vlan0 for adding vlan tag on em0 traffic and bridge0 which includes vlan0 and all the epair interfaces created for each jail. After each jail is created and running, if I remove a jail using jail -r <name>, I see the error message above and all traffic after that is dropped. You may try to recreate the jail (jail -c <name>) if just removing isn't causing the error.

PR updated with latest patch (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=201578)

Update command continuation with 4 spaces on new line

Add one tab for command continuations.

Remove tabs/spaces from newlines in screen sections.

Rev3 diff attached

Switch to virtio-blk instead of ahci-hd for performance reasons.

Rev 2 diff attached

Full diff attached

Rev 1: fixes based on review.

Removed igor cleanup for the rest of the file from this review, will submit in a separate review. Ran 'igor -z' for these changes.