In D14934#314043, @mhorne063_gmail.com wrote:

setfacl.c could also benefit from having its 350+ line main function broken up a bit. I can do this, I'm just unsure if it would be better to include it as part of this patch or a follow-up. I want to keep the changes readable.

• Skip distinfo timestamp fetching for dep targets (requested by @bdrewery)

Whitespace nit while applying to my test tree:

@bdrewery, any comment on my proposal above?

Ok, I'll bite - *when* is the removal expected to happen?

Direct commits happen to stable branches, although not regularly, but somewhat often for things that -- wait for it -- have been removed from head.

In D14890#313064, @imp wrote:

While that would be ideal, I'd wager a moderate amount that neither one of these printfs ever fires, nor would have had it been in 11.0 (or even 9.0).

The argument for adding the notice in HEAD and then MFCing it is so that when someone wants to do the next deprecation, for 13.0, and searches the tree they'll find an example to copy.

Or maybe just "The .Nm driver is not present in .Fx 12.0 and later."

I think the tense is fine - in an ideal world we would have committed this just before 11 branched, giving release users (on 11) and -current users a full cycle before the drivers actually get removed just before the 12 branch. Of course lacking a time machine that's not possible, but committing this to head, merging to stable/11 asap, and removing from 12-current at your convenience is probably the best approximation.

• += from @antoine
• address newly added BINARY_ALIASes

• use ld=${LD} (@antoine)
• remove existing BINARY_ALIAS (@mat)

In D14876#312853, @mat wrote:

Mmmm, should not this be in the .if exists(/usr/bin/ld.bfd) block? Or does USE_BINUTILS also installs a ld.bfd and a ld.ldd?

These ports currently have BINARY_ALIAS=ld=ld.bfd and should be able to use just LLD_UNSAFE with this change:

I agree with brooks - I have a small preference for memset, and have used it in the similar cases I've addressed in the tree.

The change to OR should go in independent of the resolution on the full text question.

Passes smoke tests in QEMU (defaults; invoked as qemu-system-i386 -hda image.i386)

Worth comparing with NetBSD's?

fine with me

Posting for review as a heads-up / coordinate with any WIP