- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Aug 30 2017
Aug 29 2017
Aug 26 2017
Aug 25 2017
Aug 23 2017
Ok, I just don't want to end up with the usr.bin/clang/Makefile.inc logic proliferating, but I think this is fine for now and we can revisit that question if/when we find additional places that might want it.
Approved.
I think this is acceptable, although perhaps consider having something like LIMITED_DEBUG_INFO=yes that usr.bin/clang/Makefile.inc could set rather than having -gline-tables-only and -g1 in usr.bin/clang/Makefile.inc.
Aug 22 2017
Aug 21 2017
Aug 19 2017
Aug 18 2017
I wonder why we use a different approach for the MK_CLANG_IS_CC / MK_CLANG_BOOTSTRAP pair...
PR: 221543
Aug 17 2017
For reference, the reason devel/libunwind does not work with LLD:
devel/libunwind: mark as LLD_UNSAFE
Aug 16 2017
if they are used because our as don't grok the instructions, then it won't be possible.
Aug 15 2017
You cannot directly use DROP_GIANT() in one function, and PICKUP_GIANT() in another.
However, we can't call DROP/PICKUP because they have to be in the same block.
All looks reasonable to me.
Aug 14 2017
% gcc -gline-tables-only hello.c cc1: error: unrecognized debug output level 'line-tables-only'
Aug 13 2017
How will the linker identify <= armv6 vs armv7?
Aug 11 2017
Seems reasonable
Aug 10 2017
This doesn't provide a clean way to request DHCP config for an interface without obtaining a lease during install, but this isn't a regression from current behaviour. Perhaps we can cnage the "DHCP lease acquisition failed" message to instead ask "configure DHCP anyway? Y/n" and do the exec $0 only if the user answers n.
Perhaps we should just add a -q (quiet) option, which could also pick up PR 199776
Aug 9 2017
Approved, from hselasky review. (I'm not sufficiently familiar with libusb to give it my Reviewed-by.)
Aug 8 2017
I'd like to see a brief (perhaps 1 or 2 lines) comment explaining the reason for the .sinclude/defined() contortions - i.e., just mention that this will be built out-of-tree as a port.
Approved.