Page MenuHomeFreeBSD
Feed Advanced Search

Aug 30 2017

emaste added inline comments to D12171: map mips TARGET_ARCH to triples.
Aug 30 2017, 6:15 PM
emaste created D12171: map mips TARGET_ARCH to triples.
Aug 30 2017, 5:47 PM
emaste committed rS323023: bhnd: initialize variable before use.
bhnd: initialize variable before use
Aug 30 2017, 5:40 PM
emaste committed rS323022: arge: correct bzero sizeof (pointed-to object, not pointer).
arge: correct bzero sizeof (pointed-to object, not pointer)
Aug 30 2017, 5:39 PM
emaste created D12167: rt305x: address Clang warning.
Aug 30 2017, 3:54 PM
emaste committed rS323011: usb: Add external "Intenso Memory" disk UQ_MSC_NO_INQUIRY quirk.
usb: Add external "Intenso Memory" disk UQ_MSC_NO_INQUIRY quirk
Aug 30 2017, 1:44 AM
emaste committed rS323010: hv_vss.4: Fix spelling of 'responsibility'.
hv_vss.4: Fix spelling of 'responsibility'
Aug 30 2017, 1:38 AM
emaste committed rS323009: MFC r322581: remove debug files in delete-old* when WITHOUT_DEBUG_FILES.
MFC r322581: remove debug files in delete-old* when WITHOUT_DEBUG_FILES
Aug 30 2017, 1:15 AM

Aug 29 2017

emaste committed rS323002: zfs: do not advertise edonr which is not yet supported.
zfs: do not advertise edonr which is not yet supported
Aug 29 2017, 10:24 PM

Aug 26 2017

emaste accepted D12107: crunchgen: quiet -Wmissing-prototypes.
Aug 26 2017, 3:04 PM
emaste committed rS322919: MFC r322677: pw usermod: Properly deal with empty secondary group lists (-G '').
MFC r322677: pw usermod: Properly deal with empty secondary group lists (-G '')
Aug 26 2017, 12:36 AM
emaste committed rS322918: MFC r322683: ena.4: fix spelling of 'occurred'.
MFC r322683: ena.4: fix spelling of 'occurred'
Aug 26 2017, 12:31 AM
emaste committed rS322917: MFC r322680: sa.4: fix spelling of 'suppresses'.
MFC r322680: sa.4: fix spelling of 'suppresses'
Aug 26 2017, 12:30 AM
emaste committed rS322916: sys/modules: don't build bxe,qlxgbe if the user objects to sourceless ucode.
sys/modules: don't build bxe,qlxgbe if the user objects to sourceless ucode
Aug 26 2017, 12:29 AM

Aug 25 2017

emaste added inline comments to D8753: Introduce libcaspermock.
Aug 25 2017, 1:42 PM ยท capsicum

Aug 23 2017

emaste added a comment to D12025: Improve the coverage of debug symbols for MK_DEBUG_FILES..

Ok, I just don't want to end up with the usr.bin/clang/Makefile.inc logic proliferating, but I think this is fine for now and we can revisit that question if/when we find additional places that might want it.

Aug 23 2017, 8:59 PM
emaste added a comment to D12056: bsdgrep: provide primitive literal matcher instead of erroring out on fgrep use.

Approved.

Aug 23 2017, 8:22 PM
emaste added inline comments to D12110: Add MMCCAM-enabled kernel config for IMX6, reduce debug noice in MMCCAM kernels.
Aug 23 2017, 8:07 PM
emaste accepted D12025: Improve the coverage of debug symbols for MK_DEBUG_FILES..

I think this is acceptable, although perhaps consider having something like LIMITED_DEBUG_INFO=yes that usr.bin/clang/Makefile.inc could set rather than having -gline-tables-only and -g1 in usr.bin/clang/Makefile.inc.

Aug 23 2017, 7:15 PM
emaste committed rS322820: top: use __mips__ and __NetBSD__ for consistency.
top: use __mips__ and __NetBSD__ for consistency
Aug 23 2017, 5:57 PM
emaste closed D12072: Set MK_LLD_IS_LD to MK_LLD_BOOTSTRAP for cross-tools by committing rS322811: Set MK_LLD_IS_LD to MK_LLD_BOOTSTRAP for cross-tools.
Aug 23 2017, 12:47 PM
emaste committed rS322811: Set MK_LLD_IS_LD to MK_LLD_BOOTSTRAP for cross-tools.
Set MK_LLD_IS_LD to MK_LLD_BOOTSTRAP for cross-tools
Aug 23 2017, 12:47 PM

Aug 22 2017

emaste closed D12064: Add LLD_UNSAFE to force use of ld.bfd when ld is lld by committing rP448576: Add LLD_UNSAFE to force use of ld.bfd when ld is lld.
Aug 22 2017, 6:55 PM
emaste committed rP448576: Add LLD_UNSAFE to force use of ld.bfd when ld is lld.
Add LLD_UNSAFE to force use of ld.bfd when ld is lld
Aug 22 2017, 6:55 PM
emaste committed rS322798: newvers.sh: accommodate `git worktree`.
newvers.sh: accommodate `git worktree`
Aug 22 2017, 5:57 PM
emaste added inline comments to D12099: Add minimal kernel runtime for UBSAN.
Aug 22 2017, 2:51 PM

Aug 21 2017

emaste committed rS322748: MFC r322627: arm64: return error instead of panic in unimplemented ptrace ops.
MFC r322627: arm64: return error instead of panic in unimplemented ptrace ops
Aug 21 2017, 12:23 PM

Aug 19 2017

emaste committed rS322684: sys/modules: don't build qlxgbe if the user objects to sourceless ucode.
sys/modules: don't build qlxgbe if the user objects to sourceless ucode
Aug 19 2017, 1:12 AM
emaste committed rS322683: ena.4: fix spelling of 'occurred'.
ena.4: fix spelling of 'occurred'
Aug 19 2017, 12:52 AM
emaste committed rS322682: sys/modules: don't build bxe if the user objects to sourceless ucode.
sys/modules: don't build bxe if the user objects to sourceless ucode
Aug 19 2017, 12:45 AM
emaste committed rS322680: sa.4: fix spelling of 'suppresses'.
sa.4: fix spelling of 'suppresses'
Aug 19 2017, 12:37 AM
emaste committed rS322678: pw useradd: Validate the user name before creating the entry.
pw useradd: Validate the user name before creating the entry
Aug 19 2017, 12:32 AM
emaste committed rS322677: pw usermod: Properly deal with empty secondary group lists (-G '').
pw usermod: Properly deal with empty secondary group lists (-G '')
Aug 19 2017, 12:19 AM

Aug 18 2017

emaste committed rS322675: gas: add parens to clarify expression and eliminate clang warning.
gas: add parens to clarify expression and eliminate clang warning
Aug 18 2017, 9:21 PM
emaste committed rS322671: gas: fix "format string is not a string literal" errors on mips.
gas: fix "format string is not a string literal" errors on mips
Aug 18 2017, 6:26 PM
emaste committed rS322670: bfd: cast BFD_ALIGN to fix clang error on mips.
bfd: cast BFD_ALIGN to fix clang error on mips
Aug 18 2017, 6:21 PM
emaste committed rS322664: cam iosched: fix typos in comments.
cam iosched: fix typos in comments
Aug 18 2017, 4:38 PM
emaste added inline comments to D12056: bsdgrep: provide primitive literal matcher instead of erroring out on fgrep use.
Aug 18 2017, 3:21 PM
emaste added a comment to D12072: Set MK_LLD_IS_LD to MK_LLD_BOOTSTRAP for cross-tools.

I wonder why we use a different approach for the MK_CLANG_IS_CC / MK_CLANG_BOOTSTRAP pair...

Aug 18 2017, 3:20 PM
emaste added inline comments to D12056: bsdgrep: provide primitive literal matcher instead of erroring out on fgrep use.
Aug 18 2017, 2:52 PM
emaste added a comment to D12072: Set MK_LLD_IS_LD to MK_LLD_BOOTSTRAP for cross-tools.

PR: 221543

Aug 18 2017, 2:33 PM
emaste created D12072: Set MK_LLD_IS_LD to MK_LLD_BOOTSTRAP for cross-tools.
Aug 18 2017, 2:32 PM

Aug 17 2017

emaste updated subscribers of D12037: Fix freebsd-update(8) erroneous message and exit status when "fetch install" used .
Aug 17 2017, 7:45 PM
emaste committed rS322627: arm64: return error instead of panic in unimplemented ptrace ops.
arm64: return error instead of panic in unimplemented ptrace ops
Aug 17 2017, 7:16 PM
emaste added a comment to D12064: Add LLD_UNSAFE to force use of ld.bfd when ld is lld.

For reference, the reason devel/libunwind does not work with LLD:

devel/libunwind: mark as LLD_UNSAFE
Aug 17 2017, 1:41 PM
emaste created D12064: Add LLD_UNSAFE to force use of ld.bfd when ld is lld.
Aug 17 2017, 1:30 PM
emaste committed rS322604: MFC r322356: Mark PROFILE option as broken when targetting mips64.
MFC r322356: Mark PROFILE option as broken when targetting mips64
Aug 17 2017, 1:32 AM

Aug 16 2017

emaste committed rS322589: force use of ld.bfd for linking i386 libc, even when using lld.
force use of ld.bfd for linking i386 libc, even when using lld
Aug 16 2017, 6:55 PM
emaste closed D12044: remove debug files in delete-old* for WITHOUT_DEBUG_FILES by committing rS322581: remove debug files in delete-old* when WITHOUT_DEBUG_FILES.
Aug 16 2017, 5:22 PM
emaste committed rS322581: remove debug files in delete-old* when WITHOUT_DEBUG_FILES.
remove debug files in delete-old* when WITHOUT_DEBUG_FILES
Aug 16 2017, 5:22 PM
emaste created D12044: remove debug files in delete-old* for WITHOUT_DEBUG_FILES.
Aug 16 2017, 2:10 PM
emaste added a comment to D12010: Support armv7 builds for userland.

if they are used because our as don't grok the instructions, then it won't be possible.

Aug 16 2017, 12:27 AM

Aug 15 2017

emaste added a comment to D11866: Allow vt_timer() callout to run during mountroot input loop in vt(4).

You cannot directly use DROP_GIANT() in one function, and PICKUP_GIANT() in another.

Aug 15 2017, 9:05 PM
emaste added a comment to D11866: Allow vt_timer() callout to run during mountroot input loop in vt(4).

However, we can't call DROP/PICKUP because they have to be in the same block.

Aug 15 2017, 8:55 PM
emaste added inline comments to D11814: Implement "vidcontrol -h <history_size>" for vt(4).
Aug 15 2017, 1:56 PM
emaste added inline comments to D11814: Implement "vidcontrol -h <history_size>" for vt(4).
Aug 15 2017, 1:13 PM
emaste added inline comments to D11814: Implement "vidcontrol -h <history_size>" for vt(4).
Aug 15 2017, 12:53 PM
emaste added a comment to D12027: Tag all armv7 kernels as such in their machine config line..

All looks reasonable to me.

Aug 15 2017, 12:29 AM

Aug 14 2017

emaste added inline comments to D11814: Implement "vidcontrol -h <history_size>" for vt(4).
Aug 14 2017, 10:42 PM
emaste added inline comments to D11814: Implement "vidcontrol -h <history_size>" for vt(4).
Aug 14 2017, 9:10 PM
emaste added inline comments to D12010: Support armv7 builds for userland.
Aug 14 2017, 6:59 PM
emaste added a comment to D12025: Improve the coverage of debug symbols for MK_DEBUG_FILES..
% gcc -gline-tables-only hello.c
cc1: error: unrecognized debug output level 'line-tables-only'
Aug 14 2017, 6:20 PM

Aug 13 2017

emaste committed rS322474: lld: Add `-z muldefs` option..
lld: Add `-z muldefs` option.
Aug 13 2017, 9:12 PM
emaste committed rS322467: MFC r320736: acpidump: warn and exit loop on invalid subtable length.
MFC r320736: acpidump: warn and exit loop on invalid subtable length
Aug 13 2017, 6:14 PM
emaste committed rS322466: MFC r304000 (maxim): acpidump: move variable initialization out of assert(3).
MFC r304000 (maxim): acpidump: move variable initialization out of assert(3)
Aug 13 2017, 6:13 PM
emaste committed rS322461: MFC r321298: acpidump: add ACPI NFIT (NVDIMM Firmware Interface Table).
MFC r321298: acpidump: add ACPI NFIT (NVDIMM Firmware Interface Table)
Aug 13 2017, 4:45 PM
emaste committed rS322460: MFC r215837: uart: add AX99100 chipset support.
MFC r215837: uart: add AX99100 chipset support
Aug 13 2017, 4:40 PM
emaste added a comment to D12010: Support armv7 builds for userland.

How will the linker identify <= armv6 vs armv7?

Aug 13 2017, 12:42 AM

Aug 11 2017

emaste committed rS322415: lldb: enable on i386.
lldb: enable on i386
Aug 11 2017, 8:12 PM
emaste committed rS322414: arm: enable ARM_MANY_BOARD in NOTES for LINT build.
arm: enable ARM_MANY_BOARD in NOTES for LINT build
Aug 11 2017, 7:49 PM
emaste committed rS322409: Rename at91_pmc's M_PMC malloc type to avoid duplicate definition.
Rename at91_pmc's M_PMC malloc type to avoid duplicate definition
Aug 11 2017, 6:09 PM
emaste added a comment to D11986: One copy to make CPUARCH from ARCH..

Seems reasonable

Aug 11 2017, 5:17 PM

Aug 10 2017

emaste committed rS322374: bsdinstall: record DHCP config after obtaining lease.
bsdinstall: record DHCP config after obtaining lease
Aug 10 2017, 8:26 PM
emaste closed D11967: bsdinstall: record DHCP config after obtaining lease by committing rS322374: bsdinstall: record DHCP config after obtaining lease.
Aug 10 2017, 8:26 PM
emaste added a comment to D11967: bsdinstall: record DHCP config after obtaining lease.

This doesn't provide a clean way to request DHCP config for an interface without obtaining a lease during install, but this isn't a regression from current behaviour. Perhaps we can cnage the "DHCP lease acquisition failed" message to instead ask "configure DHCP anyway? Y/n" and do the exec $0 only if the user answers n.

Aug 10 2017, 8:24 PM
emaste created D11967: bsdinstall: record DHCP config after obtaining lease.
Aug 10 2017, 8:18 PM
emaste added a comment to D3527: Suppress harmless warning if running in 'cron' mode.

Perhaps we should just add a -q (quiet) option, which could also pick up PR 199776

Aug 10 2017, 2:57 PM
emaste committed rS322360: lldb: Report inferior signals as signals, not exceptions, on FreeBSD.
lldb: Report inferior signals as signals, not exceptions, on FreeBSD
Aug 10 2017, 1:51 PM
emaste closed D11950: Mark MK_PROFILE as broken when targetting mips64 by committing rS322356: Mark PROFILE option as broken when targetting mips64.
Aug 10 2017, 1:01 PM
emaste committed rS322356: Mark PROFILE option as broken when targetting mips64.
Mark PROFILE option as broken when targetting mips64
Aug 10 2017, 1:01 PM
emaste accepted D11950: Mark MK_PROFILE as broken when targetting mips64.
Aug 10 2017, 12:58 PM

Aug 9 2017

emaste accepted D11936: Add myself to calendar.freebsd.
Aug 9 2017, 9:09 PM
emaste committed rS322326: lldb: Make i386-*-freebsd expression work on JIT path.
lldb: Make i386-*-freebsd expression work on JIT path
Aug 9 2017, 7:09 PM
emaste committed rS322325: cat: fix build with -DNO_UDOM_SUPPORT.
cat: fix build with -DNO_UDOM_SUPPORT
Aug 9 2017, 6:24 PM
emaste accepted D10937: capsicum_helpers: Add FIODTYPE to default ioctls allowed.
Aug 9 2017, 5:27 PM
emaste updated subscribers of D11317: expr(1): Add -E flag to interpret regular expressions as EREs.
Aug 9 2017, 4:54 PM
emaste added a comment to D11494: libusb(3): Expose device capabilities as libusb_bos_descriptor::dev_capability.

Approved, from hselasky review. (I'm not sufficiently familiar with libusb to give it my Reviewed-by.)

Aug 9 2017, 4:54 PM
emaste added a reviewer for D10937: capsicum_helpers: Add FIODTYPE to default ioctls allowed: oshogbo.
Aug 9 2017, 4:51 PM
emaste accepted D11935: Mark geom classes as deprecated..
Aug 9 2017, 4:08 PM
emaste accepted D11935: Mark geom classes as deprecated..
Aug 9 2017, 3:49 PM

Aug 8 2017

emaste accepted D11749: df(1): Add --si as an alternative name for -H.
Aug 8 2017, 8:18 PM
emaste accepted D11748: du(1): Add --si option and test.
Aug 8 2017, 8:17 PM
emaste added a comment to D11395: bsdgrep(1): Switch src.opts.mk .include to .sinclude for out-of-tree builds.

I'd like to see a brief (perhaps 1 or 2 lines) comment explaining the reason for the .sinclude/defined() contortions - i.e., just mention that this will be built out-of-tree as a port.

Aug 8 2017, 8:13 PM
emaste added a comment to D11233: regex(3): Refactor fast/slow stepping bits in the matching engine.

Approved.

Aug 8 2017, 8:10 PM
emaste committed rS322271: Remove now-unused badsb declaration, missed in r322200.
Remove now-unused badsb declaration, missed in r322200
Aug 8 2017, 6:32 PM
emaste added inline comments to D11589: Print more info when super blocks don't match, implement ability to ignore mismatches..
Aug 8 2017, 6:20 PM
emaste added inline comments to D11925: Export std::get_new_handler() from libcxxrt.so.
Aug 8 2017, 4:40 PM
emaste committed rS322254: MFC r321734: bsdinstall: default to UEFI-only boot on arm64.
MFC r321734: bsdinstall: default to UEFI-only boot on arm64
Aug 8 2017, 1:44 PM

Aug 7 2017

emaste added a reviewer for D11918: Fix vt(4)'s response to Device Status Report escape sequences: ed.
Aug 7 2017, 11:31 PM
emaste committed rS322202: UPDATING: clarify what the RCMDS knob controls.
UPDATING: clarify what the RCMDS knob controls
Aug 7 2017, 9:30 PM