Page MenuHomeFreeBSD
Feed Advanced Search

Apr 4 2022

bsd_dino.sk added inline comments to D34764: Enhance if_cgem (add SGMII connection type, rewrite errata logic, fix typo).
Apr 4 2022, 9:37 PM
bsd_dino.sk updated the diff for D34764: Enhance if_cgem (add SGMII connection type, rewrite errata logic, fix typo).

Fix probe issue pointed to by skibo

Apr 4 2022, 5:20 PM
bsd_dino.sk added inline comments to D34764: Enhance if_cgem (add SGMII connection type, rewrite errata logic, fix typo).
Apr 4 2022, 5:00 PM
bsd_dino.sk updated the diff for D34764: Enhance if_cgem (add SGMII connection type, rewrite errata logic, fix typo).

Inline comments made by mhorne addressed...

Apr 4 2022, 4:57 PM
bsd_dino.sk added a comment to D34764: Enhance if_cgem (add SGMII connection type, rewrite errata logic, fix typo).

The quirk handling changes ... should be committed separately from the phy_contype + typo changes.

Apr 4 2022, 4:46 PM
bsd_dino.sk requested review of D34764: Enhance if_cgem (add SGMII connection type, rewrite errata logic, fix typo).
Apr 4 2022, 2:51 PM

Apr 2 2022

bsd_dino.sk updated the diff for D34687: Add Makefile to create if_cgem.ko kernel module.

This diff was done with -U99999 and module directory was renamed to sys/modules/if_cgem. Hopefully there is no space/tabs issue, now it should apply correctly.

Apr 2 2022, 3:07 PM

Mar 31 2022

bsd_dino.sk added inline comments to D34256: Make miibus.ko module on par with using 'device miibus' in kernel config.
Mar 31 2022, 6:18 AM
bsd_dino.sk added a comment to D34687: Add Makefile to create if_cgem.ko kernel module.

Hi, the patch does not apply correctly to the main branch. Can you rebase and re-upload the diff with context?

One final suggestion: the new subfolder should be named sys/modules/if_cgem, to match the module name.

Mar 31 2022, 6:16 AM

Mar 28 2022

bsd_dino.sk added a comment to D34687: Add Makefile to create if_cgem.ko kernel module.

Minor notes, but this looks good!

In the future, please upload diffs with full context -- git show -U99999.

Mar 28 2022, 6:33 PM
bsd_dino.sk added a comment to D34687: Add Makefile to create if_cgem.ko kernel module.

Additional note: Makefile originally provided by Thomas Skibo, I'd like to attribute it properly.

Mar 28 2022, 2:09 PM
bsd_dino.sk added a comment to D34256: Make miibus.ko module on par with using 'device miibus' in kernel config.

New revision is just being created, https://reviews.freebsd.org/D34687, for building if_cgem.ko kernel module, used to test changes proposed here for miibus.ko kernel module

Mar 28 2022, 5:47 AM
bsd_dino.sk requested review of D34687: Add Makefile to create if_cgem.ko kernel module.
Mar 28 2022, 5:44 AM

Mar 6 2022

bsd_dino.sk added a comment to D34256: Make miibus.ko module on par with using 'device miibus' in kernel config.

Testing with 'make buildenv' revealed opt_platform.h is necessary as well. As part of normal buildkernel, this file is already created.

Mar 6 2022, 3:16 PM
bsd_dino.sk updated the diff for D34256: Make miibus.ko module on par with using 'device miibus' in kernel config.

Minimal diff with new files added at the end.

Mar 6 2022, 3:12 PM

Feb 19 2022

bsd_dino.sk added a comment to D34256: Make miibus.ko module on par with using 'device miibus' in kernel config.
In D34256#775528, @mindal_semihalf.com wrote:

I think it might be better to keep the file sorted the way it was before this change.
This will make this patch much easier to read.

Feb 19 2022, 11:47 AM

Feb 14 2022

bsd_dino.sk added a reviewer for D34256: Make miibus.ko module on par with using 'device miibus' in kernel config: Contributor Reviews (base).
Feb 14 2022, 9:32 AM

Feb 12 2022

bsd_dino.sk updated the diff for D34256: Make miibus.ko module on par with using 'device miibus' in kernel config.

Original patch missed inclusion of VSCPHY driver, corrected here.

Feb 12 2022, 8:18 AM
bsd_dino.sk requested review of D34256: Make miibus.ko module on par with using 'device miibus' in kernel config.
Feb 12 2022, 8:15 AM

Nov 17 2021

bsd_dino.sk added a comment to D32813: Introduce DP83867 PHY driver.

After some mail exchange regarding problem elsewhere, applied this review minus maxspeed handling for brevity, DP83867 PHY looks like working for me (I need to fix something else unrelated to this review to be sure) - at least media status sense and autonegotiation works as expected.

Nov 17 2021, 12:33 PM
bsd_dino.sk added a comment to D32813: Introduce DP83867 PHY driver.

Looking a bit more into it, I think maxspeed variable and mii_maxspeed struct member is just read from DTB, but not used anywhere.

Nov 17 2021, 10:07 AM
bsd_dino.sk added a comment to D32813: Introduce DP83867 PHY driver.

I'd like to test this review, but two errors occured when building. First one, unknown function 'device_get_property' means I need fresh sources (I see it in recently fetched git repository).
Second one, no member named 'mii_maxspeed' in 'struct mii_softc' I can't resolve recently - looking into file sys/dev/mii/miivar.h, where struct mii_softc is defined, does not show such member of structure.

Nov 17 2021, 9:57 AM