In D29861#670188, @kevans wrote:

As @0mp pointed out, with a random patch from Bugzilla you would commit with git commit --author="Bob Snow <bob@snow.us>" to get the correct authorship recorded and you would be reflected on the "Commit" line (this requires --pretty=full to show). Going forward, we should be encouraging git show style patches so that you can just git am it and not worry about the metadata or commit message.

I may be misunderstanding the process you're describing, but it sounds to me like you're talking about a situation involving merging a pull request where the author is annotated. If the submission came from a BZ bug report, is the "Submitted by" field not still relevant?

In D29861#670168, @kevans wrote:

IMO if "Submitted by" gets restored, it should be noted that it's expected to be more of an anomaly than the norm -- reserved for situations where the original work was submitted by someone else, but changed substantially enough that the author should be updated.

Two thoughts here:

In D24324#630061, @0mp wrote:

In D24324#549920, @andrew_tao173.riddles.org.uk wrote:

Discussion point: this implementation converts the variable name to upper case for consistency with the way that port option_VARS works. But there are some cases where one might want to set a mixed-case name (such as CFLAGS.arch), so maybe it shouldn't do that and just use the case as written?

I'd say there is no point in supporting all-lowercase variable names (e.g., disable_make_jobs) instead of just the actual names (e.g., DISABLE_MAKE_JOBS). I must say that I'm a bit confused why option_VARS is supposedly supporting such a syntactic sugar.

This is a clever approach! If I'm reading it correctly, this should also fix the case of unnecessary (i.e. test/bench) modules being dragged in and not used in the final build.