Fix S3 suspend.

Rebase on top of D52705.

fixes from review comment in D52598

these changes have been rolled into D52705 because the original commit that had these changes had to be reverted anyways.

In D52598#1201481, @madpilot wrote:

I finally tested this and works fine for me.

I'm sorry I was unable to test it earlier!

In D52598#1201370, @zarychtam_plan-b.pwste.edu.pl wrote:

This patch fixes panic. Please push it when it's ready.

Edit: Unfortunately, suspend is still broken, PC wakes up immediately.

Move struct acpi_wake_prep_context out of acpivar.h

In D52600#1201315, @cy wrote:

This patch fails to address the regression.

Do this correctly.

yeah you're absolutely right, I thought acpi_shutdown's dev was a device but its the actual bus of course so this is easy. Will do that in a minute

Abandoned in favour of the D52036, D52043, D52036 stack.

In D52036#1198932, @markj wrote:

Really just the latter, though "STYPE" is a bit obscure for my taste.

In D52036#1198920, @markj wrote:

I'm not a big fan of the POWER_STYPE_* naming, but hopefully that can be improved and reconciled with the POWER_SLEEP_STATE_* definitions at some point.

forgot to actually do the small fix in question

more small fixes

small fixes

Use own sysctl handler for ACPI stuff so we can still support old S-states here (even though deprecated).

make power_sysctl_stype private

Actually this would need sys/types.h to be included because sysctl.h makes use of u_int and intmax_t. Is it okay to include this?

Accept all USB4 class PCI devices in nhi_pci_probe

Fixes

Fixes

thanks :)

Fixes

Fix indentation

thanks for reviewing!

Respond to feedback

I'm still going through the code, but here's a few preliminary comments :)

Thanks :) I've added the related commit but I don't see an option to close rather than abandon. I'm assuming this would be in the "add action" dropdown?

Thanks for taking a look @avg

Committed in 231939c628f2a0a6823008c0a4d2a36b7de5146b, forgot the Differential Revision: tag, sorry about that :(

Use jrm@'s syntax for scheduler patch list

Remove duplicates in scheduler patches

@salvadore are you okay with these changes as they are?

Remove style changes

thanks for the review!

Respond to review comments

Thanks for reviewing this!

Respond to @aokblast 's review comments

In D52132#1190737, @melifaro wrote:

All good, just a note (mostly to myself) on error handling and atomicity. What we do here (myself included) is sequence on priv-check & execute calls, where we stop abruptly half-way if we lack privilege for 1 out of 10 changes. The outcome (e.g. partial change) is now dependent on the block order inside the function.
What we should do instead is either try to move towards more atomicity (checking all privileges in the beginning and failing) or more overall completion (e.g. don't stop on the first failure), which is harder reporting-wise.
Generally I'd prefer the former approach. I don't think we need to change it here, I'd rather have a separate diff reshuffling error handling approach.