Actually yes, this change isn't correct. See https://github.com/tianocore/edk2/blob/master/MdePkg/Library/UefiMemoryAllocationLib/MemoryAllocationLib.c for an example of how to allocate aligned memory (InternalAllocateAlignedPages etc.)

In D21580#470252, @araujo wrote:

You have my approve to commit it! Thank you!

In D21580#470248, @araujo wrote:

USE_GCC will set build-time and run-time dependency, if we need only build-time dependency the patch looks good to me.

Fix USES.

Fix GCC_DEFAULT.

Restore Makefile.depend

In D20562#466721, @emaste wrote:

Is stand/efi/boot1/Makefile.depend supposed to be deleted?

Keep building boot1.efi

In D20562#463153, @emaste wrote:

Since makefs fat support has been committed, proceed with removing all the EFI FAT code.

In D21281#463691, @bcran wrote:

Huh, I'm seeing some really odd stuff in there right from the very first time we call it, way before the crash (and when connecting using both HTTP and HTTPS):

In D21281#463005, @scottph wrote:

In D21281#462767, @imp wrote:

Fixed another place where we try and open a file without first calling
efihttp_dev_close and efihttp_dev_open.

In D21281#462739, @scottph wrote:

Is this error case something that happens only sometimes? Fetching multiple files is something that has definitely worked for me before.

In D19976#456807, @araujo wrote:

ping!!!

In D20765#449872, @greg_unrelenting.technology wrote:

I'm going through my list of reviews and noticed this one. Does it need more work, or can it be committed?

@yuripv Are you still planning to commit this?

I committed a temporary fix to increase the size to 100MB on x64 in r349471.

I just tried booting with this patch applied and with EDK2 firmware built from master yesterday, and I still don't see any output - both with devicetree and acpi.

• Only bump EFI_STAGING_SIZE for x64

• Added error handling around realloc.

• Fixed a couple more issues

• loader: add HTTP support using UEFI
• Updates per review feedback.

I realized one issue: we should perhaps add a configuration option such as LOADER_EFIHTTP_SUPPORT to let people disable this.

In D20562#447282, @emaste wrote:

In D20562#445261, @andrew wrote:

Is there a way to build the efi fs this without root? I build images in a Jenkins instance to test FreeBSD/arm64 on various simulators and would prefer to not need to give the Jenkins user sudo access.

Removed tmpl.xz files and updated ObsoleteFiles.inc and OptionalObsoleteFiles.inc

In D19869#432543, @mat wrote:

Approved with the changes requested.

Could you explain what problem this is solving, please? I don't think I've had a problem with loader.efi finding the FreeBSD installation to boot from.

• MAKE_ARGS should be =, not += .

• Remove duplicated and unneeded lines.