Page MenuHomeFreeBSD
Feed Advanced Search

Jul 1 2022

thj added a comment to D35676: Catch up with 2004 and improve markup..

LGTM, please check with igor to be sure I am not a great mdoc parser.

Jul 1 2022, 8:03 AM

Jun 23 2022

thj abandoned D34421: diff3: Add support for -A and -m.
Jun 23 2022, 3:16 PM
thj committed rG795888971628: Add tests for TCP_MD5 getsockopt (authored by Claudio Jeker <claudio@openbsd.org>).
Add tests for TCP_MD5 getsockopt
Jun 23 2022, 2:59 PM
thj committed rG97453e5e7258: Unlock inp when handling TCP_MD5SIG socket options (authored by Claudio Jeker <claudio@openbsd.org>).
Unlock inp when handling TCP_MD5SIG socket options
Jun 23 2022, 2:59 PM
thj closed D35532: Unlock inp when handling TCP_MD5SIG socket options.
Jun 23 2022, 2:59 PM
thj updated the diff for D35532: Unlock inp when handling TCP_MD5SIG socket options.
  • Correct copyright
Jun 23 2022, 2:48 PM
thj closed D35325: Add man page description for version and help.
Jun 23 2022, 12:39 PM
thj committed rG26b5deef22ae: diff3: Add man page description for version and help (authored by thj).
diff3: Add man page description for version and help
Jun 23 2022, 12:39 PM
thj abandoned D34762: ctld: Fix coverity raised issues.
Jun 23 2022, 12:19 PM
thj requested review of D35574: xargs: terminate if line replacement cannot be constructed.
Jun 23 2022, 10:00 AM

Jun 22 2022

thj updated the diff for D35532: Unlock inp when handling TCP_MD5SIG socket options.
  • Add test cases for getsockopt
Jun 22 2022, 3:07 PM

Jun 21 2022

thj updated subscribers of D35531: Propigate v_free_target updates to pid controllers in each domain.

There are some other thresholds that are derived from the free target. zfs_arc_free_target, vmd_pageout_wakeup_thresh and vmd_background_launder_target, at least. It's not obvious to me that the system will behave sanely if those values are left unchanged. Though, today it's possible to modify the per-domain free targets, and the sysctl handler doesn't take any of this into account.

Jun 21 2022, 9:51 AM

Jun 20 2022

thj requested review of D35532: Unlock inp when handling TCP_MD5SIG socket options.
Jun 20 2022, 1:16 PM
thj requested review of D35531: Propigate v_free_target updates to pid controllers in each domain.
Jun 20 2022, 9:31 AM

May 30 2022

thj updated the diff for D35325: Add man page description for version and help.
  • Don't user diff3 and Nm
  • bump date
May 30 2022, 12:33 PM
thj added a comment to D35325: Add man page description for version and help.

Is it worth saying whether diff3 --help and diff3 --version output to stdout or stderr?

GNU diff3 has -v as a --version alias. Does the replacement want/have that? If so, should be added to the manual page.

May 30 2022, 12:31 PM

May 26 2022

thj requested review of D35325: Add man page description for version and help.
May 26 2022, 1:42 PM
thj added a reviewer for D35324: Try to make eflag easier to follow: Klara.
May 26 2022, 1:25 PM
thj requested review of D35324: Try to make eflag easier to follow.
May 26 2022, 1:23 PM

May 25 2022

thj committed rG3ddd6eb688af: diff3: Add help and version options (authored by thj).
diff3: Add help and version options
May 25 2022, 2:10 PM
thj committed rG59f6408d8d61: diff3: Copy line into debug information (authored by thj).
diff3: Copy line into debug information
May 25 2022, 2:09 PM
thj committed rG7d975c7f93f1: diff3: Don't perform a bitwise OR when comparing diffs (authored by thj).
diff3: Don't perform a bitwise OR when comparing diffs
May 25 2022, 2:09 PM

May 5 2022

thj added a reviewer for D35117: netinet6: streamline scope6 checks for loopback traffic in ip6_output().: thj.
May 5 2022, 3:09 PM

May 2 2022

thj committed rGc1c381eb7f82: diff3: Remove test case that references non existent test files (authored by thj).
diff3: Remove test case that references non existent test files
May 2 2022, 3:03 PM

Apr 27 2022

thj committed rG5acfa48bb258: if_bnxt: Allow bnxt interfaces to use vlans (authored by Misho <misho@elwix.org>).
if_bnxt: Allow bnxt interfaces to use vlans
Apr 27 2022, 1:56 PM
thj committed rGe54505277c39: if_bnxt: Allow bnxt interfaces to use vlans (authored by Misho <misho@elwix.org>).
if_bnxt: Allow bnxt interfaces to use vlans
Apr 27 2022, 1:17 PM

Apr 26 2022

thj accepted D35066: tcp: Rack idle reduce not working..

Looks good to me

Apr 26 2022, 12:48 PM

Apr 22 2022

thj updated the diff for D34762: ctld: Fix coverity raised issues.
  • Revert "ctld: Only use strtoul when str is not NULL"
Apr 22 2022, 1:51 PM
thj added inline comments to D34762: ctld: Fix coverity raised issues.
Apr 22 2022, 1:47 PM
thj added a comment to D34762: ctld: Fix coverity raised issues.

Hits coverity id: 1474355 in our coverity

Apr 22 2022, 1:43 PM

Apr 21 2022

thj closed D34824: if_bnxt: Allow bnxt interfaces to use vlans with promisc mode.
Apr 21 2022, 8:33 AM
thj committed rG0c6a2fa33e36: if_bnxt: Allow bnxt interfaces to use vlans (authored by Misho <misho@elwix.org>).
if_bnxt: Allow bnxt interfaces to use vlans
Apr 21 2022, 8:32 AM

Apr 19 2022

thj committed rG034dd2d54f2e: diff3: Add support for -m (authored by thj).
diff3: Add support for -m
Apr 19 2022, 3:25 PM
thj committed rG9ab079c5e810: diff3: Add support for -A (authored by thj).
diff3: Add support for -A
Apr 19 2022, 2:55 PM
thj committed rGdf092859b478: diff3: seperate old and new markers from file markers (authored by thj).
diff3: seperate old and new markers from file markers
Apr 19 2022, 2:41 PM
thj committed rG2184ca3f191d: diff3: Clean up printing of ranges for edscript output (authored by thj).
diff3: Clean up printing of ranges for edscript output
Apr 19 2022, 1:52 PM
thj closed D34941: diff3: Clean up printing of ranges for edscript output.
Apr 19 2022, 1:52 PM
thj closed D34674: etcupdate: remove redundant diff3 flag.
Apr 19 2022, 7:41 AM
thj accepted D34952: prometheus_sysctl_exporter: fix metric aliasing.
Apr 19 2022, 7:39 AM

Apr 18 2022

thj added inline comments to D34941: diff3: Clean up printing of ranges for edscript output.
Apr 18 2022, 3:09 PM
thj updated the diff for D34941: diff3: Clean up printing of ranges for edscript output.
  • Don't free line buffer in getline loop
Apr 18 2022, 3:09 PM
thj requested review of D34941: diff3: Clean up printing of ranges for edscript output.
Apr 18 2022, 1:23 PM

Apr 15 2022

thj closed D34912: diff3: allow diff3 ed scripts to generate deletions.
Apr 15 2022, 2:02 PM
thj committed rG7c03df6855f4: diff3: allow diff3 ed scripts to generate deletions (authored by thj).
diff3: allow diff3 ed scripts to generate deletions
Apr 15 2022, 2:02 PM
thj updated the diff for D34912: diff3: allow diff3 ed scripts to generate deletions.
  • pass bool into prange in change
Apr 15 2022, 1:56 PM
thj updated the diff for D34912: diff3: allow diff3 ed scripts to generate deletions.
  • Only end ed input stream if we aren't issuing a delete
Apr 15 2022, 8:44 AM
thj updated the diff for D34912: diff3: allow diff3 ed scripts to generate deletions.
  • Make delete bool
Apr 15 2022, 8:01 AM

Apr 14 2022

thj added inline comments to D34912: diff3: allow diff3 ed scripts to generate deletions.
Apr 14 2022, 4:01 PM
thj requested review of D34912: diff3: allow diff3 ed scripts to generate deletions.
Apr 14 2022, 3:28 PM

Apr 13 2022

thj committed rG016bfb0a974a: etcupdate: remove redundant diff3 flag (authored by thj).
etcupdate: remove redundant diff3 flag
Apr 13 2022, 3:06 PM
thj accepted D30043: tcp: Whitespace cleanup in brr and rack.

I don't see any functional changes and rrs blocking review has landed, so this looks fine to land to me.

Apr 13 2022, 9:16 AM

Apr 12 2022

thj updated the diff for D34824: if_bnxt: Allow bnxt interfaces to use vlans with promisc mode.

With just misho's patch from bz

Apr 12 2022, 4:47 PM
thj committed rG1ea833a57290: kdb: set kdb_why when entered via reboot and panic (authored by thj).
kdb: set kdb_why when entered via reboot and panic
Apr 12 2022, 9:35 AM
thj closed D34551: kdb: set kdb_why when entered via reboot and panic.
Apr 12 2022, 9:35 AM

Apr 7 2022

thj added a reviewer for D34824: if_bnxt: Allow bnxt interfaces to use vlans with promisc mode: rpokala.
Apr 7 2022, 4:54 PM
thj added a reviewer for D34824: if_bnxt: Allow bnxt interfaces to use vlans with promisc mode: mav.
Apr 7 2022, 4:50 PM
thj requested review of D34824: if_bnxt: Allow bnxt interfaces to use vlans with promisc mode.
Apr 7 2022, 4:35 PM
thj committed rG1241e8e7aed5: siftr: expose t_flags2 in siftr output (authored by thj).
siftr: expose t_flags2 in siftr output
Apr 7 2022, 9:18 AM
thj closed D34672: siftr: expose t_flags2 in siftr output.
Apr 7 2022, 9:18 AM
thj added inline comments to D34672: siftr: expose t_flags2 in siftr output.
Apr 7 2022, 9:10 AM

Apr 6 2022

thj updated the diff for D34672: siftr: expose t_flags2 in siftr output.
  • Remove extra format specifier
Apr 6 2022, 10:00 AM

Apr 4 2022

thj requested review of D34762: ctld: Fix coverity raised issues.
Apr 4 2022, 11:06 AM

Apr 2 2022

thj abandoned D34048: Capture return values when registering waits.
Apr 2 2022, 7:40 PM

Mar 30 2022

thj updated the diff for D34672: siftr: expose t_flags2 in siftr output.
  • Update field sizes to match tcpcb
  • Update format string
Mar 30 2022, 12:36 PM

Mar 25 2022

thj requested review of D34674: etcupdate: remove redundant diff3 flag.
Mar 25 2022, 4:20 PM
thj added inline comments to D34551: kdb: set kdb_why when entered via reboot and panic.
Mar 25 2022, 3:27 PM
thj requested review of D34672: siftr: expose t_flags2 in siftr output.
Mar 25 2022, 2:51 PM

Mar 15 2022

thj added a comment to D34421: diff3: Add support for -A and -m.

There doesn't seem to be any specification of the diff3 behavior, so I spent some time looking for some test cases. GNU doesn't provide much directly in the source (https://git.savannah.gnu.org/cgit/diffutils.git/plain/tests/diff3) and also the mailing list isn't rich in corner cases relating to diff3. I've found some test cases for git's implementation (https://github.com/git/git/search?l=Shell&q=diff3) but I only skimmed that so I don't know how useful they are.

Mar 15 2022, 10:19 AM
thj committed rG81e0e7b9e36d: bsnmp: Use mkstemp when creating clients local socket (authored by thj).
bsnmp: Use mkstemp when creating clients local socket
Mar 15 2022, 8:21 AM
thj closed D34550: bsnmp: Use mkstemp when creating clients local socket.
Mar 15 2022, 8:21 AM

Mar 14 2022

thj requested review of D34551: kdb: set kdb_why when entered via reboot and panic.
Mar 14 2022, 5:05 PM
thj added a comment to D34550: bsnmp: Use mkstemp when creating clients local socket.

I am not sure if FreeBSD is upstream here, it might be harti's own private tree, it isn't 100% clear to me.

Mar 14 2022, 3:41 PM
thj requested review of D34550: bsnmp: Use mkstemp when creating clients local socket.
Mar 14 2022, 3:39 PM

Mar 10 2022

thj committed rG93b7af1d854d: diff: Re-add void argument to usage (authored by thj).
diff: Re-add void argument to usage
Mar 10 2022, 4:26 PM
thj committed rG8cf449db88b2: diff: add support for --help and --version (authored by thj).
diff: add support for --help and --version
Mar 10 2022, 4:19 PM
thj closed D34508: diff: add support for --help and --version.
Mar 10 2022, 4:18 PM
thj added a comment to D34508: diff: add support for --help and --version.

Yeah, wrong diff point with arc diff, I am sure arcanist wasn't this much trouble to use before

Mar 10 2022, 2:38 PM
thj updated the diff for D34508: diff: add support for --help and --version.

Add back the code changes

Mar 10 2022, 2:38 PM
thj updated the diff for D34508: diff: add support for --help and --version.

Update based on man page feedback

Mar 10 2022, 1:31 PM

Mar 9 2022

thj requested review of D34508: diff: add support for --help and --version.
Mar 9 2022, 11:20 AM
thj committed rG7e64519a479a: diff: set cflag when passed to diff (authored by thj).
diff: set cflag when passed to diff
Mar 9 2022, 9:35 AM
thj closed D34481: diff: set cflag when passed to diff.
Mar 9 2022, 9:35 AM

Mar 8 2022

thj requested review of D34481: diff: set cflag when passed to diff.
Mar 8 2022, 5:00 PM

Mar 4 2022

thj added a comment to D34421: diff3: Add support for -A and -m.

From the summary: "Add tests, first using the original provided 1.txt, 2.txt, 3.txt, but also add
lao tzu tao tests from the gnu diff3 how to guide and finally some manually
written tests which excised other cases."

Unless you really mean "precisely or surgically cut off with a sharp knife" (literally or figuratively), that should be "exercised".

Since (per https://reviews.freebsd.org/D34411#change-nX1rdgK113Nt) mg was explicitely put in the public domain, you could use it instead of lao tzu and tao.

Mar 4 2022, 9:16 AM

Mar 3 2022

thj updated the test plan for D34421: diff3: Add support for -A and -m.
Mar 3 2022, 10:31 AM
thj requested review of D34421: diff3: Add support for -A and -m.
Mar 3 2022, 10:30 AM

Mar 1 2022

thj committed rG4be7d087c2b5: diff: Use start of change when searching for function (authored by thj).
diff: Use start of change when searching for function
Mar 1 2022, 1:28 PM
thj closed D34328: diff: Use change start when searching for function names.
Mar 1 2022, 1:28 PM

Feb 21 2022

thj requested review of D34328: diff: Use change start when searching for function names.
Feb 21 2022, 11:19 AM

Feb 18 2022

thj committed rG3931c072c63d: diff: fix failed compare when ignoring file case (authored by thj).
diff: fix failed compare when ignoring file case
Feb 18 2022, 3:56 PM
thj closed D34201: Fix ignore case when diffing recursively.
Feb 18 2022, 3:55 PM
thj committed rGcffebd1e8fed: Remove surplus check for which diff is being tested (authored by thj).
Remove surplus check for which diff is being tested
Feb 18 2022, 3:51 PM
thj committed rGf4be3645a14d: diff: add --no-dereference flag (authored by thj).
diff: add --no-dereference flag
Feb 18 2022, 3:19 PM
thj closed D34203: Add support of --no-dereference.
Feb 18 2022, 3:18 PM
thj committed rG8f79bd9b8571: diff: Detect Objective-C methods (authored by thj).
diff: Detect Objective-C methods
Feb 18 2022, 3:13 PM
thj closed D34202: Search for objective c method definitions.
Feb 18 2022, 3:13 PM

Feb 11 2022

thj updated the diff for D34201: Fix ignore case when diffing recursively.
  • Add tests for ignore case
  • Correct path passed to diffit when using Nflag or Pflag
Feb 11 2022, 1:20 PM

Feb 10 2022

thj updated the diff for D34202: Search for objective c method definitions.
  • Add tests for finding function names
Feb 10 2022, 3:18 PM
thj updated the diff for D34203: Add support of --no-dereference.

Update correctly

Feb 10 2022, 2:15 PM
thj updated the diff for D34203: Add support of --no-dereference.

fix a return issue and add tests

Feb 10 2022, 2:13 PM