In D14567#383658, @oshogbo wrote:

@cem, @kib, @emaste, @jilles I would like to commit it as-it-is but pjd suggested to change the name to funlinkat? After some thoughts I also think that funlinkat is a bether name 'fd' suggests that it's working on 'FILE *'. Do you agree?

In D17932#383618, @brooks wrote:

In D17932#383019, @kib wrote:

Does it mean that if we have both foo and freebsd32_foo, then we cannot selectively enable only one of them for cap mode ?

Yes. I can't imagine a situation where we'd want to do that.

In D17932#383198, @emaste wrote:

In D17932#383019, @kib wrote:

Does it mean that if we have both foo and freebsd32_foo, then we cannot selectively enable only one of them for cap mode ?

I think that's probably fine, although maybe we should generate a warning or error if both exist?

In D17932#383019, @kib wrote:

Does it mean that if we have both foo and freebsd32_foo, then we cannot selectively enable only one of them for cap mode ?

Note, with rS340294 already applied make sysent makes no changes after this change.

Committed in rD52475. Accidentally failed to include link in commit message.

In D17714#382524, @kib wrote:

In D17714#382522, @brooks wrote:

In D17714#382267, @kib wrote:

Fabricate the 'topping directory' term instead of 'starting directory'.

I'd tend to call it a 'root directory' since that's what we call the base of a sub-tree in other contexts.

Cannot agree, root directory already has the defined meaning ('/').

In D17714#382267, @kib wrote:

Fabricate the 'topping directory' term instead of 'starting directory'.

• Add ${_+_} for submake calls to do the right thing with -n and -N.

• Remove !make(sysent) conditional not required on FreeBSD.

LGTM

Commit message should mention the switch to size_t.

If keeping it as is is the consensus, that's fine by me.

Looks good to me, but I'll give Bryan a change to opine.

In D17812#380637, @kib wrote:

Are you going to reformat compat32/syscalls.master ?

With the nandfs fix this passes universe. I've done a search for vop_symlink on https://grok.dragonflybsd.org and concluded that an exp-run isn't going to find anything so I'll skip that.

• Rebase

• Rebase
• Bump __FreeBSD_version for external API consumers.

• Add missed __DECONST in nandfs.

Module @emaste's comments on comments, I think this is ready to go.

• Update the VOP_SYMLINK signature in the manpage.

• Add compat32.

In D17784#380088, @emaste wrote:

I think this change is good.
__mode_t is uint16_t, this is OK on all of our architectures?

What ever overflow I thought I saw doesn't appear to exist when I read the code now. len is always <= dst_size so the memset is safe.

I'd mention the de-register part of the change in the commit message as well as the warns fixes.

In D17702#378608, @dim wrote:

In D17702#378563, @brooks wrote:

LGTM. It would be ideal to roll in the following patches I've had in my tree to avoid an extra revision bump (probably need to be hand applied due to copy/paste damage):

...

+USES+= gnome

Huh, does it use gnome, really? Is that specifically for a clang-format or scan-view feature?

LGTM

LGTM. It would be ideal to roll in the following patches I've had in my tree to avoid an extra revision bump (probably need to be hand applied due to copy/paste damage):