In D15816#334486, @kib wrote:Remove SYSPROTO for them all, instead of patching ? It is not useful for current syscalls, and obviously even less so for compat.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Jun 18 2018
Jun 18 2018
- s/kptr_t/kvaddr_t/
In D15386#335779, @rwatson wrote:In D15386#335530, @brooks wrote:
- Use new ksize_t and kptr_t instead of (u)int64_t.
- Adjust some padding.
Hmm. This is the problem with thinking overnight on things. Do you think it should be kvaddr_t rather than kptr_t?
Jun 17 2018
Jun 17 2018
- Use new ksize_t and kptr_t instead of (u)int64_t.
- Adjust some padding.
I think I've addressed @jhb's feedback now.
- Remove/cleanup casts.
- Spelling.
- Remove code subsumed by exec_args_adjust_args. (needs further testing)
Jun 15 2018
Jun 15 2018
LGTM. Doing the deprecation notice in the manpage seems like a good idea, but won't effect this review.
I just discover that libc exported these syscalls. Technically this change is an impermissible ABI break, but there isn't any valid way to the the published API to link to those symbols so I think that's ok. If it's not, I can add trivial stubs for netbsd_lchown() and netbsd_msync() that just call the respective __sys_*.
- Don't export *netbsd_* symbols.
- Use AUE_NULL for removed netbsd syscalls.
Jun 14 2018
Jun 14 2018
- Fix typo.
- Update UPDATING date and __FreeBSD_version
Regen after 335177 (rename sys_obreak to sys_break).
Name the implementation of brk and sbrk sys_break().
- GC a pointless printf.
Jun 12 2018
Jun 12 2018
brooks added a comment to rS335020: Fix number of auxargs entries to copy out for 32-bit Linuxulator..
Thanks for the fix!
Jun 10 2018
Jun 10 2018
In D15714#332308, @kib wrote:In D15714#332286, @brooks wrote:This looks fine for FreeBSD.
The current implementation will break CheriBSD, but it's easy enough to fix on our end.
What do you plan to do to fix it ? I tried to provide some way to not loose the optimization of doing the word swaps, but cannot imagine how to do it without introducing MD primitive.
But for the cheri fix it should be something sufficiently close to that ?
Jun 9 2018
Jun 9 2018
In D15714#332308, @kib wrote:In D15714#332286, @brooks wrote:This looks fine for FreeBSD.
The current implementation will break CheriBSD, but it's easy enough to fix on our end.
What do you plan to do to fix it ? I tried to provide some way to not loose the optimization of doing the word swaps, but cannot imagine how to do it without introducing MD primitive.
But for the cheri fix it should be something sufficiently close to that ?
This looks fine for FreeBSD.
Jun 8 2018
Jun 8 2018
- Rebase on top of new return.
Jun 5 2018
Jun 5 2018
Jun 1 2018
Jun 1 2018
Remove support for SYS_sys_exit in favor of SYS_exit.
- Don't export unused __sys_exit symbol.
- Update compat/freebsd32/capabilities.conf.
- Update capabilities.conf.
- Use sys_break in linux compat.
- Handle freebsd32 and ibcs.
May 31 2018
May 31 2018
In D15637#330341, @kib wrote:The syscall is _exit or _Exit, not exit.
I'm starting a sweep through syscalls.master and attempting to reduce the use of alternative function and argument names as well as return types. My hope is to eliminate the need for them, but I'm working on it as a background task so doing them one at a time.
May 30 2018
May 30 2018
Remove alternative names that are identical to the default.
- Remove a nonsensical assert.
Anyone on transport care about this?
- Fix typo.
- Rebase
- Update proposed commit date and __FreeBSD_version bump.
Exp-run completed without new errors (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228301).
- Allow begin_envv to be NULL and support prepending argv entries.
May 29 2018
May 29 2018
Correct pointer subtraction in KASSERT().
It looks to me like both of these assert()s are correct.
Correct pointer subtraction in KASSERT().
May 25 2018
May 25 2018
Support -DNO_CLEAN builds across r334223+r334224.
Regen after r334223: make vadvise compat freebsd11.
Make vadvise compat freebsd11.
May 24 2018
May 24 2018
- Nothing uses _vadvise() or __sys_vadvise so don't provide them.
- Don't document ignored struct freebsd11_vadvise_args.
Indicate the brk/sbrk are deprecated and not portable.
- Use "Fx 11.0" rather than "Fx 11"
In D15557#328428, @emaste wrote:Add a dependency cleanup in Makefile.inc1 after commit also?
- Actually name copyright holder.
- Remove generated files from review.
brooks added a reviewer for D15468: Add helper functions to copy strings into struct image_args.: kib.
- mmap(2) not mmap(3).
exect() was removed in 2018, not 2017.
Don't implement break(2) at all on aarch64 and riscv.
Avoid two suword() calls per auxarg entry.
May 23 2018
May 23 2018
- Explictitly refer to mmap.
- Refer to mmap in the right section.
In D15535#328082, @emaste wrote:Are there any architecture-specific reasons for removal?
Just a lack of backwards compatibility requirements (i.e., there are no existing FreeBSD binaries which make use of sbrk).
In D15535#328078, @saper_saper.info wrote:I have one question. From what I see in the code for brk() and sbrk() got removed from the C library, but the system call sys_obreak still exists, correct?
Thanks for the review @saper_saper.info
- Fix typo.
- Allocate argarray with malloc() and zero to prevent leak.
- Use argc + 1 + envc + 1 idiom one more place
brooks added a reviewer for D15535: Indicate the brk/sbrk are deprecated and not portable.: manpages.
- Fix build on i386.
May 22 2018
May 22 2018
Trivial testing done with amd64, freebsd32 on amd64, and linux64 on amd64.
- Cleanups suggested by kib.
- Break out the increment of pos.
- Extend to cover linux compat and eliminate AUXARGS_ENTRY_32.
May 21 2018
May 21 2018
- Return error on copyout/suword failure in freebsd_fixup.
May 18 2018
May 18 2018
brooks added reviewers for D15485: Avoid two suword() calls per auxarg entry.: jhb, emaste, kib, imp.
This patch compiles (if you don't build linux emulation), but is incomplete. I've tested a variant on CheriBSD. In this review I'm looking for feedback on the approach before altering AUXARGS_ENTRY_32 and handling linux emulation. This is certainly more efficient and might be measurably so on i386 with 4/4.
May 17 2018
May 17 2018
brooks added reviewers for D15468: Add helper functions to copy strings into struct image_args.: imp, emaste, jhb.
I've tested this on CheriBSD (mips64), amd64, and with i386 binaries on amd64 so it should be ready to go.
Use strsep() to parse init_path in start_init().