Page MenuHomeFreeBSD
Feed Advanced Search

Jun 18 2018

brooks updated the summary of D15816: Normalize COMPAT_43 syscall declarations..
Jun 18 2018, 4:54 PM
brooks added a comment to D15816: Normalize COMPAT_43 syscall declarations..
In D15816#334486, @kib wrote:

Remove SYSPROTO for them all, instead of patching ? It is not useful for current syscalls, and obviously even less so for compat.

Jun 18 2018, 4:52 PM
brooks updated the diff for D15386: Improve portability of structs xinpcb and friends..
  • s/kptr_t/kvaddr_t/
Jun 18 2018, 3:18 PM
brooks added a comment to D15386: Improve portability of structs xinpcb and friends..
  • Use new ksize_t and kptr_t instead of (u)int64_t.
  • Adjust some padding.

Hmm. This is the problem with thinking overnight on things. Do you think it should be kvaddr_t rather than kptr_t?

Jun 18 2018, 3:14 PM

Jun 17 2018

brooks updated the diff for D15386: Improve portability of structs xinpcb and friends..
  • Use new ksize_t and kptr_t instead of (u)int64_t.
  • Adjust some padding.
Jun 17 2018, 6:58 PM
brooks added a comment to D15468: Add helper functions to copy strings into struct image_args..

I think I've addressed @jhb's feedback now.

Jun 17 2018, 5:59 PM
brooks updated the diff for D15468: Add helper functions to copy strings into struct image_args..
  • Remove/cleanup casts.
  • Spelling.
  • Remove code subsumed by exec_args_adjust_args. (needs further testing)
Jun 17 2018, 4:31 PM

Jun 15 2018

brooks accepted D15827: Remove obsolete asf(8).

LGTM. Doing the deprecation notice in the manpage seems like a good idea, but won't effect this review.

Jun 15 2018, 5:26 PM
brooks added a comment to D15814: Get rid of netbsd_lchown and netbsd_msync syscall entries..

I just discover that libc exported these syscalls. Technically this change is an impermissible ABI break, but there isn't any valid way to the the published API to link to those symbols so I think that's ok. If it's not, I can add trivial stubs for netbsd_lchown() and netbsd_msync() that just call the respective __sys_*.

Jun 15 2018, 12:19 AM
brooks updated the diff for D15814: Get rid of netbsd_lchown and netbsd_msync syscall entries..
  • Don't export *netbsd_* symbols.
  • Use AUE_NULL for removed netbsd syscalls.
Jun 15 2018, 12:18 AM
brooks created D15816: Normalize COMPAT_43 syscall declarations..
Jun 15 2018, 12:11 AM

Jun 14 2018

brooks created D15814: Get rid of netbsd_lchown and netbsd_msync syscall entries..
Jun 14 2018, 10:49 PM
brooks updated the summary of D15637: Regularize the declaration of the exit syscall..
Jun 14 2018, 9:35 PM
brooks updated the diff for D15386: Improve portability of structs xinpcb and friends..
  • Fix typo.
  • Update UPDATING date and __FreeBSD_version
Jun 14 2018, 9:32 PM
brooks committed rS335178: Regen after 335177 (rename sys_obreak to sys_break)..
Regen after 335177 (rename sys_obreak to sys_break).
Jun 14 2018, 9:29 PM
brooks committed rS335177: Name the implementation of brk and sbrk sys_break()..
Name the implementation of brk and sbrk sys_break().
Jun 14 2018, 9:27 PM
brooks closed D15638: Name the implementation of brk and sbrk sys_break()..
Jun 14 2018, 9:27 PM
brooks updated the summary of D15638: Name the implementation of brk and sbrk sys_break()..
Jun 14 2018, 8:56 PM
brooks updated the summary of D15468: Add helper functions to copy strings into struct image_args..
Jun 14 2018, 8:45 PM
brooks updated the diff for D15638: Name the implementation of brk and sbrk sys_break()..
  • GC a pointless printf.
Jun 14 2018, 8:38 PM

Jun 12 2018

brooks added a comment to rS335020: Fix number of auxargs entries to copy out for 32-bit Linuxulator..

Thanks for the fix!

Jun 12 2018, 11:51 PM

Jun 10 2018

brooks added a comment to D15714: libc qsort: stop aliasing.
In D15714#332308, @kib wrote:

This looks fine for FreeBSD.

The current implementation will break CheriBSD, but it's easy enough to fix on our end.

What do you plan to do to fix it ? I tried to provide some way to not loose the optimization of doing the word swaps, but cannot imagine how to do it without introducing MD primitive.
But for the cheri fix it should be something sufficiently close to that ?

Jun 10 2018, 2:43 PM

Jun 9 2018

brooks added a comment to D15714: libc qsort: stop aliasing.
In D15714#332308, @kib wrote:

This looks fine for FreeBSD.

The current implementation will break CheriBSD, but it's easy enough to fix on our end.

What do you plan to do to fix it ? I tried to provide some way to not loose the optimization of doing the word swaps, but cannot imagine how to do it without introducing MD primitive.
But for the cheri fix it should be something sufficiently close to that ?

Jun 9 2018, 6:58 PM
brooks accepted D15714: libc qsort: stop aliasing.
Jun 9 2018, 5:54 PM
brooks added a comment to D15714: libc qsort: stop aliasing.

This looks fine for FreeBSD.

Jun 9 2018, 5:54 PM

Jun 8 2018

brooks updated the diff for D15638: Name the implementation of brk and sbrk sys_break()..
  • Rebase on top of new return.
Jun 8 2018, 1:45 PM

Jun 5 2018

brooks accepted D15665: Fix missing files in METALOG with -DNO_ROOT.

LGTM

Jun 5 2018, 2:14 PM

Jun 1 2018

brooks committed rS334500: Remove support for SYS_sys_exit in favor of SYS_exit..
Remove support for SYS_sys_exit in favor of SYS_exit.
Jun 1 2018, 10:09 PM
brooks updated the diff for D15637: Regularize the declaration of the exit syscall..
  • Don't export unused __sys_exit symbol.
  • Update compat/freebsd32/capabilities.conf.
Jun 1 2018, 5:11 PM
brooks updated the diff for D15638: Name the implementation of brk and sbrk sys_break()..
  • Update capabilities.conf.
  • Use sys_break in linux compat.
  • Handle freebsd32 and ibcs.
Jun 1 2018, 5:04 PM

May 31 2018

brooks created D15638: Name the implementation of brk and sbrk sys_break()..
May 31 2018, 11:28 PM
brooks added a comment to D15637: Regularize the declaration of the exit syscall..

This effectively reverts rS63986 and rS64001 which were obsoleted by rS225617.

May 31 2018, 10:59 PM
brooks updated the summary of D15637: Regularize the declaration of the exit syscall..
May 31 2018, 10:51 PM
brooks added a comment to D15637: Regularize the declaration of the exit syscall..
In D15637#330341, @kib wrote:

The syscall is _exit or _Exit, not exit.

May 31 2018, 9:34 PM
brooks added a reviewer for D15637: Regularize the declaration of the exit syscall.: imp.
May 31 2018, 6:46 PM
brooks added a comment to D15637: Regularize the declaration of the exit syscall..

I'm starting a sweep through syscalls.master and attempting to reduce the use of alternative function and argument names as well as return types. My hope is to eliminate the need for them, but I'm working on it as a background task so doing them one at a time.

May 31 2018, 6:45 PM
brooks created D15637: Regularize the declaration of the exit syscall..
May 31 2018, 6:41 PM
brooks committed rS334440: MFC r292268, r334176.
MFC r292268, r334176
May 31 2018, 4:11 PM
brooks committed rS334439: MFC r334176:.
MFC r334176:
May 31 2018, 4:01 PM

May 30 2018

brooks committed rS334405: Remove alternative names that are identical to the default..
Remove alternative names that are identical to the default.
May 30 2018, 10:23 PM
brooks updated the summary of D15468: Add helper functions to copy strings into struct image_args..
May 30 2018, 9:45 PM
brooks updated the diff for D15468: Add helper functions to copy strings into struct image_args..
  • Remove a nonsensical assert.
May 30 2018, 9:40 PM
brooks added a comment to D15386: Improve portability of structs xinpcb and friends..

Anyone on transport care about this?

May 30 2018, 9:02 PM
brooks updated the diff for D15386: Improve portability of structs xinpcb and friends..
  • Fix typo.
May 30 2018, 8:52 PM
brooks updated the diff for D15386: Improve portability of structs xinpcb and friends..
  • Rebase
  • Update proposed commit date and __FreeBSD_version bump.
May 30 2018, 8:52 PM
brooks updated the summary of D15386: Improve portability of structs xinpcb and friends..
May 30 2018, 8:46 PM
brooks added a comment to D15386: Improve portability of structs xinpcb and friends..

Exp-run completed without new errors (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228301).

May 30 2018, 8:45 PM
brooks updated the diff for D15468: Add helper functions to copy strings into struct image_args..
  • Allow begin_envv to be NULL and support prepending argv entries.
May 30 2018, 8:12 PM
brooks added inline comments to D15595: Update pmclog(3) and cap_rights_get(3) EXAMPLE section..
May 30 2018, 3:53 PM
brooks added inline comments to D15595: Update pmclog(3) and cap_rights_get(3) EXAMPLE section..
May 30 2018, 3:07 PM

May 29 2018

brooks committed rS334348: Correct pointer subtraction in KASSERT()..
Correct pointer subtraction in KASSERT().
May 29 2018, 8:03 PM
brooks added a comment to D15595: Update pmclog(3) and cap_rights_get(3) EXAMPLE section..

It looks to me like both of these assert()s are correct.

May 29 2018, 6:13 PM
brooks added inline comments to D15594: Update strsetp(3) EXAMPLE section..
May 29 2018, 6:02 PM
brooks committed rS334342: Correct pointer subtraction in KASSERT()..
Correct pointer subtraction in KASSERT().
May 29 2018, 5:49 PM

May 25 2018

brooks committed rS334225: Support -DNO_CLEAN builds across r334223+r334224..
Support -DNO_CLEAN builds across r334223+r334224.
May 25 2018, 8:42 PM
brooks committed rS334224: Regen after r334223: make vadvise compat freebsd11..
Regen after r334223: make vadvise compat freebsd11.
May 25 2018, 8:41 PM
brooks committed rS334223: Make vadvise compat freebsd11..
Make vadvise compat freebsd11.
May 25 2018, 8:40 PM
brooks closed D15557: Make vadvise compat freebsd11..
May 25 2018, 8:40 PM

May 24 2018

brooks updated the diff for D15557: Make vadvise compat freebsd11..
  • Nothing uses _vadvise() or __sys_vadvise so don't provide them.
  • Don't document ignored struct freebsd11_vadvise_args.
May 24 2018, 6:35 PM
brooks committed rS334176: Indicate the brk/sbrk are deprecated and not portable..
Indicate the brk/sbrk are deprecated and not portable.
May 24 2018, 6:33 PM
brooks closed D15535: Indicate the brk/sbrk are deprecated and not portable..
May 24 2018, 6:33 PM
brooks added inline comments to D15535: Indicate the brk/sbrk are deprecated and not portable..
May 24 2018, 6:20 PM
brooks updated the diff for D15535: Indicate the brk/sbrk are deprecated and not portable..
  • Use "Fx 11.0" rather than "Fx 11"
May 24 2018, 6:20 PM
brooks added a comment to D15557: Make vadvise compat freebsd11..

Add a dependency cleanup in Makefile.inc1 after commit also?

May 24 2018, 6:11 PM
brooks updated the diff for D15557: Make vadvise compat freebsd11..
  • Actually name copyright holder.
May 24 2018, 6:10 PM
brooks updated the diff for D15557: Make vadvise compat freebsd11..
  • Remove generated files from review.
May 24 2018, 5:52 PM
brooks added a reviewer for D15468: Add helper functions to copy strings into struct image_args.: kib.
May 24 2018, 5:22 PM
brooks updated the diff for D15535: Indicate the brk/sbrk are deprecated and not portable..
  • mmap(2) not mmap(3).
May 24 2018, 5:21 PM
brooks created D15557: Make vadvise compat freebsd11..
May 24 2018, 5:16 PM
brooks committed rS334169: exect() was removed in 2018, not 2017..
exect() was removed in 2018, not 2017.
May 24 2018, 5:06 PM
brooks committed rS334168: Don't implement break(2) at all on aarch64 and riscv..
Don't implement break(2) at all on aarch64 and riscv.
May 24 2018, 5:04 PM
brooks closed D15539: Don't implement break(2) at all on aarch64 and riscv..
May 24 2018, 5:04 PM
brooks committed rS334165: Avoid two suword() calls per auxarg entry..
Avoid two suword() calls per auxarg entry.
May 24 2018, 4:25 PM
brooks closed D15485: Avoid two suword() calls per auxarg entry..
May 24 2018, 4:25 PM
brooks updated the summary of D15485: Avoid two suword() calls per auxarg entry..
May 24 2018, 4:23 PM
brooks committed rP470789: Update to a new snapshot..
Update to a new snapshot.
May 24 2018, 4:04 PM
brooks updated the summary of D15485: Avoid two suword() calls per auxarg entry..
May 24 2018, 4:00 PM

May 23 2018

brooks added inline comments to D15535: Indicate the brk/sbrk are deprecated and not portable..
May 23 2018, 9:57 PM
brooks updated the diff for D15535: Indicate the brk/sbrk are deprecated and not portable..
  • Explictitly refer to mmap.
  • Refer to mmap in the right section.
May 23 2018, 9:15 PM
brooks created D15539: Don't implement break(2) at all on aarch64 and riscv..
May 23 2018, 9:04 PM
brooks added a comment to D15535: Indicate the brk/sbrk are deprecated and not portable..

Are there any architecture-specific reasons for removal?

Just a lack of backwards compatibility requirements (i.e., there are no existing FreeBSD binaries which make use of sbrk).

May 23 2018, 8:49 PM
brooks added a comment to D15535: Indicate the brk/sbrk are deprecated and not portable..

I have one question. From what I see in the code for brk() and sbrk() got removed from the C library, but the system call sys_obreak still exists, correct?

May 23 2018, 8:46 PM
brooks added a comment to D15535: Indicate the brk/sbrk are deprecated and not portable..

Thanks for the review @saper_saper.info

May 23 2018, 8:28 PM
brooks updated the diff for D15535: Indicate the brk/sbrk are deprecated and not portable..
  • Fix typo.
May 23 2018, 8:27 PM
brooks updated the diff for D15485: Avoid two suword() calls per auxarg entry..
  • Allocate argarray with malloc() and zero to prevent leak.
  • Use argc + 1 + envc + 1 idiom one more place
May 23 2018, 6:23 PM
brooks added inline comments to D15485: Avoid two suword() calls per auxarg entry..
May 23 2018, 6:13 PM
brooks added a reviewer for D15535: Indicate the brk/sbrk are deprecated and not portable.: manpages.
May 23 2018, 3:56 PM
brooks created D15535: Indicate the brk/sbrk are deprecated and not portable..
May 23 2018, 3:55 PM
brooks updated the diff for D15485: Avoid two suword() calls per auxarg entry..
  • Fix build on i386.
May 23 2018, 12:08 AM

May 22 2018

brooks added a comment to D15485: Avoid two suword() calls per auxarg entry..

Trivial testing done with amd64, freebsd32 on amd64, and linux64 on amd64.

May 22 2018, 10:20 PM
brooks updated the summary of D15485: Avoid two suword() calls per auxarg entry..
May 22 2018, 8:41 PM
brooks updated the diff for D15485: Avoid two suword() calls per auxarg entry..
  • Cleanups suggested by kib.
  • Break out the increment of pos.
  • Extend to cover linux compat and eliminate AUXARGS_ENTRY_32.
May 22 2018, 8:40 PM

May 21 2018

brooks updated the diff for D15485: Avoid two suword() calls per auxarg entry..
  • Return error on copyout/suword failure in freebsd_fixup.
May 21 2018, 8:50 PM
brooks added inline comments to D15485: Avoid two suword() calls per auxarg entry..
May 21 2018, 4:10 PM

May 18 2018

brooks added reviewers for D15485: Avoid two suword() calls per auxarg entry.: jhb, emaste, kib, imp.

This patch compiles (if you don't build linux emulation), but is incomplete. I've tested a variant on CheriBSD. In this review I'm looking for feedback on the approach before altering AUXARGS_ENTRY_32 and handling linux emulation. This is certainly more efficient and might be measurably so on i386 with 4/4.

May 18 2018, 9:16 PM
brooks created D15485: Avoid two suword() calls per auxarg entry..
May 18 2018, 9:12 PM
brooks created D15469: Remove a needlessly clever hack to start init with sys_exec()..
May 18 2018, 12:09 AM

May 17 2018

brooks added reviewers for D15468: Add helper functions to copy strings into struct image_args.: imp, emaste, jhb.

I've tested this on CheriBSD (mips64), amd64, and with i386 binaries on amd64 so it should be ready to go.

May 17 2018, 11:09 PM
brooks closed D15467: Use strsep() to parse init_path in start_init()..
May 17 2018, 11:08 PM
brooks committed rS333773: Use strsep() to parse init_path in start_init()..
Use strsep() to parse init_path in start_init().
May 17 2018, 11:08 PM