Page MenuHomeFreeBSD
Feed Advanced Search

Wed, Aug 26

anascime_amd.com added a comment to D58647: hwpmc: add MPERF/APERF MSR support for AMD/Intel CPUs.

Hello all,

Wed, Aug 26, 6:48 PM

Mon, Aug 17

anascime_amd.com added inline comments to D58647: hwpmc: add MPERF/APERF MSR support for AMD/Intel CPUs.
Mon, Aug 17, 5:41 PM
anascime_amd.com updated the diff for D58647: hwpmc: add MPERF/APERF MSR support for AMD/Intel CPUs.

I've addressed all comments

Mon, Aug 17, 5:37 PM

Sat, Aug 15

anascime_amd.com added inline comments to D58647: hwpmc: add MPERF/APERF MSR support for AMD/Intel CPUs.
Sat, Aug 15, 4:58 PM
anascime_amd.com updated the diff for D58647: hwpmc: add MPERF/APERF MSR support for AMD/Intel CPUs.

.

Sat, Aug 15, 4:53 PM

Tue, Aug 11

anascime_amd.com added a comment to D58647: hwpmc: add MPERF/APERF MSR support for AMD/Intel CPUs.

@ali_mashtizadeh.com @mhorne @kib Could you please review it again? Thanks!

Tue, Aug 11, 9:19 PM

Mon, Aug 10

anascime_amd.com updated the diff for D58647: hwpmc: add MPERF/APERF MSR support for AMD/Intel CPUs.

Add missing hwpmc_perf.c and hwpmc_perf.h

Mon, Aug 10, 6:17 PM
anascime_amd.com retitled D58647: hwpmc: add MPERF/APERF MSR support for AMD/Intel CPUs from hwpmc: add APERF/MPERF MSR support for AMD CPUs to hwpmc: add MPERF/APERF MSR support for AMD/Intel CPUs.
Mon, Aug 10, 6:08 PM
anascime_amd.com updated the diff for D58647: hwpmc: add MPERF/APERF MSR support for AMD/Intel CPUs.

Address reviewer comments: add Intel support, fix manpage, fix RDPMC

Mon, Aug 10, 6:08 PM

Aug 5 2026

anascime_amd.com added inline comments to D58647: hwpmc: add MPERF/APERF MSR support for AMD/Intel CPUs.
Aug 5 2026, 6:36 PM

Aug 4 2026

anascime_amd.com added a comment to D58649: libpmc: Add pmc.perf.3 manpage.

Siloing off docs is a classic mistake that results in poor docs. I would greatly prefer if you abandoned this revision and put them back together. Thank you for your consideration.

Aug 4 2026, 9:27 PM
anascime_amd.com added a comment to D58647: hwpmc: add MPERF/APERF MSR support for AMD/Intel CPUs.

Resubmit as patch 1/3: hwpmc driver changes only

Who told you to do this? It's very nice for the one logical change to be one complete atomic change. It's harder to reference everything on different pages, harder to bisect on split commits, and harder to follow review conversation.

Aug 4 2026, 9:24 PM
anascime_amd.com edited reviewers for D58647: hwpmc: add MPERF/APERF MSR support for AMD/Intel CPUs, added: pmc, afscoelho_gmail.com; removed: gnn.
Aug 4 2026, 9:21 PM
anascime_amd.com abandoned D58649: libpmc: Add pmc.perf.3 manpage.
Aug 4 2026, 9:18 PM
anascime_amd.com abandoned D58648: libpmc: add APERF/MPERF support for AMD CPUs.
Aug 4 2026, 9:18 PM
anascime_amd.com updated the summary of D58647: hwpmc: add MPERF/APERF MSR support for AMD/Intel CPUs.
Aug 4 2026, 9:18 PM
anascime_amd.com updated the diff for D58647: hwpmc: add MPERF/APERF MSR support for AMD/Intel CPUs.

Update: consolidate all changes into a single revision

Aug 4 2026, 9:17 PM
anascime_amd.com updated the summary of D58647: hwpmc: add MPERF/APERF MSR support for AMD/Intel CPUs.
Aug 4 2026, 7:10 PM
anascime_amd.com added a comment to D58649: libpmc: Add pmc.perf.3 manpage.

Why did you spin this off into it's own revision? I left feedback on your previous review, which was the appropriate place for it, and none of it is addressed here.

Aug 4 2026, 7:08 PM
anascime_amd.com requested review of D58649: libpmc: Add pmc.perf.3 manpage.
Aug 4 2026, 6:39 PM
anascime_amd.com requested review of D58648: libpmc: add APERF/MPERF support for AMD CPUs.
Aug 4 2026, 6:39 PM
anascime_amd.com updated the diff for D58647: hwpmc: add MPERF/APERF MSR support for AMD/Intel CPUs.

Resubmit as patch 1/3: hwpmc driver changes only

Aug 4 2026, 6:39 PM
anascime_amd.com requested review of D58647: hwpmc: add MPERF/APERF MSR support for AMD/Intel CPUs.
Aug 4 2026, 5:53 PM