Page MenuHomeFreeBSD
Feed Advanced Search

Oct 12 2024

zlei committed rGc7a2636889a6: axgbe: Fix setting promisc mode (authored by zlei).
axgbe: Fix setting promisc mode
Oct 12 2024, 1:59 PM
zlei closed D46794: axgbe: Fix setting promisc mode.
Oct 12 2024, 1:59 PM
zlei committed rGeacad82f3ad0: if_enc(4): Use new KPI to create enc interface (authored by zlei).
if_enc(4): Use new KPI to create enc interface
Oct 12 2024, 1:39 PM
zlei closed D45758: if_enc(4): Use new KPI to create enc interface.
Oct 12 2024, 1:39 PM

Oct 11 2024

zlei added a comment to D46836: sound: Shorten channel names.

@christos You tagged me to review, but I do not have strong opinion for this change, really :)

Oct 11 2024, 9:14 AM

Oct 10 2024

zlei added a comment to D47027: jail: Avoid dereferencing a potentially null pointer in kern_jail_get().

Shouldn't we simply omit outputting ip4.addr (resp., ipv6.addr) if pr->pr_addrs[PR_INET] (resp., pr->pr_addrs[PR_INET6]), is NULL?

vfs_setopt_part() has the side effect of setting the key length to 0, even though there's nothing to copy. I presume that we want to preserve that behaviour.

Oct 10 2024, 3:19 PM
zlei added inline comments to D46975: release: move OCI to ORACLE.
Oct 10 2024, 3:14 PM
zlei committed rG66ce3c8460bb: ifnet: Remove if_getamcount() (authored by markj).
ifnet: Remove if_getamcount()
Oct 10 2024, 10:04 AM
zlei committed rG3e46d65d5619: netstat: increase width of Netif column (authored by lexi_le-fay.org).
netstat: increase width of Netif column
Oct 10 2024, 10:04 AM
zlei committed rGea980c17f48e: if_clone: correctly destroy a clone from a different vnet (authored by glebius).
if_clone: correctly destroy a clone from a different vnet
Oct 10 2024, 10:04 AM
zlei committed rG5a894ac4311e: if_vmove: improve restoration in cloner's ifgroup membership (authored by glebius).
if_vmove: improve restoration in cloner's ifgroup membership
Oct 10 2024, 10:04 AM
zlei committed rG7afcdd13a49c: ifnet: allocate index at the end of if_alloc_domain() (authored by glebius).
ifnet: allocate index at the end of if_alloc_domain()
Oct 10 2024, 10:04 AM

Oct 9 2024

zlei committed rG86c8cbe788db: if_epair: Remove unneeded NULL check for the allocated ifnet (authored by zlei).
if_epair: Remove unneeded NULL check for the allocated ifnet
Oct 9 2024, 4:03 AM

Oct 8 2024

zlei committed rGa31a4ddd39bb: if_enc(4): Make enc_add_hhooks() void (authored by zlei).
if_enc(4): Make enc_add_hhooks() void
Oct 8 2024, 10:09 AM
zlei committed rGd92fc5d447ae: khelp: Sprinkle const qualifiers where appropriate (authored by zlei).
khelp: Sprinkle const qualifiers where appropriate
Oct 8 2024, 10:09 AM
zlei committed rG36fe8266ef09: hhook: Sprinkle const qualifiers where appropriate (authored by zlei).
hhook: Sprinkle const qualifiers where appropriate
Oct 8 2024, 10:09 AM
zlei committed rGf500e5c6c99b: net: Remove unneeded NULL check for the allocated ifnet (authored by zlei).
net: Remove unneeded NULL check for the allocated ifnet
Oct 8 2024, 10:09 AM
zlei committed rGd6374ee0517f: if_enc(4): Make enc_add_hhooks() void (authored by zlei).
if_enc(4): Make enc_add_hhooks() void
Oct 8 2024, 4:46 AM
zlei committed rG54c79d3ae419: khelp: Sprinkle const qualifiers where appropriate (authored by zlei).
khelp: Sprinkle const qualifiers where appropriate
Oct 8 2024, 4:46 AM
zlei committed rG18aa2a81c465: hhook: Sprinkle const qualifiers where appropriate (authored by zlei).
hhook: Sprinkle const qualifiers where appropriate
Oct 8 2024, 4:46 AM
zlei committed rG6b86b8f0f6b6: netstat: increase width of Netif column (authored by lexi_le-fay.org).
netstat: increase width of Netif column
Oct 8 2024, 4:04 AM
zlei committed rG381601cfcb56: ifnet: make if_alloc_domain() never fail (authored by glebius).
ifnet: make if_alloc_domain() never fail
Oct 8 2024, 4:02 AM

Oct 7 2024

zlei requested review of D46982: ifnet: Assert that we are assigning network stack correctly.
Oct 7 2024, 3:44 PM
zlei updated the diff for D45758: if_enc(4): Use new KPI to create enc interface.

Rebased to latest main.

Oct 7 2024, 2:34 PM
zlei added a reverting change for rG09f6ff4f1a47: iflib(9): Add support for cloning pseudo interfaces: rG816100089283: iflib: Make iflib_stop() static.
Oct 7 2024, 2:20 PM
zlei closed D46185: iflib: Make iflib_stop() static.
Oct 7 2024, 2:20 PM
zlei committed rG816100089283: iflib: Make iflib_stop() static (authored by zlei).
iflib: Make iflib_stop() static
Oct 7 2024, 2:20 PM

Oct 4 2024

zlei added a comment to D46871: sys: add conf/std.debug, generic debugging options.

I always have a GENERIC-DEBUG for stable branches, the content is similar. +1 for this.

Oct 4 2024, 10:00 AM

Oct 3 2024

zlei accepted D46857: sound: Improve /dev/sndstat channel info readability.

No objection from me, since those are verbose message that is mostly useful for debugging.

Oct 3 2024, 2:45 PM

Oct 1 2024

zlei added a comment to D46857: sound: Improve /dev/sndstat channel info readability.

I'd recommend to add test plan to do a quick demonstration for the good effect of this change. Then it will help reviewing.

Oct 1 2024, 5:33 PM
zlei added inline comments to D46186: iflib: Add iflib managed counters support.
Oct 1 2024, 4:29 PM
zlei committed rG7643141e9314: if_enc(4): Make enc_add_hhooks() void (authored by zlei).
if_enc(4): Make enc_add_hhooks() void
Oct 1 2024, 3:31 PM
zlei committed rG89937323bddd: khelp: Sprinkle const qualifiers where appropriate (authored by zlei).
khelp: Sprinkle const qualifiers where appropriate
Oct 1 2024, 3:31 PM
zlei committed rG941f8aceac1b: hhook: Sprinkle const qualifiers where appropriate (authored by zlei).
hhook: Sprinkle const qualifiers where appropriate
Oct 1 2024, 3:31 PM
zlei closed D46770: if_enc(4): Make enc_add_hhooks() never fail.
Oct 1 2024, 3:31 PM
zlei accepted D46749: sound: Move global variable initialization to sound_modevent().
Oct 1 2024, 10:36 AM

Sep 30 2024

zlei added inline comments to D46186: iflib: Add iflib managed counters support.
Sep 30 2024, 4:50 PM
zlei added a comment to D45727: bpf: Detach descriptors on interface departure event.
In D45727#1066919, @ae wrote:

You probably can directly call similar to bpf_ifdetach() function from if_vmove(). It is called from ioctl context, so you can make detaching synchronously.

Sep 30 2024, 4:40 PM
zlei added a comment to D46749: sound: Move global variable initialization to sound_modevent().

I'd probably use the full word global rather than glob, as glob has an existing meaning (even if not related to this context) and it's only two extra letters.

The whitespace fixup should be a separate commit, that can go first.

Sep 30 2024, 2:53 PM
zlei committed rG5d9c2687c3c8: pms(4): Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
pms(4): Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 5:14 AM
zlei committed rG55e34ff3a4bb: axgbe: Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
axgbe: Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 5:14 AM
zlei committed rG1290de0d5400: mxge(4): Stop checking for failures from taskqueue_create(M_WAITOK) (authored by zlei).
mxge(4): Stop checking for failures from taskqueue_create(M_WAITOK)
Sep 30 2024, 5:09 AM
zlei committed rG7000dd2e2912: liquidio(4): Stop checking for failures from… (authored by zlei).
liquidio(4): Stop checking for failures from…
Sep 30 2024, 5:09 AM
zlei committed rG7b7353261e4e: jme(4): Stop checking for failures from taskqueue_create_fast(M_WAITOK) (authored by zlei).
jme(4): Stop checking for failures from taskqueue_create_fast(M_WAITOK)
Sep 30 2024, 5:09 AM
zlei committed rG545f28e021eb: cas(4): Stop checking for failures from taskqueue_create_fast(M_WAITOK) (authored by zlei).
cas(4): Stop checking for failures from taskqueue_create_fast(M_WAITOK)
Sep 30 2024, 5:09 AM
zlei committed rGb620bc6e1dfa: axgbe: Stop checking for failures from taskqueue_create(M_WAITOK) (authored by zlei).
axgbe: Stop checking for failures from taskqueue_create(M_WAITOK)
Sep 30 2024, 5:09 AM
zlei committed rG617dcd17a5c9: bge(4): Stop checking for failures from taskqueue_create_fast(M_WAITOK) (authored by zlei).
bge(4): Stop checking for failures from taskqueue_create_fast(M_WAITOK)
Sep 30 2024, 5:09 AM
zlei committed rG8b872247de88: alc(4): Stop checking for failures from taskqueue_create_fast(M_WAITOK) (authored by zlei).
alc(4): Stop checking for failures from taskqueue_create_fast(M_WAITOK)
Sep 30 2024, 5:09 AM
zlei committed rG26e17489cd06: ale(4): Stop checking for failures from taskqueue_create_fast(M_WAITOK) (authored by zlei).
ale(4): Stop checking for failures from taskqueue_create_fast(M_WAITOK)
Sep 30 2024, 5:09 AM
zlei committed rG0b1ac58493b1: age(4): Stop checking for failures from taskqueue_create_fast(M_WAITOK) (authored by zlei).
age(4): Stop checking for failures from taskqueue_create_fast(M_WAITOK)
Sep 30 2024, 5:09 AM
zlei committed rG3e90f15df4c0: ae(4): Stop checking for failures from taskqueue_create_fast(M_WAITOK) (authored by zlei).
ae(4): Stop checking for failures from taskqueue_create_fast(M_WAITOK)
Sep 30 2024, 5:09 AM
zlei committed rGc55da1eaf79e: vchiq(4): Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
vchiq(4): Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 5:09 AM
zlei committed rGeded71c830ee: sdhci(4): Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
sdhci(4): Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 5:09 AM
zlei committed rG36fb983d227d: sound: Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
sound: Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 5:09 AM
zlei committed rG68c96d15d3e2: sume(4): Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
sume(4): Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 5:09 AM
zlei committed rG6f7d5f52c19b: mlx(4): Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
mlx(4): Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 5:09 AM
zlei committed rG909623bc1a28: mfi(4): Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
mfi(4): Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 5:09 AM
zlei committed rG20805d47938b: iser(4): Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
iser(4): Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 5:09 AM
zlei committed rG736dfe255d89: hptnr(4): Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
hptnr(4): Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 5:09 AM
zlei committed rG438e078d3166: ice(4): Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
ice(4): Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 5:09 AM
zlei committed rGe86d353a893f: hptrr(4): Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
hptrr(4): Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 5:09 AM
zlei committed rG3df0c68bdb28: hpt27xx(4): Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
hpt27xx(4): Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 5:09 AM
zlei committed rG97cc0b1fa252: fwip(4): Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
fwip(4): Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 5:09 AM
zlei committed rGf5f9d9d4039d: etherswitch: Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
etherswitch: Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 5:09 AM
zlei committed rG568cb5592586: ena(4): Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
ena(4): Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 5:09 AM
zlei committed rG73e399c157a8: drm2: Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
drm2: Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 5:09 AM
zlei committed rGbe61ff389f42: cxgbe(4): Stop checking for failures from malloc/mb_alloc_ext_pgs(M_WAITOK) (authored by zlei).
cxgbe(4): Stop checking for failures from malloc/mb_alloc_ext_pgs(M_WAITOK)
Sep 30 2024, 5:09 AM
zlei committed rG783ec23313de: bnxt(4): Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
bnxt(4): Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 5:09 AM
zlei committed rG09491167a541: cxgb(4): Stop checking for failures from malloc/buf_ring_alloc(M_WAITOK) (authored by zlei).
cxgb(4): Stop checking for failures from malloc/buf_ring_alloc(M_WAITOK)
Sep 30 2024, 5:09 AM
zlei committed rGd0aa34422a53: ath(4): Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
ath(4): Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 5:09 AM
zlei committed rGd40d85672e9d: altera: Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
altera: Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 5:09 AM
zlei committed rG9113fe381f1e: al_eth: Stop checking for failures from malloc/buf_ring_alloc(M_WAITOK) (authored by zlei).
al_eth: Stop checking for failures from malloc/buf_ring_alloc(M_WAITOK)
Sep 30 2024, 5:09 AM
zlei committed rG91b6d79c2f39: smmu: Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
smmu: Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 5:09 AM
zlei committed rG53922b3c2669: arm ti: Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
arm ti: Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 5:09 AM
zlei committed rGa8a127328ea4: tests: Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
tests: Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 5:09 AM
zlei committed rGa7fff4fb4ec6: krping: Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
krping: Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 5:09 AM
zlei committed rG4e98af94a124: xdr: Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
xdr: Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 5:08 AM
zlei committed rGebf9b28b19e2: LinuxKPI: 802.11: Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
LinuxKPI: 802.11: Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 5:08 AM
zlei committed rG019abb5cf986: if_vlan: Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
if_vlan: Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 5:08 AM
zlei committed rGbe02b9a1142e: netsmb: Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
netsmb: Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 5:08 AM
zlei committed rGf7bcf5725fee: altq: Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
altq: Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 5:08 AM
zlei committed rGa4417f586ffc: udf: Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
udf: Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 5:08 AM
zlei committed rG6b42548c6dd7: subr_bus: Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
subr_bus: Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 5:08 AM
zlei committed rG8f17a8c8a2d6: ctl: Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
ctl: Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 5:08 AM
zlei committed rGca22505a15a7: kern_fail: Stop checking for failures from fp_malloc(M_WAITOK) (authored by zlei).
kern_fail: Stop checking for failures from fp_malloc(M_WAITOK)
Sep 30 2024, 5:08 AM
zlei committed rG70280bc71d28: mxge(4): Stop checking for failures from taskqueue_create(M_WAITOK) (authored by zlei).
mxge(4): Stop checking for failures from taskqueue_create(M_WAITOK)
Sep 30 2024, 4:47 AM
zlei committed rG518e138448b4: liquidio(4): Stop checking for failures from… (authored by zlei).
liquidio(4): Stop checking for failures from…
Sep 30 2024, 4:47 AM
zlei committed rG6b25a8f07958: jme(4): Stop checking for failures from taskqueue_create_fast(M_WAITOK) (authored by zlei).
jme(4): Stop checking for failures from taskqueue_create_fast(M_WAITOK)
Sep 30 2024, 4:47 AM
zlei committed rGa1075ea2a314: qat(4): Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
qat(4): Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 4:47 AM
zlei committed rGf6c8db29aad8: dpaa2: Stop checking for failures from malloc/taskqueue_create(M_WAITOK) (authored by zlei).
dpaa2: Stop checking for failures from malloc/taskqueue_create(M_WAITOK)
Sep 30 2024, 4:47 AM
zlei committed rGe78770d62f8a: cas(4): Stop checking for failures from taskqueue_create_fast(M_WAITOK) (authored by zlei).
cas(4): Stop checking for failures from taskqueue_create_fast(M_WAITOK)
Sep 30 2024, 4:47 AM
zlei committed rG39c35f6c5445: axgbe: Stop checking for failures from taskqueue_create(M_WAITOK) (authored by zlei).
axgbe: Stop checking for failures from taskqueue_create(M_WAITOK)
Sep 30 2024, 4:47 AM
zlei committed rG7ae70062241b: ale(4): Stop checking for failures from taskqueue_create_fast(M_WAITOK) (authored by zlei).
ale(4): Stop checking for failures from taskqueue_create_fast(M_WAITOK)
Sep 30 2024, 4:47 AM
zlei committed rGea86e323e52f: age(4): Stop checking for failures from taskqueue_create_fast(M_WAITOK) (authored by zlei).
age(4): Stop checking for failures from taskqueue_create_fast(M_WAITOK)
Sep 30 2024, 4:47 AM
zlei committed rGf5cbe8ce89f1: bge(4): Stop checking for failures from taskqueue_create_fast(M_WAITOK) (authored by zlei).
bge(4): Stop checking for failures from taskqueue_create_fast(M_WAITOK)
Sep 30 2024, 4:47 AM
zlei committed rGa6c873a822b5: alc(4): Stop checking for failures from taskqueue_create_fast(M_WAITOK) (authored by zlei).
alc(4): Stop checking for failures from taskqueue_create_fast(M_WAITOK)
Sep 30 2024, 4:47 AM
zlei committed rG5de9286b9af6: ae(4): Stop checking for failures from taskqueue_create_fast(M_WAITOK) (authored by zlei).
ae(4): Stop checking for failures from taskqueue_create_fast(M_WAITOK)
Sep 30 2024, 4:47 AM
zlei committed rG40015f1c11ee: vchiq(4): Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
vchiq(4): Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 4:47 AM
zlei committed rG5a7db2ff56f9: sdhci(4): Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
sdhci(4): Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 4:47 AM
zlei committed rG140a0c8f3981: sume(4): Stop checking for failures from malloc(M_WAITOK) (authored by zlei).
sume(4): Stop checking for failures from malloc(M_WAITOK)
Sep 30 2024, 4:47 AM