Page MenuHomeFreeBSD
Feed Advanced Search

May 26 2023

austin.zhang_dell.com requested review of D40278: net/ntp: fix security vulnerabilities.
May 26 2023, 8:54 AM

May 4 2023

austin.zhang_dell.com abandoned D39743: VM: Stabilize map->anon_loc to reuse memory region.
May 4 2023, 8:45 AM

Apr 27 2023

austin.zhang_dell.com added a comment to D39845: VM anonymous clustering: be more persistent.

what if the freed hole is between 2 anon vma entries (curr_min_addr will fall down to the higher entry->end right?), however the hole won't be reused.
I used the test code mentioned earlier to verify your patch, still I can see anon_loc growing and memory footprint increasing.

Apr 27 2023, 3:05 PM
austin.zhang_dell.com added a comment to D39845: VM anonymous clustering: be more persistent.
In D39845#907052, @kib wrote:

We cannot provide the minimal VA spread with ASLR, after all this is the point of the 'R' in it. To glue vm_map_entries and underlying objects to avoid their proliferation is the goal of clustering.

Apr 27 2023, 2:24 PM
austin.zhang_dell.com added a comment to D39845: VM anonymous clustering: be more persistent.

My thought is upward migration of map->anon_loc could lead problem in some condition.
below test code can demonstrate malloced address still shift to higher address due to anon_loc updating, forcing jemalloc to eat more memory to store metadata.

Apr 27 2023, 8:43 AM
austin.zhang_dell.com added inline comments to D39743: VM: Stabilize map->anon_loc to reuse memory region.
Apr 27 2023, 6:07 AM
austin.zhang_dell.com updated the diff for D39743: VM: Stabilize map->anon_loc to reuse memory region.

introduce vm.anon_low_pref option to optimize cluster anon behavior.

Apr 27 2023, 4:44 AM

Apr 25 2023

austin.zhang_dell.com added a comment to D39743: VM: Stabilize map->anon_loc to reuse memory region.

By setting vm.cluster_anon=1, the clustering and updating of anon_loc will not occur during the test, preventing the occurrence of the jemalloc leak issue.
Which means this change is specifically targeting scenarios with vm.cluster_anon=2. So is it not recommend to use cluster_anon=2 in practice? we tried this setting to suppress vma fragment.

Apr 25 2023, 2:47 PM
austin.zhang_dell.com updated the diff for D39743: VM: Stabilize map->anon_loc to reuse memory region.
Apr 25 2023, 8:05 AM
austin.zhang_dell.com added a comment to D39743: VM: Stabilize map->anon_loc to reuse memory region.
In D39743#905866, @kib wrote:

Is the patch reversed? Also, please generate full context when uploading a patch to the FreeBSD phabricator (diff -U 999999999).

If the patch is reversed, I believe that it is an optimization for very specific usage. For instance, if you change your demostration program to increment the malloc'ed size by PAGE_SIZE for each iteration, VSS would start growing the same as without the patch. Really it just disables anon clustering.

That said, I would not object against a knob to disable updating anon_loc, if it helps for some specific heavy loads.

Apr 25 2023, 8:00 AM
austin.zhang_dell.com added reviewers for D39743: VM: Stabilize map->anon_loc to reuse memory region: markj, kib.
Apr 25 2023, 4:49 AM

Apr 21 2023

austin.zhang_dell.com requested review of D39743: VM: Stabilize map->anon_loc to reuse memory region.
Apr 21 2023, 6:12 AM

Jan 6 2022

austin.zhang_dell.com added a reviewer for D33667: atrtc: reads Century field from FADT table: akumar3_isilon.com.
Jan 6 2022, 7:51 AM · x86

Dec 27 2021

austin.zhang_dell.com added reviewers for D33667: atrtc: reads Century field from FADT table: vangyzen, dab.
Dec 27 2021, 9:01 AM · x86
austin.zhang_dell.com requested review of D33667: atrtc: reads Century field from FADT table.
Dec 27 2021, 8:27 AM · x86